[Koha-cvs] koha admin/marc_subfields_structure.pl koha-tmp...

Antoine Farnault antoine at koha-fr.org
Mon Mar 19 19:35:13 CET 2007


CVSROOT:	/sources/koha
Module name:	koha
Changes by:	Antoine Farnault <toins>	07/03/19 18:35:13

Modified files:
	admin          : marc_subfields_structure.pl 
	koha-tmpl/intranet-tmpl/prog/en/admin: 
	                                       marc_subfields_structure.tmpl 
	updater        : updatedatabase 

Log message:
	 - adding default value in marc_subfield_structure.
	 - now marc_subfields_structure displays subfields in tab view.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/koha/admin/marc_subfields_structure.pl?cvsroot=koha&r1=1.40&r2=1.41
http://cvs.savannah.gnu.org/viewcvs/koha/koha-tmpl/intranet-tmpl/prog/en/admin/marc_subfields_structure.tmpl?cvsroot=koha&r1=1.4&r2=1.5
http://cvs.savannah.gnu.org/viewcvs/koha/updater/updatedatabase?cvsroot=koha&r1=1.159&r2=1.160

Patches:
Index: admin/marc_subfields_structure.pl
===================================================================
RCS file: /sources/koha/koha/admin/marc_subfields_structure.pl,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -b -r1.40 -r1.41
--- admin/marc_subfields_structure.pl	9 Mar 2007 15:34:17 -0000	1.40
+++ admin/marc_subfields_structure.pl	19 Mar 2007 18:35:12 -0000	1.41
@@ -175,6 +175,7 @@
         else {
             $toggle = 1;
         }
+        $row_data{defaultvalue} = $data->{defaultvalue};
         $row_data{tab} = CGI::scrolling_list(
             -name   => 'tab',
             -id     => "tab$i",
@@ -204,6 +205,7 @@
           . "<input type=\"hidden\" name=\"tagsubfield\" value=\""
           . $data->{'tagsubfield'}
           . "\" id=\"tagsubfield\">";
+        $row_data{subfieldcode} = $data->{'tagsubfield'};
         $row_data{liblibrarian} = CGI::escapeHTML( $data->{'liblibrarian'} );
         $row_data{libopac}      = CGI::escapeHTML( $data->{'libopac'} );
         $row_data{seealso}      = CGI::escapeHTML( $data->{'seealso'} );
@@ -392,8 +394,8 @@
     my $dbh = C4::Context->dbh;
     $template->param( tagfield => "$input->param('tagfield')" );
     my $sth = $dbh->prepare(
-"replace marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link)
-                                    values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"
+"replace marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link,defaultvalue)
+                                    values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"
     );
     my @tagsubfield       = $input->param('tagsubfield');
     my @liblibrarian      = $input->param('liblibrarian');
@@ -406,6 +408,7 @@
     my @authtypecodes     = $input->param('authtypecode');
     my @value_builder     = $input->param('value_builder');
     my @link              = $input->param('link');
+    my @defaultvalue      = $input->param('defaultvalue');
 
     for ( my $i = 0 ; $i <= $#tagsubfield ; $i++ ) {
         my $tagfield    = $input->param('tagfield');
@@ -424,6 +427,7 @@
         my $hidden = $hidden[$i];                     #input->param("hidden$i");
         my $isurl  = $input->param("isurl$i") ? 1 : 0;
         my $link   = $link[$i];
+        my $defaultvalue = $defaultvalue[$i];
 
         if ($liblibrarian) {
             unless ( C4::Context->config('demo') eq 1 ) {
@@ -443,8 +447,8 @@
                     $hidden,
                     $isurl,
                     $frameworkcode,
-
                     $link,
+                    $defaultvalue,
                 );
             }
         }
@@ -561,10 +565,5 @@
             next => "<a href=\"$script_name?offset=$nextpage\">" );
     }
 }    #---- END $OP eq DEFAULT
-$template->param(
-    intranetcolorstylesheet =>
-      C4::Context->preference("intranetcolorstylesheet"),
-    intranetstylesheet => C4::Context->preference("intranetstylesheet"),
-    IntranetNav        => C4::Context->preference("IntranetNav"),
-);
+
 output_html_with_http_headers $input, $cookie, $template->output;

Index: koha-tmpl/intranet-tmpl/prog/en/admin/marc_subfields_structure.tmpl
===================================================================
RCS file: /sources/koha/koha/koha-tmpl/intranet-tmpl/prog/en/admin/marc_subfields_structure.tmpl,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- koha-tmpl/intranet-tmpl/prog/en/admin/marc_subfields_structure.tmpl	11 Mar 2007 21:08:12 -0000	1.4
+++ koha-tmpl/intranet-tmpl/prog/en/admin/marc_subfields_structure.tmpl	19 Mar 2007 18:35:12 -0000	1.5
@@ -18,19 +18,46 @@
     <form action="<!-- TMPL_VAR NAME="script_name" -->" name="Aform" method="post">
     <input type="hidden" name="op" value="add_validate" />
     <input type="hidden" name="frameworkcode" value="<!-- TMPL_VAR NAME="frameworkcode" -->" />
+    <input type="submit" value="Save Changes" />
+    
+    <h3>Tag <!-- TMPL_VAR NAME="tagfield" --></h3>
+    <b>Edit subfields :</b>
+    <div id="tabs">
     <!-- TMPL_LOOP NAME="loop" -->
-    <div class="data <!-- TMPL_VAR NAME="toggle" -->">
-    <fieldset>
-        <legend>Tag <!-- TMPL_VAR NAME="tagfield" -->, Subfield <!-- TMPL_VAR NAME="tagsubfield" --></legend>
-        <h3>MARC constraints</h3>
-            <p><label for="repeatable<!-- TMPL_VAR NAME="row" -->">Repeatable</label><!-- TMPL_VAR NAME="repeatable" -->&nbsp;</p>
-            <p><label for="mandatory<!-- TMPL_VAR NAME="row" -->">Mandatory</label><!-- TMPL_VAR NAME="mandatory" -->&nbsp;</p>
-            <p><label for="seealso<!-- TMPL_VAR NAME="row" -->">Search also</label><input type="text" id="seealso<!-- TMPL_VAR NAME="row" -->" name="seealso" value="<!-- TMPL_VAR name="seealso" -->" size="20" /> (example for 200a: '200c','200d','200e'...)</p>
-            <p><label for="kohafield<!-- TMPL_VAR NAME="row" -->">Koha link</label><!-- TMPL_VAR NAME="kohafield" --></p>
-        <h3>Editor constaints</h3>
+           <!-- TMPL_IF NAME="subfieldcode"-->
+               <input type="hidden" name="tagsubfield" value="<!-- TMPL_VAR NAME="subfieldcode" -->" />
+               <a 
+                    href="javascript:active('sub<!-- TMPL_VAR NAME='subfieldcode' -->');"
+                    class="tab_inactive"
+                    id="sub<!-- TMPL_VAR NAME="subfieldcode" -->"
+                    title="<!-- TMPL_VAR NAME="liblibrarian" -->"
+                >
+                    <!-- TMPL_VAR NAME="subfieldcode" -->
+               </a>
+           <!-- /TMPL_IF -->
+           <!-- /TMPL_LOOP -->
+    </div>
+    
+    <div id="content" style="display:block">
+        <!-- TMPL_LOOP NAME="loop" --> 
+        <!-- TMPL_IF NAME="subfieldcode"-->
+        <div id="content_sub<!-- TMPL_VAR NAME="subfieldcode" -->" class="content_hidden">
+        
+        <h3>Basic constaints</h3>
             <p><label for="liblibrarian<!-- TMPL_VAR NAME="row" -->">Text for librarian</label><input id="liblibrarian<!-- TMPL_VAR NAME="row" -->" type="text" name="liblibrarian" value="<!-- TMPL_VAR NAME="liblibrarian" -->" size="40" maxlength="80" /></p>
             <p><label for="libopac<!-- TMPL_VAR NAME="row" -->">Text for OPAC</label><input type="text" id="libopac<!-- TMPL_VAR NAME="row" -->" name="libopac" value="<!-- TMPL_VAR NAME="libopac" -->" size="40" maxlength="80" /></p>
+                <p><label for="repeatable<!-- TMPL_VAR NAME="row" -->">Repeatable</label><!-- TMPL_VAR NAME="repeatable" -->&nbsp;</p>
+                <p><label for="mandatory<!-- TMPL_VAR NAME="row" -->">Mandatory</label><!-- TMPL_VAR NAME="mandatory" -->&nbsp;</p>
             <p><label for="tab<!-- TMPL_VAR NAME="row" -->">Managed in tab</label><!-- TMPL_VAR NAME="tab" --> (ignore means that the subfield is NOT managed by Koha)</p>
+                
+                <a href="javascript:displayMoreConstraint('more<!-- TMPL_VAR NAME="subfieldcode" -->')">display more constraints</a>
+               
+            <span id="more<!-- TMPL_VAR NAME="subfieldcode" -->" class="content_hidden">
+                <h3>Advanced constraint</h3>
+                <p>
+                    <label for="defaultvalue">default value</label>
+                    <input type="text" name="defaultvalue" id="defaultvalue" value="<!-- TMPL_VAR NAME="defaultvalue" -->" />
+                </p>
             <p><label for="hidden">hidden</label><input type="text" id="hidden<!-- TMPL_VAR NAME="row" -->" name="hidden" value="<!-- TMPL_VAR name="hidden" -->" size="2" /> (see online help)</label></p>
             <p><label for="isurl<!-- TMPL_VAR NAME="row" -->">Is a URL</label><!-- TMPL_VAR NAME="isurl" --> (if checked, it means that the subfield is an URL and can be clicked</p>
             <p><label>Link</label><input type="text" name="link" value="<!-- TMPL_VAR NAME="link" -->" size="10" maxlength="5" /> (exemple:200b)</p>
@@ -39,9 +66,12 @@
                 <p><label>Thesaurus</label><!-- TMPL_VAR NAME="authtypes" --></p>
                 <p><label>Plugin</label><!-- TMPL_VAR NAME="value_builder" --></p>
             </p>
-    </fieldset>
+                <p><label for="kohafield<!-- TMPL_VAR NAME="row" -->">Koha link</label><!-- TMPL_VAR NAME="kohafield" --></p>
+            </span>
+        </div>
+        <!-- /TMPL_IF -->
     <!-- /TMPL_LOOP -->
-    <input type="submit" value="Save Changes" />
+    </div>
     </form>
 <!-- /TMPL_IF -->
 
@@ -134,5 +164,47 @@
 <!-- /TMPL_IF -->
 <!-- /TMPL_IF -->
 
+<script language="JavaScript" type="text/javascript">
+
+function active(numlayer){
+    var contentdiv   = document.getElementById("content");
+    var subfields    = contentdiv.getElementsByTagName("div");
+    var numSubfield  = subfields.length;
+    var tabs = document.getElementById("tabs").getElementsByTagName('a');
+
+    // all others must be hidden
+    for (i=0; i < numSubfield ; i++ ) {
+        if (subfields[i].getAttribute('id') == "content_"+numlayer) {
+        
+            // display this subfield
+            subfields[i].removeAttribute("class");
+            subfields[i].setAttribute("class","content_visible");
+            
+            // change css class
+            tabs[i].removeAttribute('class');
+            tabs[i].setAttribute('class',"tab_active");
+            
+        } else {
+            tabs[i].removeAttribute('class');
+            tabs[i].setAttribute('class',"tab_inactive");
+            subfields[i].removeAttribute("class");
+            subfields[i].setAttribute("class","content_hidden");
+        }
+    }
+}
+
+
+function displayMoreConstraint(numlayer){
+    var thisdiv = document.getElementById(numlayer);
+    if(thisdiv.getAttribute("class") == "content_hidden"){
+        thisdiv.removeAttribute('class');
+        thisdiv.setAttribute("class","content_visible");
+    } else {
+        thisdiv.removeAttribute('class');
+        thisdiv.setAttribute("class","content_hidden");
+    }
+}
+
+</script>
 
 <!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->

Index: updater/updatedatabase
===================================================================
RCS file: /sources/koha/koha/updater/updatedatabase,v
retrieving revision 1.159
retrieving revision 1.160
diff -u -b -r1.159 -r1.160
--- updater/updatedatabase	16 Mar 2007 01:25:09 -0000	1.159
+++ updater/updatedatabase	19 Mar 2007 18:35:13 -0000	1.160
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 
-# $Id: updatedatabase,v 1.159 2007/03/16 01:25:09 kados Exp $
+# $Id: updatedatabase,v 1.160 2007/03/19 18:35:13 toins Exp $
 
 # Database Updater
 # This script checks for required updates to the database.
@@ -949,6 +949,15 @@
             extra  => '',
         },
     ],
+    marc_subfield_structure => [
+        {
+            field => 'defaultvalue',
+            type  => 'TEXT',
+            null  => 'NULL',
+            key    => '',
+            extra  => '',
+        }
+    ],
     opac_news => [
         {
             field  => 'expirationdate',
@@ -1968,6 +1977,10 @@
 exit;
 
 # $Log: updatedatabase,v $
+# Revision 1.160  2007/03/19 18:35:13  toins
+#  - adding default value in marc_subfield_structure.
+#  - now marc_subfields_structure displays subfields in tab view.
+#
 # Revision 1.159  2007/03/16 01:25:09  kados
 # Using my precrash CVS copy I did the following:
 #





More information about the Koha-cvs mailing list