[Koha-devel] pm structure : Acquisition.pm modifications

paul POULAIN paul.poulain at free.fr
Tue Jun 11 07:02:17 CEST 2002


Pat Eyler wrote:

>(pate puts on his Unit Testing hat.)
>
>>On Mon, Jun 10, 2002 at 10:35:58PM +0200, paul POULAIN wrote:
>>    
>>
>>>the Acquisition.pm (aka : Catalogue.pm for MARC version) contains too
>>>much subs imho. It's hard to read, and not always very coherent :
>>>      
>>>
>>>I propose to divide the script in 2 differents ones.
>>>the first would be Biblio.pm (used only for biblio management :
>>>biblio/biblioitems/items/additionalauthor/subtitle tables), the second
>>>would remain Acquisition.pm (Catalogue.pm for MARC)
>>>      
>>>
>>I like the idea of separating the routines for biblio handling
>>from the routines for order processing.   If the proposed Catalogue.pm
>>is going to handle Marc record processing, which is biblio information,
>>doesn't that mean that Catalogue.pm would replace Biblio.pm, not
>>Acquisition.pm?
>>
>As we split subroutines out into new files, let's please try to write
>tests for them using the Test::Harness framework.  Being able to run a
>testsuite automagically and verify that we've not added new bugs will help
>all of us sleep better at night.
>
If my great-loved-super-hyper-best benevolent dictator agree, for 
instance, i'll just split the file in 2. Test::harness will come later.
If my benevolent dictator disagree to this solution, he can do this 
f@#{#@g job himself  ;-)))
--
Paul

>  
>





More information about the Koha-devel mailing list