From chris at katipo.co.nz  Wed May  1 16:19:33 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Wed May  1 16:19:33 2002
Subject: [Koha-devel] New tarball
Message-ID: <20020501231756.GV21253@katipo.co.nz>

Hi all

Ive just popped up a new rc1 tarball at developer.koha.org.

It has a new TODO file, and glens koha-sql-generator has been removed.
(It was a tool for converting a GLAS database file into something koha can
use)

I figure we should put it in a contrib section or something instead.

Chris
-- 
Chris Cormack                                                     Programmer
025 500 789                                        Katipo Communications Ltd
chris at katipo.co.nz                                          www.katipo.co.nz



From finlayt at users.sourceforge.net  Wed May  1 17:09:16 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:09:16 2002
Subject: [Koha-devel] CVS: koha bookcount.pl,NONE,1.1 moredetail.pl,1.4,1.5
Message-ID: <E17349X-00045x-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv15441

Modified Files:
	moredetail.pl 
Added Files:
	bookcount.pl 
Log Message:

moredetail.pl presents circulation information taken from the
branchtransfers table

Circ2.pm has been changed a little

admin/branches.pl alows branches to be added, edited and deleted.

updatedatabase needs more fixing


--- NEW FILE ---
#!/usr/bin/perl

#written 7/3/2002 by Finlay
#script to display reports

use strict;
use CGI;
use C4::Search;
use C4::Circulation::Circ2;
use C4::Output;

# get all the data ....
my %env;
my $main='#cccc99';
my $secondary='#ffffcc';

my $input = new CGI;
my $itm = $input->param('itm');
my $bi = $input->param('bi');
my $bib = $input->param('bib');
my $branches = getbranches(\%env);

my $idata = itemdatanum($itm);
my $data = bibitemdata($bi);

my $homebranch = $branches->{$idata->{'homebranch'}}->{'branchname'};
my $holdingbranch = $branches->{$idata->{'holdingbranch'}}->{'branchname'};

my ($lastmove, $message) = lastmove($itm);

my $lastdate;
my $count;
if (not $lastmove) {
    $lastdate = $message;
    $count = issuessince($itm , 0);
} else {
    $lastdate = $lastmove->{'datearrived'};
    $count = issuessince($itm ,$lastdate);
}


# make the page ... 
print $input->header;


print startpage;
print startmenu('report');
print center;

print <<"EOF";
<br>
<FONT SIZE=6><em><a href=/cgi-bin/koha/detail.pl?bib=$bib&type=intra>$data->{'title'} ($data->{'author'})</a></em></FONT><P>
<p>
<img src="/images/holder.gif" width=16 height=200 align=left>
<TABLE  CELLSPACING=0  CELLPADDING=5 border=1 width=440 >
  <TR VALIGN=TOP><td  bgcolor="99cc33" background="/images/background-mem.gif">
  <B>BARCODE $idata->{'barcode'}</b></TD>
</TR>
<TR VALIGN=TOP  >
<TD width=440 >

<b>Home Branch: </b> $homebranch <br>
<b>Current Branch: </b> $holdingbranch<br>
<b>Date arrived at current branch: </b> $lastdate <br>
<b>Number of issues since since the above date :</b> $count <br>

<table cellspacing =0 cellpadding=5 border=1 width = 440>
<TR><TD > <b>Branch</b></td>  <TD >   <b>No. of Issues</b></td>   <td><b>Last seen at branch</b></td></TR>
EOF

foreach my $branchcode (keys %$branches) {
    my $issues = issuesat($itm, $branchcode);
    my $date = lastseenat($itm, $branchcode);
    my $seen = slashdate($date);
    print << "EOF";
<TR><TD > <b>$branches->{$branchcode}->{'branchname'}</b></td>
<TD >    <b> $issues </b></td>             <td><b> $seen</b></td></TR>
EOF
}
print <<"EOF";
</table>
</TR>

</table>
EOF


print endmenu('report');
print endpage;


##############################################
# This stuff should probably go into C4::Search
# database includes
use DBI;
use C4::Database;

sub itemdatanum {
    my ($itemnumber)=@_;
    my $dbh=C4Connect;
    my $itm = $dbh->quote("$itemnumber");
    my $query = "select * from items where itemnumber=$itm";
    my $sth=$dbh->prepare($query);
    $sth->execute;
    my $data=$sth->fetchrow_hashref;
    $sth->finish;
    $dbh->disconnect;
    return($data);
}

sub lastmove {
      my ($itemnumber)=@_;
      my $dbh=C4Connect;
      my $var1 = $dbh->quote($itemnumber);
      my $sth =$dbh->prepare("select max(branchtransfers.datearrived) from branchtransfers where branchtransfers.itemnumber=$var1");
      $sth->execute;
      my ($date) = $sth->fetchrow_array;
      return(0, "Item has no branch transfers record") if not $date;
      my $var2 = $dbh->quote($date);      
      $sth=$dbh->prepare("Select * from branchtransfers where branchtransfers.itemnumber=$var1 and branchtransfers.datearrived=$var2");
      $sth->execute;
      my ($data) = $sth->fetchrow_hashref;
      return(0, "Item has no branch transfers record") if not $data;
      $sth->finish;
      $dbh->disconnect;
      return($data,"");
 }

sub issuessince {
      my ($itemnumber, $date)=@_;
      my $dbh=C4Connect;
      my $itm = $dbh->quote($itemnumber);
      my $dat = $dbh->quote($date);
      my $sth=$dbh->prepare("Select count(*) from issues where issues.itemnumber=$itm and issues.timestamp > $dat");
      $sth->execute;
      my $count=$sth->fetchrow_hashref;
      $sth->finish;
      $dbh->disconnect;
      return($count->{'count(*)'});
}

sub issuesat {
      my ($itemnumber, $brcd)=@_;
      my $dbh=C4Connect;
      my $itm = $dbh->quote($itemnumber);
      my $brc = $dbh->quote($brcd);
      my $query = "Select count(*) from issues where itemnumber=$itm and branchcode = $brc";
      my $sth=$dbh->prepare($query);
      $sth->execute;
      my ($count)=$sth->fetchrow_array;
      $sth->finish;
      $dbh->disconnect;
      return($count);
}

sub lastseenat {
      my ($itemnumber, $brcd)=@_;
      my $dbh=C4Connect;
      my $itm = $dbh->quote($itemnumber);
      my $brc = $dbh->quote($brcd);
      my $query = "Select max(timestamp) from issues where itemnumber=$itm and branchcode = $brc";
      my $sth=$dbh->prepare($query);
      $sth->execute;
      my ($date1)=$sth->fetchrow_array;
      $sth->finish;
      $query = "Select max(datearrived) from branchtransfers where itemnumber=$itm and tobranch = $brc";
      my $sth=$dbh->prepare($query);
      $sth->execute;
      my ($date2)=$sth->fetchrow_array;
      $sth->finish;
      $dbh->disconnect;
      $date2 =~ s/-//g;
      $date2 =~ s/://g;
      $date2 =~ s/ //g;
      my $date;
      if ($date1 < $date2) {
	  $date = $date2;
      } else {
	  $date = $date1;
      }
      return($date);
}


#####################################################
# write date....
sub slashdate {
    my ($date) = @_;
    if (not $date) {
	return "never";
    }
    my ($yr, $mo, $da, $hr, $mi) = (substr($date, 0, 4), substr($date, 4, 2), substr($date, 6, 2), substr($date, 8, 2), substr($date, 10, 2));
    return "$hr:$mi  $da/$mo/$yr";
}

Index: moredetail.pl
===================================================================
RCS file: /cvsroot/koha/koha/moredetail.pl,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** moredetail.pl	8 Apr 2002 23:44:43 -0000	1.4
--- moredetail.pl	2 May 2002 00:08:53 -0000	1.5
***************
*** 172,176 ****
  print <<printend
  <b>Cancelled: $items[$i]->{'wthdrawn'}<br>
! <b>Total Issues:</b> $items[$i]->{'issues'}<br>
  <b>Group Number:</b> $bi <br>
  <b>Biblio number:</b> $bib <br>
--- 172,176 ----
  print <<printend
  <b>Cancelled: $items[$i]->{'wthdrawn'}<br>
! <b><a href=/cgi-bin/koha/bookcount.pl?&bib=$bib&bi=$bi&itm=$items[$i]->{'itemnumber'}>Total Issues:</a></b> $items[$i]->{'issues'}<br>
  <b>Group Number:</b> $bi <br>
  <b>Biblio number:</b> $bib <br>




From finlayt at users.sourceforge.net  Wed May  1 17:09:16 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:09:16 2002
Subject: [Koha-devel] CVS: koha/updater updatedatabase,1.4,1.5
Message-ID: <E17349X-00046T-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/updater
In directory usw-pr-cvs1:/tmp/cvs-serv15441/updater

Modified Files:
	updatedatabase 
Log Message:

moredetail.pl presents circulation information taken from the
branchtransfers table

Circ2.pm has been changed a little

admin/branches.pl alows branches to be added, edited and deleted.

updatedatabase needs more fixing


Index: updatedatabase
===================================================================
RCS file: /cvsroot/koha/koha/updater/updatedatabase,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** updatedatabase	26 Mar 2002 05:08:52 -0000	1.4
--- updatedatabase	2 May 2002 00:08:53 -0000	1.5
***************
*** 138,156 ****
      print "Setting type of categorycode in branchcategories to varchar(4),\n and making the primary key.\n";
      my $sti=$dbh->prepare("alter table branchcategories change categorycode categorycode varchar(4) not null");
!     $sti->execute;
!     $sti=$dbh->prepare("alter table branchcategories add primary key (categorycode)");
!     $sti->execute;
  }
  
  unless ($branchcategories{'branchcode'} eq 'varchar(4)') {
!     print "Setting type of branchcode in branchcategories to varchar(4).\n";
!     my $sti=$dbh->prepare("alter table branchcategories change branchcode branchcode varchar(4)");
!     $sti->execute;
  }
  
  unless ($branchcategories{'codedescription'} eq 'text') {
      print "Replacing branchholding in branchcategories with codedescription text.\n";
!     my $sti=$dbh->prepare("alter table branchcategories change branchholding codedescription text");
!     $sti->execute;
  }
  
--- 138,173 ----
      print "Setting type of categorycode in branchcategories to varchar(4),\n and making the primary key.\n";
      my $sti=$dbh->prepare("alter table branchcategories change categorycode categorycode varchar(4) not null");
!     $sth->execute;
!     $sth=$dbh->prepare("alter table branchcategories add primary key (categorycode)");
!     $sth->execute;
  }
  
  unless ($branchcategories{'branchcode'} eq 'varchar(4)') {
!     print "Changing branchcode in branchcategories to categoryname text.\n";
!     my $sth=$dbh->prepare("alter table branchcategories change branchcode categoryname text");
!     $sth->execute;
  }
  
  unless ($branchcategories{'codedescription'} eq 'text') {
      print "Replacing branchholding in branchcategories with codedescription text.\n";
!     my $sth=$dbh->prepare("alter table branchcategories change branchholding codedescription text");
!     $sth->execute;
! }
! 
! # Create new branchrelations table if it doesnt already exist....
! my $branchrelationsexists;
! 
! my $sth=$dbh->prepare("show tables");
! $sth->execute;
! while (my ($tablename) = $sth->fetchrow) {
!     if ($tablename == "branchrelations") {
! 	$branchrelationsexists = 1;
!     }
! }
! 
! unless ($branchrelationsexists) {
!     print "creating branchrelations table";
!     my $sth->prepare("create table branchrelations (branchcode varchar(4), categorycode varchar(4))");
!     $sth->execute;
  }
  




From finlayt at users.sourceforge.net  Wed May  1 17:09:16 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:09:16 2002
Subject: [Koha-devel] CVS: koha/admin branches.pl,1.1,1.2
Message-ID: <E17349X-00046L-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/admin
In directory usw-pr-cvs1:/tmp/cvs-serv15441/admin

Modified Files:
	branches.pl 
Log Message:

moredetail.pl presents circulation information taken from the
branchtransfers table

Circ2.pm has been changed a little

admin/branches.pl alows branches to be added, edited and deleted.

updatedatabase needs more fixing


Index: branches.pl
===================================================================
RCS file: /cvsroot/koha/koha/admin/branches.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** branches.pl	5 Mar 2002 20:48:42 -0000	1.1
--- branches.pl	2 May 2002 00:08:53 -0000	1.2
***************
*** 1,280 ****
  #!/usr/bin/perl
  
! #script to administer the aqbudget table
! #written 20/02/2002 by paul.poulain at free.fr
! # This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html)
! 
! # ALGO :
! # this script use an $op to know what to do.
! # if $op is empty or none of the above values,
! #	- the default screen is build (with all records, or filtered datas).
! #	- the   user can clic on add, modify or delete record.
! # if $op=add_form
! #	- if primkey exists, this is a modification,so we read the $primkey record
! #	- builds the add/modify form
! # if $op=add_validate
! #	- the user has just send datas, so we create/modify the record
! # if $op=delete_form
! #	- we show the record having primkey=$primkey and ask for deletion validation form
! # if $op=delete_confirm
! #	- we delete the record having primkey=$primkey
  
  use strict;
- use C4::Output;
  use CGI;
! use C4::Search;
  use C4::Database;
  
! sub StringSearch  {
! 	my ($env,$searchstring,$type)=@_;
! 	my $dbh = &C4Connect;
! 	$searchstring=~ s/\'/\\\'/g;
! 	my @data=split(' ',$searchstring);
! 	my $count=@data;
! 	my $query="Select branchcode,branchname,branchaddress1,branchaddress2,branchaddress3,branchphone,branchfax,branchemail,issuing from branches where (branchcode like \"$data[0]%\") order by branchcode";
! 	my $sth=$dbh->prepare($query);
! 	$sth->execute;
! 	my @results;
! 	my $cnt=0;
! 	while (my $data=$sth->fetchrow_hashref){
! 	push(@results,$data);
! 	$cnt ++;
! 	}
! 	#  $sth->execute;
! 	$sth->finish;
! 	$dbh->disconnect;
! 	return ($cnt,\@results);
! }
! 
! my $input = new CGI;
! my $searchfield=$input->param('searchfield');
! my $pkfield="branchcode";
! my $reqsel="select branchcode,branchname,branchaddress1,branchaddress2,branchaddress3,branchphone,branchfax,branchemail,issuing from branches where branchcode='$searchfield'";
! my $reqdel="delete from branches where branchcode='$searchfield'";
! #my $branchcode=$input->param('branchcode');
! my $offset=$input->param('offset');
  my $script_name="/cgi-bin/koha/admin/branches.pl";
- 
  my $pagesize=20;
  my $op = $input->param('op');
! $searchfield=~ s/\,//g;
  print $input->header;
  
! #start the page and read in includes
  print startpage();
  print startmenu('admin');
  
! ################## ADD_FORM ##################################
! # called by default. Used to create form to add or  modify a record
! if ($op eq 'add_form') {
! 	#---- if primkey exists, it's a modify action, so read values to modify...
! 	my $data;
! 	if ($searchfield) {
! 		my $dbh = &C4Connect;
! 		my $sth=$dbh->prepare("select branchcode,branchname,branchaddress1,branchaddress2,branchaddress3,branchphone,branchfax,branchemail,issuing  from branches where branchcode='$searchfield'");
! 		$sth->execute;
! 		$data=$sth->fetchrow_hashref;
! 		$sth->finish;
! 	}
! 	print <<printend
! 	<script>
! 	/////////////////////////////////////////////////////////////////////////////////////////////////////////////////
! 	function isNotNull(f,noalert) {
! 		if (f.value.length ==0) {
!    return false;
! 		}
! 		return true;
! 	}
! 	/////////////////////////////////////////////////////////////////////////////////////////////////////////////////
! 	function toUC(f) {
! 		var x=f.value.toUpperCase();
! 		f.value=x;
! 		return true;
! 	}
! 	/////////////////////////////////////////////////////////////////////////////////////////////////////////////////
! 	function isNum(v,maybenull) {
! 	var n = new Number(v.value);
! 	if (isNaN(n)) {
! 		return false;
! 		}
! 	if (maybenull==0 && v.value=='') {
! 		return false;
! 	}
! 	return true;
! 	}
! 	/////////////////////////////////////////////////////////////////////////////////////////////////////////////////
! 	function isDate(f) {
! 		var t = Date.parse(f.value);
! 		if (isNaN(t)) {
! 			return false;
! 		}
! 	}
! 	/////////////////////////////////////////////////////////////////////////////////////////////////////////////////
! 	function Check(f) {
! 		var ok=1;
! 		var _alertString="";
! 		var alertString2;
! 		if (f.searchfield.value.length==0) {
! 			_alertString += "- branch code missing\\n";
! 		}
! 		if (f.branchname.value.length==0) {
! 			_alertString += "- branch name missing\\n";
! 		}
! 		if (_alertString.length==0) {
! 			document.Aform.submit();
! 		} else {
! 			alertString2 = "Form not submitted because of the following problem(s)\\n";
! 			alertString2 += "------------------------------------------------------------------------------------\\n\\n";
! 			alertString2 += _alertString;
! 			alert(alertString2);
! 		}
! 	}
! 	</SCRIPT>
! printend
! ;#/
! 	if ($searchfield) {
! 		print "<h1>Modify branch</h1>";
! 	} else {
! 		print "<h1>Add branch</h1>";
! 	}
! 	print "<form action='$script_name' name=Aform method=post>";
! 	print "<input type=hidden name=op value='add_validate'>";
! 	print "<table>";
! 	if ($searchfield) {
! 		print "<tr><td>Branch code</td><td><input type=hidden name=searchfield value=$searchfield>$searchfield</td></tr>";
! 	} else {
! 		print "<tr><td>Branch code</td><td><input type=text name=searchfield size=5 maxlength=5 onBlur=toUC(this)></td></tr>";
! 	}
! 	print "<tr><td>Name</td><td><input type=text name=branchname size=40 maxlength=80 value='$data->{'branchname'}'>&nbsp;</td></tr>";
! 	print "<tr><td>Adress</td><td><input type=text name=branchaddress1 value='$data->{'branchaddress1'}'></td></tr>";
! 	print "<tr><td>&nbsp;</td><td><input type=text name=branchaddress2 value='$data->{'branchaddress2'}'></td></tr>";
! 	print "<tr><td>&nbsp;</td><td><input type=text name=branchaddress3 value='$data->{'branchaddress3'}'></td></tr>";
! 	print "<tr><td>Phone</td><td><input type=text name=branchphone value='$data->{'branchphone'}'></td></tr>";
! 	print "<tr><td>Fax</td><td><input type=text name=branchfax value='$data->{'branchfax'}'></td></tr>";
! 	print "<tr><td>E-mail</td><td><input type=text name=branchemail value='$data->{'branchemail'}'></td></tr>";
! 	print "<tr><td>Issuing</td><td><input type=text name=issuing value='$data->{'issuing'}'></td></tr>";
! 	print "<tr><td>&nbsp;</td><td><INPUT type=button value='OK' onClick='Check(this.form)'></td></tr>";
! 	print "</table>";
! 	print "</form>";
! ;
! 													# END $OP eq ADD_FORM
! ################## ADD_VALIDATE ##################################
! # called by add_form, used to insert/modify data in DB
  } elsif ($op eq 'add_validate') {
! 	my $dbh=C4Connect;
! 	my $query = "replace branches (branchcode,branchname,branchaddress1,branchaddress2,branchaddress3,branchphone,branchfax,branchemail,issuing) values (";
! 	$query.= $dbh->quote($input->param('branchcode')).",";
! 	$query.= $dbh->quote($input->param('branchname')).",";
! 	$query.= $dbh->quote($input->param('branchaddress1')).",";
! 	$query.= $dbh->quote($input->param('branchaddress2')).",";
! 	$query.= $dbh->quote($input->param('branchaddress3')).",";
! 	$query.= $dbh->quote($input->param('branchphone')).",";
! 	$query.= $dbh->quote($input->param('branchfax')).",";
! 	$query.= $dbh->quote($input->param('branchemail')).",";
! 	$query.= $dbh->quote($input->param('issuing')).")";
! 	my $sth=$dbh->prepare($query);
! 	$sth->execute;
! 	$sth->finish;
! 	print "data recorded";
! 	print "<form action='$script_name' method=post>";
! 	print "<input type=submit value=OK>";
! 	print "</form>";
! 													# END $OP eq ADD_VALIDATE
! ################## DELETE_CONFIRM ##################################
! # called by default form, used to confirm deletion of data in DB
! } elsif ($op eq 'delete_confirm') {
! 	my $dbh = &C4Connect;
! 	my $sth=$dbh->prepare("select count(*) as total from borrowers where branchcode='$searchfield'");
! 	$sth->execute;
! 	my $total = $sth->fetchrow_hashref;
! 	$sth->finish;
! 	print "$reqsel";
! 	my $sth=$dbh->prepare($reqsel);
  	$sth->execute;
- 	my $data=$sth->fetchrow_hashref;
  	$sth->finish;
! 	print mktablehdr;
! 	print mktablerow(2,'#99cc33',bold('Branch code'),bold("$searchfield"),'/images/background-mem.gif');
! 	print "<form action='$script_name' method=post><input type=hidden name=op value=delete_confirmed><input type=hidden name=searchfield value='$searchfield'>";
! 	print "<tr><td>Branch code</td><td>$data->{'branchcode'}</td></tr>";
! 	print "<tr><td>&nbsp; name</td><td>$data->{'branchname'}</td></tr>";
! 	print "<tr><td>&nbsp; adress</td><td>$data->{'branchaddress1'}</td></tr>";
! 	print "<tr><td>&nbsp;</td><td>$data->{'branchaddress2'}</td></tr>";
! 	print "<tr><td>&nbsp;</td><td>$data->{'branchaddress3'}</td></tr>";
! 	print "<tr><td>&nbsp;phone</td><td>$data->{'branchphone'}</td></tr>";
! 	print "<tr><td>&nbsp; fax</td><td>$data->{'branchfax'}</td></tr>";
! 	print "<tr><td>&nbsp; e-mail</td><td>$data->{'branchemail'}</td></tr>";
! 	print "<tr><td>&nbsp; issuing</td><td>$data->{'issuing'}</td></tr>";
! 	if ($total->{'total'} >0) {
! 		print "<tr><td colspan=2 align=center><b>This record is used $total->{'total'} times. Deletion not possible</b></td></tr>";
! 		print "<tr><td colspan=2></form><form action='$script_name' method=post><input type=submit value=OK></form></td></tr>";
! 	} else {
! 		print "<tr><td colspan=2 align=center>CONFIRM DELETION</td></tr>";
! 		print "<tr><td><INPUT type=submit value='YES'></form></td><td><form action='$script_name' method=post><input type=submit value=NO></form></td></tr>";
! 	}
! 													# END $OP eq DELETE_CONFIRM
! ################## DELETE_CONFIRMED ##################################
! # called by delete_confirm, used to effectively confirm deletion of data in DB
! } elsif ($op eq 'delete_confirmed') {
! 	my $dbh=C4Connect;
! #	my $searchfield=$input->param('branchcode');
! 	my $sth=$dbh->prepare($reqdel);
  	$sth->execute;
  	$sth->finish;
! 	print "data deleted";
! 	print "<form action='$script_name' method=post>";
! 	print "<input type=submit value=OK>";
! 	print "</form>";
! 													# END $OP eq DELETE_CONFIRMED
! ################## DEFAULT ##################################
! } else { # DEFAULT
! 	my @inputs=(["text","searchfield",$searchfield],
! 		["reset","reset","clr"]);
! 	print mkheadr(2,'branches admin');
! 	print mkformnotable("$script_name", at inputs);
! 	print <<printend
! 
! printend
! 	;
! 	if  ($searchfield ne '') {
! 		print "You Searched for <b>$searchfield<b><p>";
! 	}
! 	print mktablehdr;
! 	print mktablerow(9,'#99cc33',bold('Branch code'),bold('name'),bold('adress'),
! 	bold('phone'),bold('fax'),bold('mail'),bold('issuing'),
! 	'&nbsp;','&nbsp;','/images/background-mem.gif');
! 	my $env;
! 	my ($count,$results)=StringSearch($env,$searchfield,'web');
! 	my $toggle="white";
! 	for (my $i=$offset; $i < ($offset+$pagesize<$count?$offset+$pagesize:$count); $i++){
! 		#find out stats
! 	#  	my ($od,$issue,$fines)=categdata2($env,$results->[$i]{'borrowernumber'});
! 	#  	$fines=$fines+0;
! 	  	if ($toggle eq 'white'){
! 	    		$toggle="#ffffcc";
! 	  	} else {
! 	    		$toggle="white";
! 	  	}
! 		print mktablerow(9,$toggle,$results->[$i]{'branchcode'},$results->[$i]{'branchname'},
! 		$results->[$i]{'branchaddress1'}.$results->[$i]{'branchaddress2'}.$results->[$i]{'branchaddress3'},
! 		$results->[$i]{'branchphone'},,$results->[$i]{'branchfax'},,$results->[$i]{'branchmail'},,$results->[$i]{'issuing'},
! 		mklink("$script_name?op=add_form&searchfield=".$results->[$i]{'branchcode'},'Edit'),
! 		mklink("$script_name?op=delete_confirm&searchfield=".$results->[$i]{'branchcode'},'Delete',''));
! 	}
! 	print mktableft;
! 	print "<form action='$script_name' method=post>";
! 	print "<input type=hidden name=op value=add_form>";
! 	if ($offset>0) {
! 		my $prevpage = $offset-$pagesize;
! 		print mklink("$script_name?offset=".$prevpage,'&lt;&lt; Prev');
! 	}
! 	print "&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;";
! 	if ($offset+$pagesize<$count) {
! 		my $nextpage =$offset+$pagesize;
! 		print mklink("$script_name?offset=".$nextpage,'Next &gt;&gt;');
! 	}
! 	print "<br><input type=image src=\"/images/button-add-member.gif\"  WIDTH=188  HEIGHT=44  ALT=\"Add budget\" BORDER=0 ></a><br>";
! 	print "</form>";
! } #---- END $OP eq DEFAULT
! print endmenu('admin');
! print endpage();
--- 1,387 ----
  #!/usr/bin/perl
  
! # Finlay working on this file from 26-03-2002
! # Reorganising this branches admin page.....
  
  use strict;
  use CGI;
! use C4::Output;
  use C4::Database;
  
! # Fixed variables
! my $linecolor1='#ffffcc';
! my $linecolor2='white';
! my $backgroundimage="/images/background-mem.gif";
  my $script_name="/cgi-bin/koha/admin/branches.pl";
  my $pagesize=20;
+ 
+ 
+ #######################################################################################
+ # Main loop....
+ 
+ my $input = new CGI;
+ my $branchcode=$input->param('branchcode');
  my $op = $input->param('op');
! 
! # header
  print $input->header;
  
! # start the page and read in includes
  print startpage();
  print startmenu('admin');
  
! if ($op eq 'add') {
! # If the user has pressed the "add new branch" button. 
!     print heading("Branches: Add Branch");
!     print editbranchform();
! 
! } elsif ($op eq 'edit') {
! # if the user has pressed the "edit branch settings" button.
!     print heading("Branches: Edit Branch");
!     print editbranchform($branchcode);
! 
  } elsif ($op eq 'add_validate') {
! # confirm settings change...
!     my $params = $input->Vars;
!     unless ($params->{'branchcode'} && $params->{'branchname'}) {
! 	default ("Cannot change branch record: You must specify a Branchname and a Branchcode");
!     } else {
! 	setbranchinfo($params);
! 	default ("Branch record changed for branch: $params->{'branchname'}");
!     }
! 
! } elsif ($op eq 'delete') {
! # if the user has pressed the "delete branch" button.
!     my $message = checkdatabasefor($branchcode);
!     if ($message) {
! 	default($message);
!     } else {
! 	print deleteconfirm($branchcode);
!     }
! 
! } elsif ($op eq 'delete_confirmed') {
! # actually delete branch and return to the main screen....
!     deletebranch($branchcode);
!     default("The branch with code $branchcode has been deleted.");
! 
! } else {
! # if no operation has been set...
!     default();
! }
! 
! 
! print endmenu('admin');
! print endpage();
! 
! ######################################################################################################
! #
! # html output functions....
! 
! sub default {
!     my ($message) = @_;
!     print heading("Branches");
!     print "<font color='red'>$message</font>";
!     print "<form action='$script_name' method=post><input type='hidden' name='op' value='add'><input type=submit value='Add New Branch'></form>";
!     print branchinfotable();
!     print branchcategoriestable();
! }
! 
! sub heading {
!     my ($head) = @_;
!     return "<FONT SIZE=6><em>$head</em></FONT><br>";
! }
! 
! sub editbranchform {
! # prepares the edit form...
!     my ($branchcode) = @_;
!     my $data;
!     if ($branchcode) {
! 	$data = getbranchinfo($branchcode);
! 	$data = $data->[0];
!     }
! # make the checkboxs.....
!     my $catinfo = getcategoryinfo();
!     my $catcheckbox;
!     foreach my $cat (@$catinfo) {
! 	my $checked = "";
! 	my $tmp = $cat->{'categorycode'};
! 	if (grep {/^$tmp$/} @{$data->{'categories'}}) {
! 	    $checked = "CHECKED";
! 	}
! 	$catcheckbox .= <<EOF;
! <tr><td>$cat->{'categoryname'}</td>
! <td><INPUT TYPE="checkbox" NAME="$cat->{'categorycode'}" VALUE="1" $checked>$cat->{'codedescription'}</td></tr>
! EOF
!     }
!     my $form = <<EOF;
! <form action='$script_name' name=Aform method=post>
! <input type=hidden name=op value='add_validate'>
! <table>
! <tr><td>Branch code</td><td><input type=text name=branchcode size=5 maxlength=5 value='$data->{'branchcode'}'></td></tr>
! <tr><td>Name</td><td><input type=text name=branchname size=40 maxlength=80 value='$data->{'branchname'}'>&nbsp;</td></tr>
! $catcheckbox
! <tr><td>Address</td><td><input type=text name=branchaddress1 value='$data->{'branchaddress1'}'></td></tr>
! <tr><td>&nbsp;</td><td><input type=text name=branchaddress2 value='$data->{'branchaddress2'}'></td></tr>
! <tr><td>&nbsp;</td><td><input type=text name=branchaddress3 value='$data->{'branchaddress3'}'></td></tr>
! <tr><td>Phone</td><td><input type=text name=branchphone value='$data->{'branchphone'}'></td></tr>
! <tr><td>Fax</td><td><input type=text name=branchfax value='$data->{'branchfax'}'></td></tr>
! <tr><td>E-mail</td><td><input type=text name=branchemail value='$data->{'branchemail'}'></td></tr>
! <tr><td>&nbsp;</td><td><input type=submit value='Submit'></td></tr> 
! </table>
! </form> 
! EOF
!     return $form;
! }
! 
! sub deleteconfirm {
! # message to print if the 
!     my ($branchcode) = @_;
!     my $output = <<EOF;
! Confirm delete: 
! <form action='$script_name' method=post><input type='hidden' name='op' value='delete_confirmed'>
! <input type='hidden' name='branchcode' value=$branchcode>
! <input type=submit value=YES></form>
! <form action='$script_name' method=post><input type='hidden' name='op' value=''>
! <input type=submit value=NO></form>
! EOF
!     return $output;
! }
! 
! 
! sub branchinfotable {
! # makes the html for a table of branch info from reference to an array of hashs.
! 
!     my ($branchcode) = @_;
!     my $branchinfo;
!     if ($branchcode) {
! 	$branchinfo = getbranchinfo($branchcode);
!     } else {
! 	$branchinfo = getbranchinfo();
!     }
!     my $table = <<EOF;
! <table border='1' cellpadding='5' cellspacing='0' width='550'>
! <tr> <th colspan='5' align='left' bgcolor='#99cc33' background=$backgroundimage>
! <font size='5'><b>Branches</b></font></th> </tr> 
! <tr bgcolor='#889999'> 
! <td width='175'><b>Name</b></td> 
! <td width='25'><b>Code</b></td> 
! <td width='175'><b>Address</b></td>
! <td width='175'><b>Categories</b></td>
! <td width='50'><b>&nbsp;</b></td>
! </tr>
! EOF
! 
!     my $color;
!     foreach my $branch (@$branchinfo) {
! 	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
! 	my $address = '';
! 	$address .= $branch->{'branchaddress1'}          if ($branch->{'branchaddress1'});
! 	$address .= '<br>'.$branch->{'branchaddress2'}   if ($branch->{'branchaddress2'});
! 	$address .= '<br>'.$branch->{'branchaddress3'}   if ($branch->{'branchaddress3'});
! 	$address .= '<br>ph: '.$branch->{'branchphone'}   if ($branch->{'branchphone'});
! 	$address .= '<br>fax: '.$branch->{'branchfax'}    if ($branch->{'branchfax'});
! 	$address .= '<br>email: '.$branch->{'branchemail'} if ($branch->{'branchemail'});
! 	$address = '(nothing entered)' unless ($address);
! 	my $categories = '';
! 	foreach my $cat (@{$branch->{'categories'}}) {
! 	    my ($catinfo) = @{getcategoryinfo($cat)};
! 	    $categories .= $catinfo->{'categoryname'}."<br>";
! 	}
! 	$categories = '(no categories set)' unless ($categories);
! 	$table .= <<EOF;
! <tr bgcolor='$color'>
!     <td align='left' valign='top'>$branch->{'branchname'}</td>
!     <td align='left' valign='top'>$branch->{'branchcode'}</td>
!     <td align='left' valign='top'>$address</td>
!     <td align='left' valign='top'>$categories</td>
!     <td align='left' valign='top'> 
! <form action='$script_name' method=post>
! <input type='hidden' name='op' value='edit'>
! <input type='hidden' name='branchcode' value='$branch->{'branchcode'}'>
! <input type=submit value=Edit>
! </form>
! <form action='$script_name' method=post>
! <input type='hidden' name='branchcode' value='$branch->{'branchcode'}'>
! <input type='hidden' name='op' value='delete'><input type=submit value=Delete>
! </form></td>
! </tr>
! EOF
!     }
!     $table .= "</table><br>";
!     return $table;
! }
! 
! sub branchcategoriestable {
! #Needs to be implemented...
! 
!     my $categoryinfo = getcategoryinfo();
!     my $table = <<EOF;
! <table border='1' cellpadding='5' cellspacing='0'>
! <tr> <th colspan='5' align='left' bgcolor='#99cc33' background=$backgroundimage>
! <font size='5'><b>Branches Categories</b></font></th> </tr> 
! <tr bgcolor='#889999'> 
! <td width='175'><b>Name</b></td> 
! <td width='25'><b>Code</b></td> 
! <td width='200'><b>Description</b></td>
! </tr>
! EOF
! my $color;
!     foreach my $cat (@$categoryinfo) {
! 	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
! 	$table .= <<EOF;
! <tr bgcolor='$color'>
!     <td align='left' valign='top'>$cat->{'categoryname'}</td>
!     <td align='left' valign='top'>$cat->{'categorycode'}</td>
!     <td align='left' valign='top'>$cat->{'codedescription'}</td>
! </tr>
! EOF
!     }
!     $table .= "</table>";
!     return $table;
! }
! 
! ######################################################################################################
! #
! # Database functions....
! 
! sub getbranchinfo {
! # returns a reference to an array of hashes containing branches,
! 
!     my ($branchcode) = @_;
!     my $dbh = &C4Connect;
!     my $query;
!     if ($branchcode) {
! 	my $bc = $dbh->quote($branchcode);
! 	$query = "Select * from branches where branchcode = $bc";
!     }
!     else {$query = "Select * from branches";}
!     my $sth = $dbh->prepare($query);
!     $sth->execute;
!     my @results;
!     while (my $data = $sth->fetchrow_hashref) { 
! 	my $tmp = $data->{'branchcode'}; my $brc = $dbh->quote($tmp);
! 	$query = "select categorycode from branchrelations where branchcode = $brc";
! 	my $nsth = $dbh->prepare($query);
! 	$nsth->execute;
! 	my @cats = ();
! 	while (my ($cat) = $nsth->fetchrow_array) {
! 	    push(@cats, $cat);
! 	}
! 	$nsth->finish;
! 	$data->{'categories'} = \@cats;
! 	push(@results, $data);
!     }
!     $sth->finish;
!     $dbh->disconnect;
!     return \@results;
! }
! 
! sub getcategoryinfo {
! # returns a reference to an array of hashes containing branches,
!     my ($catcode) = @_;
!     my $dbh = &C4Connect;
!     my $query;
!     if ($catcode) {
! 	my $cc = $dbh->quote($catcode);
! 	$query = "select * from branchcategories where categorycode = $cc";
!     } else {
! 	$query = "Select * from branchcategories";
!     }
!     my $sth = $dbh->prepare($query);
!     $sth->execute;
!     my @results;
!     while (my $data = $sth->fetchrow_hashref) { 
! 	push(@results, $data);
!     }
!     $sth->finish;
!     $dbh->disconnect;
!     return \@results;
! }
! 
! sub setbranchinfo {
! # sets the data from the editbranch form, and writes to the database...
!     my ($data) = @_;
!     my $dbh=&C4Connect;
!     my $query = "replace branches (branchcode,branchname,branchaddress1,branchaddress2,branchaddress3,branchphone,branchfax,branchemail) values (";
!     my $tmp;
!     $tmp = $data->{'branchcode'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchname'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchaddress1'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchaddress2'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchaddress3'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchphone'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchfax'}; $query.= $dbh->quote($tmp).",";
!     $tmp = $data->{'branchemail'}; $query.= $dbh->quote($tmp).")";
!     my $sth=$dbh->prepare($query);
!     $sth->execute;
!     $sth->finish;
!     $dbh->disconnect;
! # sort out the categories....
!     my @checkedcats;
!     my $cats = getcategoryinfo();
!     foreach my $cat (@$cats) {
! 	my $code = $cat->{'categorycode'};
! 	if ($data->{$code}) {
! 	    push(@checkedcats, $code);
! 	}
!     }
!     my $branchcode = $data->{'branchcode'};
!     my $branch = getbranchinfo($branchcode);
!     $branch = $branch->[0];
!     my $branchcats = $branch->{'categories'};
!     my @addcats;
!     my @removecats;
!     foreach my $bcat (@$branchcats) {
! 	unless (grep {/^$bcat$/} @checkedcats) {
! 	    push(@removecats, $bcat);
! 	}
!     }
!     foreach my $ccat (@checkedcats){
! 	unless (grep {/^$ccat$/} @$branchcats) {
! 	    push(@addcats, $ccat);
! 	}
!     }	
!     my $dbh=&C4Connect;
!     foreach my $cat (@addcats) {
! 	my $query = "insert into branchrelations (branchcode, categorycode) values('$branchcode', '$cat')";
! 	my $sth = $dbh->prepare($query);
  	$sth->execute;
  	$sth->finish;
!     }
!     foreach my $cat (@removecats) {
! 	my $query = "delete from branchrelations where branchcode='$branchcode' and categorycode='$cat'";
! 	my $sth = $dbh->prepare($query);
  	$sth->execute;
  	$sth->finish;
!     }
!     $dbh->disconnect;
! }
! 
! sub deletebranch {
! # delete branch...
!     my ($branchcode) = @_;
!     my $query = "delete from branches where branchcode = '$branchcode'";
!     my $dbh=&C4Connect;
!     my $sth=$dbh->prepare($query);
!     $sth->execute;
!     $sth->finish;
!     $dbh->disconnect;
! }
! 
! sub checkdatabasefor {
! # check to see if the branchcode is being used in the database somewhere....
!     my ($branchcode) = @_;
!     my $dbh = &C4Connect;
!     my $sth=$dbh->prepare("select count(*) from items where holdingbranch='$branchcode' or homebranch='$branchcode'");
!     $sth->execute;
!     my ($total) = $sth->fetchrow_array;
!     $sth->finish;
!     $dbh->disconnect;
!     my $message;
!     if ($total) {
! 	$message = "Branch cannot be deleted because there are $total items using that branch.";
!     } 
!     return $message;
! }
! 
! 




From finlayt at users.sourceforge.net  Wed May  1 17:09:17 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:09:17 2002
Subject: [Koha-devel] CVS: koha/C4 Search.pm,1.18,1.19
Message-ID: <E17349X-000465-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv15441/C4

Modified Files:
	Search.pm 
Log Message:

moredetail.pl presents circulation information taken from the
branchtransfers table

Circ2.pm has been changed a little

admin/branches.pl alows branches to be added, edited and deleted.

updatedatabase needs more fixing


Index: Search.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Search.pm,v
retrieving revision 1.18
retrieving revision 1.19
diff -C2 -r1.18 -r1.19
*** Search.pm	10 Apr 2002 09:55:17 -0000	1.18
--- Search.pm	2 May 2002 00:08:53 -0000	1.19
***************
*** 962,966 ****
  
  sub itemissues {
!   my ($bibitem,$biblio)=@_;
    my $dbh=C4Connect;
    my $query="Select * from items where 
--- 962,966 ----
  
  sub itemissues {
!   my ($bibitem, $biblio)=@_;
    my $dbh=C4Connect;
    my $query="Select * from items where 




From finlayt at users.sourceforge.net  Wed May  1 17:09:18 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:09:18 2002
Subject: [Koha-devel] CVS: koha/C4/Circulation Circ2.pm,1.21,1.22
Message-ID: <E17349X-00046D-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv15441/C4/Circulation

Modified Files:
	Circ2.pm 
Log Message:

moredetail.pl presents circulation information taken from the
branchtransfers table

Circ2.pm has been changed a little

admin/branches.pl alows branches to be added, edited and deleted.

updatedatabase needs more fixing


Index: Circ2.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Circ2.pm,v
retrieving revision 1.21
retrieving revision 1.22
diff -C2 -r1.21 -r1.22
*** Circ2.pm	13 Mar 2002 21:13:42 -0000	1.21
--- Circ2.pm	2 May 2002 00:08:53 -0000	1.22
***************
*** 5,8 ****
--- 5,9 ----
  
  use strict;
+ # use warnings;
  require Exporter;
  use DBI;
***************
*** 24,29 ****
      
  @ISA = qw(Exporter);
! @EXPORT = qw(&getbranches &getprinters &getpatroninformation &currentissues &getiteminformation &findborrower &issuebook &returnbook
! &find_reserves &transferbook);
  %EXPORT_TAGS = ( );     # eg: TAG => [ qw!name1 name2! ],
  		  
--- 25,29 ----
      
  @ISA = qw(Exporter);
! @EXPORT = qw(&getbranches &getprinters &getpatroninformation &currentissues &getiteminformation &findborrower &issuebook &returnbook &returnbook2 &find_reserves &transferbook &decode);
  %EXPORT_TAGS = ( );     # eg: TAG => [ qw!name1 name2! ],
  		  
***************
*** 63,67 ****
  
  sub getbranches {
!     my ($env) = @_;
      my %branches;
      my $dbh=&C4Connect;  
--- 63,67 ----
  
  sub getbranches {
! # returns a reference to a hash of references to branches...
      my %branches;
      my $dbh=&C4Connect;  
***************
*** 69,73 ****
      $sth->execute;
      while (my $branch=$sth->fetchrow_hashref) {
! #	(next) if ($branch->{'branchcode'} eq 'TR');
  	$branches{$branch->{'branchcode'}}=$branch;
      }
--- 69,80 ----
      $sth->execute;
      while (my $branch=$sth->fetchrow_hashref) {
! 	my $tmp = $branch->{'branchcode'}; my $brc = $dbh->quote($tmp);
! 	my $query = "select categorycode from branchrelations where branchcode = $brc";
! 	my $nsth = $dbh->prepare($query);
! 	$nsth->execute;
! 	while (my ($cat) = $nsth->fetchrow_array) {
! 	    $branch->{$cat} = 1;
! 	}
! 	$nsth->finish;
  	$branches{$branch->{'branchcode'}}=$branch;
      }
***************
*** 96,115 ****
      my ($env, $borrowernumber,$cardnumber) = @_;
      my $dbh=&C4Connect;  
      my $sth;
      open O, ">>/root/tkcirc.out";
      print O "Looking up patron $borrowernumber / $cardnumber\n";
      if ($borrowernumber) {
! 	$sth=$dbh->prepare("select * from borrowers where borrowernumber=$borrowernumber");
      } elsif ($cardnumber) {
! 	$sth=$dbh->prepare("select * from borrowers where cardnumber=$cardnumber");
      } else {
! 	 # error condition.  This subroutine must be called with either a
! 	 # borrowernumber or a card number.
! 	$env->{'apierror'}="invalid borrower information passed to getpatroninformation subroutine";
! 	 return();
      }
      $sth->execute;
!     my $borrower=$sth->fetchrow_hashref;
!     my $flags=patronflags($env, $borrower, $dbh);
      $sth->finish;
      $dbh->disconnect;
--- 103,123 ----
      my ($env, $borrowernumber,$cardnumber) = @_;
      my $dbh=&C4Connect;  
+     my $query;
      my $sth;
      open O, ">>/root/tkcirc.out";
      print O "Looking up patron $borrowernumber / $cardnumber\n";
      if ($borrowernumber) {
! 	$query = "select * from borrowers where borrowernumber=$borrowernumber";
      } elsif ($cardnumber) {
! 	$query = "select * from borrowers where cardnumber=$cardnumber";
      } else {
! 	$env->{'apierror'} = "invalid borrower information passed to getpatroninformation subroutine";
! 	return();
      }
+     $env->{'mess'} = $query;
+     $sth = $dbh->prepare($query);
      $sth->execute;
!     my $borrower = $sth->fetchrow_hashref;
!     my $flags = patronflags($env, $borrower, $dbh);
      $sth->finish;
      $dbh->disconnect;
***************
*** 120,123 ****
--- 128,158 ----
  }
  
+ sub decode {
+     my ($encoded) = @_;
+     my $seq = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789+-';
+     my @s = map { index($seq,$_); } split(//,$encoded);
+     my $l = ($#s+1) % 4;
+     if ($l)
+     {
+ 	if ($l == 1)
+ 	{
+ 	    print "Error!";
+ 	    return;
+ 	}
+ 	$l = 4-$l;
+ 	$#s += $l;
+     }
+     my $r = '';
+     while ($#s >= 0)
+     {
+ 	my $n = (($s[0] << 6 | $s[1]) << 6 | $s[2]) << 6 | $s[3];
+ 	$r .=chr(($n >> 16) ^ 67) .
+ 	     chr(($n >> 8 & 255) ^ 67) .
+ 	     chr(($n & 255) ^ 67);
+ 	@s = @s[4..$#s];
+     }
+     $r = substr($r,0,length($r)-$l);
+     return $r;
+ }
  
  
***************
*** 188,205 ****
  
  sub transferbook {
!     my ($env, $iteminformation, $barcode) = @_;
!     my $messages;
      my $dbh=&C4Connect;
      #new entry in branchtransfers....
!     my $sth = $dbh->prepare("insert into branchtransfers (itemnumber, frombranch, datearrived, tobranch) values($iteminformation->{'itemnumber'}, '$env->{'frbranchcd'}', now(), '$env->{'tobranchcd'}')");
!     $sth->execute || return (0,"database error: $sth->errstr");
      $sth->finish;
      #update holdingbranch in items .....
!     $sth = $dbh->prepare("update items set holdingbranch='$env->{'tobranchcd'}' where items.itemnumber=$iteminformation->{'itemnumber'}");
!     $sth->execute || return (0,"database error: $sth->errstr");
!     $sth->execute;
      $sth->finish;
      $dbh->disconnect;
!     return (1, $messages);
  }
  
--- 223,266 ----
  
  sub transferbook {
! # transfer book code....
!     my ($tbr, $barcode) = @_;
!     my $message = "";
!     my %env;
!     my $branches = getbranches();
!     my $iteminformation = getiteminformation(\%env,0, $barcode);
!     if (not $iteminformation) {
! 	$message = "<font color='red' size='+2'>There is no book with barcode: $barcode </font>";
! 	return (0, $message, 0);
!     }
!     my $fbr = $iteminformation->{'holdingbranch'};
!     if ($branches->{$fbr}->{'PE'}) {
! 	$message = "<font color='red' size='+2'>You cannot transfer a book that is in a permanant branch.</font>";
! 	return (0, $message, $iteminformation);
!     }
!     if ($fbr eq $tbr) {
! 	$message = "<font color='red' size='+2'>You can't transfer the book to the branch it is already at! </font>";
! 	return (0, $message, $iteminformation);
!     }
      my $dbh=&C4Connect;
+     my ($currentborrower) = currentborrower(\%env, $iteminformation->{'itemnumber'}, $dbh);
+     if ($currentborrower) {
+ 	$message = "<font color='red' size='+2'>Book cannot be transfered bracause it is currently on loan to: $currentborrower . Please return book first.</font>";
+ 	return (0, $message, $iteminformation);
+     }
+     my $itm = $dbh->quote($iteminformation->{'itemnumber'});
+     $fbr = $dbh->quote($fbr);
+     $tbr = $dbh->quote($tbr);
      #new entry in branchtransfers....
!     my $query = "insert into branchtransfers (itemnumber, frombranch, datearrived, tobranch) values($itm, $fbr, now(), $tbr)";
!     my $sth = $dbh->prepare($query);
!     $sth->execute; 
      $sth->finish;
      #update holdingbranch in items .....
!     $query = "update items set datelastseen = now(), holdingbranch=$tbr where items.itemnumber=$itm";
!     $sth = $dbh->prepare($query);
!     $sth->execute; 
      $sth->finish;
      $dbh->disconnect;
!     return (1, $message, $iteminformation);
  }
  
***************
*** 396,400 ****
  	    # check for overdue fine
  
- 	    $overduecharge;
  	    $sth=$dbh->prepare("select * from accountlines where (borrowernumber=$borrower->{'borrowernumber'}) and (itemnumber = $iteminformation->{'itemnumber'}) and (accounttype='FU' or accounttype='O')");
  	    $sth->execute;
--- 457,460 ----
***************
*** 407,412 ****
  	    }
  	    $sth->finish;
! 	 }
! 	 if ($iteminformation->{'itemlost'} eq '1'){
  	    # check for charge made for lost book
  	    my $query="select * from accountlines where (itemnumber =
--- 467,472 ----
  	    }
  	    $sth->finish;
! 	}
! 	if ($iteminformation->{'itemlost'} eq '1'){
  	    # check for charge made for lost book
  	    my $query="select * from accountlines where (itemnumber =
***************
*** 518,582 ****
  
  
  sub patronflags {
  # Original subroutine for Circ2.pm
      my %flags;
!     my ($env,$patroninformation,$dbh) = @_;
!     my $amount = checkaccount($env,$patroninformation->{'borrowernumber'}, $dbh);
      if ($amount > 0) { 
  	my %flaginfo;
! 	$flaginfo{'message'}=sprintf "Patron owes \$%.02f", $amount; 
! 	if ($amount>5) {
! 	    $flaginfo{'noissues'}=1;
  	}
! 	$flags{'CHARGES'}=\%flaginfo;
      } elsif ($amount < 0){
         my %flaginfo;
!        $amount=$amount*-1;
!        $flaginfo{'message'}=sprintf "Patron has credit of \$%.02f", $amount;
!        	$flags{'CHARGES'}=\%flaginfo;
      }
      if ($patroninformation->{'gonenoaddress'} == 1) {
  	my %flaginfo;
! 	$flaginfo{'message'}='Borrower has no valid address.'; 
! 	$flaginfo{'noissues'}=1;
! 	$flags{'GNA'}=\%flaginfo;
      }
      if ($patroninformation->{'lost'} == 1) {
  	my %flaginfo;
! 	$flaginfo{'message'}='Borrower\'s card reported lost.'; 
! 	$flaginfo{'noissues'}=1;
! 	$flags{'LOST'}=\%flaginfo;
      }
      if ($patroninformation->{'debarred'} == 1) {
  	my %flaginfo;
! 	$flaginfo{'message'}='Borrower is Debarred.'; 
! 	$flaginfo{'noissues'}=1;
! 	$flags{'DBARRED'}=\%flaginfo;
      }
      if ($patroninformation->{'borrowernotes'}) {
  	my %flaginfo;
! 	$flaginfo{'message'}="$patroninformation->{'borrowernotes'}";
! 	$flags{'NOTES'}=\%flaginfo;
      }
!     my ($odues, $itemsoverdue) = checkoverdues($env,$patroninformation->{'borrowernumber'},$dbh);
      if ($odues > 0) {
  	my %flaginfo;
! 	$flaginfo{'message'}="Yes";
! 	$flaginfo{'itemlist'}=$itemsoverdue;
  	foreach (sort {$a->{'date_due'} cmp $b->{'date_due'}} @$itemsoverdue) {
  	    $flaginfo{'itemlisttext'}.="$_->{'date_due'} $_->{'barcode'} $_->{'title'} \n";
  	}
! 	$flags{'ODUES'}=\%flaginfo;
      }
!     my ($nowaiting,$itemswaiting) = checkwaiting($env,$dbh,$patroninformation->{'borrowernumber'});
!     if ($nowaiting>0) {
  	my %flaginfo;
! 	$flaginfo{'message'}="Reserved items available";
! 	$flaginfo{'itemlist'}=$itemswaiting;
! 	$flaginfo{'itemfields'}=['barcode', 'title', 'author', 'dewey', 'subclass', 'holdingbranch'];
! 	$flags{'WAITING'}=\%flaginfo;
      }
-     my $flag;
-     my $key;
      return(\%flags);
  }
--- 578,798 ----
  
  
+ 
+ sub returnbook2 {
+     my ($env, $barcode) = @_;
+     my @messages;
+     my $dbh=&C4Connect;
+ # get information on item
+     my ($iteminformation) = getiteminformation($env, 0, $barcode);
+     if (not $iteminformation) {
+ 	push(@messages, "<font color='red' size='+2'> There is no book with barcode: $barcode </font>");
+ 	return (0, \@messages, 0 ,0);
+     }
+ #    updatelastseen($env, $dbh, $iteminformation->{'itemnumber'});
+ 
+ # find the borrower
+     my $borrower;
+     my ($currentborrower) = currentborrower($env, $iteminformation->{'itemnumber'}, $dbh);
+     if (not $currentborrower) {
+ 	push(@messages, "<font color='red' size='+2'>Book: $barcode is not currently issued.</font>");
+ 	return (0, \@messages, 0,0);
+     }
+ # update issues, thereby returning book (should push this out into another subroutine
+     ($borrower) = getpatroninformation($env, $currentborrower, 0);
+     my $query = "update issues set returndate = now()
+         where (borrowernumber = '$borrower->{'borrowernumber'}') 
+         and (itemnumber = '$iteminformation->{'itemnumber'}') and (returndate is null)";
+     my $sth = $dbh->prepare($query);
+     $sth->execute;
+     $sth->finish;
+     push(@messages, "Book has been returned.");
+ 
+     my $tbr = $env->{'branchcode'};
+     my ($transfered, $message, $item) = transferbook($tbr, $barcode);
+     if ($transfered) {
+ 	push(@messages, "Book: as been transfered.");
+      }
+ 
+     if ($iteminformation->{'itemlost'}) {
+ 	updateitemlost($dbh, $iteminformation->{'itemnumber'});
+ # check for charge made for lost book
+ 	my $query = "select * from accountlines where (itemnumber = '$iteminformation->{'itemnumber'}') 
+             and (accounttype='L' or accounttype='Rep') order by date desc";
+ 	my $sth = $dbh->prepare($query);
+ 	$sth->execute;
+ 	if (my $data = $sth->fetchrow_hashref) {
+ # writeoff this amount 
+ 	    my $offset;
+ 	    my $amount = $data->{'amount'};
+ 	    my $acctno = $data->{'accountno'};
+ 	    my $amountleft;
+ 	    if ($data->{'amountoutstanding'} == $amount) {
+ 		$offset = $data->{'amount'};
+ 		$amountleft = 0;
+ 	    } else {
+ 		$offset = $amount - $data->{'amountoutstanding'};
+ 		$amountleft = $data->{'amountoutstanding'} - $amount;
+ 	    }
+ 	    my $uquery = "update accountlines
+ 		  set accounttype = 'LR',amountoutstanding='0'
+ 		  where (borrowernumber = '$data->{'borrowernumber'}')
+ 		  and (itemnumber = '$iteminformation->{'itemnumber'}')
+ 		  and (accountno = '$acctno') ";
+ 	    my $usth = $dbh->prepare($uquery);
+ 	    $usth->execute;
+ 	    $usth->finish;
+ #check if any credit is left if so writeoff other accounts
+ 	    my $nextaccntno = getnextacctno($env,$data->{'borrowernumber'},$dbh);
+ 	    if ($amountleft < 0){
+ 		$amountleft*=-1;
+ 	    }
+ 	    if ($amountleft > 0){
+ 		my $query = "select * from accountlines
+ 		  where (borrowernumber = '$data->{'borrowernumber'}') and (amountoutstanding >0)
+ 		  order by date";
+ 		my $msth = $dbh->prepare($query);
+ 		$msth->execute;
+ 		  # offset transactions
+ 		my $newamtos;
+ 		my $accdata;
+ 		while (($accdata=$msth->fetchrow_hashref) and ($amountleft>0)){
+ 		    if ($accdata->{'amountoutstanding'} < $amountleft) {
+ 			$newamtos = 0;
+ 			$amountleft = $amountleft - $accdata->{'amountoutstanding'};
+ 		    }  else {
+ 			$newamtos = $accdata->{'amountoutstanding'} - $amountleft;
+ 			$amountleft = 0;
+ 		    }
+ 		    my $thisacct = $accdata->{accountno};
+ 		    my $updquery = "update accountlines set amountoutstanding= '$newamtos'
+ 		                where (borrowernumber = '$data->{'borrowernumber'}') and (accountno='$thisacct')";
+ 		    my $usth = $dbh->prepare($updquery);
+ 		    $usth->execute;
+ 		    $usth->finish;
+ 		    $updquery = "insert into accountoffsets 
+ 		          (borrowernumber, accountno, offsetaccount,  offsetamount)
+ 		          values
+ 		          ('$data->{'borrowernumber'}','$accdata->{'accountno'}','$nextaccntno','$newamtos')";
+ 		    my $usth = $dbh->prepare($updquery);
+ 		    $usth->execute;
+ 		    $usth->finish;
+ 		}
+ 		$msth->finish;
+ 	    }
+ 	    if ($amountleft > 0){
+ 		$amountleft*=-1;
+ 	    }
+ 	    my $desc="Book Returned ".$iteminformation->{'barcode'};
+ 	    $uquery = "insert into accountlines
+ 		  (borrowernumber,accountno,date,amount,description,accounttype,amountoutstanding)
+ 		  values ('$data->{'borrowernumber'}','$nextaccntno',now(),0-$amount,'$desc',
+ 		  'CR',$amountleft)";
+ 	    $usth = $dbh->prepare($uquery);
+ 
+ 	    $usth->execute;
+ 	    $usth->finish;
+ 	    $uquery = "insert into accountoffsets
+ 		  (borrowernumber, accountno, offsetaccount,  offsetamount)
+ 		  values ($borrower->{'borrowernumber'},$data->{'accountno'},$nextaccntno,$offset)";
+ 	    $usth = $dbh->prepare($uquery);
+ 	    $usth->execute;
+ 	    $usth->finish;
+ 	    $uquery="update items set paidfor='' where itemnumber='$iteminformation->{'itemnumber'}'";
+ 	    $usth = $dbh->prepare($uquery);
+ 	    $usth->execute;
+ 	    $usth->finish;
+ 	}
+ 	$sth->finish;
+     }
+ 
+ # check for overdue fine
+     my $query = "select * from accountlines where (borrowernumber='$borrower->{'borrowernumber'}') 
+         and (itemnumber = '$iteminformation->{'itemnumber'}') and (accounttype='FU' or accounttype='O')";
+     $sth = $dbh->prepare($query);
+     $sth->execute;
+ # alter fine to show that the book has been returned
+     if (my $data = $sth->fetchrow_hashref) {
+ 	my $query = "update accountlines set accounttype='F' 
+             where (borrowernumber=$borrower->{'borrowernumber'}) and (itemnumber=$iteminformation->{'itemnumber'}) 
+             and (acccountno='$data->{'accountno'}')";
+ 	my $usth=$dbh->prepare($query);
+ 	$usth->execute();
+ 	$usth->finish();
+     }
+     $sth->finish;
+ 
+     my ($resfound, $resrec) = find_reserves($env, $dbh, $iteminformation->{'itemnumber'});
+     if ($resfound eq 'y') {
+ 	my ($borrower) = getpatroninformation($env,$resrec->{'borrowernumber'},0);
+ 	my ($branches) = getbranches();
+ 	my $branchname = $branches->{$resrec->{'branchcode'}}->{'branchname'};
+ 	push(@messages, "<b><font color=red>RESERVED</font></b> for collection by $borrower->{'firstname'} $borrower->{'surname'} ($borrower->{'cardnumber'}) at $branchname");
+     }
+     UpdateStats($env,$env->{'branchcode'},'return','0','',$iteminformation->{'itemnumber'});
+     $dbh->disconnect;
+     return (1, \@messages, $iteminformation, $borrower);
+ }
+ 
+ 
+ 
  sub patronflags {
  # Original subroutine for Circ2.pm
      my %flags;
!     my ($env, $patroninformation, $dbh) = @_;
!     my $amount = checkaccount($env, $patroninformation->{'borrowernumber'}, $dbh);
      if ($amount > 0) { 
  	my %flaginfo;
! 	$flaginfo{'message'}= sprintf "Patron owes \$%.02f", $amount; 
! 	if ($amount > 5) {
! 	    $flaginfo{'noissues'} = 1;
  	}
! 	$flags{'CHARGES'} = \%flaginfo;
      } elsif ($amount < 0){
         my %flaginfo;
!        $amount = $amount*-1;
!        $flaginfo{'message'} = sprintf "Patron has credit of \$%.02f", $amount;
!        	$flags{'CHARGES'} = \%flaginfo;
      }
      if ($patroninformation->{'gonenoaddress'} == 1) {
  	my %flaginfo;
! 	$flaginfo{'message'} = 'Borrower has no valid address.'; 
! 	$flaginfo{'noissues'} = 1;
! 	$flags{'GNA'} = \%flaginfo;
      }
      if ($patroninformation->{'lost'} == 1) {
  	my %flaginfo;
! 	$flaginfo{'message'} = 'Borrower\'s card reported lost.'; 
! 	$flaginfo{'noissues'} = 1;
! 	$flags{'LOST'} = \%flaginfo;
      }
      if ($patroninformation->{'debarred'} == 1) {
  	my %flaginfo;
! 	$flaginfo{'message'} = 'Borrower is Debarred.'; 
! 	$flaginfo{'noissues'} = 1;
! 	$flags{'DBARRED'} = \%flaginfo;
      }
      if ($patroninformation->{'borrowernotes'}) {
  	my %flaginfo;
! 	$flaginfo{'message'} = "$patroninformation->{'borrowernotes'}";
! 	$flags{'NOTES'} = \%flaginfo;
      }
!     my ($odues, $itemsoverdue) = checkoverdues($env, $patroninformation->{'borrowernumber'}, $dbh);
      if ($odues > 0) {
  	my %flaginfo;
! 	$flaginfo{'message'} = "Yes";
! 	$flaginfo{'itemlist'} = $itemsoverdue;
  	foreach (sort {$a->{'date_due'} cmp $b->{'date_due'}} @$itemsoverdue) {
  	    $flaginfo{'itemlisttext'}.="$_->{'date_due'} $_->{'barcode'} $_->{'title'} \n";
  	}
! 	$flags{'ODUES'} = \%flaginfo;
      }
!     my ($nowaiting, $itemswaiting) = checkwaiting($env, $dbh, $patroninformation->{'borrowernumber'});
!     if ($nowaiting > 0) {
  	my %flaginfo;
! 	$flaginfo{'message'} = "Reserved items available";
! 	$flaginfo{'itemlist'} = $itemswaiting;
! 	$flaginfo{'itemfields'} = ['barcode', 'title', 'author', 'dewey', 'subclass', 'holdingbranch'];
! 	$flags{'WAITING'} = \%flaginfo;
      }
      return(\%flags);
  }
***************
*** 604,612 ****
  sub updatelastseen {
  # Stolen from Returns.pm
!     my ($env,$dbh,$itemnumber)= @_;
!     my $br = $env->{'branchcode'};
!     my $query = "update items 
!     set datelastseen = now(), holdingbranch = '$br'
!     where (itemnumber = '$itemnumber')";
      my $sth = $dbh->prepare($query);
      $sth->execute;
--- 820,828 ----
  sub updatelastseen {
  # Stolen from Returns.pm
!     my ($env, $dbh, $itemnumber) = @_;
!     my $brc = $env->{'branchcode'};
!     $brc = $dbh->quote($brc);
!     my $itm = $dbh->quote($itemnumber);
!     my $query = "update items set datelastseen = now(), holdingbranch = $brc where (itemnumber = $itm)";
      my $sth = $dbh->prepare($query);
      $sth->execute;
***************
*** 617,621 ****
  # Original subroutine for Circ2.pm
      my ($env, $itemnumber, $dbh) = @_;
!     my $q_itemnumber=$dbh->quote($itemnumber);
      my $sth=$dbh->prepare("select borrowers.borrowernumber from
      issues,borrowers where issues.itemnumber=$q_itemnumber and
--- 833,837 ----
  # Original subroutine for Circ2.pm
      my ($env, $itemnumber, $dbh) = @_;
!     my $q_itemnumber = $dbh->quote($itemnumber);
      my $sth=$dbh->prepare("select borrowers.borrowernumber from
      issues,borrowers where issues.itemnumber=$q_itemnumber and
***************
*** 623,627 ****
      NULL");
      $sth->execute;
!     my ($previousborrower)=$sth->fetchrow;
      return($previousborrower);
  }
--- 839,843 ----
      NULL");
      $sth->execute;
!     my ($previousborrower) = $sth->fetchrow;
      return($previousborrower);
  }




From finlayt at users.sourceforge.net  Wed May  1 17:18:08 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:18:08 2002
Subject: [Koha-devel] CVS: koha/circ circulationold.pl,NONE,1.1 returns.pl,NONE,1.1 branchtransfers.pl,1.3,1.4 circulation.pl,1.23,1.24
Message-ID: <E17347C-0003yk-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/circ
In directory usw-pr-cvs1:/tmp/cvs-serv14842

Modified Files:
	branchtransfers.pl circulation.pl 
Added Files:
	circulationold.pl returns.pl 
Log Message:

Changes to circulations:
added returns.pl  ->  deals with the returns only
moved old circulation.pl to circulationold.pl which still deals with issues.
fixed up branchtransfers.pl
moved circulation2.pl to circulation.pl

Note more changes coming next week


--- NEW FILE ---
#!/usr/bin/perl

use CGI qw/:standard/;
use C4::Circulation::Circ2;
use C4::Output;
use C4::Print;
use DBI;


my %env;
my $headerbackgroundcolor='#99cc33';
my $circbackgroundcolor='#ffffcc';
my $circbackgroundcolor='white';
my $linecolor1='#ffffcc';
my $linecolor2='white';
my $backgroundimage="/images/background-mem.gif";
my $query=new CGI;
my $branches=getbranches(\%env);
my $printers=getprinters(\%env);
my $branch=$query->param('branch');
my $printer=$query->param('printer');
#print $query->header;
($branch) || ($branch=$query->cookie('branch'));
($printer) || ($printer=$query->cookie('printer'));
my ($oldbranch, $oldprinter);
if ($query->param('selectnewbranchprinter')) {
    $oldbranch=$branch;
    $oldprinter=$printer;
    $branch='';
    $printer='';
}
$env{'branchcode'}=$branch;
$env{'printer'}=$printer;
$env{'queue'}=$printer;
my $branchcount=0;
my $printercount=0;
my $branchoptions;
my $printeroptions;
foreach (keys %$branches) {
    (next) unless ($_);
    (next) if (/^TR$/);
    $branchcount++;
    my $selected='';
    ($selected='selected') if ($_ eq $oldbranch);
    $branchoptions.="<option value=$_ $selected>$branches->{$_}->{'branchname'}\n";
}
foreach (keys %$printers) {
    (next) unless ($_);
    $printercount++;
    my $selected='';
    ($selected='selected') if ($_ eq $oldprinter);
    $printeroptions.="<option value=$_ $selected>$printers->{$_}->{'printername'}\n";
}
if ($printercount==1) {
    ($printer)=keys %$printers;
}
if ($branchcount==1) {
    ($branch)=keys %$branches;
}


my $branchname='';
my $printername='';
if ($branch && $printer) {
    $branchname=$branches->{$branch}->{'branchname'};
    $printername=$printers->{$printer}->{'printername'};
}


my $branchcookie=$query->cookie(-name=>'branch', -value=>"$branch", -expires=>'+1y');
my $printercookie=$query->cookie(-name=>'printer', -value=>"$printer", -expires=>'+1y');

print $query->header(-type=>'text/html',-expires=>'now', -cookie=>[$branchcookie,$printercookie]);
#print $query->dump;
print startpage();
#print startmenu('circulation');
my @inp=startmenu('circulation');
if ($query->param('module') eq 'issues' && $query->param('barcode') eq '' && $query->param('charges') eq 'yes'){
 my $count=@inp;
 for (my $i=0;$i<$count;$i++){
  my $bornum=$query->param('borrnumber');
  $inp[$i]=~ s/onLoad=focusinput\(\)/onLoad=focusinput\(\)\;messenger\(\"\/cgi-bin\/koha\/pay.pl?bornum=$bornum\"\)\;window1.focus\(\)/;
 }
}
print @inp;

print <<EOF
<script language="javascript" type="text/javascript">
<!--
function messenger(url){
   window1=window.open(url,"window1","height=700,width=600,left=150,top=50,350,screenY=50");
}
//-->
</script>
EOF
;
if ($printer && $branch) {

    SWITCH: {
	if ($query->param('module') eq 'issues') { issues(); last SWITCH; }
	if ($query->param('module') eq 'returns') { returns(); last SWITCH; }
	issues();
    }
} else {
    my ($printerform, $branchform);
    if ($printercount>1) {
	$printerform=<<"EOF";

<table border=0 cellspacing=0 cellpadding=5>
<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Choose a Printer</font></td></tr>
<tr><td>
<select name=printer>
$printeroptions
</select>
</td></tr>
</table>
EOF
    } else {
	my ($printer) = keys %$printers;
	$printerform=<<"EOF";
	<input type=hidden name=printer value=$printer>
EOF
    }

    if ($branchcount>1) {
	$branchform=<<"EOF";
<table border=0 cellpadding=5 cellspacing=0>
<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Choose a Branch</font></td></tr>
<tr><td>
<select name=branch>
$branchoptions
</select>
</td></tr>
</table>
EOF
    }
    print << "EOF";
    <center>
    Select a branch and a printer
    <form method=get>
    <table border=0>
    <tr><td>
    $branchform
    </td><td>
    $printerform
    </td></tr>
    </table>
    <input type=submit>
    </form>
EOF
}


print endmenu('circulation');
print endpage();

sub default {
print << "EOF";
<a href=cirulationold.pl?module=issues&branch=$branch&printer=$printer>Issues</a>
<a href=cirulationold.pl?module=returns&branch=$branch&printer=$printer>Returns</a>
EOF
}


sub decode {
    ($encoded) = @_;
    $seq = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789+-';
    @s = map { index($seq,$_); } split(//,$encoded);
    $l = ($#s+1) % 4;
    if ($l)
    {
	if ($l == 1)
	{
	    print "Error!";
	    return;
	}
	$l = 4-$l;
	$#s += $l;
    }
    $r = '';
    while ($#s >= 0)
    {
	$n = (($s[0] << 6 | $s[1]) << 6 | $s[2]) << 6 | $s[3];
	$r .=chr(($n >> 16) ^ 67) .
	     chr(($n >> 8 & 255) ^ 67) .
	     chr(($n & 255) ^ 67);
	@s = @s[4..$#s];
    }
    $r = substr($r,0,length($r)-$l);
    return $r;
}

sub returns {
    my %returneditems;
    print "<FONT SIZE=6><em>Circulation: Returns</em></FONT><br>";
    foreach ($query->param) {
	(next) unless (/ri-(\d*)/);
	my $counter=$1;
	(next) if ($counter>20);
	my $barcode=$query->param("ri-$counter");
      # I'm not POSITIVE this decode belongs here - can't tell what causes it to run.
      # decode cuecat
      chomp($barcode);
      @fields = split(/\./,$barcode);
      @results = map(decode($_), @fields[1..$#fields]);
      if ($#results == 2)
      {
  	$barcode=$results[2];
      }
      # end decode
	my $duedate=$query->param("dd-$counter");
	my $borrowernumber=$query->param("bn-$counter");
	$counter++;
	$returneditems{$counter}=$barcode;
	$riduedate{$counter}=$duedate;
	$riborrowernumber{$counter}=$borrowernumber;
	$ritext.="<input type=hidden name=ri-$counter value=$barcode>\n";
	$ritext.="<input type=hidden name=dd-$counter value=$duedate>\n";
	$ritext.="<input type=hidden name=bn-$counter value=$borrowernumber>\n";
    }
    if (my $barcode=$query->param('barcode')) {
      # decode cuecat
      chomp($barcode);
      @fields = split(/\./,$barcode);
      @results = map(decode($_), @fields[1..$#fields]);
      if ($#results == 2)
      {
  	$barcode=$results[2];
      }
      # end decode
	$ritext.="<input type=hidden name=ri-0 value=$barcode>\n";
	$returneditems{0}=$barcode;
    }
	
    my $barcodeentrytext= << "EOF";
    <form method=post action=/cgi-bin/koha/circ/cirulationold.pl>
    <table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
	<tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage><font color=black><b>Enter Book Barcode</b></font></td></tr>
	<tr><td>Item Barcode:</td><td><input name=barcode size=10></td></tr>
    </table>
    <input type=hidden name=module value=returns>
    <input type=hidden name=branch value=$branch>
    <input type=hidden name=printer value=$printer>
    $ritext
EOF
    if ((my $barcode=$query->param('barcode')) || (%returneditems)) {
      # decode cuecat
      chomp($barcode);
      @fields = split(/\./,$barcode);
      @results = map(decode($_), @fields[1..$#fields]);
      if ($#results == 2)
      {
  	$barcode=$results[2];
      }
      # end decode
	my ($iteminformation, $borrower, $messages, $overduecharge) = returnbook(\%env, $barcode);
	
	(my $nosuchitem=1) unless ($iteminformation);
	$riborrowernumber{0}=$borrower->{'borrowernumber'};
	$riduedate{0}=$iteminformation->{'date_due'};
	$barcodeentrytext.= "<input type=hidden name=dd-0 value=$iteminformation->{'date_due'}>\n";
	$barcodeentrytext.= "<input type=hidden name=bn-0 value=$borrower->{'borrowernumber'}>\n";
	my @datearr = localtime(time());
	my $todaysdate = (1900+$datearr[5]).'-'.sprintf ("%0.2d", ($datearr[4]+1)).'-'.
	  sprintf ("%0.2d", $datearr[3]);
	my $itemtable=<<"EOF";
<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Returned Item Information</font></th></tr>
<tr><td>
Title: $iteminformation->{'title'}<br>
<!--Hlt decided they dont want these showing, uncoment the html to make it work

Author: $iteminformation->{'author'}<br>
Barcode: <a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}&type=intra onClick="openWindow(this, 'Item', 480, 640)">$iteminformation->{'barcode'}</a><br>
Date Due: $iteminformation->{'date_due'}-->
</td></tr>
</table>
EOF
	if ($messages) {
	    my $messagetext='';
	    foreach (@$messages) {
		$messagetext.="$_<p>\n";
	    }
	    print << "EOF";
<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
<tr><th bgcolor=$headerbackgroundcolor $background=$backgroundimage><font color=black>Messages</font></th></tr>
<tr><td>
$messagetext
</td></tr>
</table>
<p>
EOF
        }
	if (($nosuchitem) && ($barcode)) {
	    print << "EOF";
	    <table border=0 cellpadding=1>
	    <tr>
	    <td valign=top>
	    $barcodeentrytext
	    </td>
	    <td valign=top>
	    <table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
	    <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Error</font></th></tr>
	    <tr><td>
	    <table border=0 cellpadding=5>
	    <tr><td>
	    $barcode is not a valid barcode.
	    </td></tr>
	    </table>
	    </td></tr>
	    </table>
	    </td>
	    </tr>
	    </table>
EOF
	} elsif ($nosuchitem) {
	    print << "EOF";
	    <table border=0 cellpadding=1>
	    <tr>
	    <td valign=top>
	    $barcodeentrytext
	    </td>
	    </tr>
	    </table>
EOF
	} else {
	    if ($borrower->{'borrowernumber'}) {
		my ($patrontable, $flaginfotext) = patrontable($borrower);
		print << "EOF";
		<table border=0 cellpadding=5>
		    <tr>
			<td>
			$barcodeentrytext
			</td>
			<td align=center valign=top>
			$itemtable
			</td>
		    </tr>
		    <tr>
			<td valign=top align=center colspan=2>
			<table border=0>
			<tr><td valign=top>
			$patrontable
			</td>
			<td valign=top>
			$flaginfotext
			</td>
			</tr>
			</table>
			</td>
		    </tr>
		</table>
		<br>
EOF
	    } else {
		print << "EOF";
		<table border=0 cellpadding=5>
		<tr><td>
		$barcodeentrytext
		</td>
		<td>

		<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
		<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Error</font></th></tr>
		<tr><td>
		<table border=0 cellpadding=5>
		<tr><td>
		$iteminformation->{'title'} by $iteminformation->{'author'} was not loaned out.
		</td></tr>
		</table>
		</td></tr>
		</table>
		</td>
		</tr>
		</table>
EOF
	    }
	}
	print << "EOF";
	<p>
	<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
	<tr><th colspan=6 bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Returned Items</font></th></tr>
	<tr><th>Due Date</th><th>Bar Code</th><th>Title</th><th>Author</th><th>Type</th><th>Borrower</th></tr>
EOF
	my $color='';
	#set up so only the lat 8 returned items display (make for faster loading pages)
	my $count=0;
	foreach (sort {$a <=> $b} keys %returneditems) {
	  if ($count < 8){
	    ($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
	    my $barcode=$returneditems{$_};
	    my $duedate=$riduedate{$_};
	    my @datearr = localtime(time());
	    ###
	    # convert to nz date format
	    my @tempdate=split(/-/,$duedate);
	    $duedate="$tempdate[2]/$tempdate[1]/$tempdate[0]";
	    ####
	    my $todaysdate = (1900+$datearr[5]).'-'.sprintf ("%0.2d", ($datearr[4]+1)).'-'.sprintf ("%0.2d", $datearr[3]);
	    my $overduetext="$duedate";
	    ($overduetext="<font color=red>$duedate</font>") if ($duedate lt $todaysdate);
	    ($duedate) || ($overduetext="<img src=/koha/images/blackdot.gif>");
	    my $borrowernumber=$riborrowernumber{$_};
	    my ($borrower) = getpatroninformation(\%env,$borrowernumber,0);
	    my ($iteminformation) = getiteminformation(\%env, 0, $barcode);
	    print "<tr><td bgcolor=$color>$overduetext</td><td bgcolor=$color align=center><a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}&type=intra onClick=\"openWindow(this, 'Item', 480, 640)\">$barcode</a></td><td bgcolor=$color>$iteminformation->{'title'}</td><td bgcolor=$color>$iteminformation->{'author'}</td><td bgcolor=$color align=center>$iteminformation->{'itemtype'}</td><td bgcolor=$color><img src=/koha/images/blackdot.gif><a href=/cgi-bin/koha/moremember.pl?bornum=$borrower->{'borrowernumber'} onClick=\"openWindow(this,'Member', 480, 640)\">$borrower->{'cardnumber'}</a> $borrower->{'firstname'} $borrower->{'surname'}</td></tr>\n";
	  } else {
	    last
	  }
	  $count++;
	}
	print "</table>\n";
    } else {
	print $barcodeentrytext;
    }
    print "</form>\n";
    print "</td></tr></table>\n";
}

sub issues {

    my ($noheader) = shift;
    my $print=$query->param('print');
    my $borrowernumber=$query->param('borrnumber');    
    my $barcode=$query->param('barcode');
    if ($barcode eq ''){
      $print='yes';     
    } elsif ($barcode eq ' '){
      $query->param('barcode','');
      $barcode='';
    }
    if ($print eq 'yes' && $borrowernumber ne ''){
      my ($borrower, $flags) = getpatroninformation(\%env,$borrowernumber,0);
      $env{'todaysissues'}=1;
      my ($borrowerissues) = currentissues(\%env, $borrower);
      $env{'nottodaysissues'}=1;
      $env{'todaysissues'}=0;
      my ($borroweriss2)=currentissues(\%env, $borrower);
      $env{'nottodaysissues'}=0;
      my $i=0;
      my @issues;
      foreach (sort keys %$borrowerissues) {
        $issues[$i]=$borrowerissues->{$_};
	my $dd=$issues[$i]->{'date_due'};
	#convert to nz style dates
	#this should be set with some kinda config variable	
	my @tempdate=split(/-/,$dd);
	$issues[$i]->{'date_due'}="$tempdate[2]/$tempdate[1]/$tempdate[0]";
	$i++;
      }
      foreach (sort keys %$borroweriss2) {
        $issues[$i]=$borroweriss2->{$_};
	my $dd=$issues[$i]->{'date_due'};
	#convert to nz style dates
	#this should be set with some kinda config variable	
	my @tempdate=split(/-/,$dd);
	$issues[$i]->{'date_due'}="$tempdate[2]/$tempdate[1]/$tempdate[0]";
	$i++;
      }
      remoteprint(\%env,\@issues,$borrower);
      $query->param('borrnumber','')
    }
    unless ($noheader) {
      print <<EOF
      <p align=right>
      <FONT SIZE=2  face="arial, helvetica">
      <a href=circulationold.pl?borrnumber=$borrowernumber&module=issues&branch=$branch&printer=$printer&print>Next Borrower</a> ||
      <a href=returns.pl>Returns</a> ||
      <a href=branchtransfers.pl>Transfers</a></font><p>
        
	</p>
<FONT SIZE=6><em>Circulation: Issues</em></FONT><br>
EOF
    }
    if (my $borrnumber=$query->param('borrnumber')) {
	my ($borrower, $flags) = getpatroninformation(\%env,$borrnumber,0);
	my $year=$query->param('year');
	my $month=$query->param('month');
	my $day=$query->param('day');
	if (my $barcode=$query->param('barcode')) {
          # decode cuecat
          chomp($barcode);
          @fields = split(/\./,$barcode);
          @results = map(decode($_), @fields[1..$#fields]);
          if ($#results == 2)
          {
      	    $barcode=$results[2];
          }
          # end decode
	    my $invalidduedate=0;
	    $env{'datedue'}='';
	    if (($year eq 0) && ($month eq 0) && ($year eq 0)) {
		$env{'datedue'}='';
	    } else {
		if (($year eq 0) || ($month eq 0) || ($year eq 0)) {
		    print "Invalid Due Date Specified. Book was not issued.<p>\n";
		    $invalidduedate=1;
		} else {
		    if (($day>30) && (($month==4) || ($month==6) || ($month==9) || ($month==11))) {
			print "Invalid Due Date Specified. Book was not issued. Only 30 days in $month month.<p>\n";
			$invalidduedate=1;
		    } elsif (($day>29) && ($month==2)) {
			print "Invalid Due Date Specified. Book was not issued.  Never that many days in February!<p>\n";
			$invalidduedate=1;
		    } elsif (($month==2) && ($day>28) && (($year%4) && ((!($year%100) || ($year%400))))) {
			print "Invalid Due Date Specified. Book was not issued.  $year is not a leap year.<p>\n";
			$invalidduedate=1;
		    } else {
			$env{'datedue'}="$year-$month-$day";
		    }
		}
	    }
	    my %responses;
	    foreach (sort $query->param) {
		if ($_ =~ /response-(\d*)/) {
		    $responses{$1}=$query->param($_);
		}
	    }
	    if (my $qnumber=$query->param('questionnumber')) {
		$responses{$qnumber}=$query->param('answer');
	    }
	    unless ($invalidduedate) {
	        my @time=localtime(time);
		my $date= (1900+$time[5])."-".($time[4]+1)."-".$time[3];
		my ($iteminformation, $duedate, $rejected, $question, $questionnumber, $defaultanswer, $message) = issuebook(\%env, $borrower, $barcode, \%responses,$date);
		unless ($iteminformation) {
		    print << "EOF";
		    <table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
		    <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Error</font></th></tr>
		    <tr><td>
		    <table border=0 cellpadding=5>
		    <tr><td>
		    $barcode is not a valid barcode.
		    </td></tr>
		    </table>
EOF
		}
		if ($rejected) {
		    if ($rejected == -1) {
		    } else {
			print << "EOF"
			<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
			<tr><th><font color=black size=6>Error Issuing Book</font></th></tr>
			<tr><td><font color=red size=6>$rejected</font></td></tr>
			</table>
			<br>
EOF
		    }
		}
		my $responsesform='';
		foreach (keys %responses) {
		    $responsesform.="<input type=hidden name=response-$_ value=$responses{$_}>\n";
		}
		if ($question) {
		    my $stickyduedate=$query->param('stickyduedate');
		    print << "EOF";
		    <table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
		    <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black><b>Issuing Question</b></font></td></tr>
		    <tr><td>
		    <table border=0 cellpadding=10>
		    <tr><td>
		    Attempting to issue $iteminformation->{'title'} by $iteminformation->{'author'} to $borrower->{'firstname'} $borrower->{'surname'}.
		    <p>
		    $question
		    </td></tr>
		    </table>
		    </td></tr>

		    <tr><td align=center>
		    <table border=0>
		    <tr><td>
		    <form method=get>
		    <input type=hidden name=module value=issues>
		    <input type=hidden name=borrnumber value=$borrnumber>
		    <input type=hidden name=barcode value=$barcode>
		    <input type=hidden name=questionnumber value=$questionnumber>
		    <input type=hidden name=day value=$day>
		    <input type=hidden name=month value=$month>
		    <input type=hidden name=year value=$year>
		    <input type=hidden name=stickyduedate value=$stickyduedate>
		    <input type=hidden name=branch value=$branch>
		    <input type=hidden name=printer value=$printer>
		    $responsesform
		    <input type=hidden name=answer value=Y>
		    <input type=submit value=Yes>
		    </form>
		    </td>
		    <td>
		    <form method=get>
		    <input type=hidden name=module value=issues>
		    <input type=hidden name=borrnumber value=$borrnumber>
		    <input type=hidden name=barcode value=$barcode>
		    <input type=hidden name=questionnumber value=$questionnumber>
		    <input type=hidden name=day value=$day>
		    <input type=hidden name=month value=$month>
		    <input type=hidden name=year value=$year>
		    <input type=hidden name=stickyduedate value=$stickyduedate>
		    <input type=hidden name=branch value=$branch>
		    <input type=hidden name=printer value=$printer>
		    $responsesform
		    <input type=hidden name=answer value=N>
		    <input type=submit value=No>
		    </form>
		    </td>
		    </tr>
		    </table>
		    </td></tr>
		    </table>
		    </td></tr>
		    </table>
EOF
		    return;
		}
		if ($message) {
		    print << "EOF";
		    <table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
		    <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Message</font></th></tr>
		    <tr><td>$message</td></tr>
		    </table>
		    <p>
EOF
		}
	    }
	}
	my $issueid=$query->param('issueid');
	($issueid) || ($issueid=int(rand()*1000000000));
	my $flag='';
	my $flagtext='';
	my $flaginfotext='';
	foreach $flag (sort keys %$flags) {
	    if ($flags->{$flag}->{'noissues'}) {
		$flagtext.="<font color=red>$flag</font> ";
	    } else {
		$flagtext.="$flag ";
	    }
	    $flags->{$flag}->{'message'}=~s/\n/<br>/g;
	    if ($flags->{$flag}->{'noissues'}) {
		$flaginfotext.="<tr><td bgcolor=red valign=top><font color=black><b>$flag</b></font></td><td bgcolor=red><font color=black><b>$flags->{$flag}->{'message'}</b></font></td></tr>\n";
	    } else {
		$flaginfotext.="<tr><td valign=top>$flag</td><td>$flags->{$flag}->{'message'}</td></tr>\n";
	    }
	}
	if ($flaginfotext) {
	    $flaginfotext="<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd><tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage colspan=2><font color=black>Patron Flags</font></th></tr>$flaginfotext</table>\n";
	}
	$env{'nottodaysissues'}=1;
	my ($borrowerissues) = currentissues(\%env, $borrower);
	$env{'nottodaysissues'}=0;
	$env{'todaysissues'}=1;
	my ($today) = currentissues(\%env, $borrower);
	$env{'todaysissues'}=0;
	my $previssues='';
	my @datearr = localtime(time());
	my $todaysdate = (1900+$datearr[5]).sprintf ("%0.2d", ($datearr[4]+1)).sprintf ("%0.2d", $datearr[3]);
	my $color='';
	foreach (sort keys %$borrowerissues) {
	    ($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
	    my $bookissue=$borrowerissues->{$_};
	    my $bgcolor='';
	    my $datedue=$bookissue->{'date_due'};
	    my $dd=$bookissue->{'date_due'};
	    #convert to nz style dates
	    #this should be set with some kinda config variable
	    
	    my @tempdate=split(/-/,$dd);
	    $dd="$tempdate[2]/$tempdate[1]/$tempdate[0]";
	    
	    #####
	    $datedue=~s/-//g;
	    if ($datedue < $todaysdate) {
		$dd="<font color=red>$dd</font>\n";
	    }
            $previssues.="<tr><td bgcolor=$color align=center>$dd</td><td bgcolor=$color align=center><a href=/cgi-bin/koha/detail.pl?bib=$bookissue->{'biblionumber'}&type=intra onClick=\"openWindow(this, 'Item', 480, 640)\">$bookissue->{'barcode'}</a></td><td bgcolor=$color>$bookissue->{'title'}</td><td bgcolor=$color>$bookissue->{'author'}</td><td bgcolor=$color align=center>$bookissue->{'dewey'} $bookissue->{'subclass'}</td></tr>\n";
	}
	my $todaysissues='';
	$color='';
	foreach (sort keys %$today) {
	    ($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
	    my $bookissue=$today->{$_};
	    $todaysissues.="<tr><td bgcolor=$color align=center>$bookissue->{'date_due'}</td><td bgcolor=$color align=center><a href=/cgi-bin/koha/detail.pl?bib=$bookissue->{'biblionumber'}&type=intra onClick=\"openWindow(this, 'Item', 480, 640)\">$bookissue->{'barcode'}</a></td><td bgcolor=$color>$bookissue->{'title'}</td><td bgcolor=$color>$bookissue->{'author'}</td><td bgcolor=$color align=center>$bookissue->{'dewey'} $bookissue->{'subclass'}</td></tr>\n";
	}
	for ($i=1; $i<32; $i++) {
	    my $selected='';
	    if (($query->param('stickyduedate')) && ($day==$i)) {
		$selected='selected';
	    }
	    $dayoptions.="<option value=$i $selected>$i";
	}
	my $counter=1;
	foreach (('Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec')) {
	    my $selected='';
	    if (($query->param('stickyduedate')) && ($month==$counter)) {
		$selected='selected';
	    }
	    $monthoptions.="<option value=$counter $selected>$_";
	    $counter++;
	}
	for ($i=$datearr[5]+1900; $i<$datearr[5]+1905; $i++) {
	    my $selected='';
	    if (($query->param('stickyduedate')) && ($year==$i)) {
		$selected='selected';
	    }
	    $yearoptions.="<option value=$i $selected>$i";
	}

	my $selected='';
	($query->param('stickyduedate')) && ($selected='checked');
	my ($borrower, $flags) = getpatroninformation(\%env,$borrnumber,0);
	my ($patrontable, $flaginfotable) = patrontable($borrower);
	print << "EOF";
	$patrontable
	$flaginfotable
	&nbsp; &nbsp;<br> <a href=cirulationold.pl?selectnewbranchprinter=1><b>Branch:</b></a> $branch,
	 <a href=cirulationold.pl?selectnewbranchprinter=1><b>Printer:</b></a> $printer<P>
	 <p>
	<form method=get>
    <table border=1 cellpadding=5>
    <tr>
	<td align=center valign=top>
	    <table border=0 cellspacing=0 cellpadding=5>
	        <tr><th align=center background=$backgroundimage><font color=black><b>Enter Book Barcode</b></font></th></tr>
		<tr><td align=center>
		<table border=0>
		<tr><td>Item Barcode:</td><td><input name=barcode size=10></td><td><input type=submit value=Issue></tr>
		<tr><td colspan=3 align=center>
		<table border=0 cellpadding=0 cellspacing=0>
		<tr><td>
		<select name=day><option value=0>Day$dayoptions</select>
		</td><td>
		<select name=month><option value=0>Month$monthoptions</select>
		</td><td>
		<select name=year><option value=0>Year$yearoptions</select>
		</td></tr>
		</table>
		<input type=checkbox name=stickyduedate $selected> Sticky Due Date
		</td></tr>
	      </table>
       	<input type=hidden name=module value=issues>
	<input type=hidden name=borrnumber value=$borrnumber>
	<input type=hidden name=branch value=$branch>
	<input type=hidden name=printer value=$printer>
	
EOF
;

  if ($flags->{'CHARGES'}){
            print "<input type=hidden name=charges value=yes>";
  }
    my $amountold=$flags->{'CHARGES'}->{'message'};
  my @temp=split(/\$/,$amountold);
  $amountold=$temp[1];
  print "<input type=hidden name=oldamount value=$amountold>";
print <<EOF
</form>
	</td>


    </tr>
    </table>
    </table>
    
    <p clear=all>
<!-- issues tables-->
	<table border=1 cellpadding=5 cellspacing=0 width=90%>
	<td colspan=2 align=center>
	<table border=0 cellpadding=5 cellspacing=0 width=100% > 
	    <tr><th colspan=5 bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black><b>Issues Today</b></font></th></tr>
	    <tr><th>Due Date</th><th>Bar Code</th><th>Title</th><th>Author</th><th>Class</th></tr>
	    $todaysissues
	</table>
	</td>
    </tr>

    <tr>
	<td colspan=2 align=center>
	<table border=0 cellpadding=5 cellspacing=0 width=100%>
	    <tr><th colspan=5 bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black><b>Previous Issues</b></font></th></tr>
	    <tr><th>Due Date</th><th>Bar Code</th><th>Title</th><th>Author</th><th>Class</th></tr>
	    $previssues
	</table>
	</td>
    </tr>
</table>
</td></tr></table>
<p>
EOF
    } else {
	if (my $findborrower=$query->param('findborrower')) {
	    my ($borrowers, $flags) = findborrower(\%env, $findborrower);
	    my @borrowers=@$borrowers;
	    if ($#borrowers == -1) {
		$query->param('findborrower', '');
		print "No borrower matched '$findborrower'<p>\n";
		issues(1);
		return;
	    }
	    if ($#borrowers == 0) {
		$query->param('borrnumber', $borrowers[0]->{'borrowernumber'});
		$query->param('barcode',' ');
		issues(1);
		return;
	    } else {
		print "<form method=get>\n";
		print "<input type=hidden name=module value=issues>\n";
		print "<input type=hidden name=branch value=$branch>\n";
		print "<input type=hidden name=printer value=$printer>\n";
		print "<input type=hidden name=barcode value=\" \">\n";
		print "<table border=0 cellspacing=0 cellpadding=5 bgcolor=#dddddd>";
		print "<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black><b>Select a borrower</b></font></th></tr>\n";
		print "<tr><td align=center>\n";
		print "<select name=borrnumber size=7>\n";
		foreach (sort {$a->{'surname'}.$a->{'firstname'} cmp $b->{'surname'}.$b->{'firstname'}} @$borrowers) {
		    print "<option value=$_->{'borrowernumber'}>$_->{'surname'}, $_->{'firstname'} ($_->{'cardnumber'})\n";
		}
		print "</select><br>";
		print "<input type=submit>\n";
		print "</td></tr></table>\n";
		print "</td></tr></table>\n";
	    }
	} else {
	    print << "EOF";
<form method=get>
<table border=0 cellpadding=5 cellspacing=0 bgcolor=#dddddd>
<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black><b>Enter borrower card number<br> or partial last name</b></font></td></tr>
<tr><td><input name=findborrower></td></tr>
</table>
<input type=hidden name=module value=issues>
<input type=hidden name=branch value=$branch>
<input type=hidden name=printer value=$printer>
<input type=hidden name=barcode value=" ">
</form>
</td></tr></table>
EOF
	}
    }
}


sub patrontable {
    my ($borrower) = @_;
    my $flags=$borrower->{'flags'};
    my $flagtext='';
    my $flaginfotable='';
    my $flaginfotext='';
    my $flag;
    foreach $flag (sort keys %$flags) {
	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
	if ($flags->{$flag}->{'noissues'}) {
	    $flagtext.="<font color=red>$flag</font> ";
	} else {
	    $flagtext.="$flag ";
	}
	$flags->{$flag}->{'message'}=~s/\n/<br>/g;
	if ($flags->{$flag}->{'noissues'}) {
	    if ($flag eq 'CHARGES') {
		$flaginfotext.="<tr><td valign=top><font color=red>$flag</font></td><td bgcolor=$color><b>$flags->{$flag}->{'message'}</b> <a href=/cgi-bin/koha/pay.pl?bornum=$borrower->{'borrowernumber'} onClick=\"openWindow(this, 'Payment', 480,640)\">Payment</a></td></tr>\n";
	    } else {
		$flaginfotext.="<tr><td valign=top><font color=red>$flag</font></td><td bgcolor=$color>$flags->{$flag}->{'message'}</td></tr>\n";
	    }
	} else {
	    if ($flag eq 'CHARGES') {
		$flaginfotext.="<tr><td valign=top>$flag</td><td> $flags->{$flag}->{'message'} <a href=/cgi-bin/koha/pay.pl?bornum=$borrower->{'borrowernumber'} onClick=\"openWindow(this, 'Payment', 480,640)\">Payment</a></td></tr>\n";
	    } elsif ($flag eq 'WAITING') {
		my $itemswaiting='';
		my $items=$flags->{$flag}->{'itemlist'};
		foreach $item (@$items) {
		    my ($iteminformation) = getiteminformation($env, $item->{'itemnumber'}, 0);
		    $itemswaiting.="<a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}&type=intra onClick=\"openWindow(this, 'Item', 480, 640)\">$iteminformation->{'barcode'}</a> $iteminformation->{'title'} ($branches->{$iteminformation->{'holdingbranch'}}->{'branchname'})<br>\n";
		}
		$flaginfotext.="<tr><td valign=top>$flag</td><td>$itemswaiting</td></tr>\n";
	    } elsif ($flag eq 'ODUES') {
		my $items=$flags->{$flag}->{'itemlist'};
		my $itemswaiting="<table border=0 cellspacing=0 cellpadding=2>\n";
		my $currentcolor=$color;
		{
		    my $color=$currentcolor;
		    foreach $item (@$items) {
			($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
			my ($iteminformation) = getiteminformation($env, $item->{'itemnumber'}, 0);
			$itemswaiting.="<tr><td><font color=red>$iteminformation->{'date_due'}</font></td><td bgcolor=$color><a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}&type=intra onClick=\"openWindow(this, 'Item', 480, 640)\">$iteminformation->{'barcode'}</a></td><td>$iteminformation->{'title'}</td></tr>\n";
		    }		    
		}
		$itemswaiting.="</table>\n";
		if ($query->param('module') ne 'returns'){
  		  $flaginfotext.="<tr><td valign=top>$flag</td><td>$flags->{$flag}->{'message'}, See below</td></tr>\n";
		} else {
  		  $flaginfotext.="<tr><td valign=top>$flag</td><td>$flags->{$flag}->{'message'}</td></tr>\n"; 
		}
	    } else {
		$flaginfotext.="<tr><td valign=top>$flag</td><td>$flags->{$flag}->{'message'}</td></tr>\n";
	    }
	}
    }
    ($flaginfotext) && ($flaginfotext="<tr><td bgcolor=$headerbackgroundcolor background=$backgroundimage colspan=2><b>Flags</b></td></tr>$flaginfotext\n");
    $flaginfotext.="</table>";
    my $patrontable= << "EOF";
    <table border=1
    cellpadding=5 cellspacing=0 align=right>
    <tr><td bgcolor=$headerbackgroundcolor background=$backgroundimage colspan=2><font color=black><b>Patron Information</b></font></td></tr>
    <tr><td colspan=2>
    <a href=/cgi-bin/koha/moremember.pl?bornum=$borrower->{'borrowernumber'} onClick="openWindow(this,'Member', 480, 640)">$borrower->{'cardnumber'}</a> $borrower->{'surname'}, $borrower->{'title'} $borrower->{'firstname'}<br>
EOF
    if ($query->param('module') ne 'returns'){ 
       $patrontable.="$borrower->{'streetaddress'} $borrower->{'city'} Cat:
       $borrower->{'categorycode'} ";
     }
    $patrontable.=<< "EOF";
    
    </td></tr>

EOF
    return($patrontable, $flaginfotext);
}

--- NEW FILE ---
#!/usr/bin/perl

#written 11/3/2002 by Finlay
#script to execute returns of books

use strict;
use CGI;
use C4::Circulation::Circ2;
use C4::Search;
use C4::Output;


my %env;
my $headerbackgroundcolor='#99cc33';
my $circbackgroundcolor='#ffffcc';
my $circbackgroundcolor='white';
my $linecolor1='#ffffcc';
my $linecolor2='white';
my $backgroundimage="/images/background-mem.gif";

my $query=new CGI;
my $branches = getbranches();

my $branch = $query->param("branch");
my $printer = $query->param("printer");

($branch) || ($branch=$query->cookie('branch')) ;
($printer) || ($printer=$query->cookie('printer')) ;

#
# Some code to handle the error if there is no branch or printer setting.....
#

$env{'branchcode'}=$branch;
$env{'printer'}=$printer;
$env{'queue'}=$printer;

# Set up the item stack ....
my $ritext = '';
my %returneditems;
my %riduedate;
my %riborrowernumber;
foreach ($query->param) {
    (next) unless (/ri-(\d*)/);
    my $counter=$1;
    (next) if ($counter>20);
    my $barcode=$query->param("ri-$counter");
    my $duedate=$query->param("dd-$counter");
    my $borrowernumber=$query->param("bn-$counter");
    $counter++;
    # decode cuecat
    $barcode = cuecatbarcodedecode($barcode);
    $returneditems{$counter}=$barcode;
    $riduedate{$counter}=$duedate;
    $riborrowernumber{$counter}=$borrowernumber;
    $ritext.="<input type=hidden name=ri-$counter value=$barcode>\n";
    $ritext.="<input type=hidden name=dd-$counter value=$duedate>\n";
    $ritext.="<input type=hidden name=bn-$counter value=$borrowernumber>\n";
}

my $iteminformation;
my $borrower;
my $returned = 0;
my $messages;
# actually return book (SQL CALL) and prepare item table.....
if (my $barcode = $query->param('barcode')) {
    # decode cuecat
    $barcode = cuecatbarcodedecode($barcode);
    ($returned, $messages, $iteminformation, $borrower) = returnbook2(\%env, $barcode);
    if ($returned) {
	$returneditems{0} = $barcode;
	$riborrowernumber{0} = $borrower->{'borrowernumber'};
	$riduedate{0} = $iteminformation->{'date_due'};
	$ritext.= "<input type=hidden name=ri-0 value=$barcode>\n";
	$ritext.= "<input type=hidden name=dd-0 value=$iteminformation->{'date_due'}>\n";
	$ritext.= "<input type=hidden name=bn-0 value=$borrower->{'borrowernumber'}>\n";
    }
}

##################################################################################
# HTML code....
# title....
my $title = <<"EOF";
<p align=right>
<FONT SIZE=2  face="arial, helvetica">
<a href=circulationold.pl?module=issues&branch=$branch&printer=$printer&print>Next Borrower</a> ||
<a href=returns.pl>Returns</a> ||
<a href=branchtransfers.pl>Transfers</a></font></p>
<FONT SIZE=6><em>Circulation: Returns</em></FONT>

EOF

my $itemtable;
if ($iteminformation) {
    $itemtable = <<"EOF";
<table border=1 cellpadding=5 cellspacing=0>
<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage>
<font color=black>Returned Item Information</font></th></tr>
<tr><td>
Title: $iteminformation->{'title'}<br>
<!--Hlt decided they dont want these showing, uncoment the html to make it work

Author: $iteminformation->{'author'}<br>
Barcode: <a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}
&type=intra onClick="openWindow(this, 'Item', 480, 640)">$iteminformation->{'barcode'}</a><br>
Date Due: $iteminformation->{'date_due'}-->
</td></tr>
</table>
<p>
EOF
}

# Barcode entry box, with hidden inputs attached....
my $barcodeentrytext= << "EOF";
<form method=post action=/cgi-bin/koha/circ/returns.pl>
<table border=1 cellpadding=5 cellspacing=0 align=left>
<tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage>
<font color=black><b>Enter Book Barcode</b></font></td></tr>
<tr><td>Item Barcode:</td><td><input name=barcode size=10></td></tr>
</table>
<input type=hidden name=branch value=$branch>
<input type=hidden name=printer value=$printer>
$ritext
</form>
EOF

# collect the messages and put into message table....
my $messagetable;
if ($messages) {
    my $messagetext='';
    foreach (@$messages) {
	$messagetext .= "$_<br>";
    }
    $messagetext = substr($messagetext, 0, -4);
    if ($messagetext) {
	$messagetable = << "EOF";
<table border=1 cellpadding=5 cellspacing=0>
<tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Messages</font></th></tr>
<tr><td>
$messagetext
</td></tr>
</table>
<p>
EOF
    }
}

# patrontable ....
my $borrowertable;
if ($borrower) {
    my $patrontable = << "EOF";
<table border=1 cellpadding=5 cellspacing=0 align=right>
<tr><td colspan=2 bgcolor=$headerbackgroundcolor background=$backgroundimage>
<font color=black><b>Patron Information</b></font></td></tr>
<tr><td colspan=2>
<a href=/cgi-bin/koha/moremember.pl?bornum=$borrower->{'borrowernumber'} 
onClick="openWindow(this,'Member', 480, 640)">$borrower->{'cardnumber'}</a>
$borrower->{'surname'}, $borrower->{'title'} $borrower->{'firstname'}<br>
</td></tr></table>
EOF
    my $flags = $borrower->{'flags'};
    my $flaginfotext='';
    my $flag;
    my $color = '';
    foreach $flag (sort keys %$flags) {
	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
	$flags->{$flag}->{'message'}=~s/\n/<br>/g;
	if ($flags->{$flag}->{'noissues'}) {
	    if ($flag eq 'CHARGES') {
		$flaginfotext.= <<"EOF";
<tr><td valign=top><font color=red>$flag</font></td>
<td bgcolor=$color><b>$flags->{$flag}->{'message'}</b> 
<a href=/cgi-bin/koha/pay.pl?bornum=$borrower->{'borrowernumber'} 
onClick=\"openWindow(this, 'Payment', 480,640)\">Payment</a></td></tr>
EOF
	    } else {
		$flaginfotext.= <<"EOF";
<tr><td valign=top><font color=red>$flag</font></td>
<td bgcolor=$color>$flags->{$flag}->{'message'}</td></tr>
EOF
	    }
	} else {
	    if ($flag eq 'CHARGES') {
		$flaginfotext .= << "EOF";
<tr><td valign=top>$flag</td>
<td> $flags->{$flag}->{'message'} <a href=/cgi-bin/koha/pay.pl?bornum=$borrower->{'borrowernumber'} 
onClick=\"openWindow(this, 'Payment', 480,640)\">Payment</a></td></tr>
EOF
	    } elsif ($flag eq 'WAITING') {
		my $itemswaiting='';
		my $items = $flags->{$flag}->{'itemlist'};
		foreach my $item (@$items) {
		    my ($iteminformation) = getiteminformation(\%env, $item->{'itemnumber'}, 0);
		    $itemswaiting .= <<"EOF";
<a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}&type=intra 
onClick=\"openWindow(this, 'Item', 480, 640)\">$iteminformation->{'barcode'}</a> 
$iteminformation->{'title'} ($branches->{$iteminformation->{'holdingbranch'}}->{'branchname'})<br>
EOF
		}
		$flaginfotext.="<tr><td valign=top>$flag</td><td>$itemswaiting</td></tr>\n";
	    } elsif ($flag eq 'ODUES') {
		my $items = $flags->{$flag}->{'itemlist'};
		$flaginfotext .=  <<"EOF";
<tr><td bgcolor=$color><font color=red>$flag</font></td>
<td bgcolor=$color>Patron has Overdue books</td></tr>
EOF
	    } else {
		$flaginfotext .= "<tr><td valign=top>$flag</td><td>$flags->{$flag}->{'message'}</td></tr>\n";
	    }
	}
    }
    if ($flaginfotext) {
	$flaginfotext = << "EOF";
<table border=1 cellpadding=5 cellspacing=0> <tr><td bgcolor=$headerbackgroundcolor background=$backgroundimage colspan=2><b>Flags</b></td></tr>
$flaginfotext 
</table>
EOF
    }
    $borrowertable = << "EOF";
<table border=0 cellpadding=5>
<tr>
<td valign=top>$patrontable</td>
<td valign=top>$flaginfotext</td>
</tr>
</table>
EOF
}

# the returned items.....
my $returneditemstable = << "EOF";
<br><p>
<table border=1 cellpadding=5 cellspacing=0 align=left>
<tr><th colspan=6 bgcolor=$headerbackgroundcolor background=$backgroundimage>
<font color=black>Returned Items</font></th></tr>
<tr><th>Due Date</th><th>Bar Code</th><th>Title</th><th>Author</th><th>Type</th><th>Borrower</th></tr>
EOF

my $color='';
#set up so only the lat 8 returned items display (make for faster loading pages)
my $count=0;
foreach (sort {$a <=> $b} keys %returneditems) {
    if ($count < 8) {
	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
	my $barcode = $returneditems{$_};
	my $duedate = $riduedate{$_};
	my @datearr = localtime(time());
	###
	# convert to nz date format
	my @tempdate = split(/-/,$duedate);
	$duedate = "$tempdate[2]/$tempdate[1]/$tempdate[0]";
	####
	my $todaysdate 
	    = (1900+$datearr[5]).'-'.sprintf ("%0.2d", ($datearr[4]+1)).'-'.sprintf ("%0.2d", $datearr[3]);
	my $overduetext = "$duedate";
	($overduetext="<font color=red>$duedate</font>") if ($duedate lt $todaysdate);
	($duedate) || ($overduetext = "<img src=/images/blackdot.gif>");
	my $borrowernumber = $riborrowernumber{$_};
	my ($borrower) = getpatroninformation(\%env,$borrowernumber,0);
	my ($iteminformation) = getiteminformation(\%env, 0, $barcode);;
	$returneditemstable .= << "EOF";
<tr><td bgcolor=$color>$overduetext</td>
<td bgcolor=$color align=center>
<a href=/cgi-bin/koha/detail.pl?bib=$iteminformation->{'biblionumber'}&type=intra onClick=\"openWindow(this, 'Item', 480, 640)\">$barcode</a></td>
<td bgcolor=$color>$iteminformation->{'title'}</td>
<td bgcolor=$color>$iteminformation->{'author'}</td>
<td bgcolor=$color align=center>$iteminformation->{'itemtype'}</td>
<td bgcolor=$color>
<a href=/cgi-bin/koha/moremember.pl?bornum=$borrower->{'borrowernumber'} onClick=\"openWindow(this,'Member', 480, 640)\">$borrower->{'cardnumber'}</a> $borrower->{'firstname'} $borrower->{'surname'}</td></tr>
EOF
    } else {
	last;
    }
    $count++;
}
$returneditemstable .= "</table>\n";


# actually print the page!


print $query->header();
print startpage();
print startmenu('circulation');

print $title;

# my $flags = $borrower->{'flags'};
# foreach my $key (keys %$flags) {
#     print "$key : $flags->{$key} <br> ";
# }

print $barcodeentrytext;

print $messagetable;

if ($returned) {
    print $itemtable;
    print $borrowertable;
}
(print $returneditemstable) if (%returneditems); 

print endmenu('circulation');
print endpage();

sub cuecatbarcodedecode {
    my ($barcode) = @_;
    chomp($barcode);
    my @fields = split(/\./,$barcode);
    my @results = map(decode($_), @fields[1..$#fields]);
    if ($#results == 2){
  	return $results[2];
    } else {
	return $barcode;
    } 
} 


Index: branchtransfers.pl
===================================================================
RCS file: /cvsroot/koha/koha/circ/branchtransfers.pl,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -r1.3 -r1.4
*** branchtransfers.pl	14 Mar 2002 01:51:16 -0000	1.3
--- branchtransfers.pl	2 May 2002 00:06:28 -0000	1.4
***************
*** 7,13 ****
  use CGI;
  use C4::Circulation::Circ2;
- use C4::Search;
  use C4::Output;
  
  
  my %env;
--- 7,14 ----
  use CGI;
  use C4::Circulation::Circ2;
  use C4::Output;
  
+ ###############################################
+ # constants
  
  my %env;
***************
*** 19,42 ****
  my $backgroundimage="/images/background-mem.gif";
  
  my $query=new CGI;
- my $branches=getbranches(\%env);
  
  my $tobranchcd=$query->param('tobranchcd');
  my $frbranchcd='';
  
- $env{'tobranchcd'}=$tobranchcd;
- 
  
  my $tobranchoptions;
! foreach (keys %$branches) {
!         (next) unless ($_);
!         (next) if (/^TR$/);
!         my $selected='';
!         ($selected='selected') if ($_ eq $tobranchcd);
!         $tobranchoptions.="<option value=$_ $selected>$branches->{$_}->{'branchname'}\n";
  }
  
  # collect the stack of books already transfered so they can printed...
- my @messages;
  my %transfereditems;
  my $ritext = '';
--- 20,44 ----
  my $backgroundimage="/images/background-mem.gif";
  
+ my $branches=getbranches();
+ 
+ ###############################################
+ #  Getting state
+ 
  my $query=new CGI;
  
  my $tobranchcd=$query->param('tobranchcd');
  my $frbranchcd='';
  
  
+ # set up the branchselect options....
  my $tobranchoptions;
! foreach my $br (keys %$branches) {
!     (next) if $branches->{$br}->{'PE'};
!     my $selected='';
!     ($selected='selected') if ($br eq $tobranchcd);
!     $tobranchoptions.="<option value=$br $selected>$branches->{$br}->{'branchname'}\n";
  }
  
  # collect the stack of books already transfered so they can printed...
  my %transfereditems;
  my $ritext = '';
***************
*** 58,94 ****
      }
  
  #if the barcode has been entered action that and write a message and onto the top of the stack...
  my $iteminformation;
- 
- my $todaysdate;
  if (my $barcode=$query->param('barcode')) {
!     my $iteminformation = getiteminformation(\%env,0, $barcode);
!     my $fail=0;
!     if (not $iteminformation) {
! 	$fail=1;
! 	@messages = ("There is no book with barcode: $barcode ", @messages);
      }
!     $frbranchcd = $iteminformation->{'holdingbranch'};
!     %env->{'frbranchcd'} = $frbranchcd;
!     if ($frbranchcd eq $tobranchcd) {
! 	$fail=1;
! 	@messages = ("You can't transfer the book to the branch it is already at!", @messages);
!     }
! # should add some more tests ... like is the book already out, maybe it cant be moved....
!     if (not $fail) {
! 	my ($transfered, $message) = transferbook(\%env, $iteminformation, $barcode);
! 	if (not $transfered) {@messages = ($message, @messages);}
! 	else {
! 	    $ritext.="<input type=hidden name=bc-0 value=$barcode>\n";
! 	    $ritext.="<input type=hidden name=fb-0 value=$frbranchcd>\n";
! 	    $ritext.="<input type=hidden name=tb-0 value=$tobranchcd>\n";
! 	    $transfereditems{0}=$barcode;
! 	    $frbranchcds{0}=$frbranchcd;
! 	    $tobranchcds{0}=$tobranchcd;
! 	    @messages = ("Book: $barcode has been transfered", @messages);
! 	}
      }
  }
  
  my $entrytext= << "EOF";
  <form method=post action=/cgi-bin/koha/circ/branchtransfers.pl>
--- 60,89 ----
      }
  
+ # Warnings etc that get displayed at top of next page....
+ my @messages;
+ 
  #if the barcode has been entered action that and write a message and onto the top of the stack...
  my $iteminformation;
  if (my $barcode=$query->param('barcode')) {
!     my $iteminformation = getiteminformation(\%env,0 ,$barcode);
!     my ($transfered, $message, $iteminformation) = transferbook($tobranchcd, $barcode);
!     if (not $transfered) {
! 	push(@messages, $message);
      }
!     else {
! 	my $frbranchcd = $iteminformation->{'holdingbranch'};
! 	$ritext.="<input type=hidden name=bc-0 value=$barcode>\n";
! 	$ritext.="<input type=hidden name=fb-0 value=$frbranchcd>\n";
! 	$ritext.="<input type=hidden name=tb-0 value=$tobranchcd>\n";
! 	$transfereditems{0}=$barcode;
! 	$frbranchcds{0}=$frbranchcd;
! 	$tobranchcds{0}=$tobranchcd;
! 	push(@messages, "Book: $barcode has been transfered");
      }
  }
  
+ #################################################################################
+ # Html code....
+ 
  my $entrytext= << "EOF";
  <form method=post action=/cgi-bin/koha/circ/branchtransfers.pl>
***************
*** 115,137 ****
      my $messagetext='';
      foreach (@messages) {
! 	$messagetext.="$_<p>\n";
      }
      $messagetable = << "EOF";
! <table border=0 cellpadding=5 cellspacing=0 bgcolor='#dddddd'>
! <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font color=black>Messages</font></th></tr>
  <tr><td> $messagetext </td></tr></table>
  EOF
  }
  
! 
  
  print $query->header;
  print startpage;
  print startmenu('circulation');
! print "<FONT SIZE=6><em>Circulation: Transfers</em></FONT><br>";
! 
! 
! print $messagetable if (@messages);
  
  
  print $entrytext;
--- 110,138 ----
      my $messagetext='';
      foreach (@messages) {
! 	$messagetext.="$_<br>";
      }
+     $messagetext = substr($messagetext, 0, -4);
      $messagetable = << "EOF";
! <table border=1 cellpadding=5 cellspacing=0 bgcolor='#dddddd'>
! <tr><th bgcolor=$headerbackgroundcolor background=$backgroundimage><font>Messages</font></th></tr>
  <tr><td> $messagetext </td></tr></table>
  EOF
  }
  
! #######################################################################################
! # Make the page .....
  
  print $query->header;
  print startpage;
  print startmenu('circulation');
! print <<"EOF";
! <p align=right>
! <FONT SIZE=2  face="arial, helvetica">
! <a href=circulationold.pl?module=issues>Next Borrower</a> ||
! <a href=returns.pl>Returns</a> ||
! <a href=branchtransfers.pl>Transfers</a></font></p><FONT SIZE=6><em>Circulation: Transfers</em></FONT><br>
! EOF
  
+ print $messagetable;
  
  print $entrytext;

Index: circulation.pl
===================================================================
RCS file: /cvsroot/koha/koha/circ/circulation.pl,v
retrieving revision 1.23
retrieving revision 1.24
diff -C2 -r1.23 -r1.24
*** circulation.pl	14 Mar 2002 01:50:17 -0000	1.23
--- circulation.pl	2 May 2002 00:06:28 -0000	1.24
***************
*** 1,4 ****
--- 1,5 ----
  #!/usr/bin/perl
  
+ use strict;
  use CGI qw/:standard/;
  use C4::Circulation::Circ2;
***************
*** 8,12 ****
  
  
[...1030 lines suppressed...]
! <table border=1 cellpadding=5 cellspacing=0>
! <tr><td colspan=2 bgcolor=$headerbackgroundcolor align=center background=$backgroundimage>
! <font color=black><b>Please Set Branch and Printer</b></font></td></tr>
! <tr><td>
! $branchform
! </td>
! <td>
! $printerform
! </td></tr>
! </table>
! <input type="submit" value="Change Settings" type="changesettings">
! </form>
! 
  
  EOF
  }
+ 
+ print endmenu('circulation');
+ print endpage();
+ 




From finlayt at users.sourceforge.net  Wed May  1 17:24:11 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Wed May  1 17:24:11 2002
Subject: [Koha-devel] CVS: koha database.mysql,1.3,1.4
Message-ID: <E1734Nc-0004sV-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv18536

Modified Files:
	database.mysql 
Log Message:

added branchrelations table and changed branchcategories table to allow
admin/branches.pl to work properly.


Index: database.mysql
===================================================================
RCS file: /cvsroot/koha/koha/database.mysql,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -r1.3 -r1.4
*** database.mysql	29 Apr 2002 05:25:41 -0000	1.3
--- database.mysql	2 May 2002 00:23:26 -0000	1.4
***************
*** 305,310 ****
  CREATE TABLE branchcategories (
    categorycode char(2) DEFAULT '' NOT NULL,
!   branchcode char(4) DEFAULT '' NOT NULL,
!   branchholding int(11)
  );
  
--- 305,319 ----
  CREATE TABLE branchcategories (
    categorycode char(2) DEFAULT '' NOT NULL,
!   categoryname text,
!   codedescription text,
!   PRIMARY KEY (categorycode)
! );
! 
! #
! # Table structure for table 'branchrelations'
! #
! CREATE TABLE branchrelations (
!   branchcode varchar(4) DEFAULT '' NOT NULL,
!   categorycode varchar(4) DEFAULT '' NOT NULL
  );
  
***************
*** 330,336 ****
  CREATE TABLE branchtransfers (
    itemnumber int(11) DEFAULT '0' NOT NULL,
!   datesent date DEFAULT '0000-00-00' NOT NULL,
    frombranch varchar(4),
!   datearrived date,
    tobranch varchar(4),
    comments text
--- 339,345 ----
  CREATE TABLE branchtransfers (
    itemnumber int(11) DEFAULT '0' NOT NULL,
!   datesent datetime DEFAULT '0000-00-00' NOT NULL,
    frombranch varchar(4),
!   datearrived datetime,
    tobranch varchar(4),
    comments text




From tipaul at users.sourceforge.net  Thu May  2 02:20:29 2002
From: tipaul at users.sourceforge.net (Paul POULAIN)
Date: Thu May  2 02:20:29 2002
Subject: [Koha-devel] CVS: koha database.mysql,1.4,1.5
Message-ID: <E173Cki-000081-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv32641

Modified Files:
	database.mysql 
Log Message:
updated database.mysql : dropped unused tables, created indexes : old database.mysql updated by updatedatabase2.pl script


Index: database.mysql
===================================================================
RCS file: /cvsroot/koha/koha/database.mysql,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** database.mysql	2 May 2002 00:23:26 -0000	1.4
--- database.mysql	2 May 2002 09:19:49 -0000	1.5
***************
*** 1,60 ****
! # MySQL dump 7.1
! #
! # Host: localhost    Database: c4test
! #--------------------------------------------------------
! # Server version	3.22.32-log
  
  #
! # Table structure for table 'accountlines'
  #
  CREATE TABLE accountlines (
[...1500 lines suppressed...]
+ 
  CREATE TABLE systempreferences (
!   variable char(50) NOT NULL default '',
!   value char(200) default NULL,
!   PRIMARY KEY  (variable)
! ) TYPE=ISAM PACK_KEYS=1;
! # --------------------------------------------------------
  
  #
! # Table structure for table `users`
  #
+ 
  CREATE TABLE users (
!   usercode varchar(10) NOT NULL default '',
    username text,
    password text,
!   level smallint(6) default NULL,
!   PRIMARY KEY  (usercode)
! ) TYPE=ISAM PACK_KEYS=1;
  




From tipaul at users.sourceforge.net  Thu May  2 02:20:30 2002
From: tipaul at users.sourceforge.net (Paul POULAIN)
Date: Thu May  2 02:20:30 2002
Subject: [Koha-devel] CVS: koha/updater updatedatabase2.pl,1.1,1.2
Message-ID: <E173Cki-000088-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/updater
In directory usw-pr-cvs1:/tmp/cvs-serv32641/updater

Modified Files:
	updatedatabase2.pl 
Log Message:
updated database.mysql : dropped unused tables, created indexes : old database.mysql updated by updatedatabase2.pl script


Index: updatedatabase2.pl
===================================================================
RCS file: /cvsroot/koha/koha/updater/updatedatabase2.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** updatedatabase2.pl	19 Mar 2002 15:39:31 -0000	1.1
--- updatedatabase2.pl	2 May 2002 09:19:50 -0000	1.2
***************
*** 43,75 ****
  my $dbh=C4Connect;
  
- my %tables;
  my $sth=$dbh->prepare("show tables");
  $sth->execute;
  while (my ($table) = $sth->fetchrow) {
      $tables{$table}=1;
  }
  
! print "creating thesaurus...\n";
! dosql($dbh,"CREATE TABLE bibliothesaurus (code BIGINT not null AUTO_INCREMENT, freelib CHAR (255) not null , stdlib CHAR (255) not null , type CHAR (80) not null , PRIMARY KEY (code), INDEX (freelib),index(stdlib),index(type))");
! 	my $sti=$dbh->prepare("select subject from bibliosubject");
! 	$sti->execute;
! 	$i=0;
! 	while ($line =$sti->fetchrow_hashref) {
! 		$i++;
  #		print "$i $line->{'subject'}\n";
! 		$sti2=$dbh->prepare("select count(*) as t from bibliothesaurus where freelib=".$dbh->quote($line->{'subject'}));
! 		$sti2->execute;
! 		if ($sti2->err) {
! 			print "error : ".$sti2->errstr." \n tried to execute : $sql_cmd\n";
! 			die;
! 		}
! 		$line2=$sti2->fetchrow_hashref;
! 		if ($line2->{'t'} ==0) {
! 			dosql($dbh,"insert into bibliothesaurus (freelib,stdlib) values (".$dbh->quote($line->{'subject'}).",".$dbh->quote($line->{'subject'}).")");
! 		} else {
! 			print "pas ecriture pour : $line->{'subject'}\n";
! 		}
! 
! 	}
  
  #aqbookfund : the sample db is full of trash data. Delete and recreate
--- 43,75 ----
  my $dbh=C4Connect;
  
  my $sth=$dbh->prepare("show tables");
  $sth->execute;
  while (my ($table) = $sth->fetchrow) {
      $tables{$table}=1;
+     print "table $table\n";
  }
  
! #print "creating thesaurus...\n";
! #dosql($dbh,"CREATE TABLE bibliothesaurus (code BIGINT not null AUTO_INCREMENT, freelib CHAR (255) not null , stdlib CHAR (255) not null , type CHAR (80) not null , PRIMARY KEY (code), INDEX (freelib),index(stdlib),index(type))");
! #	my $sti=$dbh->prepare("select subject from bibliosubject");
! #	$sti->execute;
! #	$i=0;
! #	while ($line =$sti->fetchrow_hashref) {
! #		$i++;
  #		print "$i $line->{'subject'}\n";
! #		$sti2=$dbh->prepare("select count(*) as t from bibliothesaurus where freelib=".$dbh->quote($line->{'subject'}));
! #		$sti2->execute;
! #		if ($sti2->err) {
! #			print "error : ".$sti2->errstr." \n tried to execute : $sql_cmd\n";
! #			die;
! #		}
! #		$line2=$sti2->fetchrow_hashref;
! #		if ($line2->{'t'} ==0) {
! #			dosql($dbh,"insert into bibliothesaurus (freelib,stdlib) values (".$dbh->quote($line->{'subject'}).",".$dbh->quote($line->{'subject'}).")");
! #		} else {
! #			print "pas ecriture pour : $line->{'subject'}\n";
! #		}
! #
! #	}
  
  #aqbookfund : the sample db is full of trash data. Delete and recreate
***************
*** 124,130 ****
  	dosql($dbh,"ALTER TABLE aqorderdelivery DROP PRIMARY KEY, ADD PRIMARY KEY(ordernumber);");
  	dosql($dbh,"ALTER TABLE aqorders DROP PRIMARY KEY, ADD PRIMARY KEY(ordernumber);");
! 	dosql($dbh,"ALTER TABLE biblio DROP PRIMARY KEY, ADD PRIMARY KEY(biblionumber, biblionumber);");
  	dosql($dbh,"ALTER TABLE biblioitems DROP PRIMARY KEY, ADD PRIMARY KEY(biblionumber, biblioitemnumber)");
! 	dosql($dbh,"CREATE INDEX SUBTITLE ON bibliosubtitle (subtitle(80))");
  	dosql($dbh,"ALTER TABLE borexp CHANGE borrowernumber borrowernumber INT (11) not null");
  	dosql($dbh,"ALTER TABLE borexp CHANGE newexp newexp DATE not null");
--- 124,130 ----
  	dosql($dbh,"ALTER TABLE aqorderdelivery DROP PRIMARY KEY, ADD PRIMARY KEY(ordernumber);");
  	dosql($dbh,"ALTER TABLE aqorders DROP PRIMARY KEY, ADD PRIMARY KEY(ordernumber);");
! 	dosql($dbh,"ALTER TABLE biblio DROP PRIMARY KEY, ADD PRIMARY KEY(biblionumber);");
  	dosql($dbh,"ALTER TABLE biblioitems DROP PRIMARY KEY, ADD PRIMARY KEY(biblionumber, biblioitemnumber)");
! #	dosql($dbh,"CREATE INDEX SUBTITLE ON bibliosubtitle (subtitle(80))");
  	dosql($dbh,"ALTER TABLE borexp CHANGE borrowernumber borrowernumber INT (11) not null");
  	dosql($dbh,"ALTER TABLE borexp CHANGE newexp newexp DATE not null");




From truth_nz at users.sourceforge.net  Thu May  2 19:48:04 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Thu May  2 19:48:04 2002
Subject: [Koha-devel] CVS: koha/C4 Acquisitions.pm,1.6,1.7
Message-ID: <E173T6d-0006ao-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv25277/C4

Modified Files:
	Acquisitions.pm 
Log Message:
Bug fixes to get the new acqui.simple system working.


Index: Acquisitions.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Acquisitions.pm,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -r1.6 -r1.7
*** Acquisitions.pm	29 Apr 2002 05:25:41 -0000	1.6
--- Acquisitions.pm	3 May 2002 02:47:33 -0000	1.7
***************
*** 407,411 ****
  author        = $biblio->{'author'},
  copyrightdate = $biblio->{'copyright'},
! series        = $series;
  seriestitle   = $biblio->{'seriestitle'},
  notes         = $biblio->{'notes'},
--- 407,411 ----
  author        = $biblio->{'author'},
  copyrightdate = $biblio->{'copyright'},
! serial        = $series,
  seriestitle   = $biblio->{'seriestitle'},
  notes         = $biblio->{'notes'},
***************
*** 413,417 ****
  
    $sth = $dbh->prepare($query);
- #  print $query;
    $sth->execute;
  
--- 413,416 ----
***************
*** 913,923 ****
  booksellerid         = $item->{'booksellerid'},
  dateaccessioned      = NOW(),
! homebranch           = $item->{'branch'},
! holdingbranch        = $item->{'branch'},
  price                = $item->{'price'},
  replacementprice     = $item->{'replacementprice'},
  replacementpricedate = NOW(),
- notforloan           = $item->{'loan'},
  itemnotes            = $item->{'itemnotes'}";
  
      $sth = $dbh->prepare($query);
--- 912,926 ----
  booksellerid         = $item->{'booksellerid'},
  dateaccessioned      = NOW(),
! homebranch           = $item->{'homebranch'},
! holdingbranch        = $item->{'homebranch'},
  price                = $item->{'price'},
  replacementprice     = $item->{'replacementprice'},
  replacementpricedate = NOW(),
  itemnotes            = $item->{'itemnotes'}";
+ 
+     if ($item->{'loan'}) {
+       $query .= ",
+ notforloan           = $item->{'loan'}";
+     } # if
  
      $sth = $dbh->prepare($query);




From truth_nz at users.sourceforge.net  Thu May  2 19:48:25 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Thu May  2 19:48:25 2002
Subject: [Koha-devel] CVS: koha detail.pl,1.3,1.4
Message-ID: <E173T6d-0006aj-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv25277

Modified Files:
	detail.pl 
Log Message:
Bug fixes to get the new acqui.simple system working.


Index: detail.pl
===================================================================
RCS file: /cvsroot/koha/koha/detail.pl,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -r1.3 -r1.4
*** detail.pl	15 Mar 2001 10:17:33 -0000	1.3
--- detail.pl	3 May 2002 02:47:33 -0000	1.4
***************
*** 5,9 ****
  
  use strict;
- #use DBI;
  use C4::Search;
  use CGI;
--- 5,8 ----
***************
*** 11,53 ****
  
  my $input = new CGI;
! print $input->header;
! #whether it is called from the opac of the intranet
! my $type=$input->param('type');
! if ($type eq ''){
!   $type='intra';
! }
! #setup colours
  my $main;
  my $secondary;
  if ($type eq 'opac'){
!   $main='#99cccc';
!   $secondary='#efe5ef';
  } else {
!   $main='#cccc99';
!   $secondary='#ffffcc';
! }
  print startpage();
  print startmenu($type);
- #print $type;
- my $blah;
- my $bib=$input->param('bib');
- my $title=$input->param('title');
- if ($type ne 'opac'){
-   print "<a href=request.pl?bib=$bib><img height=42  WIDTH=120 BORDER=0 src=\"/images/requests.gif\" align=right border=0></a>";
- }
  
  
- my @items=ItemInfo(\$blah,$bib,$type);
- my $dat=bibdata($bib);
- my $count=@items;
- my ($count3,$addauthor)=addauthor($bib);
- my $additional=$addauthor->[0]->{'author'};                                                             
- for (my $i=1;$i<$count3;$i++){                                                                          
-   $additional=$additional."|".$addauthor->[$i]->{'author'};                                             
- }  
- my @temp=split('\t',$items[0]);
  if ($type eq 'catmain'){
    print mkheadr(3,"Catalogue Maintenance");
! }
  if ($dat->{'author'} ne ''){
    print mkheadr(3,"$dat->{'title'} ($dat->{'author'}) $temp[4]");
--- 10,56 ----
  
  my $input = new CGI;
! my $type  = $input->param('type');
! my $bib   = $input->param('bib');
! my $title = $input->param('title');
! my @items = &ItemInfo(undef, $bib, $type);
! my $dat   = &bibdata($bib);
! my $count = @items;
! my ($count3, $addauthor) = &addauthor($bib);
! my $additional = $addauthor->[0]->{'author'};
! my @temp       = split('\t', $items[0]);
  my $main;
  my $secondary;
+ 
+ if ($type eq ''){
+     $type = 'opac';
+ } # if
+ 
+ # setup colours
  if ($type eq 'opac'){
!     $main      = '#99cccc';
!     $secondary = '#efe5ef';
  } else {
!     $main      = '#cccc99';
!     $secondary = '#ffffcc';
! } # else
! 
! print $input->header;
  print startpage();
  print startmenu($type);
  
+ if ($type ne 'opac'){
+     print << "EOF";
+ <a href=request.pl?bib=$bib><img height=42  WIDTH=120 BORDER=0 src=\"/images/requests.gif\" align=right border=0></a>
+ EOF
+ } # if
+ 
+ for (my $i = 1; $i < $count3; $i++) {
+     $additional .= "|" . $addauthor->[$i]->{'author'};
+ } # for
  
  if ($type eq 'catmain'){
    print mkheadr(3,"Catalogue Maintenance");
! } # if
! 
  if ($dat->{'author'} ne ''){
    print mkheadr(3,"$dat->{'title'} ($dat->{'author'}) $temp[4]");
***************
*** 55,59 ****
    print mkheadr(3,"$dat->{'title'} $temp[4]");
  }
! print <<printend
  
  <TABLE  CELLSPACING=0  CELLPADDING=5 border=1 align=left width="220">
--- 58,62 ----
    print mkheadr(3,"$dat->{'title'} $temp[4]");
  }
! print << "EOF";
  
  <TABLE  CELLSPACING=0  CELLPADDING=5 border=1 align=left width="220">
***************
*** 67,83 ****
  
  <td  bgcolor="$main" 
! printend
! ;
  if ($type ne 'opac'){
   print "background=\"/images/background-mem.gif\"";
  }
! print <<printend
  ><B>BIBLIO RECORD 
! printend
! ;
  if ($type ne 'opac'){
    print "$bib";
  }
! print <<printend
  </TD></TR>
  
--- 70,86 ----
  
  <td  bgcolor="$main" 
! EOF
! 
  if ($type ne 'opac'){
   print "background=\"/images/background-mem.gif\"";
  }
! print << "EOF";
  ><B>BIBLIO RECORD 
! EOF
! 
  if ($type ne 'opac'){
    print "$bib";
  }
! print << "EOF";
  </TD></TR>
  
***************
*** 85,103 ****
  <tr VALIGN=TOP  >
  <TD>
! printend
! ;
  if ($type ne 'opac'){
    print "<INPUT TYPE=\"image\" name=\"submit\"  VALUE=\"modify\" height=42  WIDTH=93 BORDER=0 src=\"/images/modify-mem.gif\"> 
    <INPUT TYPE=\"image\" name=\"delete\"  VALUE=\"delete\" height=42  WIDTH=93 BORDER=0 src=\"/images/delete-mem.gif\">";
  }
! print <<printend
  <br>
  <FONT SIZE=2  face="arial, helvetica">
! printend
! ;
  
  
  if ($type ne 'opac'){
! print <<printend
  <b>Subtitle:</b> $dat->{'subtitle'}<br>
  <b>Author:</b> $dat->{'author'}<br>
--- 88,105 ----
  <tr VALIGN=TOP  >
  <TD>
! EOF
! 
  if ($type ne 'opac'){
    print "<INPUT TYPE=\"image\" name=\"submit\"  VALUE=\"modify\" height=42  WIDTH=93 BORDER=0 src=\"/images/modify-mem.gif\"> 
    <INPUT TYPE=\"image\" name=\"delete\"  VALUE=\"delete\" height=42  WIDTH=93 BORDER=0 src=\"/images/delete-mem.gif\">";
  }
! print << "EOF";
  <br>
  <FONT SIZE=2  face="arial, helvetica">
! EOF
  
  
  if ($type ne 'opac'){
! print << "EOF";
  <b>Subtitle:</b> $dat->{'subtitle'}<br>
  <b>Author:</b> $dat->{'author'}<br>
***************
*** 113,118 ****
  <b>Total Number of Items:</b> $count
  <p>
! printend
! ;
  }
  else {
--- 115,120 ----
  <b>Total Number of Items:</b> $count
  <p>
! EOF
! 
  }
  else {
***************
*** 149,153 ****
  
  }
! print <<printend
  </form>
  </font></TD>
--- 151,155 ----
  
  }
! print << "EOF";
  </form>
  </font></TD>
***************
*** 156,165 ****
  </TABLE>
  <img src="/images/holder.gif" width=16 height=300 align=left>
! 
! printend
! ;
! 
! 
! #print @items;
  
  my $i=0;
--- 158,162 ----
  </TABLE>
  <img src="/images/holder.gif" width=16 height=300 align=left>
! EOF
  
  my $i=0;
***************
*** 174,179 ****
  my $colour=1;
  while ($i < $count){
! #  print $items[$i],"<br>";
!   my @results=split('\t',$items[$i]);
    if ($type ne 'opac'){
      $results[1]=mklink("/cgi-bin/koha/moredetail.pl?item=$results[5]&bib=$bib&bi=$results[8]&type=$type",$results[1]);
--- 171,176 ----
  my $colour=1;
  while ($i < $count){
! 
!   my @results = split('\t', $items[$i]);
    if ($type ne 'opac'){
      $results[1]=mklink("/cgi-bin/koha/moredetail.pl?item=$results[5]&bib=$bib&bi=$results[8]&type=$type",$results[1]);
***************
*** 217,229 ****
  print mktablehdr();
  if ($type ne 'opac'){
! print <<printend
  <TR VALIGN=TOP>
  <TD  bgcolor="99cc33" background="/images/background-mem.gif" colspan=2><p><b>HELP</b><br>
  <b>Update Biblio for all Items:</b> Click on the <b>Modify</b> button [left] to amend the biblio.  Any changes you make will update the record for <b>all</b> the items listed above. <p>
  <b>Updating the Biblio for only ONE or SOME Items:</b> 
! printend
! ;
  if ($type eq 'catmain'){
! print <<printend
  If some of the items listed above need a different biblio, 
  you need to click on the wrong item, then shift the group it belongs to, to the correct biblio.
--- 214,226 ----
  print mktablehdr();
  if ($type ne 'opac'){
! print << "EOF";
  <TR VALIGN=TOP>
  <TD  bgcolor="99cc33" background="/images/background-mem.gif" colspan=2><p><b>HELP</b><br>
  <b>Update Biblio for all Items:</b> Click on the <b>Modify</b> button [left] to amend the biblio.  Any changes you make will update the record for <b>all</b> the items listed above. <p>
  <b>Updating the Biblio for only ONE or SOME Items:</b> 
! EOF
! 
  if ($type eq 'catmain'){
! print << "EOF";
  If some of the items listed above need a different biblio, 
  you need to click on the wrong item, then shift the group it belongs to, to the correct biblio.
***************
*** 232,245 ****
  
     </TR>
! printend
! ;
  } else {
! print <<printend
  If some of the items listed above need a different biblio, or are on the wrong biblio, you must use the <a href="acquisitions/">acquisitions</a> process to fix this. You will need to "re-order" the items, and delete them from this biblio.
  <p>
  
     </TR>
! printend
! ;
  }
  }
--- 229,242 ----
  
     </TR>
! EOF
! 
  } else {
! print << "EOF";
  If some of the items listed above need a different biblio, or are on the wrong biblio, you must use the <a href="acquisitions/">acquisitions</a> process to fix this. You will need to "re-order" the items, and delete them from this biblio.
  <p>
  
     </TR>
! EOF
! 
  }
  }




From truth_nz at users.sourceforge.net  Thu May  2 19:48:26 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Thu May  2 19:48:26 2002
Subject: [Koha-devel] CVS: koha/acqui.simple addbiblioitem.pl,1.1,1.2 additem.pl,1.1,1.2 savebiblio.pl,1.1,1.2 savebiblioitem.pl,1.1,1.2 saveitem.pl,1.1,1.2
Message-ID: <E173T6d-0006ay-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/acqui.simple
In directory usw-pr-cvs1:/tmp/cvs-serv25277/acqui.simple

Modified Files:
	addbiblioitem.pl additem.pl savebiblio.pl savebiblioitem.pl 
	saveitem.pl 
Log Message:
Bug fixes to get the new acqui.simple system working.


Index: addbiblioitem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/addbiblioitem.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** addbiblioitem.pl	29 Apr 2002 05:29:02 -0000	1.1
--- addbiblioitem.pl	3 May 2002 02:47:33 -0000	1.2
***************
*** 17,27 ****
      
      ($count, @results) = &getbiblio($biblionumber);
!     $title = @results[0]->{'title'};
  
!     print $input->header;
!     print startpage();
!     print startmenu('acquisitions');
  
!     print << "EOF";
  <font size="6"><em>Adding New Group Information - $title</em></font>
  <table bgcolor="#ffcc00" width="80%" cellpadding="5">
--- 17,31 ----
      
      ($count, @results) = &getbiblio($biblionumber);
!     
!     if (! $count) {
! 	print $input->redirect('addbooks.pl');
!     } else {
! 	$title = @results[0]->{'title'};
  
! 	print $input->header;
! 	print startpage();
! 	print startmenu('acquisitions');
  
! 	print << "EOF";
  <font size="6"><em>Adding New Group Information - $title</em></font>
  <table bgcolor="#ffcc00" width="80%" cellpadding="5">
***************
*** 64,75 ****
  EOF
  
!     ($count, @results) = &getitemtypes;
!     for (my $i = 0; $i < $count; $i++) {
! 	print << "EOF";
  <option value="$results[$i]->{'itemtype'}">$results[$i]->{'itemtype'} - $results[$i]->{'description'}
  EOF
!     } # for
  
!     print << "EOF";
  </select></td>
  </tr>
--- 68,79 ----
  EOF
  
! 	($count, @results) = &getitemtypes;
! 	for (my $i = 0; $i < $count; $i++) {
! 	    print << "EOF";
  <option value="$results[$i]->{'itemtype'}">$results[$i]->{'itemtype'} - $results[$i]->{'description'}
  EOF
! 	} # for
  
! 	print << "EOF";
  </select></td>
  </tr>
***************
*** 117,121 ****
  EOF
  
!     print endmenu();
!     print endpage();
  } # else
--- 121,126 ----
  EOF
  
! 	print endmenu();
! 	print endpage();
!     } # else
  } # else

Index: additem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/additem.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** additem.pl	29 Apr 2002 05:29:02 -0000	1.1
--- additem.pl	3 May 2002 02:47:33 -0000	1.2
***************
*** 16,20 ****
      print $input->redirect('addbooks.pl');
  } else {
!     
      ($count, @results) = &getbiblioitem($biblioitemnum);
      
--- 16,20 ----
      print $input->redirect('addbooks.pl');
  } else {
! 
      ($count, @results) = &getbiblioitem($biblioitemnum);
      
***************
*** 63,67 ****
  <center>
  <h2>Section Three: Specific Item Information</h2>
! <form action="saveitems" method="post">
  <input type="hidden" name="biblioitemnum" value="$biblioitemnum">
  <table>
--- 63,67 ----
  <center>
  <h2>Section Three: Specific Item Information</h2>
! <form action="saveitem.pl" method="post">
  <input type="hidden" name="biblioitemnum" value="$biblioitemnum">
  <table>

Index: savebiblio.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/savebiblio.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** savebiblio.pl	29 Apr 2002 05:29:02 -0000	1.1
--- savebiblio.pl	3 May 2002 02:47:33 -0000	1.2
***************
*** 6,16 ****
  
  my $input = new CGI;
! my $biblio->{'title'}       = $input->param('title');
! my $biblio->{'subtitle'}    = $input->param('subtitle');
! my $biblio->{'author'}      = $input->param('author');
! my $biblio->{'seriestitle'} = $input->param('seriestitle');
! my $biblio->{'copyright'}   = $input->param('copyrightdate');
! my $biblio->{'abstract'}    = $input->param('abstract');
! my $biblio->{'notes'}       = $input->param('notes');
  my $biblionumber;
  
--- 6,17 ----
  
  my $input = new CGI;
! my $biblio = { title       => $input->param('title'),
!                subtitle    => $input->param('subtitle'),
!                author      => $input->param('author'),
!                seriestitle => $input->param('seriestitle'),
!                copyright   => $input->param('copyrightdate'),
!                abstract    => $input->param('abstract'),
!                notes       => $input->param('notes')
!              }; # my $biblio
  my $biblionumber;
  
***************
*** 20,25 ****
  
      $biblionumber = &newbiblio($biblio);
!     &newsubtitle($biblionumber, $subtitle);
  
!     print $input->redirect('addbiblioitem.pl?biblionumber=$biblionumber');
  } # else
--- 21,26 ----
  
      $biblionumber = &newbiblio($biblio);
!     &newsubtitle($biblionumber, $biblio->{'subtitle'});
  
!     print $input->redirect("addbiblioitem.pl?biblionumber=$biblionumber");
  } # else

Index: savebiblioitem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/savebiblioitem.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** savebiblioitem.pl	29 Apr 2002 05:29:02 -0000	1.1
--- savebiblioitem.pl	3 May 2002 02:47:33 -0000	1.2
***************
*** 37,40 ****
      $biblioitemnum = &newbiblioitem($biblioitem);
  
!     print $input->redirect('additem.pl?biblioitemnum=$biblioitemnum');
  } # else
--- 37,40 ----
      $biblioitemnum = &newbiblioitem($biblioitem);
  
!     print $input->redirect("additem.pl?biblioitemnum=$biblioitemnum");
  } # else

Index: saveitem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/saveitem.pl,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -r1.1 -r1.2
*** saveitem.pl	29 Apr 2002 05:29:02 -0000	1.1
--- saveitem.pl	3 May 2002 02:47:33 -0000	1.2
***************
*** 9,13 ****
  my $biblioitemnum = $input->param('biblioitemnum');
  my $item          = {
!     biblioitemnum    => $biblioitemnum,
      homebranch       => $input->param('homebranch'),
      replacementprice => $input->param('replacementprice'),
--- 9,13 ----
  my $biblioitemnum = $input->param('biblioitemnum');
  my $item          = {
!     biblioitemnumber => $biblioitemnum,
      homebranch       => $input->param('homebranch'),
      replacementprice => $input->param('replacementprice'),
***************
*** 31,35 ****
  	&newitems($item, ($barcode));
  
! 	print $input->redirect('additem.pl?biblioitemnum=$biblioitemnum');
      } # else
  } # else
--- 31,35 ----
  	&newitems($item, ($barcode));
  
! 	print $input->redirect("additem.pl?biblioitemnum=$biblioitemnum");
      } # else
  } # else




From pate at eylerfamily.org  Fri May  3 10:47:07 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May  3 10:47:07 2002
Subject: [Koha-devel] CVS: koha database.mysql,1.4,1.5
In-Reply-To: <E173Cki-000081-00@usw-pr-cvs1.sourceforge.net>
Message-ID: <Pine.LNX.4.30.0205021003120.22793-100000@bigfun.whirlycott.com>

On Thu, 2 May 2002, Paul POULAIN wrote:

Paul,
could you check things like this into the rel-1-2 branch as well.  It
would be nice to get a cleaner more functional DB included in the 1.1.2
release.

thanks,
-pate


> Update of /cvsroot/koha/koha
> In directory usw-pr-cvs1:/tmp/cvs-serv32641
>
> Modified Files:
> 	database.mysql
> Log Message:
> updated database.mysql : dropped unused tables, created indexes : old database.mysql updated by updatedatabase2.pl script
>
>
> Index: database.mysql
> ===================================================================
> RCS file: /cvsroot/koha/koha/database.mysql,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -C2 -r1.4 -r1.5
> *** database.mysql	2 May 2002 00:23:26 -0000	1.4
> --- database.mysql	2 May 2002 09:19:49 -0000	1.5
> ***************
> *** 1,60 ****
> ! # MySQL dump 7.1
> ! #
> ! # Host: localhost    Database: c4test
> ! #--------------------------------------------------------
> ! # Server version	3.22.32-log
>
>   #
> ! # Table structure for table 'accountlines'
>   #
>   CREATE TABLE accountlines (
> [...1500 lines suppressed...]
> +
>   CREATE TABLE systempreferences (
> !   variable char(50) NOT NULL default '',
> !   value char(200) default NULL,
> !   PRIMARY KEY  (variable)
> ! ) TYPE=ISAM PACK_KEYS=1;
> ! # --------------------------------------------------------
>
>   #
> ! # Table structure for table `users`
>   #
> +
>   CREATE TABLE users (
> !   usercode varchar(10) NOT NULL default '',
>     username text,
>     password text,
> !   level smallint(6) default NULL,
> !   PRIMARY KEY  (usercode)
> ! ) TYPE=ISAM PACK_KEYS=1;
>
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From rangi at users.sourceforge.net  Fri May  3 15:28:03 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Fri May  3 15:28:03 2002
Subject: [Koha-devel] CVS: koha INSTALL,1.1,1.2 Hints,1.1,1.2
Message-ID: <E173kn0-0005Qh-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv20806

Added Files:
	INSTALL Hints 
Log Message:
No harm in adding these to the main branch either







From rangi at users.sourceforge.net  Fri May  3 15:37:01 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Fri May  3 15:37:01 2002
Subject: [Koha-devel] CVS: koha INSTALL,NONE,1.1.2.1 Hints,NONE,1.1.2.1
Message-ID: <E173khY-0004zf-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv19047

Added Files:
      Tag: rel-1-2
	INSTALL Hints 
Log Message:
Installation documents


--- NEW FILE ---
Koha - Requirements and quick-start installation guide

INSTALL document included with [Koha]

For information on how to install Koha without requiring multiple virtual servers - See KohaAllInOne. 
For additional information on how your Configuration files should look see the Hints file.

Important....
To successfully use Koha you need some additional software:

A webserver (It was built to work with Apache, but there is no reason it shouldnt work with any other webserver). 
Mysql (You could intead use postgres, or another sql based database) 
Perl (mod_perl isnt needed, tho koha should work with mod_perl but this hasnt been tested yet). 

Perl Modules:

Date::Manip 
DBI 
Set::Scalar 
DBD::mysql (or whatever database system you use) 
AuthenDBI (if you want to use Database based authentication) 
CDK (for the telnet interface not nessecary if you plan to use the web based circulation module) also requires installation of the C CDK libraries http://www.vexus.ca/CDK.html ( CDKModuleHasProblems ) 

--------------------------------------------------------------------------------


Quick-start Installation Guide
(Assumes the Use of MySQL and Apache)

1. Create a new mysql database called for example Koha

From truth_nz at users.sourceforge.net  Sun May  5 19:48:05 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Sun May  5 19:48:05 2002
Subject: [Koha-devel] CVS: koha/acqui.simple addbiblioitem.pl,1.2,1.3 additem.pl,1.2,1.3 savebiblio.pl,1.2,1.3 savebiblioitem.pl,1.2,1.3 saveitem.pl,1.2,1.3
Message-ID: <E174YXY-00029y-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/acqui.simple
In directory usw-pr-cvs1:/tmp/cvs-serv7908

Modified Files:
	addbiblioitem.pl additem.pl savebiblio.pl savebiblioitem.pl 
	saveitem.pl 
Log Message:
Fixed bug due to way hashes take values. Was stopping items being saved to
database. Added code to pick up branch list from database.


Index: addbiblioitem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/addbiblioitem.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** addbiblioitem.pl	3 May 2002 02:47:33 -0000	1.2
--- addbiblioitem.pl	6 May 2002 02:47:49 -0000	1.3
***************
*** 115,119 ****
  </tr>
  <tr valign="top">
! <td colspan="4" align="center"><input type="submit" value="Add New Item"></td>
  </tr>
      
--- 115,119 ----
  </tr>
  <tr valign="top">
! <td colspan="4" align="center"><input type="submit" value="Add New Group"></td>
  </tr>
      

Index: additem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/additem.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** additem.pl	3 May 2002 02:47:33 -0000	1.2
--- additem.pl	6 May 2002 02:47:49 -0000	1.3
***************
*** 12,15 ****
--- 12,17 ----
  my $count;
  my @results;
+ my $branchcount;
+ my @branches;
  
  if (! $biblioitemnum) {
***************
*** 30,33 ****
--- 32,36 ----
      
  	($count, @results) = &getitemsbybiblioitem($biblioitemnum);
+ 	($branchcount, @branches) = &branches;
  
  	if ($count) {
***************
*** 70,74 ****
  <td><input name="barcode" size="10" value="$maxbarcode" /></td>
  <td align="right">Home Branch:</td>
! <td><select name="homebranch"><option value="STWE">Stewart Elementary<option value="MEZ">Meziadin Elementary</select></td>
  </tr>
  <tr>
--- 73,87 ----
  <td><input name="barcode" size="10" value="$maxbarcode" /></td>
  <td align="right">Home Branch:</td>
! <td><select name="homebranch">
! EOF
! 
! 	for (my $i = 0; $i < $branchcount; $i ++) {
! 	    print << "EOF";
! <option value="$branches[$i]->{'branchcode'}">$branches[$i]->{'branchname'}
! EOF
! 	} # for
! 
! 	print << "EOF";
! </select></td>
  </tr>
  <tr>

Index: savebiblio.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/savebiblio.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** savebiblio.pl	3 May 2002 02:47:33 -0000	1.2
--- savebiblio.pl	6 May 2002 02:47:49 -0000	1.3
***************
*** 6,17 ****
  
  my $input = new CGI;
! my $biblio = { title       => $input->param('title'),
!                subtitle    => $input->param('subtitle'),
!                author      => $input->param('author'),
!                seriestitle => $input->param('seriestitle'),
!                copyright   => $input->param('copyrightdate'),
!                abstract    => $input->param('abstract'),
!                notes       => $input->param('notes')
!              }; # my $biblio
  my $biblionumber;
  
--- 6,18 ----
  
  my $input = new CGI;
! my $biblio = {
!     title       => $input->param('title'),
!     subtitle    => $input->param('subtitle')?$input->param('subtitle'):"",
!     author      => $input->param('author')?$input->param('author'):"",
!     seriestitle => $input->param('seriestitle')?$input->param('seriestitle'):"",
!     copyright   => $input->param('copyrightdate')?$input->param('copyrightdate'):"",
!     abstract    => $input->param('abstract')?$input->param('abstract'):"",
!     notes       => $input->param('notes')?$input->param('notes'):""
! }; # my $biblio
  my $biblionumber;
  

Index: savebiblioitem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/savebiblioitem.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** savebiblioitem.pl	3 May 2002 02:47:33 -0000	1.2
--- savebiblioitem.pl	6 May 2002 02:47:49 -0000	1.3
***************
*** 9,31 ****
  my $biblioitem = {
      biblionumber      => $biblionumber,
!     publishercode     => $input->param('publishercode'),
!     publicationyear   => $input->param('publicationyear'),
!     place             => $input->param('year'),
!     illus             => $input->param('illus'),
!     isbn              => $input->param('isbn'),
!     additionalauthors => $input->param('additionalauthors'),
!     subjectheadings   => $input->param('subjectheadings'),
!     itemtype          => $input->param('itemtype'),
!     url               => $input->param('url'),
!     dewey             => $input->param('dewey'),
!     subclass          => $input->param('subclass'),
!     issn              => $input->param('issn'),
!     lccn              => $input->param('lccn'),
!     volume            => $input->param('volume'),
!     number            => $input->param('number'),
!     volumeddesc       => $input->param('volumeddesc'),
!     pages             => $input->param('pages'),
!     size              => $input->param('size'),
!     notes             => $input->param('notes')
  };
  my $biblioitemnum;
--- 9,31 ----
  my $biblioitem = {
      biblionumber      => $biblionumber,
!     publishercode     => $input->param('publishercode')?$input->param('publishercode'):"",
!     publicationyear   => $input->param('publicationyear')?$input->param('publicationyear'):"",
!     place             => $input->param('year')?$input->param('year'):"",
!     illus             => $input->param('illus')?$input->param('illus'):"",
!     isbn              => $input->param('isbn')?$input->param('isbn'):"",
!     additionalauthors => $input->param('additionalauthors')?$input->param('additionalauthors'):"",
!     subjectheadings   => $input->param('subjectheadings')?$input->param('subjectheadings'):"",
!     itemtype          => $input->param('itemtype')?$input->param('itemtype'):"",
!     url               => $input->param('url')?$input->param('url'):"",
!     dewey             => $input->param('dewey')?$input->param('dewey'):"",
!     subclass          => $input->param('subclass')?$input->param('subclass'):"",
!     issn              => $input->param('issn')?$input->param('issn'):"",
!     lccn              => $input->param('lccn')?$input->param('lccn'):"",
!     volume            => $input->param('volume')?$input->param('volume'):"",
!     number            => $input->param('number')?$input->param('number'):"",
!     volumeddesc       => $input->param('volumeddesc')?$input->param('volumeddesc'):"",
!     pages             => $input->param('pages')?$input->param('pages'):"",
!     size              => $input->param('size')?$input->param('size'):"",
!     notes             => $input->param('notes')?$input->param('notes'):""
  };
  my $biblioitemnum;

Index: saveitem.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui.simple/saveitem.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** saveitem.pl	3 May 2002 02:47:33 -0000	1.2
--- saveitem.pl	6 May 2002 02:47:49 -0000	1.3
***************
*** 11,17 ****
      biblioitemnumber => $biblioitemnum,
      homebranch       => $input->param('homebranch'),
!     replacementprice => $input->param('replacementprice'),
!     itemnotes        => $input->param('notes')
! };
  my $count;
  my @results;
--- 11,17 ----
      biblioitemnumber => $biblioitemnum,
      homebranch       => $input->param('homebranch'),
!     replacementprice => $input->param('replacementprice')?$input->param('replacementprice'):"",
!     itemnotes        => $input->param('notes')?$input->param('notes'):""
! }; # my $item
  my $count;
  my @results;




From finlayt at users.sourceforge.net  Sun May  5 21:13:01 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Sun May  5 21:13:01 2002
Subject: [Koha-devel] CVS: koha member.pl,1.1.1.1,1.2
Message-ID: <E174Zrm-0005wM-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv22769

Modified Files:
	member.pl 
Log Message:

Changed the word: Fines to: Charges


Index: member.pl
===================================================================
RCS file: /cvsroot/koha/koha/member.pl,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -C2 -r1.1.1.1 -r1.2
*** member.pl	19 Dec 2000 23:45:51 -0000	1.1.1.1
--- member.pl	6 May 2002 04:12:48 -0000	1.2
***************
*** 28,32 ****
  print mktablehdr;
  print mktablerow(8,'#99cc33',bold('Card'),bold('Surname'),bold('Firstname'),bold('Category')
! ,bold('Address'),bold('OD/Issues'),bold('Fines'),bold('Notes'),'/images/background-mem.gif');
  my $env;
  my ($count,$results)=BornameSearch($env,$member,'web');
--- 28,32 ----
  print mktablehdr;
  print mktablerow(8,'#99cc33',bold('Card'),bold('Surname'),bold('Firstname'),bold('Category')
! ,bold('Address'),bold('OD/Issues'),bold('Charges'),bold('Notes'),'/images/background-mem.gif');
  my $env;
  my ($count,$results)=BornameSearch($env,$member,'web');




From finlayt at users.sourceforge.net  Sun May  5 21:31:04 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Sun May  5 21:31:04 2002
Subject: [Koha-devel] CVS: koha/C4/Circulation Circ2.pm,1.22,1.23
Message-ID: <E174a91-0006gX-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv25518/C4/Circulation

Modified Files:
	Circ2.pm 
Log Message:

Changed the error message from: There is no book with barcode: XXXXXX
to: No item with barcode: XXXXXXX


Index: Circ2.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Circ2.pm,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -r1.22 -r1.23
*** Circ2.pm	2 May 2002 00:08:53 -0000	1.22
--- Circ2.pm	6 May 2002 04:30:37 -0000	1.23
***************
*** 230,234 ****
      my $iteminformation = getiteminformation(\%env,0, $barcode);
      if (not $iteminformation) {
! 	$message = "<font color='red' size='+2'>There is no book with barcode: $barcode </font>";
  	return (0, $message, 0);
      }
--- 230,234 ----
      my $iteminformation = getiteminformation(\%env,0, $barcode);
      if (not $iteminformation) {
! 	$message = "<font color='red' size='+2'>No item with barcode: $barcode </font>";
  	return (0, $message, 0);
      }




From finlayt at users.sourceforge.net  Sun May  5 21:37:02 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Sun May  5 21:37:02 2002
Subject: [Koha-devel] CVS: koha/C4/Circulation Circ2.pm,1.23,1.24
Message-ID: <E174aEu-0006wa-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4/Circulation
In directory usw-pr-cvs1:/tmp/cvs-serv26528/C4/Circulation

Modified Files:
	Circ2.pm 
Log Message:

Removed the "Item has been transfered" message from the returnbook2
subroutine.


Index: Circ2.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Circulation/Circ2.pm,v
retrieving revision 1.23
retrieving revision 1.24
diff -C2 -r1.23 -r1.24
*** Circ2.pm	6 May 2002 04:30:37 -0000	1.23
--- Circ2.pm	6 May 2002 04:36:42 -0000	1.24
***************
*** 586,590 ****
      my ($iteminformation) = getiteminformation($env, 0, $barcode);
      if (not $iteminformation) {
! 	push(@messages, "<font color='red' size='+2'> There is no book with barcode: $barcode </font>");
  	return (0, \@messages, 0 ,0);
      }
--- 586,590 ----
      my ($iteminformation) = getiteminformation($env, 0, $barcode);
      if (not $iteminformation) {
! 	push(@messages, "<font color='red' size='+2'> No item with barcode: $barcode </font>");
  	return (0, \@messages, 0 ,0);
      }
***************
*** 610,616 ****
      my $tbr = $env->{'branchcode'};
      my ($transfered, $message, $item) = transferbook($tbr, $barcode);
-     if ($transfered) {
- 	push(@messages, "Book: as been transfered.");
-      }
  
      if ($iteminformation->{'itemlost'}) {
--- 610,613 ----




From rangi at users.sourceforge.net  Mon May  6 15:00:04 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Mon May  6 15:00:04 2002
Subject: [Koha-devel] CVS: koha/updater updatedatabase,1.5,1.6
Message-ID: <E174qWE-000454-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/updater
In directory usw-pr-cvs1:/tmp/cvs-serv15559/updater

Modified Files:
	updatedatabase 
Log Message:
Fixing a typo


Index: updatedatabase
===================================================================
RCS file: /cvsroot/koha/koha/updater/updatedatabase,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -r1.5 -r1.6
*** updatedatabase	2 May 2002 00:08:53 -0000	1.5
--- updatedatabase	6 May 2002 21:59:40 -0000	1.6
***************
*** 47,51 ****
  unless ($tables{'z3950queue'}) {
      print "Adding z3950queue table...\n";
!     my $sti=$dbh->prepare("create table z3950queue (id int auto_increment primary key, term text, type char(10), startdate int, enddate int, done smallint, results longblob, numercords int, servers text, identifier char(30))");
      $sti->execute;
  }
--- 47,51 ----
  unless ($tables{'z3950queue'}) {
      print "Adding z3950queue table...\n";
!     my $sti=$dbh->prepare("create table z3950queue (id int auto_increment primary key, term text, type char(10), startdate int, enddate int, done smallint, results longblob, numrecords int, servers text, identifier char(30))");
      $sti->execute;
  }




From rangi at users.sourceforge.net  Mon May  6 16:13:05 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Mon May  6 16:13:05 2002
Subject: [Koha-devel] CVS: koha/C4 Search.pm,1.19,1.20
Message-ID: <E174red-0000ic-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv2274/C4

Modified Files:
	Search.pm 
Log Message:
Removing keywordsearch2 (no longer used)
Fixing glitches in counting lost items.
In items
itemlost=1 item marked lost by a librarian
itemlost=2 item marked lost by kohas automatic this item is over 4 weeks
overdue routine.

To the borrowers (ie in the opac) they should just show as lost


Index: Search.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Search.pm,v
retrieving revision 1.19
retrieving revision 1.20
diff -C2 -r1.19 -r1.20
*** Search.pm	2 May 2002 00:08:53 -0000	1.19
--- Search.pm	6 May 2002 23:12:25 -0000	1.20
***************
*** 297,450 ****
  }
  
- sub KeywordSearch2 {
-   my ($env,$type,$search,$num,$offset)=@_;
-   my $dbh = &C4Connect;
-   $search->{'keyword'}=~ s/ +$//;
-   $search->{'keyword'}=~ s/'/\\'/;
-   my @key=split(' ',$search->{'keyword'});
-   my $count=@key;
-   my $i=1;
-   my @results;
-   my $query ="Select * from biblio,bibliosubtitle,biblioitems where
-   biblio.biblionumber=biblioitems.biblionumber and
-   biblio.biblionumber=bibliosubtitle.biblionumber and
-   (((title like '$key[0]%' or title like '% $key[0]%')";
-   while ($i < $count){
-     $query=$query." and (title like '$key[$i]%' or title like '% $key[$i]%')";
-     $i++;
-   }
-   $query.= ") or ((subtitle like '$key[0]%' or subtitle like '% $key[0]%')";
-   for ($i=1;$i<$count;$i++){
-     $query.= " and (subtitle like '$key[$i]%' or subtitle like '% $key[$i]%')";
-   }
-   $query.= ") or ((seriestitle like '$key[0]%' or seriestitle like '% $key[0]%')";
-   for ($i=1;$i<$count;$i++){
-     $query.=" and (seriestitle like '$key[$i]%' or seriestitle like '% $key[$i]%')";
-   }
-   $query.= ") or ((biblio.notes like '$key[0]%' or biblio.notes like '% $key[0]%')";
-   for ($i=1;$i<$count;$i++){
-     $query.=" and (biblio.notes like '$key[$i]%' or biblio.notes like '% $key[$i]%')";
-   }
-   $query.= ") or ((biblioitems.notes like '$key[0]%' or biblioitems.notes like '% $key[0]%')";
-   for ($i=1;$i<$count;$i++){
-     $query.=" and (biblioitems.notes like '$key[$i]%' or biblioitems.notes like '% $key[$i]%')";
-   }
-   if ($search->{'keyword'} =~ /new zealand/i){
-     $query.= "or (title like 'nz%' or title like '% nz %' or title like '% nz' or subtitle like 'nz%'
-     or subtitle like '% nz %' or subtitle like '% nz' or author like 'nz %' 
-     or author like '% nz %' or author like '% nz')"
-   }
-   if ($search->{'keyword'} eq  'nz' || $search->{'keyword'} eq 'NZ' ||
-   $search->{'keyword'} =~ /nz /i || $search->{'keyword'} =~ / nz /i ||
-   $search->{'keyword'} =~ / nz/i){
-     $query.= "or (title like 'new zealand%' or title like '% new zealand %'
-     or title like '% new zealand' or subtitle like 'new zealand%' or
-     subtitle like '% new zealand %'
-     or subtitle like '% new zealand' or author like 'new zealand%' 
-     or author like '% new zealand %' or author like '% new zealand' or 
-     seriestitle like 'new zealand%' or seriestitle like '% new zealand %'
-     or seriestitle like '% new zealand')"
-   }
-   $query=$query."))";
-   if ($search->{'class'} ne ''){
-     my @temp=split(/\|/,$search->{'class'});
-     my $count=@temp;
-     $query.= "and ( itemtype='$temp[0]'";
-     for (my $i=1;$i<$count;$i++){
-       $query.=" or itemtype='$temp[$i]'";
-      }
-   $query.=")"; 
-   }
-   if ($search->{'dewey'} ne ''){
-     $query.= "and (dewey like '$search->{'dewey'}%') ";
-   }
-    $query.="group by biblio.biblionumber";
-    #$query.=" order by author,title";
- #  print $query;
-   my $sth=$dbh->prepare($query);
-   $sth->execute;
-   $i=0;
-   while (my $data=$sth->fetchrow_hashref){
- #    my $sti=$dbh->prepare("select dewey,subclass from biblioitems where biblionumber=$data->{'biblionumber'}
- #    ");
- #    $sti->execute;
- #    my ($dewey, $subclass) = $sti->fetchrow;
-     my $dewey=$data->{'dewey'};
-     my $subclass=$data->{'subclass'};
-     $dewey=~s/\.*0*$//;
-     ($dewey == 0) && ($dewey='');
-     ($dewey) && ($dewey.=" $subclass");
- #    $sti->finish;
-     $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey";
- #      print $results[$i];
-     $i++;
-   }
-   $sth->finish;
-   $sth=$dbh->prepare("Select biblionumber from bibliosubject where subject
-   like '%$search->{'keyword'}%' group by biblionumber");
-   $sth->execute;
-   while (my $data=$sth->fetchrow_hashref){
-     $query="Select * from biblio,biblioitems where
-     biblio.biblionumber=$data->{'biblionumber'} and
-     biblio.biblionumber=biblioitems.biblionumber ";
-     if ($search->{'class'} ne ''){
-       my @temp=split(/\|/,$search->{'class'});
-       my $count=@temp;
-       $query.= " and ( itemtype='$temp[0]'";
-       for (my $i=1;$i<$count;$i++){
-         $query.=" or itemtype='$temp[$i]'";
-       }
-       $query.=")"; 
-       
-     }
-     if ($search->{'dewey'} ne ''){
-       $query.= "and (dewey like '$search->{'dewey'}%') ";
-     }
-     my $sth2=$dbh->prepare($query);
-     $sth2->execute;
- #    print $query;
-     while (my $data2=$sth2->fetchrow_hashref){
-       my $dewey= $data2->{'dewey'};
-       my $subclass=$data2->{'subclass'};
-       $dewey=~s/\.*0*$//;          
-       ($dewey == 0) && ($dewey='');              
-       ($dewey) && ($dewey.=" $subclass") ;                  
- #      $sti->finish;              
-        $results[$i]="$data2->{'author'}\t$data2->{'title'}\t$data2->{'biblionumber'}\t$data2->{'copyrightdate'}\t$dewey";
- #      print $results[$i];
-       $i++;   
-     }
-     $sth2->finish;
-   }    
-   my $i2=1;
-   @results=sort @results;
-   my @res;
-   my $count=@results;
-   $i=1;
-   if ($count > 0){
-     $res[0]=$results[0];
-   }
-   while ($i2 < $count){
-     if ($results[$i2] ne $res[$i-1]){
-       $res[$i]=$results[$i2];
-       $i++;
-     }
-     $i2++;
-   }
-   $i2=0;
-   my @res2;
-   $count=@res;
-   while ($i2 < $num && $i2 < $count){
-     $res2[$i2]=$res[$i2+$offset];
- #    print $res2[$i2];
-     $i2++;
-   }
-   $sth->finish;
-   $dbh->disconnect;
- #  $i--;
- #  $i++;
-   return($i, at res2);
- }
- 
  sub CatSearch  {
    my ($env,$type,$search,$num,$offset)=@_;
--- 297,300 ----
***************
*** 738,742 ****
  #  print $type;
    if ($type ne 'intra'){
!     $query.=" and (items.itemlost<>1 or items.itemlost is NULL)
      and (wthdrawn <> 1 or wthdrawn is NULL)";
    }
--- 588,593 ----
  #  print $type;
    if ($type ne 'intra'){
!     $query.=" and ((items.itemlost<>1 and items.itemlost <> 2)
!     or items.itemlost is NULL)
      and (wthdrawn <> 1 or wthdrawn is NULL)";
    }
***************
*** 758,762 ****
        $datedue = "$temp[2]/$temp[1]/$temp[0]";
      }
!     if ($data->{'itemlost'} eq '1'){
          $datedue='Itemlost';
      }
--- 609,613 ----
        $datedue = "$temp[2]/$temp[1]/$temp[0]";
      }
!     if ($data->{'itemlost'} eq '1' || $data->{'itemlost'} eq '2'){
          $datedue='Itemlost';
      }
***************
*** 1188,1192 ****
    biblionumber=$bibnum ";
    if ($type ne 'intra'){
!     $query.=" and (itemlost <>1 or itemlost is NULL) and
      (wthdrawn <> 1 or wthdrawn is NULL)";      
    }
--- 1039,1043 ----
    biblionumber=$bibnum ";
    if ($type ne 'intra'){
!     $query.=" and ((itemlost <>1 and itemlost <> 2) or itemlost is NULL) and
      (wthdrawn <> 1 or wthdrawn is NULL)";      
    }
***************
*** 1207,1212 ****
      my $query2="select * from issues,items where issues.itemnumber=                          
      '$data->{'itemnumber'}' and returndate is NULL
!     and items.itemnumber=issues.itemnumber and (items.itemlost <>1 or
!     items.itemlost is NULL)"; 
      my $sth2=$dbh->prepare($query2);     
      $sth2->execute;         
--- 1058,1065 ----
      my $query2="select * from issues,items where issues.itemnumber=                          
      '$data->{'itemnumber'}' and returndate is NULL
!     and items.itemnumber=issues.itemnumber and ((items.itemlost <>1 and
!     items.itemlost <> 2) or items.itemlost is NULL) 
!     and (wthdrawn <> 1 or wthdrawn is NULL)"; 
!     
      my $sth2=$dbh->prepare($query2);     
      $sth2->execute;         
***************
*** 1226,1229 ****
--- 1079,1085 ----
          $lostcount++;
        }
+       if ($data->{'itemlost'} eq '2'){
+         $lostcount++;
+       }
        if ($data->{'holdingbranch'} eq 'FM'){
          $mending++;
***************
*** 1282,1289 ****
  
  sub barcodes{
    my ($biblioitemnumber)=@_;
    my $dbh=C4Connect;
    my $query="Select barcode from items where
!    biblioitemnumber='$biblioitemnumber'";
    my $sth=$dbh->prepare($query);
    $sth->execute;
--- 1138,1149 ----
  
  sub barcodes{
+   #called from request.pl
    my ($biblioitemnumber)=@_;
    my $dbh=C4Connect;
    my $query="Select barcode from items where
!    biblioitemnumber='$biblioitemnumber'
!    and ((itemlost <> 1 and itemlost <> 2) or itemlost is NULL) and
!    (wthdrawn <> 1 or wthdrawn is NULL)";
! #   print $query;
    my $sth=$dbh->prepare($query);
    $sth->execute;




From rangi at users.sourceforge.net  Mon May  6 17:09:07 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Mon May  6 17:09:07 2002
Subject: [Koha-devel] CVS: koha/C4 Search.pm,1.20,1.21
Message-ID: <E174sWk-0003wF-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv14738/C4

Modified Files:
	Search.pm 
Log Message:
Making the CatSearch and KeywordSearch return more sane returns
Returns an array of hashrefs now, rather than the array of tab separated
strings it was returning before.



Index: Search.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Search.pm,v
retrieving revision 1.20
retrieving revision 1.21
diff -C2 -r1.20 -r1.21
*** Search.pm	6 May 2002 23:12:25 -0000	1.20
--- Search.pm	7 May 2002 00:08:20 -0000	1.21
***************
*** 243,247 ****
  #	  print $i4;
  	  if ($i4 <=$end && $i4 > $offset){
! 	    $res2[$i3]="$data2->{'author'}\t$data2->{'title'}\t$data2->{'biblionumber'}\t$data2->{'copyrightdate'}\t$dewey";	
              $i3++;
              $i4++;
--- 243,250 ----
  #	  print $i4;
  	  if ($i4 <=$end && $i4 > $offset){
! 	    $data2->{'dewey'}=$dewey;
! 	    $res2[$i3]=$data2;
! 	    
! #	    $res2[$i3]="$data2->{'author'}\t$data2->{'title'}\t$data2->{'biblionumber'}\t$data2->{'copyrightdate'}\t$dewey";	
              $i3++;
              $i4++;
***************
*** 283,288 ****
          ($dewey == 0) && ($dewey='');               
          ($dewey) && ($dewey.=" $subclass") ;                      
!         $sth->finish;                                                        
! 	$res2[$i]="$data2->{'author'}\t$data2->{'title'}\t$data2->{'biblionumber'}\t$data2->{'copyrightdate'}\t$dewey";
          $i++;
      }
--- 286,293 ----
          ($dewey == 0) && ($dewey='');               
          ($dewey) && ($dewey.=" $subclass") ;                      
!         $sth->finish;                                             
! 	$data2->{'dewey'}=$dewey;
! 	$res2[$i]=$data2;
! #	$res2[$i]="$data2->{'author'}\t$data2->{'title'}\t$data2->{'biblionumber'}\t$data2->{'copyrightdate'}\t$dewey";
          $i++;
      }
***************
*** 473,477 ****
  	   ($dewey == 0) && ($dewey='');
  	   ($dewey) && ($dewey.=" $subclass");
!            $results[$i2]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'isbn'}\t$data->{'itemtype'}";
             $i2++; 
  	   $sth->finish;
--- 478,484 ----
  	   ($dewey == 0) && ($dewey='');
  	   ($dewey) && ($dewey.=" $subclass");
! 	   $data->{'dewey'}=$dewey;
! 	   $results[$i2]=$data;
! #           $results[$i2]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'isbn'}\t$data->{'itemtype'}";
             $i2++; 
  	   $sth->finish;
***************
*** 527,540 ****
    ($dewey == 0) && ($dewey='');
    ($dewey) && ($dewey.=" $subclass");
    $sti->finish;
    if ($true == 1){
    if ($count > $offset && $count <= $limit){
!     if ($type ne 'subject' && $type ne 'precise'){
!        $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'illus'}";
!     } elsif ($search->{'isbn'} ne '' || $search->{'item'} ne ''){
!        $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'illus'}";
!     } else {  
!      $results[$i]="$data->{'author'}\t$data->{'subject'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'illus'}";
!     }
      $i++;
    }
--- 534,549 ----
    ($dewey == 0) && ($dewey='');
    ($dewey) && ($dewey.=" $subclass");
+   $data->{'dewey'}=$dewey;
    $sti->finish;
    if ($true == 1){
    if ($count > $offset && $count <= $limit){
! #    if ($type ne 'subject' && $type ne 'precise'){
! #       $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'illus'}";
! #    } elsif ($search->{'isbn'} ne '' || $search->{'item'} ne ''){
! #       $results[$i]="$data->{'author'}\t$data->{'title'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'illus'}";
! #    } else {  
! #     $results[$i]="$data->{'author'}\t$data->{'subject'}\t$data->{'biblionumber'}\t$data->{'copyrightdate'}\t$dewey\t$data->{'illus'}";
! #    }
!     $results[$i]=$data;
      $i++;
    }




From rangi at users.sourceforge.net  Mon May  6 17:10:01 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Mon May  6 17:10:01 2002
Subject: [Koha-devel] CVS: koha search.pl,1.6,1.7
Message-ID: <E174sXU-0003yo-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv15194

Modified Files:
	search.pl 
Log Message:
Now use the new hash based results returned from Search.pm



Index: search.pl
===================================================================
RCS file: /cvsroot/koha/koha/search.pl,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -r1.6 -r1.7
*** search.pl	8 Apr 2002 23:44:43 -0000	1.6
--- search.pl	7 May 2002 00:09:06 -0000	1.7
***************
*** 150,162 ****
  while ($i < $count2){
  #    print $results[$i]."\n";
!     my @stuff=split('\t',$results[$i]);
!     $stuff[1]=~ s/\`/\\\'/g;
!     my $title2=$stuff[1];
      $title2=~ s/ /%20/g;
      if ($subject eq ''){
! #      print $stuff[0];
!       $stuff[1]=mklink("/cgi-bin/koha/detail.pl?type=$type&bib=$stuff[2]&title=$title2",$stuff[1]);
!       my $word=$stuff[0];
! #      print $word;
        $word=~ s/([a-z]) +([a-z])/$1%20$2/ig;
        $word=~ s/  //g;
--- 150,163 ----
  while ($i < $count2){
  #    print $results[$i]."\n";
! #    my @stuff=split('\t',$results[$i]);
!     my $result=$results[$i];
!     $result->{'title'}=~ s/\`/\\\'/g;
!     my $title2=$result->{'title'};
      $title2=~ s/ /%20/g;
+     my $location='';
+     my $itemcount;
      if ($subject eq ''){
!       $result->{'title'}=mklink("/cgi-bin/koha/detail.pl?type=$type&bib=$result->{'biblionumber'}&title=$title2",$result->{'title'});
!       my $word=$result->{'author'};
        $word=~ s/([a-z]) +([a-z])/$1%20$2/ig;
        $word=~ s/  //g;
***************
*** 165,238 ****
        $word=~ s/\n//g;
        my $url="/cgi-bin/koha/search.pl?author=$word&type=$type";
!       $stuff[7]=$stuff[5];
!       $stuff[5]='';
!       $stuff[0]=mklink($url,$stuff[0]);
!       my ($count,$lcount,$nacount,$fcount,$scount,$lostcount,$mending,$transit,$ocount)=itemcount($env,$stuff[2],$type);
!       $stuff[4]=$count;
        if ($nacount > 0){
!         $stuff[5]=$stuff[5]."On Loan";
  	if ($nacount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($nacount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";
        }
        if ($lcount > 0){
!          $stuff[5]=$stuff[5]."Levin";
           if ($lcount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($lcount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";
        }
        if ($fcount > 0){
!         $stuff[5]=$stuff[5]."Foxton";
           if ($fcount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($fcount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($scount > 0){
!         $stuff[5]=$stuff[5]."Shannon";
           if ($scount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($scount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($lostcount > 0){
!         $stuff[5]=$stuff[5]."Lost";
           if ($lostcount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($lostcount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($mending > 0){
!         $stuff[5]=$stuff[5]."Mending";
           if ($mending >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($mending)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($transit > 0){
!         $stuff[5]=$stuff[5]."In Transiit";
           if ($transit >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($transit)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($ocount > 0){
!         $stuff[5]=$stuff[5]."On Order";
           if ($ocount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($ocount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        
!       if ($type ne 'opac'){
!         $stuff[6]=mklink("/cgi-bin/koha/request.pl?bib=$stuff[2]","Request");
!       }
      } else {
!       my $word=$stuff[1];
        $word=~ s/ /%20/g;
        
!         $stuff[1]=mklink("/cgi-bin/koha/subjectsearch.pl?subject=$word&type=$type",$stuff[1]);
  
      }
--- 166,241 ----
        $word=~ s/\n//g;
        my $url="/cgi-bin/koha/search.pl?author=$word&type=$type";
!       $result->{'author'}=mklink($url,$result->{'author'});
!       my ($count,$lcount,$nacount,$fcount,$scount,$lostcount,$mending,$transit,$ocount)=itemcount($env,$result->{'biblionumber'},$type);
!       $itemcount=$count;
!       ####
!       # Fix this chunk below, remove all hardcoded branch references
!       # need to fix itemcount as well
!       ###
        if ($nacount > 0){
!         $location=$location."On Loan";
  	if ($nacount >1 ){                                                                                                         
! 	  $location=$location." ($nacount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";
        }
        if ($lcount > 0){
!          $location=$location."Levin";
           if ($lcount >1 ){                                                                                                         
! 	  $location=$location." ($lcount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";
        }
        if ($fcount > 0){
!         $location=$location."Foxton";
           if ($fcount >1 ){                                                                                                         
! 	  $location=$location." ($fcount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($scount > 0){
!         $location=$location."Shannon";
           if ($scount >1 ){                                                                                                         
! 	  $location=$location." ($scount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($lostcount > 0){
!         $location=$location."Lost";
           if ($lostcount >1 ){                                                                                                         
! 	  $location=$location." ($lostcount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($mending > 0){
!         $location=$location."Mending";
           if ($mending >1 ){                                                                                                         
! 	  $location=$location." ($mending)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($transit > 0){
!         $location=$location."In Transiit";
           if ($transit >1 ){                                                                                                         
! 	  $location=$location." ($transit)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($ocount > 0){
!         $location=$location."On Order";
           if ($ocount >1 ){                                                                                                         
! 	  $location=$location." ($ocount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        
! #      if ($type ne 'opac'){
! #        $result->{'request'}=mklink("/cgi-bin/koha/request.pl?bib=$stuff[2]","Request");
! #      }
      } else {
!       my $word=$result->{'subject'};
        $word=~ s/ /%20/g;
        
!         $result->{'title'}=mklink("/cgi-bin/koha/subjectsearch.pl?subject=$word&type=$type",$result->{'subject'});
  
      }
***************
*** 240,253 ****
      if ($colour == 1){
        if ($illustrator) {
! 	  print mktablerow(7,$secondary,$stuff[1],$stuff[0],$stuff[7],$stuff[3],$stuff[4],$stuff[5],$stuff[6]);
        } else {
! 	  print mktablerow(6,$secondary,$stuff[1],$stuff[0],$stuff[3],$stuff[4],$stuff[5],$stuff[6]);
        }
        $colour=0;
      } else {
        if ($illustrator) {
! 	  print mktablerow(7,'white',$stuff[1],$stuff[0],$stuff[7],$stuff[3],$stuff[4],$stuff[5],$stuff[6]);
        } else {
! 	  print mktablerow(6,'white',$stuff[1],$stuff[0],$stuff[3],$stuff[4],$stuff[5],$stuff[6]);
        }
        $colour=1;
--- 243,256 ----
      if ($colour == 1){
        if ($illustrator) {
! 	  print mktablerow(7,$secondary,$result->{'title'},$result->{'author'},$result->{'illus'},$result->{'copyrightdate'},$itemcount,$location);
        } else {
! 	  print mktablerow(6,$secondary,$result->{'title'},$result->{'author'},$result->{'copyrightdate'},$itemcount,$location);
        }
        $colour=0;
      } else {
        if ($illustrator) {
! 	  print mktablerow(7,'white',$result->{'title'},$result->{'author'},$result->{'illus'},$result->{'copyrightdate'},$itemcount,$location);
        } else {
! 	  print mktablerow(6,'white',$result->{'title'},$result->{'author'},$result->{'copyrightdate'},$itemcount,$location);
        }
        $colour=1;




From rangi at users.sourceforge.net  Mon May  6 17:10:02 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Mon May  6 17:10:02 2002
Subject: [Koha-devel] CVS: koha/acqui newbasket2.pl,1.1.1.1,1.2
Message-ID: <E174sXU-0003yt-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/acqui
In directory usw-pr-cvs1:/tmp/cvs-serv15194/acqui

Modified Files:
	newbasket2.pl 
Log Message:
Now use the new hash based results returned from Search.pm



Index: newbasket2.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui/newbasket2.pl,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -C2 -r1.1.1.1 -r1.2
*** newbasket2.pl	19 Dec 2000 23:45:56 -0000	1.1.1.1
--- newbasket2.pl	7 May 2002 00:09:06 -0000	1.2
***************
*** 30,36 ****
  my $title=$input->param('search');
  $search{'title'}=$title;
! my $keyword=$input->param('search');
  $search{'keyword'}=$keyword;
! my $author=$input->param('search');
  $search{'author'}=$author;
  
--- 30,36 ----
  my $title=$input->param('search');
  $search{'title'}=$title;
! my $keyword=$input->param('d');
  $search{'keyword'}=$keyword;
! my $author=$input->param('author');
  $search{'author'}=$author;
  
***************
*** 46,52 ****
  my $id=$input->param('id');
  my $basket=$input->param('basket');
! 
  my ($count, at booksellers)=bookseller($id);
- 																																   print startpage();       
  
  print startpage();
--- 46,56 ----
  my $id=$input->param('id');
  my $basket=$input->param('basket');
! my $sub=$input->param('sub');
! my $donation;
! if ($id == 72){
!   $donation='yes';
! }
! #print $sub;
  my ($count, at booksellers)=bookseller($id);
  
  print startpage();
***************
*** 54,60 ****
  print mkheadr(1,"Shopping Basket For: $booksellers[0]->{'name'}");
  
  print <<printend
! 
! <a href=newbiblio.pl?id=$id&basket=$basket><img src=/images/add-biblio.gif width=187 heigth=42 border=0 align=right alt="Add New Biblio"></a>
  <a href=basket.pl?basket=$basket><img src=/images/view-basket.gif width=187 heigth=42 border=0 align=right alt="View Basket"></a>
  
--- 58,68 ----
  print mkheadr(1,"Shopping Basket For: $booksellers[0]->{'name'}");
  
+ if ($donation ne 'yes'){
+   print "<a href=newbiblio.pl?id=$id&basket=$basket&sub=$sub>";
+ } else {
+   print "<a href=newdonation.pl?id=$id&basket=$basket&sub=$sub>";
+ }
  print <<printend
! <img src=/images/add-biblio.gif width=187 heigth=42 border=0 align=right alt="Add New Biblio"></a>
  <a href=basket.pl?basket=$basket><img src=/images/view-basket.gif width=187 heigth=42 border=0 align=right alt="View Basket"></a>
  
***************
*** 72,84 ****
  my @results;
  
!     if ($keyword ne ''){
! #      print "hey";
!       ($count, at results)=&KeywordSearch(\$blah,'intra',\%search,$num,$offset);
!     } elsif ($search{'front'} ne '') {
!     ($count, at results)&FrontSearch(\$blah,'intra',\%search,$num,$offset);
!     }else {
        ($count, at results)=&CatSearch(\$blah,'loose',\%search,$num,$offset);
! #            print "hey";
!     }
  
  print "You searched on ";
--- 80,86 ----
  my @results;
  
! 
        ($count, at results)=&CatSearch(\$blah,'loose',\%search,$num,$offset);
! 
  
  print "You searched on ";
***************
*** 111,125 ****
  while ($i < $count2){
  #    print $results[$i]."\n";
!     my @stuff=split('\t',$results[$i]);
!     $stuff[1]=~ s/\`/\\\'/g;
!     my $title2=$stuff[1];
!     my $author2=$stuff[0];
!     my $copyright=$stuff[3];
      $author2=~ s/ /%20/g;
      $title2=~ s/ /%20/g;
      $title2=~ s/\#/\&\#x23;/g;
!       $stuff[1]=mklink("/cgi-bin/koha/acqui/newbiblio.pl?title=$title2&author=$author2&copyright=$copyright&id=$id&basket=$basket&biblio=$stuff[2]",$stuff[1]);
!       my $word=$stuff[0];
! #      print $word;
        $word=~ s/([a-z]) +([a-z])/$1%20$2/ig;
        $word=~ s/  //g;
--- 113,134 ----
  while ($i < $count2){
  #    print $results[$i]."\n";
! #    my @stuff=split('\t',$results[$i]);
!     my $result=$results[$i];
!     $result->{'title'}=~ s/\`/\\\'/g;
!     my $title2=$result->{'title'};
!     my $author2=$result->{'author'};
!     my $copyright=$result->{'copyrightdate'};
      $author2=~ s/ /%20/g;
      $title2=~ s/ /%20/g;
      $title2=~ s/\#/\&\#x23;/g;
!     $title2=~ s/\"/\&quot\;/g;
!     my $itemcount;
!     my $location='';
!     if ($donation eq 'yes'){
!       $result->{'title'}=mklink("/cgi-bin/koha/acqui/newdonation.pl?author=$author2&copyright=$copyright&id=$id&basket=$basket&biblio=$result->{'biblionumber'}&title=$title2",$result->{'title'});
!     } else {
!       $result->{'title'}=mklink("/cgi-bin/koha/acqui/newbiblio.pl?sub=$sub&author=$author2&copyright=$copyright&id=$id&basket=$basket&biblio=$result->{'biblionumber'}&title=$title2",$result->{'title'});
!     }  
!     my $word=$result->{'author'};
        $word=~ s/([a-z]) +([a-z])/$1%20$2/ig;
        $word=~ s/  //g;
***************
*** 128,189 ****
        $word=~ s/\n//g;
        my $url="/cgi-bin/koha/search.pl?author=$word&type=$type";
!       $stuff[0]=mklink($url,$stuff[0]);
!       my ($count,$lcount,$nacount,$fcount,$scount,$lostcount,$mending,$transit)=itemcount($env,$stuff[2],$type);
!       $stuff[4]=$count;
        if ($nacount > 0){
!         $stuff[5]=$stuff[5]."On Loan";
  	if ($nacount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($nacount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";
        }
        if ($lcount > 0){
!          $stuff[5]=$stuff[5]."Levin";
           if ($lcount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($lcount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";
        }
        if ($fcount > 0){
!         $stuff[5]=$stuff[5]."Foxton";
           if ($fcount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($fcount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($scount > 0){
!         $stuff[5]=$stuff[5]."Shannon";
           if ($scount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($scount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($lostcount > 0){
!         $stuff[5]=$stuff[5]."Lost";
           if ($lostcount >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($lostcount)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($mending > 0){
!         $stuff[5]=$stuff[5]."Mending";
           if ($mending >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($mending)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        if ($transit > 0){
!         $stuff[5]=$stuff[5]."In Transiit";
           if ($transit >1 ){                                                                                                         
! 	  $stuff[5]=$stuff[5]." ($transit)";                                                                                            
           }                                                                                                                         
! 	 $stuff[5].=" ";	
        }
        
      if ($colour == 1){
!       print mktablerow(6,$secondary,$stuff[1],$stuff[0],$stuff[3],$stuff[4],$stuff[5],$stuff[6]);
        $colour=0;
      } else{
!       print mktablerow(6,'white',$stuff[1],$stuff[0],$stuff[3],$stuff[4],$stuff[5],$stuff[6]);
        $colour=1;
      }
--- 137,198 ----
        $word=~ s/\n//g;
        my $url="/cgi-bin/koha/search.pl?author=$word&type=$type";
!       $result->{'author'}=mklink($url,$result->{'author'});
!       my ($count,$lcount,$nacount,$fcount,$scount,$lostcount,$mending,$transit)=itemcount($env,$result->{'biblionumber'},$type);
!       $itemcount=$count;
        if ($nacount > 0){
!         $location=$location."On Loan";
  	if ($nacount >1 ){                                                                                                         
! 	  $location=$location." ($nacount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";
        }
        if ($lcount > 0){
!          $location=$location."Levin";
           if ($lcount >1 ){                                                                                                         
! 	  $location=$location." ($lcount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";
        }
        if ($fcount > 0){
!         $location=$location."Foxton";
           if ($fcount >1 ){                                                                                                         
! 	  $location=$location." ($fcount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($scount > 0){
!         $location=$location."Shannon";
           if ($scount >1 ){                                                                                                         
! 	  $location=$location." ($scount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($lostcount > 0){
!         $location=$location."Lost";
           if ($lostcount >1 ){                                                                                                         
! 	  $location=$location." ($lostcount)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($mending > 0){
!         $location=$location."Mending";
           if ($mending >1 ){                                                                                                         
! 	  $location=$location." ($mending)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        if ($transit > 0){
!         $location=$location."In Transiit";
           if ($transit >1 ){                                                                                                         
! 	  $location=$location." ($transit)";                                                                                            
           }                                                                                                                         
! 	 $location.=" ";	
        }
        
      if ($colour == 1){
!       print mktablerow(6,$secondary,$result->{'title'},$result->{'author'},$result->{'copyrightdate'},$itemcount,$location);
        $colour=0;
      } else{
!       print mktablerow(6,'white',$result->{'title'},$result->{'author'},$result->{'copyrightdate'},$itemcount,$location);
        $colour=1;
      }
***************
*** 196,200 ****
  print mktableft();
  if ($offset < $count){
!     my $search="num=$num&offset=$offset&type=$type&id=$id&basket=$basket&search=$keyword";
      my $stuff=mklink("/cgi-bin/koha/acqui/newbasket2.pl?$search",'Next');
      print $stuff;
--- 205,209 ----
  print mktableft();
  if ($offset < $count){
!     my $search="num=$num&offset=$offset&type=$type&id=$id&basket=$basket&search=$title&author=$author";
      my $stuff=mklink("/cgi-bin/koha/acqui/newbasket2.pl?$search",'Next');
      print $stuff;




From rangi at users.sourceforge.net  Mon May  6 19:34:02 2002
From: rangi at users.sourceforge.net (Chris Cormack)
Date: Mon May  6 19:34:02 2002
Subject: [Koha-devel] CVS: koha ChangeLog,1.1.2.3,1.1.2.4
Message-ID: <E174umi-0003NG-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv12743

Modified Files:
      Tag: rel-1-2
	ChangeLog 
Log Message:
Combined this with the old Changelog file, so it has the history since the
1.0 release

Will tar up and put up a new rc1 that contains the changelog and hints file.



Index: ChangeLog
===================================================================
RCS file: /cvsroot/koha/koha/ChangeLog,v
retrieving revision 1.1.2.3
retrieving revision 1.1.2.4
diff -C2 -r1.1.2.3 -r1.1.2.4
*** ChangeLog	25 Apr 2002 19:47:05 -0000	1.1.2.3
--- ChangeLog	7 May 2002 02:32:58 -0000	1.1.2.4
***************
*** 1,14 ****
! 2002-04-25 09:12 pate
  
- 	* output.t, testKoha.pl: added tests for Output.pm (nearing
- 	complete coverage)
- 
- 	* C4/Output.pm: added prototyping where possible, cleaned up some
- 	compiler warnings, found and fixed an error in mkformnotable while
- 	adding tests
- 
- 2002-04-25 06:57  pate   
- 
- 	* koha.t: added fixEthnicity tests
  
  2002-04-17 14:35  pate
--- 1,4 ----
! Changelog since version 1.1.1
  
  
  2002-04-17 14:35  pate
***************
*** 495,1121 ****
  	to get the items showing in date_due order
  
! 2001-07-12 04:12  pawelzc
! 
! 	* translator/translator.readme: Spelling and english language
! 	corrections.
! 
! 2001-07-05 14:37  rangi
! 
! 	* deletemem.pl: Script to delete a member/patron
! 
! 2001-07-05 14:37  rangi
! 
! 	* memberentry.pl: Fix to handle the delete call, redirects to
! 	deletemem.pl
! 
! 2001-06-27 14:53  rangi
! 
! 	* translator/translator.pl: Modified so that the first available
! 	language is chosen if none is specified
! 
! 2001-06-26 15:27  tonnesen
! 
! 	* C4/Catalogue.pm: Finished updateBiblioItem subroutine
! 
! 2001-06-26 15:13  rangi
! 
! 	* translator/: translator.pl, translator.readme: Scripts to permit
! 	koha webpages to display in different natural languages Courtesy of
! 	Pawel Skuza
! 
! 2001-06-26 14:13  tonnesen
! 
! 	* C4/Catalogue.pm: newBiblio subroutine completed.
! 
! 2001-06-26 13:17  tonnesen
! 
! 	* C4/Catalogue.pm: Added biblioitems table update when
! 	newBiblioItem() routine is called.
! 
! 2001-06-26 10:15  tonnesen
! 
! 	* C4/Catalogue.pm: Beginning updateBiblio routine.
! 
! 2001-06-25 13:15  tonnesen
! 
! 	* marc/viewmarc.pl: Prototype marc record viewer and editor.
! 
! 2001-06-25 13:12  tonnesen
! 
! 	* marc/TODO: A TODO file for MARC support
! 
! 2001-06-25 12:43  tonnesen
! 
! 	* C4/Catalogue.pm: Added skeletons of update routines.
! 
! 2001-06-25 12:07  tonnesen
! 
! 	* marc/koha2marc: Minor documentation changes.
! 
! 2001-06-25 11:55  tonnesen
! 
! 	* marc/koha2marc: Perl script to convert existing Koha tables to
! 	the new MARC tables.
! 
! 2001-06-25 11:54  tonnesen
! 
! 	* marc/deletemarc: SQL commands to clear all of the MARC tables. 
! 	This is terribly dangerous, but I find it useful during the
! 	development work.  :)
! 
! 2001-06-25 11:52  tonnesen
! 
! 	* marc/marcschema.sql: Schema for MARC storage tables.	Blatantly
! 	stolen from www.pytheas.org.  I also added the 0XX tables.
! 
! 2001-06-25 11:49  tonnesen
! 
! 	* C4/Catalogue.pm: Cataloguing API.  Very early draft at this
! 	point.
! 
! 2001-06-19 20:36  rangi
! 
! 	* readingrec.pl, C4/Search.pm: Made a little change to allow the
! 	reading record to be sorted, and now defaults to the last 50 items
! 	borrowed
! 
! 2001-05-17 15:36  rangi
! 
! 	* database.mysql: Changed the interim field in the items table, to
! 	be paidfor The horowhenua librarians wanted a place to store
! 	information when a lost item was paid for. The information is
! 	removed if the item is ever returned.  The interim field was a
! 	hangover from the previous system and wasnt be used so I stole it
! 	:-)
! 
! 2001-05-15 16:05  rangi
! 
! 	* C4/Accounts2.pm: More little bug fixes in the manual credits
! 	section
! 
! 2001-05-09 16:29  rangi
! 
! 	* C4/Circulation/Circ2.pm: Changed the way a lost book being
! 	returned is handled.  If the book has already been paid for a
! 	credit is added to their account.  And offset against any current
! 	charges
! 
! 2001-05-09 16:26  rangi
! 
! 	* updateitem.pl: Set up so marking a item lost, adds a charge for
! 	the replacement price to a borrowers record (if it is on issue)
! 
! 2001-05-09 16:23  rangi
! 
! 	* renewscript.pl: Fixed so renewing a rental item adds a charge
! 
! 2001-05-09 16:22  rangi
! 
! 	* mancredit.pl, maninvoice.pl, C4/Accounts2.pm: Added facility to
! 	do a cash refund.  Also HLT allows ppl to work off their bill,so
! 	added a facility to do manual credit for that
! 
! 2001-05-08 17:05  rangi
! 
! 	* C4/Circulation/Renewals2.pm: Renewing a rental or pay item from
! 	the borrowers record screen Now adds a charge to the borrowers
! 	account
! 
! 2001-05-02 16:06  tonnesen
! 
! 	* groups.pl, C4/Groups.pm: Steve Tonnesen's K12Admin-specific (for
! 	the time-being) group based overdue reports.
! 
! 2001-05-02 15:38  tonnesen
! 
! 	* C4/Circulation/Circ2.pm: Added an overdue variable to the
! 	itemdata returned by the currentissues subroutine.  This makes it
! 	easier to pick out overdue items in other modules (ie circulation,
! 	reports, etc.)
! 
! 2001-05-02 14:15  rangi
! 
! 	* C4/Circulation/Circ2.pm: Fixed the code that adds a credit or
! 	wipes a lost book charge from a borrowers account if said book is
! 	returned
! 
! 2001-05-02 14:13  rangi
! 
! 	* C4/Accounts2.pm: Added functions to add credits and invoices to
! 	borrowers account
! 
! 2001-05-02 14:11  rangi
! 
! 	* boraccount.pl, moremember.pl: Turned off the tidy accounts
! 	feature in the view accounts screen (boraccount.pl) And got it so
! 	outstanding credits are shown on the moremember.pl (view member
! 	screen)
! 
! 2001-05-02 14:08  rangi
! 
! 	* mancredit.pl, maninvoice.pl: Scripts to add manual invoices, or
! 	credits to a borrower/member/patron's account.	Called from
! 	boraccount.pl (ie the view account screen)
! 
! 2001-05-01 16:24  rangi
! 
! 	* C4/Accounts2.pm: Fixed a bug in the return lost routine (when a
! 	payment is made on a lost item) So that the correct date was being
! 	recorded
! 
! 2001-04-19 17:31  rangi
! 
! 	* circ/circulation.pl: Quick bodge to restrict the number of
! 	returned books showing to 8.  (Request from the librarians here to
! 	speed up the screen reload) Needs to be tidied up
! 
! 2001-04-17 19:51  rangi
! 
! 	* C4/Accounts2.pm: Add functionality so that when the replacement
! 	cost of a lost item is paid Its returned off the members/patrons
! 	card. And a note is placed on the item saying that its been paid
! 	for.  The item stays marked as lost. But the patron does not accrue
! 	more fines
! 
! 2001-04-03 14:32  rangi
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Making a change to
! 	the way charges are handled, the system originally worked such that
! 	if a borrower owed more than $5 issues werent allowed. This worked
! 	fine except that often borrowers wish to borrows say 3 pay videos
! 	at $2 each, then 2 books say. The three pay videos rack up charges
! 	of $6 and then they cant issue the books until that is paid. 
! 	Reworked so that it cares about previous charges, not the ones
! 	accrued during current issue process.
! 
! 2001-04-02 15:51  rangi
! 
! 	* pay.pl, stats.pl, C4/Accounts2.pm, C4/Stats.pm, sec/writeoff.pl:
! 	Reworking statistics for payments and writeoffs
! 
! 2001-03-28 18:11  rangi
! 
! 	* moremember.pl: Commenting out the code that doesnt allow renewals
! 	if a renewal has already occured
! 
! 2001-03-27 19:00  rangi
! 
! 	* circ/circulation.pl: Adding in javscript code to open a new
! 	window for payments
! 
! 2001-03-27 18:23  rangi
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Reworked layout of
! 	issues section.
! 
! 2001-03-27 13:45  rangi
! 
! 	* sec/writeoff.pl: Getting writeoff stats being stored as well
! 
! 2001-03-27 13:43  rangi
! 
! 	* C4/: Accounts2.pm, Stats.pm: Modified the update stats routine to
! 	store borrowernumbers also Passing borrowernumbers to update stats
! 	from Account routines
! 
! 2001-03-22 14:20  rangi
! 
! 	* circ/circulation.pl: Changes made by Glen to allow the
! 	circulation module to work with a ASCII-wand, or CueCat (weird
! 	encoded) input equally well.
! 	
! 	Do not bother installing the CueCat driver or any other software -
! 	it's not needed.
! 
! 2001-03-18 14:06  rangi
! 
! 	* overdue.pl: Script to list overdue books under the headings
! 	Due-Date Patron Phone Title Author
! 	
! 	The patron can be email by clicking on the name (if the database
! 	contains an email address for them)
! 	
! 	Courtesy of Glen Stewart
! 
! 2001-03-15 02:17  rangi
! 
! 	* detail.pl, moredetail.pl: Added code to allow searches to be used
! 	by catalogue maintenance
! 
! 2001-03-15 02:15  rangi
! 
! 	* C4/Maintainance.pm, maint/catmaintain.pl: Added functionality to
! 	allow invalid itemtype to be fixed
! 
! 2001-03-15 02:11  rangi
! 
! 	* maint/shiftbib.pl: Script to shift a group to another biblio,
! 	called as part of catalogue maintenance
! 
! 2001-03-13 14:41  rangi
! 
! 	* catmaintain.pl, maint/catmaintain.pl: Shifted catmaintain.pl to a
! 	dir that can be easily passowrd protected
! 
! 2001-03-13 14:04  rangi
! 
! 	* catmaintain.pl, C4/Maintainance.pm: Got undeleting biblios going
! 	(catalogue maintenance should probably be in a password protected
! 	super librarian area or the like)
! 
! 2001-03-12 15:33  rangi
! 
! 	* newbiblio.pl: Just realised this is supposed to be in the acqui/
! 	dir (doh)
! 
! 2001-03-12 15:32  rangi
! 
! 	* acqui/: acquire.pl, newbiblio.pl: Glens updates to automatically
! 	increment barcode, and to remove hardcoded itemtypes in scripts
! 
! 2001-03-12 15:29  rangi
! 
! 	* memberentry.pl: Modified to include Glen Stewarts automatic
! 	member/patron cardnumber incrementation
! 
! 2001-03-12 15:15  rangi
! 
! 	* newbiblio.pl: Script from Glen Stewart, i think to do with
! 	simplified acqusitions module? (correct me if im wrong glen)
! 
! 2001-03-12 14:43  rangi
! 
! 	* database.mysql: Database definition file, checked into cvs to
! 	make keeping database current easier
! 
! 2001-03-07 13:12  rangi
! 
! 	* insertdata.pl: Fixing stupid bug that was causing the sql insert
! 	command to break if a person had a ' in their name
! 
! 2001-03-07 13:02  rangi
! 
! 	* moremember.pl: Changing the form so it passes through a modify
! 	value to tell the script to show the flags
! 
! 2001-03-06 17:48  rangi
! 
! 	* insertdata.pl, memberentry.pl: Added the functionality to allow
! 	librarians to manipulate the flag status on borrowers ie lost,
! 	debarred, and gone no address
! 
! 2001-03-06 13:16  rangi
! 
! 	* search.pl: Fixing " glitch in titles
! 
! 2001-03-06 13:13  rangi
! 
! 	* opac-search.pl: Fixing a bug in the opac search that meant that
! 	titles that contained " were caused the detail page to error
! 
! 2001-02-27 14:08  rangi
! 
! 	* delbiblio.pl: Quick fix to stop ppl from being able to delete
! 	biblios that have items attached
! 
! 2001-02-21 14:33  rangi
! 
! 	* circ/circulation.pl: Rejigged printing issues, to print out
! 	everything on issue to the borrower
! 
! 2001-02-21 14:27  rangi
! 
! 	* stats.pl: Fixed a little glitch in the daily stats script that
! 	meant it wasnt counting renewals
! 
! 2001-02-21 14:17  rangi
! 
! 	* moremember.pl: Got a link from items on issue thru to item
! 	details (like in the circ module) And also stopped already renewed
! 	books from being renewable in the issues list
! 
! 2001-02-18 14:13  rangi
! 
! 	* C4/Circulation/Circ2.pm: Little fix to the returnbook routine so
! 	the correct branchcode is passed to the updatestats routine
! 
! 2001-02-13 18:41  rangi
! 
! 	* circ/circulation.pl: A bodgy hack so that hitting enter in issues
! 	(with no barcode) prints out the borrowers issue slip and starts a
! 	new borrower
! 
! 2001-02-13 16:29  rangi
! 
! 	* circ/circulation.pl: The Horowhenua libraries wanted less patron
! 	and item information displaying at returns So Added some if
! 	statements to not display patron addresses, and to only display the
! 	title of the item These presumably would be changed to suit
! 	individual libraries wants
! 
! 2001-02-13 16:27  rangi
! 
! 	* C4/Circulation/Circ2.pm: Made some changes to checkreserve and
! 	find_reserves, so that items are always displayed as reserved when
! 	returned, not just once
! 
! 2001-02-11 14:44  rangi
! 
! 	* detail.pl: Little fix so that if the item has no author
! 	information, empty () dont disply
! 
! 2001-02-11 14:38  rangi
! 
! 	* search.pl: Changing the front page search of the intranet site to
! 	just be a keyword search
! 
! 2001-02-07 15:47  tonnesen
! 
! 	* shelves.pl, C4/BookShelves.pm: Added header and log substition
! 	variables
! 
! 2001-02-07 12:27  tonnesen
! 
! 	* shelves.pl, C4/BookShelves.pm: Start of code to implement virtual
! 	bookshelves in Koha.
! 
! 2001-02-05 10:48  tonnesen
! 
! 	* loadmodules.pl, C4/Search.pm: loadmodules.pl allows redirection
! 	to different modules based on systemprefs Added subroutine in
! 	Search.pm load systemprefs from new systempreferences table in
! 	database.  Initial use is to allow using my simplified acquisitions
! 	module in place of vendor-based acquisitions module.  Default is
! 	vendor-based module.
! 
! 2001-02-05 09:47  tonnesen
! 
! 	* C4/Circulation/Circ2.pm: Added a couple of missing
! 	$dbh->disconnect lines that were logging errors in apache log
! 	files.
! 
! 2001-02-05 09:24  tonnesen
! 
! 	* circ/circulation.pl: Fixed backgroundimage in circulation module.
! 	 Background image now displays only in header lines.
! 
! 2001-02-04 14:25  rangi
! 
! 	* C4/Print.pm, circ/circulation.pl: Fixing printing error, now is
! 	printing all of the days issues for borrower
! 
! 2001-01-31 20:09  rangi
! 
! 	* circ/circulation.pl: Made sure the printer queue value was being
! 	set before calling print
! 
! 2001-01-31 18:08  rangi
! 
! 	* C4/Print.pm, C4/Circulation/Circ2.pm, circ/circulation.pl:
! 	Attempting to get issues slip to print when borrower is finished
! 	with
! 
! 2001-01-31 15:40  rangi
! 
! 	* stats.pl: Fixed a bug that was meaning some payments werent
! 	counted
! 
! 2001-01-31 14:09  rangi
! 
! 	* C4/Circulation/Circ2.pm: Fixed a little bug in
! 	getiteminformation, it wasnt returning item loanlength
! 
! 2001-01-31 13:38  rangi
! 
! 	* C4/Output.pm, circ/circulation.pl: Added a line to Ouput.pm to
! 	enable circulation to use its own includes Changed the look of
! 	circulation.pl to the green/yellow colours
! 	
! 	Note: Steve, i added another variable $backgroundimage that sets
! 	the background image for the main tables, so it should be
! 	straightforward to change the look back to the colours you had if
! 	you want to
! 
! 2001-01-31 11:34  rangi
! 
! 	* moremember.pl: Changed it so you cant renew a book that is on
! 	request, made a link from the on request text to the
! 	request(reserve) data
! 
! 2001-01-31 10:14  tonnesen
! 
! 	* circ/circulation.pl: Mostly just look changes, got rid of table
! 	borders, alternating colors on table rows.  Some fixes to returned
! 	items in returns module.
! 
! 2001-01-31 10:13  tonnesen
! 
! 	* C4/Circulation/Circ2.pm: Return itemlist array, and itemlisttext
! 	(text version of overdues) with overdue flag in
! 	getpatroninformation()
! 
! 2001-01-25 16:39  rangi
! 
! 	* misc/fines2.pl: Script to generate overdue fines.  Ideally run as
! 	a cronjob each night
! 
! 2001-01-25 16:17  tonnesen
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Returns module
! 	lists recently returned items, cookies used to store branch and
! 	printer preferences.
! 
! 2001-01-24 16:01  tonnesen
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Refined Returns
! 	module.  Added ability to select branch and printer.  Fixed charges
! 	for rental items.
! 
! 2001-01-23 15:48  tonnesen
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Changes to web
! 	circulation module: rudimentary returns module, arbitrary due date
! 	for issues, flag info displayed, overdue books are displayed in
! 	red.
! 
! 2001-01-22 16:12  tonnesen
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Fixed a bug in
! 	issuing reserved books.  Was calling non-existent printreserve
! 	subroutine
! 
! 2001-01-22 15:48  tonnesen
! 
! 	* C4/Circulation/Circ2.pm, circ/circulation.pl: Started work on a
! 	web-based circulation interface.
! 
! 2001-01-17 15:45  tonnesen
! 
! 	* C4/Circulation/Circ2.pm, tkperl/tkcirc: Added support for showing
! 	patron flags in the issues module.  Moved popup message windows to
! 	a Toplevel widget instead of a message widget.	Toplevel widgets
! 	come up much faster than message widgets.
! 
! 2001-01-16 15:34  rangi
! 
! 	* C4/Circulation/Fines.pm: Fixing a glitch in the fines routine,
! 	was failing if adding a new fine to the same user for the same item
! 
! 2001-01-15 11:31  tonnesen
! 
! 	* C4/Circulation/Circ2.pm: API for circulation modules
! 
! 2001-01-15 11:22  tonnesen
! 
! 	* tkperl/tkcirc: Now uses Circ2.pm generic interface subroutines.
! 
! 2001-01-09 12:47  tonnesen
! 
! 	* tkperl/tkcirc: Moved returned item list from a scrolled text box
! 	to a scrolled table.
! 
! 2001-01-09 09:36  tonnesen
! 
! 	* tkperl/tkcirc: First release of Perl/Tk circulation interface
! 
! 2001-01-05 09:47  tonnesen
! 
! 	* C4/Output.pm: Renamed koha.conf config entry from "path" to
! 	"includes", which is more meaningful in the koha.conf file.
! 
! 2001-01-05 09:39  tonnesen
! 
! 	* C4/Circulation/Main.pm: Modified getbranch() and getprinter()
! 	subroutines to not pop up a menu if there is only one branch or one
! 	printer, but just select the single option automatically.
! 
! 2001-01-05 08:30  tonnesen
! 
! 	* C4/Output.pm: Added support for moving path=... variable to
! 	/etc/koha.conf
! 
! 2000-12-21 11:56  rangi
! 
! 	* C4/Database.pm: Shifted Database connection variables out into a
! 	configuration file The permissions on this config file should also
! 	be strict, since they contain the database password.  At a minimum,
! 	the apache user needs to be able to read it, as well as any other
! 	user that runs circ.  I would suggest ownership of
! 	www-data.libadmins with no access to others.  libadmins contain all
! 	users that use circ
! 	
! 	destined for v1.08
! 
! 2000-12-19 15:45  rangi
! 
! 	* boraccount.pl, borrwraper.pl, catmaintain.pl, charges.pl,
! 	currency.pl, delbiblio.pl, delitem.pl, detail.pl, fines.pl,
! 	imemberentry.pl, insertdata.pl, insertidata.pl, insertjdata.pl,
! 	jmemberentry.pl, member.pl, memberentry.pl, modbib.pl,
! 	modbibitem.pl, moditem.pl, modrequest.pl, moredetail.pl,
! 	moremember.pl, newimember.pl, newjmember.pl, newmember.pl,
! 	opac-search.pl, orderbreakdown.pl, pay.pl, placerequest.pl,
! 	readingrec.pl, renewscript.pl, reports.pl, request.pl,
! 	reservereport.pl, reservereport.xls, search.pl, showbudget.pl,
! 	simpleredirect.pl, stats.pl, stats2.pl, subjectsearch.pl,
! 	tidyaccounts.pl, updatebibitem.pl, updatebiblio.pl,
! 	updatecharges.pl, updateitem.pl, C4/Accounts.pm, C4/Accounts2.pm,
! 	C4/Acquisitions.pm, C4/Circmain.pm, C4/Circulation.pm,
! 	C4/Database.pm, C4/Format.pm, C4/Input.pm, C4/InterfaceCDK.pm,
! 	C4/Maintainance.pm, C4/Output.pm, C4/Print.pm, C4/Reserves.pm,
! 	C4/Reserves2.pm, C4/Scan.pm, C4/Search.pm, C4/Security.pm,
! 	C4/Stats.pm, C4/Stock.pm, C4/Circulation/Borrissues.pm,
! 	C4/Circulation/Borrower.pm, C4/Circulation/Fines.pm,
! 	C4/Circulation/Issues.pm, C4/Circulation/Main.pm,
! 	C4/Circulation/Renewals.pm, C4/Circulation/Renewals2.pm,
! 	C4/Circulation/Returns.pm, C4/Interface/AccountsCDK.pm,
! 	C4/Interface/BorrowerCDK.pm, C4/Interface/FlagsCDK.pm,
! 	C4/Interface/RenewalsCDK.pm, C4/Interface/ReserveentCDK.pm,
! 	acqui/acquire.pl, acqui/addorder.pl, acqui/basket.pl,
! 	acqui/finishreceive.pl, acqui/modorders.pl, acqui/newbasket.pl,
! 	acqui/newbasket2.pl, acqui/newbiblio.pl, acqui/order.pl,
! 	acqui/receive.pl, acqui/recieveorder.pl, acqui/supplier.pl,
! 	acqui/updatesupplier.pl, misc/fixborrower.pl, misc/fixcatalog.pl,
! 	misc/fixorders.pl, misc/fixorders.pl2, misc/fixrefs.pl,
! 	misc/makebaskets.pl, misc/makeformats.pl, misc/tidyaccounts.pl,
! 	sec/writeoff.pl, telnet/borrwraper.pl, telnet/circ,
! 	telnet/doreturns.pl, telnet/issuewrapper.pl,
! 	telnet/returnswrapper.pl, telnet/startint.pl: Initial revision
! 
! 2000-12-19 15:45  rangi
! 
! 	* boraccount.pl, borrwraper.pl, catmaintain.pl, charges.pl,
! 	currency.pl, delbiblio.pl, delitem.pl, detail.pl, fines.pl,
! 	imemberentry.pl, insertdata.pl, insertidata.pl, insertjdata.pl,
! 	jmemberentry.pl, member.pl, memberentry.pl, modbib.pl,
! 	modbibitem.pl, moditem.pl, modrequest.pl, moredetail.pl,
! 	moremember.pl, newimember.pl, newjmember.pl, newmember.pl,
! 	opac-search.pl, orderbreakdown.pl, pay.pl, placerequest.pl,
! 	readingrec.pl, renewscript.pl, reports.pl, request.pl,
! 	reservereport.pl, reservereport.xls, search.pl, showbudget.pl,
! 	simpleredirect.pl, stats.pl, stats2.pl, subjectsearch.pl,
! 	tidyaccounts.pl, updatebibitem.pl, updatebiblio.pl,
! 	updatecharges.pl, updateitem.pl, C4/Accounts.pm, C4/Accounts2.pm,
! 	C4/Acquisitions.pm, C4/Circmain.pm, C4/Circulation.pm,
! 	C4/Database.pm, C4/Format.pm, C4/Input.pm, C4/InterfaceCDK.pm,
! 	C4/Maintainance.pm, C4/Output.pm, C4/Print.pm, C4/Reserves.pm,
! 	C4/Reserves2.pm, C4/Scan.pm, C4/Search.pm, C4/Security.pm,
! 	C4/Stats.pm, C4/Stock.pm, C4/Circulation/Borrissues.pm,
! 	C4/Circulation/Borrower.pm, C4/Circulation/Fines.pm,
! 	C4/Circulation/Issues.pm, C4/Circulation/Main.pm,
! 	C4/Circulation/Renewals.pm, C4/Circulation/Renewals2.pm,
! 	C4/Circulation/Returns.pm, C4/Interface/AccountsCDK.pm,
! 	C4/Interface/BorrowerCDK.pm, C4/Interface/FlagsCDK.pm,
! 	C4/Interface/RenewalsCDK.pm, C4/Interface/ReserveentCDK.pm,
! 	acqui/acquire.pl, acqui/addorder.pl, acqui/basket.pl,
! 	acqui/finishreceive.pl, acqui/modorders.pl, acqui/newbasket.pl,
! 	acqui/newbasket2.pl, acqui/newbiblio.pl, acqui/order.pl,
! 	acqui/receive.pl, acqui/recieveorder.pl, acqui/supplier.pl,
! 	acqui/updatesupplier.pl, misc/fixborrower.pl, misc/fixcatalog.pl,
! 	misc/fixorders.pl, misc/fixorders.pl2, misc/fixrefs.pl,
! 	misc/makebaskets.pl, misc/makeformats.pl, misc/tidyaccounts.pl,
! 	sec/writeoff.pl, telnet/borrwraper.pl, telnet/circ,
! 	telnet/doreturns.pl, telnet/issuewrapper.pl,
! 	telnet/returnswrapper.pl, telnet/startint.pl: Files shifted into
! 	Sourceforge CVS
! 
--- 485,627 ----
  	to get the items showing in date_due order
  
! #Version 1.1.1
! Last release before MARC support
! - Mainly bugfixes. Lots of little glitches in web circulation and members
!   dealt with.
! - Fixed bugs in the manual accounts section
! 
! New Features.
! - Courtesy of Pawel Skuza: A little script that allows multiple language
!   interfaces to koha. Read the scripts/translator/translator.readme for a
!   better explanation.
! - Deleting members/borrowers now works
! 
! 
! #Version 1.1.0
! A Huge amount of changes, many thanks to Glen Stewart and Steve Tonnesen
! -Shifted configuration variables out of Database.pm in the koha.conf (should
!   live in /etc/koha.conf
! - Little fix in detail.pl so that empty () dont display when an item doesnt
!   have an author
! - Added loadmodules.pl
!   loadmodules.pl allows redirection to different modules based on systemprefs
!   Added subroutine in Search.pm load systemprefs from new systempreferences
!   table in database.  Initial use is to allow using my simplified acquisitions
!   module in place of vendor-based acquisitions module.  Default is
!   vendor-based module
! - Changed moremember.pl
!   Fixed so you cant renew and already renewed book, or a book that is on
!   reserve(request)
! - Added shelves.pl
!   Start of code to implement virtual bookshelves
! - Changed stats.pl
!   Fixed a bug that was stopping renewals being counted
! - Added circ/circulation
!   Script to handle issues and returns from web
! - Added tkperl/tkcirc
!   Start of tkperl based circulation module
! - Added C4/Bookshelves.pm
!   Module to facilitate virtual bookshelves
! - Changed C4/Database.pm
!   Shifted configuration variables out of module
! - Changed C4/Search.pm
!   Added subroutine in Search.pm load systemprefs from new systempreferences
!   table in database.  Initial use is to allow using my simplified acquisitions
!   module in place of vendor-based acquisitions module.  Default is
!   vendor-based module.
! - Added C4/Circulation/Circ2.pm
!   API for circulation, huge thanks to Steve Tonnesen tonnesen at cmsd.bc.ca for
!   this.
!   
! - Plus lots of little html changes
! 
! 
! #Version 1.07
! Lots of changes
! Included Glen Stewarts (glen_stewart at associate.com)
! koha.sql generator script, for importing data into koha (koha-sql-generator)
! Additions:
! - currency.pl - Script to allow for exchange rates to be modified
! - tidyaccounts.pl - Script to tidy up a borrowers account (still needs work)
! - catmaintain.pl - Script to do catalogue maintenance,
!   only does subject maintenance at the moment
!   nessecitated a change in index.html
! 
! Changes
! - Changed the Statistics table.
!   Use databasepatch1.06-1.07 to implement
!   mysql -uusername -ppassword databasename < databasepatch1.06-1.07
! - Moredetail.pl
!   Added link to acqusition data from accession date
! - Search.pl
!   Fixed dewey search, was only returning first screen of results
! - Stats.pl
!   New daily stats report, runs much faster
! - C4/Acquisitions.pm
!   Fixing bug in modify order, allowing changing of bookfund when receiving
! - C4/Maintainance.pm
!   Module containing functions used in catalogue maintenance
! - C4/Search.pm
!   Tidying up error handling, slight modification to title search
! - C4/Stats.pm
!   Changed updatestats routine so it stores itemnumbers and itemtypes
! - C4/Circulation/Issues.pm
!   Updated call to update stats so itemtype and itemnumber are passed
! - C4/Circulation/Main.pm
!   Fixing glitch in checkreserve function which meant some reserves werent
!   marked as being filled
! - C4/Circulation/Returns.pm
!   Updated call to update stats so itemnumber is passed
! - C4/Circulation/Renewals.pm
!   Updated call to update stats so itemnumber is passed
! - C4/Circulation/Renewals2.pm
!   Updated call to update stats so itemnumber is passed
! - acqui/acquire.pl
!   Fixed so bookfunds can be changed
! - acqui/addorder.pl
!   Modify order working better
! - acqui/finishreceive.pl
!   Setting quantity ordered to 0 cancels order now
! - acqui/newbiblio.pl
!   Fixed so estimated prices show correctly
!   And recommended retail price shows if known
! 
! - index.html (intranet) added link to catalogue maintenance section
! 
! #Version 1.06
! Seperate forms for adding institutions or children as members/patrons.
! Additional authors being search as part of Author search
! Optimised catalogue searches.
! Fixed deleting orders bug in acquisitions
! Got book title showing up on reserve charge
! 
! #Version 1.05
! Fixing reserves/requests, so that only items in the group requested (not
! whole biblio) trigger the reserves flag.
! Fixed bad behaviour in subject search.
! Got Dewey decimal search going
! Got receript summary screen in acquisitions working better
! Fixing more spelling mistakes
! 
! #Version 1.04
! Tidying up tarball, fixing some spelling mistakes
! 
! #Version 1.03
! Some fairly major changes
! All books waiting for a borrower are now showing on their card in the telnet
! screen.
! Reference books never being able to the public
! Reworked searches, allowing class search to combine with the title, author
! and keyword searchs
! Added an exact title search
! 
! # Version 1.02
! Fixed a glitch in reserves/requests ... no longer showing filled reserves
! Fixed a glitch in ordering to with # in titles
! 
! # Version 1.01
! Fixed bug in reserves deletion
! Fixed bug with " in biblio
! Fixed bug in displaying multiple copies of the same order (when receiving
! acquisitions)
! Fixed bug in Subject search that was duplicating some titles




From finlayt at users.sourceforge.net  Mon May  6 21:38:54 2002
From: finlayt at users.sourceforge.net (Finlay Thompson)
Date: Mon May  6 21:38:54 2002
Subject: [Koha-devel] CVS: koha/circ branchtransfers.pl,1.4,1.5
Message-ID: <E174whn-00024c-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/circ
In directory usw-pr-cvs1:/tmp/cvs-serv7610/circ

Modified Files:
	branchtransfers.pl 
Log Message:

changed the destination branch dropdown to only show branches that have
categorycode == CU, ie can be current branch.


Index: branchtransfers.pl
===================================================================
RCS file: /cvsroot/koha/koha/circ/branchtransfers.pl,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** branchtransfers.pl	2 May 2002 00:06:28 -0000	1.4
--- branchtransfers.pl	7 May 2002 04:36:00 -0000	1.5
***************
*** 34,38 ****
  my $tobranchoptions;
  foreach my $br (keys %$branches) {
!     (next) if $branches->{$br}->{'PE'};
      my $selected='';
      ($selected='selected') if ($br eq $tobranchcd);
--- 34,38 ----
  my $tobranchoptions;
  foreach my $br (keys %$branches) {
!     (next) unless $branches->{$br}->{'CU'};
      my $selected='';
      ($selected='selected') if ($br eq $tobranchcd);




From nsr at etome.net  Tue May  7 12:55:02 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Tue May  7 12:55:02 2002
Subject: [Koha-devel] IRC meet, anyone?
Message-ID: <NGBBLPDKODDLFDKEDCDKGEFICBAA.nsr@etome.net>

A couple of people have suggested that we try to have a meeting via IRC...
I'd suggest Thursday evening (my time, which is eastern standard).  Pat has
a list of possible times that work for all the various timezones (more or
less) based on what I know about people's availability [Pat, I seem to have
forgotten to make a note of the ones you thought that worked -- please send
that out and/or to me :)].

Possible agenda items(_very_ random and subject to editing):
* target setting
* coordination of efforts
* timetables, or at least feature ordering
* CVS use, setup, branching
* a steering committee
* outside involvement (ie, K12Linux, oss4lib)
* features and priorities
* new user/installer assistance
* future meetings (and times, etc)
* standards (MARC, circulation, etc)
* resources in re standards
* design, coding practice
* version numbering, etc. (which is semi settled)
* suggestions on documentation

Thoughts?, Suggestions?,
Nick




From pate at eylerfamily.org  Tue May  7 13:31:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Tue May  7 13:31:02 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: <NGBBLPDKODDLFDKEDCDKGEFICBAA.nsr@etome.net>
Message-ID: <Pine.LNX.4.30.0205071604080.22997-100000@bigfun.whirlycott.com>

On Tue, 7 May 2002, Nicholas Rosasco wrote:

> A couple of people have suggested that we try to have a meeting via IRC...
> I'd suggest Thursday evening (my time, which is eastern standard).  Pat has
> a list of possible times that work for all the various timezones (more or
> less) based on what I know about people's availability [Pat, I seem to have
> forgotten to make a note of the ones you thought that worked -- please send
> that out and/or to me :)].

I'm up for it. Thursday evening works for me, though it might not work for
everyone.  I'm not sure where everyone is timezone wise, but here's a
quick table (I hope I have everyone right):

Me:      0100  1100  1400  1600  1800  2100
Mike:    0400  1400  1700  1900  2100  0000
 GMT     0900  1900  2200  0000  0200  0500
Paul:    1100  2100  0000  0200  0400  0700
Sergey:  1200  2200  0100  0300  0500  0800
Katipo:  2100  0700  1000  1200  1400  1700

All AM times (except for the first column and the 1100 for me) would be
Friday.  It looks like someone will have to cope with ugly hours.  I'm
willing to make any of these, shall we vote?  (Do we need to make any
corrections before we do?)

Are there any non-developers that should be invited?  At some point, I'd
like to hear what librarians (US, NZ, and Euro) have to say about what
they'd like to see Koha do.

>
> Possible agenda items(_very_ random and subject to editing):
> * target setting
> * coordination of efforts
> * timetables, or at least feature ordering
> * CVS use, setup, branching
> * a steering committee
> * outside involvement (ie, K12Linux, oss4lib)
> * features and priorities
> * new user/installer assistance
> * future meetings (and times, etc)
> * standards (MARC, circulation, etc)
> * resources in re standards
> * design, coding practice
> * version numbering, etc. (which is semi settled)
> * suggestions on documentation
>

These all look like things we really need to talk about.  THey also look
like too much to cover in one go.  Maybe if we break this out into three
session it would be more doable.  Perhaps:

  Policy:    Targets, Timetable, Steering Committee, Standards, and
             Follow-up Meetings

  Strategy:  Version Numbering, Design & Coding Practice, Resources for
             Standards, and Outside Involvement

  Tactical:  Docs, New User/Installer Assistance, Coordination, and
             CVS Use

I'd also suggest that we think about having someone chair the meeting(s)
and hold ourselves to a (minimal) set of rules of order -- too many people
and too many topics can get ugly fast.  Nick, would you like to do this or
shall we ask a Katipan?

-pate

> Thoughts?, Suggestions?,
> Nick
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>





From nsr at etome.net  Tue May  7 13:41:01 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Tue May  7 13:41:01 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: <Pine.LNX.4.30.0205071604080.22997-100000@bigfun.whirlycott.com>
Message-ID: <NGBBLPDKODDLFDKEDCDKKEFICBAA.nsr@etome.net>


> -----Original Message-----
> From: koha-devel-admin at lists.sourceforge.net
> [mailto:koha-devel-admin at lists.sourceforge.net]On Behalf Of Pat Eyler
> Sent: Tuesday, May 07, 2002 4:30 PM
> To: nrosasco at acm.org
> Cc: Sergey.Yanovitsky at itgrp.net; koha-devel at lists.sourceforge.net
> Subject: Re: [Koha-devel] IRC meet, anyone?
>
>
> On Tue, 7 May 2002, Nicholas Rosasco wrote:
>
> > A couple of people have suggested that we try to have a meeting
> via IRC...
> > I'd suggest Thursday evening (my time, which is eastern
> standard).  Pat has
> > a list of possible times that work for all the various
> timezones (more or
> > less) based on what I know about people's availability [Pat, I
> seem to have
> > forgotten to make a note of the ones you thought that worked --
> please send
> > that out and/or to me :)].
>
> I'm up for it. Thursday evening works for me, though it might not work for
> everyone.  I'm not sure where everyone is timezone wise, but here's a
> quick table (I hope I have everyone right):
>
> Me:      0100  1100  1400  1600  1800  2100
> Mike:    0400  1400  1700  1900  2100  0000
>  GMT     0900  1900  2200  0000  0200  0500
> Paul:    1100  2100  0000  0200  0400  0700
> Sergey:  1200  2200  0100  0300  0500  0800
> Katipo:  2100  0700  1000  1200  1400  1700
>

> I'd also suggest that we think about having someone chair the meeting(s)
> and hold ourselves to a (minimal) set of rules of order -- too many people
> and too many topics can get ugly fast.  Nick, would you like to do this or
> shall we ask a Katipan?

Actually... Rachel, would you be willing to do this?

Nick




From paul.poulain at free.fr  Wed May  8 03:38:11 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May  8 03:38:11 2002
Subject: [Koha-devel] proposition for MARC version
Message-ID: <3CD8FFAD.9070107@free.fr>

In attachment, you will find my proposition for MARC version. don't 
hesitate to do any remarks.

RTF version and OpenOffice.org original version
--
Paul
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: MARC walktrough.rtf
Url: http://lists.koha.org/pipermail/koha-devel/attachments/20020508/8fd025d0/attachment.txt 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MARC walktrough.sxw
Type: application/octet-stream
Size: 10974 bytes
Desc: not available
Url : http://lists.koha.org/pipermail/koha-devel/attachments/20020508/8fd025d0/attachment.obj 

From dragon28 at ihug.co.nz  Wed May  8 04:09:01 2002
From: dragon28 at ihug.co.nz (Mike Mylonas)
Date: Wed May  8 04:09:01 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: 
	<Pine.LNX.4.30.0205071604080.22997-100000@bigfun.whirlycott.com>
References: <Pine.LNX.4.30.0205071604080.22997-100000@bigfun.whirlycott.com>
Message-ID: <1020857116.20021.6.camel@zeus.dragon-is.co.nz>

On Wed, 2002-05-08 at 08:30, Pat Eyler wrote:
> 
> > A couple of people have suggested that we try to have a meeting via IRC...
> > I'd suggest Thursday evening (my time, which is eastern standard).

I would be in as well ...
> 
> I'm up for it. Thursday evening works for me, though it might not work for
> everyone.  I'm not sure where everyone is timezone wise, but here's a
> quick table (I hope I have everyone right):
> 
> Me:      0100  1100  1400  1600  1800  2100
> Mike:    0400  1400  1700  1900  2100  0000
>  GMT     0900  1900  2200  0000  0200  0500
> Paul:    1100  2100  0000  0200  0400  0700
> Sergey:  1200  2200  0100  0300  0500  0800
> Katipo:  2100  0700  1000  1200  1400  1700


Can we assume that Mike should read Nick, and as a gentle reminder, I
think that it would be productive if Steve and Roger could be in as well
... I know that Roger is in Sydney, Australia, not sure about Steve.
> 
> 
> Are there any non-developers that should be invited?  At some point, I'd
> like to hear what librarians (US, NZ, and Euro) have to say about what
> they'd like to see Koha do.

I think that seeing seeing as Katipo and HLT have a lot of input that
the meeting time would have be close to the normal working day with NZ
Standard time GMT +12...
> 
> I'd also suggest that we think about having someone chair the meeting(s)
> and hold ourselves to a (minimal) set of rules of order -- too many people
> and too many topics can get ugly fast.  Nick, would you like to do this or
> shall we ask a Katipan?
> 

Mike

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: This is a digitally signed message part
Url : http://lists.koha.org/pipermail/koha-devel/attachments/20020508/d87cbd71/attachment.pgp 

From rog at saas.nsw.edu.au  Wed May  8 04:26:14 2002
From: rog at saas.nsw.edu.au (Roger Buck)
Date: Wed May  8 04:26:14 2002
Subject: [Koha-devel] IRC meet, anyone?
References: <Pine.LNX.4.30.0205071604080.22997-100000@bigfun.whirlycott.com> <1020857116.20021.6.camel@zeus.dragon-is.co.nz>
Message-ID: <3CD90B39.413990AC@saas.nsw.edu.au>

Hi Mike et al,

Mike Mylonas wrote:
> 
> On Wed, 2002-05-08 at 08:30, Pat Eyler wrote:
> >
> > > A couple of people have suggested that we try to have a meeting via IRC...

[--snip--]

> think that it would be productive if Steve and Roger could be in as well
> ... I know that Roger is in Sydney, Australia, not sure about Steve.

[--snip--]

It's almost impossible for me to schedule stuff for next few weeks. 

During school time I'm mostly travelling (I work on school networks
right across New South Wales). I do monitor the list +  personal email
on a 48 hour turn-around but that's about my only reliable method of
staying in touch.

School vacations are an exception - and always my most productive
periods ;^)

Thanks for the thought :)

R.



From paul.poulain at free.fr  Wed May  8 05:33:01 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May  8 05:33:01 2002
Subject: [Koha-devel] proposition for MARC version
References: <3CD8FFAD.9070107@free.fr>
Message-ID: <3CD91B6C.2010501@free.fr>

paul POULAIN wrote:

> In attachment, you will find my proposition for MARC version. don't 
> hesitate to do any remarks.
>
> RTF version and OpenOffice.org original version 

Also placed in the Wiki for more convenient modifiings.
--
Paul




From pate at eylerfamily.org  Wed May  8 06:05:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 06:05:02 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: <1020857116.20021.6.camel@zeus.dragon-is.co.nz>
Message-ID: <Pine.LNX.4.30.0205080859290.744-100000@bigfun.whirlycott.com>

On 8 May 2002, Mike Mylonas wrote:

> On Wed, 2002-05-08 at 08:30, Pat Eyler wrote:
> >
> > > A couple of people have suggested that we try to have a meeting via IRC...
> > > I'd suggest Thursday evening (my time, which is eastern standard).
>
> I would be in as well ...
> >
> > I'm up for it. Thursday evening works for me, though it might not work for
> > everyone.  I'm not sure where everyone is timezone wise, but here's a
> > quick table (I hope I have everyone right):
> >
> > Me:      0100  1100  1400  1600  1800  2100
> > Mike:    0400  1400  1700  1900  2100  0000
> >  GMT     0900  1900  2200  0000  0200  0500
> > Paul:    1100  2100  0000  0200  0400  0700
> > Sergey:  1200  2200  0100  0300  0500  0800
> > Katipo:  2100  0700  1000  1200  1400  1700
>
>
> Can we assume that Mike should read Nick, and as a gentle reminder, I
> think that it would be productive if Steve and Roger could be in as well
> ... I know that Roger is in Sydney, Australia, not sure about Steve.

Yes, Mike is actually Nick (sorry guys).  I agree that Roger and Steve
should be in as well, I just didn't know where they lived ...

Roger, Steve; where are you timewise in the above chart?

> >
> >
> > Are there any non-developers that should be invited?  At some point, I'd
> > like to hear what librarians (US, NZ, and Euro) have to say about what
> > they'd like to see Koha do.
>
> I think that seeing seeing as Katipo and HLT have a lot of input that
> the meeting time would have be close to the normal working day with NZ
> Standard time GMT +12...

I sort of agree, I'd like to minimize the pain for all involved, but the
NZ folk are the most numerous and the ones we really need involved more
than anyone else.

> >
> > I'd also suggest that we think about having someone chair the meeting(s)
> > and hold ourselves to a (minimal) set of rules of order -- too many people
> > and too many topics can get ugly fast.  Nick, would you like to do this or
> > shall we ask a Katipan?
> >
>

I think Rachel makes sense (thanks, Nick for the suggestion)


-pate

> Mike
>
>




From pate at eylerfamily.org  Wed May  8 06:10:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 06:10:02 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: <12813236075.20020508135818@itgrp.net>
Message-ID: <Pine.LNX.4.30.0205080905260.744-100000@bigfun.whirlycott.com>

On Wed, 8 May 2002, Sergey A Yanovitsky wrote:

> Hello Pat,
Hi Sergey,

>
> Tuesday, May 07, 2002, 11:30:22 PM, you wrote:
>
> PE> On Tue, 7 May 2002, Nicholas Rosasco wrote:
>
> PE> I'm up for it. Thursday evening works for me, though it might not work for
> PE> everyone.  I'm not sure where everyone is timezone wise, but here's a
> PE> quick table (I hope I have everyone right):
>
> PE> Me:      0100  1100  1400  1600  1800  2100
> PE> Mike:    0400  1400  1700  1900  2100  0000
> PE>  GMT     0900  1900  2200  0000  0200  0500
> PE> Paul:    1100  2100  0000  0200  0400  0700
> PE> Sergey:  1200  2200  0100  0300  0500  0800
> PE> Katipo:  2100  0700  1000  1200  1400  1700
>
> PE> All AM times (except for the first column and the 1100 for me) would be
> PE> Friday.  It looks like someone will have to cope with ugly hours.  I'm
> PE> willing to make any of these, shall we vote?  (Do we need to make any
> PE> corrections before we do?)
>
> Actually I'm on +2, not +3 :) So right times for me are:
>  GMT     0900  1900  2200  0000  0200  0500
> Sergey:  1100  2100  0000  0200  0400  0700

Chalk up another goof for me.  Sorry.

>
> PE> Are there any non-developers that should be invited?  At some point, I'd
> PE> like to hear what librarians (US, NZ, and Euro) have to say about what
> PE> they'd like to see Koha do.
> Dunno..   There are not much unixoids here :( Especially the ones that
> do something to libraries. :(

too bad.  maybe we can set up a windows irc client and help them through
something once they're ready to contribute to discussions like this.  ;)

-pate


>
> [skip]
>




From pate at eylerfamily.org  Wed May  8 07:35:34 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 07:35:34 2002
Subject: [Koha-devel] proposition for MARC version
In-Reply-To: <3CD91B6C.2010501@free.fr>
Message-ID: <Pine.LNX.4.30.0205081021570.1606-100000@bigfun.whirlycott.com>

On Wed, 8 May 2002, paul POULAIN wrote:

> paul POULAIN wrote:
>
> > In attachment, you will find my proposition for MARC version. don't
> > hesitate to do any remarks.
> >
> > RTF version and OpenOffice.org original version
>
> Also placed in the Wiki for more convenient modifiings.


Thanks Paul for all the time and effort.  I'm trying to digest all of it
right now, so I'll hold off on making comments about it until I attain
enlightnement ;)

One tangental comment though; I've noticed a lot of small comments in a
variety of places and from a lot of people that talk about how to
implement things in a very web specific way.  This is a dangerous place to
go.  It would be a lot better if we develop a very clear division between
business logic and presentation logic.  If we do this well, it means that
we can write different front-ends much more easily (CLI, GNOME, KDE, FOX,
WAP[1], whatever).

-pate

[1] Wouldn't it be great to reserve, renew, search for materials from a
WAP enabled cell phone or similar device?

> --
> Paul
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>





From tonnesen at cmsd.bc.ca  Wed May  8 09:04:06 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Wed May  8 09:04:06 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: <Pine.LNX.4.30.0205080859290.744-100000@bigfun.whirlycott.com>
Message-ID: <Pine.LNX.3.96.1020508074343.5139J-100000@hss-labs.cmsd.bc.ca>

On Wed, 8 May 2002, Pat Eyler wrote:

> > > Me:      0100  1100  1400  1600  1800  2100
> > > Mike:    0400  1400  1700  1900  2100  0000
> > >  GMT     0900  1900  2200  0000  0200  0500
> > > Paul:    1100  2100  0000  0200  0400  0700
> > > Sergey:  1200  2200  0100  0300  0500  0800
> > > Katipo:  2100  0700  1000  1200  1400  1700

> Yes, Mike is actually Nick (sorry guys).  I agree that Roger and Steve
> should be in as well, I just didn't know where they lived ...
> 
> Roger, Steve; where are you timewise in the above chart?


I'm GMT-8

Steve:    0100  1100  1400  1600  1800  2100


I've been pretty quiet on the Koha development front of late, but I'd love
to get back into it.  I'm amazed at the amount of development that is
going on now!  :)

Steve.




From pate at eylerfamily.org  Wed May  8 09:04:28 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 09:04:28 2002
Subject: [Koha-devel] IRC meet, anyone?
In-Reply-To: <Pine.LNX.3.96.1020508074343.5139J-100000@hss-labs.cmsd.bc.ca>
Message-ID: <Pine.LNX.4.30.0205081049410.1606-100000@bigfun.whirlycott.com>

On Wed, 8 May 2002, Tonnesen Steve wrote:

>
> On Wed, 8 May 2002, Pat Eyler wrote:
>
> > > > Me:      0100  1100  1400  1600  1800  2100
> > > > Mike:    0400  1400  1700  1900  2100  0000
> > > >  GMT     0900  1900  2200  0000  0200  0500
> > > > Paul:    1100  2100  0000  0200  0400  0700
> > > > Sergey:  1200  2200  0100  0300  0500  0800
> > > > Katipo:  2100  0700  1000  1200  1400  1700
>
> > Yes, Mike is actually Nick (sorry guys).  I agree that Roger and Steve
> > should be in as well, I just didn't know where they lived ...
> >
> > Roger, Steve; where are you timewise in the above chart?
>
>
> I'm GMT-8
>
> Steve:    0100  1100  1400  1600  1800  2100
>
>
> I've been pretty quiet on the Koha development front of late, but I'd love
> to get back into it.  I'm amazed at the amount of development that is
> going on now!  :)

Ahh, we share a timezone ... where are you?  I'm near Seattle.


Would you mind making a middle of the night session?

-pate


>
> Steve.
>
>




From paul.poulain at free.fr  Wed May  8 09:07:57 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May  8 09:07:57 2002
Subject: [Koha-devel] proposition for MARC version
References: <Pine.LNX.4.30.0205081021570.1606-100000@bigfun.whirlycott.com>
Message-ID: <3CD94123.60708@free.fr>

Pat Eyler wrote:

>Thanks Paul for all the time and effort.  I'm trying to digest all of it
>right now, so I'll hold off on making comments about it until I attain
>enlightnement ;)
>
>One tangental comment though; I've noticed a lot of small comments in a
>variety of places and from a lot of people that talk about how to
>implement things in a very web specific way.  This is a dangerous place to
>go.  It would be a lot better if we develop a very clear division between
>business logic and presentation logic.  If we do this well, it means that
>we can write different front-ends much more easily (CLI, GNOME, KDE, FOX,
>WAP[1], whatever).
>
>-pate
>
>[1] Wouldn't it be great to reserve, renew, search for materials from a
>WAP enabled cell phone or similar device?
>

If I understand well, you say that because of my paragraph about how to 
manually add a biblio with the web interface ?
If that's it, I'm OK. But I hope my DB-structure doesn't depend on the 
tool you use to play with koha...

My two main priorities were : having a generic MARC structure to be able 
to accept any MARC format, and having a structure that enables fast 
searches on medium-big libraries.
--
Paul




From paul.poulain at free.fr  Wed May  8 09:09:08 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May  8 09:09:08 2002
Subject: [Koha-devel] IRC meet, anyone?
References: <Pine.LNX.4.30.0205080859290.744-100000@bigfun.whirlycott.com>
Message-ID: <3CD94388.6060308@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020508/8e462d1f/attachment.htm 

From pate at eylerfamily.org  Wed May  8 09:09:10 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 09:09:10 2002
Subject: [Koha-devel] proposition for MARC version
In-Reply-To: <3CD94123.60708@free.fr>
Message-ID: <Pine.LNX.4.30.0205081118140.1606-100000@bigfun.whirlycott.com>

On Wed, 8 May 2002, paul POULAIN wrote:

> Pat Eyler wrote:
>
> >Thanks Paul for all the time and effort.  I'm trying to digest all of it
> >right now, so I'll hold off on making comments about it until I attain
> >enlightnement ;)
> >
> >One tangental comment though; I've noticed a lot of small comments in a
> >variety of places and from a lot of people that talk about how to
> >implement things in a very web specific way.  This is a dangerous place to
> >go.  It would be a lot better if we develop a very clear division between
> >business logic and presentation logic.  If we do this well, it means that
> >we can write different front-ends much more easily (CLI, GNOME, KDE, FOX,
> >WAP[1], whatever).
> >
> >-pate
> >
> >[1] Wouldn't it be great to reserve, renew, search for materials from a
> >WAP enabled cell phone or similar device?
> >
>
> If I understand well, you say that because of my paragraph about how to
> manually add a biblio with the web interface ?
> If that's it, I'm OK. But I hope my DB-structure doesn't depend on the
> tool you use to play with koha...

No, I don't have any problems with your DB structure.  (I still don't
wuite understand MARC, but I'm getting there.)  I'm just hoping that we
can divide the kinds of changes we make into two types:
  Those that are presentation oriented (i.e., to the web interface or some
  other user interface).

  Those that are business logic oriented, like your DB changes.

Sometimes there will be some overlap,  you proposed extensions to the
searches that would require changes to be made in the presentation as
well.  This is not a problem, we just need to make sure that the changes
happen in both places.

I think we're in violent agreement ;)

-pate

>
> My two main priorities were : having a generic MARC structure to be able
> to accept any MARC format, and having a structure that enables fast
> searches on medium-big libraries.
> --
> Paul
>
>




From paul.poulain at free.fr  Wed May  8 09:09:28 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May  8 09:09:28 2002
Subject: [Koha-devel] proposition for MARC version
References: <Pine.LNX.4.30.0205081118140.1606-100000@bigfun.whirlycott.com>
Message-ID: <3CD944A6.10108@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020508/14c9faf5/attachment.htm 

From pate at eylerfamily.org  Wed May  8 09:11:33 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 09:11:33 2002
Subject: [Koha-devel] proposition for MARC version
In-Reply-To: <3CD944A6.10108@free.fr>
Message-ID: <Pine.LNX.4.30.0205081133160.2304-100000@bigfun.whirlycott.com>

On Wed, 8 May 2002, paul POULAIN wrote:

> Pat Eyler wrote:
> > I think we're in violent agreement ;)
>
> we are ;-)
>

Great.

> Next question : when will we decide to use html::template or a similar
> tool for koha. It's a must have to separate presentation from business
> logic.

Let's decide this in our IRC meeting.  Before then, we should certainly
kick it about.

html::template, AxKit, Mason, others?  are all possible tools.  I'm
tempted to say that html::template is the best way to go, but I don't have
enough experience with any of them to make a strong statement.

Would someone like to code up a simple page or two in all three (and any
others you want) so we can see what we'd be looking at?  Also, if would be
nice to know what requirements we'd be adding.  (AxKit requires mod_perl,
Mason strongly recommends it.)

-pate

> Chris agrees to say AxKit is too heavy for us, so the best choice is
> html::template.
> --
> Paul
>
>
>




From chris at katipo.co.nz  Wed May  8 14:34:04 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Wed May  8 14:34:04 2002
Subject: [Koha-devel] [Fwd: Re: Some Info on KOHA]
Message-ID: <1020893670.13025.19.camel@orbweb.katipo.co.nz>

Forwarding, FYI, and if anyone has time to answer any of the questions.
If not, ill have a crack at them after work today.

Chris

----Forwarded Message-----

> From: Rosalie Blake <rosalie at library.org.nz>
> To: Olugbenga Adara <gbengaadara at yahoo.com>
> Cc: chris Cormack <chris at katipo.co.nz>
> Subject: Re: Some Info on KOHA
> Date: 09 May 2002 09:19:46 +1200
> 
> Hello Olugbenga,
> 
> On 8 May 2002, at 10:03, Olugbenga Adara wrote:
> 
> > I have seen, downloaded and briefly evaluated Koha
> > some 12 months ago. But now I am thinking of
> > introducing koha to a University Library (Obafemi
> > Awolowo University, Ile-Ife ) here in Nigeria. I would
> > like to know the following things please
> > 
> > 1. Can Koha be used without barcodes ? Presently the
> > library does not use any barcode and i wonder whether
> > other means may be used.
> Yes, definitely. If you want to use it for circulation, you need some 
> identifier which is unique to every item you want to issue, but you 
> possibly have an accession number of some sort. There is no 
> reason you shouldn't use that. We use barcodes because it is 
> quicker to scan a barcode with a reader, than to type a 6-digit or 
> more number. But we frequently just type the barcode number on 
> machines that do not have scanners.
> > 
> > 2. How reliable is the Marc Import tool
> Sorry, I can't answer this. You need to ask this on the koha listserv: 
> koha at lists.katipo.co.nz which you can join by following the leads on 
> http://www.koha.org/mailing_list.html.
> > 
> > 3. The library intends to start computerisation by
> > only using the opac - allowing patrons to search for
> > books. Could Koha function (OPAC) without patron
> > information?
> I think so, although it will not be able to report on whether an item is 
> on issue or available for borrowing. Again, the listserv will give you a 
> more authoritative answer.
> I've copied my reply to Chris Cormack, who was the chief 
> programmer (still is) on Koha. He may add some remarks of his own.
> > 
> > I also want to thank you for the great job you did by
> > releasing koha gpl
> Thank you. We're very proud ot it.
> Good Luck
> Rosalie Blake
> Horowhenua Library Trust
> > 
> > Hope to get your reply soon
> > 
> > thanks
> > 
> > Olugbenga Adara,
> > Ibadan, Nigeria
> > 
> > __________________________________________________
> > Do You Yahoo!?
> > Yahoo! Health - your guide to health and wellness
> > http://health.yahoo.com
> 
> 
-- 



From pate at eylerfamily.org  Wed May  8 15:19:03 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 15:19:03 2002
Subject: [Koha-devel] irc meeting tomorrow
Message-ID: <Pine.LNX.4.30.0205081812310.6370-100000@bigfun.whirlycott.com>

After a brief poll on the irc channel, we've come up with a tentative
start time of 2PM Katipo Time (GMT+12).  This seems to incovenience the
majority of the people the least (sorry Sergey and Paul).  We can either
run with Nick's full blown agenda, or the shorter one I proposed and just
plan on more meetings to hit all the items.

Rachel, you seem to be the logical chair for the meeting, what do you
think?  Anyone else?

-pate




From rog at saas.nsw.edu.au  Wed May  8 16:12:06 2002
From: rog at saas.nsw.edu.au (Roger Buck)
Date: Wed May  8 16:12:06 2002
Subject: [Koha-devel] [Fwd: Re: Some Info on KOHA]
References: <1020893670.13025.19.camel@orbweb.katipo.co.nz>
Message-ID: <3CD9B0B3.4881977C@saas.nsw.edu.au>

> From: Rosalie Blake <rosalie at library.org.nz>
> To: Olugbenga Adara <gbengaadara at yahoo.com>
> Cc: chris Cormack <chris at katipo.co.nz>

[--snip--]

> > 3. The library intends to start computerisation by
> > only using the opac - allowing patrons to search for
> > books. Could Koha function (OPAC) without patron
> > information?
> I think so, although it will not be able to report
> on whether an item is on issue or available for borrowing.

What we have:
 Three levels of access:

 1. OPAC browse only - anyone can access catalogue for search only.

 2. OPAC browse and request only - Members must log in using personal
username and password. Users can register on-line and make on-line
requests. Details of all requests are recorded in database and email
notification sent to library admins (including details such as graphical
and alphanumeric barcodes, hot links to user accounts, current request
lists etc. If you don't want to use swipeable barcodes you can still use
barcode numbers and enter/view them in human readable format.

 3. All the standard koha and opac stuff using unmodified distribution
to access a unified database.

What we have done:
We have reorganized the "standard" koha distribution so that we can run
"public" and "private" versions side-by-side on same server but
protected by Apache/MySQL (in our case, mod_auth_mysql) authentication.
The "public" opac is a modified sub-set of the "standard" koha
distribution, plus some extra perl scripts, javascript, cookies and
soupermail for email integration purposes (soupermail.sourceforge.net)



Main Benefits:
 Can provide a complete on-line environment with no requirement for
users to physically attend library (items are sent to borrowers by
standard mail).

 Staff can track status of reserves, borrowings etc (users can do that
too if you want to allow it).

Seems to work ;^)



Main Liabilities:
 Privacy and security are _major_ issues. It is very difficult to
maintain a detailed,web-accessible database and still protect your users
to the extent that they deserve!

 Our approach to solving these issues is to simply by minimise the
amount of information stored in your database. Apart from information
about resources, our on-line database only stores member username and
password details... minimal additional information (such as email
address) is stored using cookies (not stored in server database).

 This is _much_ less than most library admins would accept... and it is
very inefficient... but it allows us to provide a good service to users
and we are willing to accept the administrative limitations until we
have time to develop a better solution to address on-line privacy and
security issues



Summary:
 The opac options described above need more work to provide a
"professional" solution - but they do work.

 It is possible to run OPAC web based services using minimal user
information in the database. Patron information (stored in on-line
database) is only required if you wish to provide on-line requests
and/or other extended services.

 We have only just started testing the setup as described above, but
looks like it will work for our specific needs -  about 6,000 items and
1,500 geographically remote library members - resource library
specialising in resources for k-12 learning difficulties.

 We'd like to see the extended web access features as part of Koha main
distribution but we have been holding off as we think Kapito/others are
already working on some of these extended features... and that they will
do a much better job than us :)

I can organise a tarball (upload to CVS or whatever) if anyone is
interested.

R.



From pate at eylerfamily.org  Wed May  8 16:27:05 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May  8 16:27:05 2002
Subject: [Koha-devel] development &c
In-Reply-To: <3CD9B0B3.4881977C@saas.nsw.edu.au>
Message-ID: <Pine.LNX.4.30.0205081921500.7785-100000@bigfun.whirlycott.com>

On Thu, 9 May 2002, Roger Buck wrote:

>
>  We'd like to see the extended web access features as part of Koha main
> distribution but we have been holding off as we think Kapito/others are
> already working on some of these extended features... and that they will
> do a much better job than us :)

I'd love to see these features.  If you don't feel comfortable releasing
them into the mainline tree, you could always create a branch and let
katipo (or whoever) merge bits into the mainline (or into
rel_1_2) selectively.

-pate

>
> R.
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From truth_nz at users.sourceforge.net  Wed May  8 18:08:03 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Wed May  8 18:08:03 2002
Subject: [Koha-devel] CVS: koha/C4 Acquisitions.pm,1.7,1.8 Output.pm,1.6,1.7 Search.pm,1.21,1.22
Message-ID: <E175cPC-0005jf-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/C4
In directory usw-pr-cvs1:/tmp/cvs-serv21556

Modified Files:
	Acquisitions.pm Output.pm Search.pm 
Log Message:
Update to catalogue to allow change of biblio abstracts.
Related modifications to acqui system to match changes in Acquisition.pm
detail.pm changed to show abstract - still working on how to show url's


Index: Acquisitions.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Acquisitions.pm,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -r1.7 -r1.8
*** Acquisitions.pm	3 May 2002 02:47:33 -0000	1.7
--- Acquisitions.pm	9 May 2002 01:07:36 -0000	1.8
***************
*** 339,356 ****
  
  sub branches {
!   my $dbh=C4Connect;
!   my $query="Select * from branches";
!   my $sth=$dbh->prepare($query);
!   $sth->execute;
!   my @results;
!   my $i=0;
!   while (my $data=$sth->fetchrow_hashref){
!     $results[$i]=$data;
!     $i++;
!   }
!   $sth->finish;
!   $dbh->disconnect;
!   return($i, at results);
! }
  
  sub bookfundbreakdown {
--- 339,358 ----
  
  sub branches {
!     my $dbh   = C4Connect;
!     my $query = "Select * from branches";
!     my $sth   = $dbh->prepare($query);
!     my $i     = 0;
!     my @results;
! 
!     $sth->execute;
!     while (my $data = $sth->fetchrow_hashref) {
!         $results[$i] = $data;
!     	$i++;
!     } # while
! 
!     $sth->finish;
!     $dbh->disconnect;
!     return($i, @results);
! } # sub branches
  
  sub bookfundbreakdown {
***************
*** 420,436 ****
  }
  
  sub modbiblio {
!   my ($bibnum, $title, $author, $copyright, $seriestitle, $serial, $unititle, $notes)=@_;
    my $dbh   = C4Connect;
!   my $query = "Update biblio set
! title         = '$title',
! author        = '$author',
! copyrightdate = '$copyright',
! seriestitle   = '$seriestitle',
! serial        = '$serial',
! unititle      = '$unititle',
! notes         = '$notes'
! where biblionumber = $bibnum";
!   my $sth   = $dbh->prepare($query);
  
    $sth->execute;
--- 422,452 ----
  }
  
+ 
  sub modbiblio {
!   my ($biblio) = @_;
    my $dbh   = C4Connect;
!   my $query;
!   my $sth;
!   
!   $biblio->{'title'}         = $dbh->quote($biblio->{'title'});
!   $biblio->{'author'}        = $dbh->quote($biblio->{'author'});
!   $biblio->{'abstract'}      = $dbh->quote($biblio->{'abstract'});
!   $biblio->{'copyrightdate'} = $dbh->quote($biblio->{'copyrightdate'});
!   $biblio->{'seriestitle'}   = $dbh->quote($biblio->{'serirestitle'});
!   $biblio->{'serial'}        = $dbh->quote($biblio->{'serial'});
!   $biblio->{'unititle'}      = $dbh->quote($biblio->{'unititle'});
!   $biblio->{'notes'}         = $dbh->quote($biblio->{'notes'});
! 
!   $query = "Update biblio set
! title         = $biblio->{'title'},
! author        = $biblio->{'author'},
! abstract      = $biblio->{'abstract'},
! copyrightdate = $biblio->{'copyrightdate'},
! seriestitle   = $biblio->{'seriestitle'},
! serial        = $biblio->{'serial'},
! unititle      = $biblio->{'unititle'},
! notes         = $biblio->{'notes'}
! where biblionumber = $biblio->{'biblionumber'}";
!   $sth   = $dbh->prepare($query);
  
    $sth->execute;
***************
*** 438,453 ****
    $sth->finish;
    $dbh->disconnect;
!   return($bibnum);
! }
  
  sub modsubtitle {
!   my ($bibnum,$subtitle)=@_;
!   my $dbh=C4Connect;
!   my $query="update bibliosubtitle set subtitle='$subtitle' where biblionumber=$bibnum";
!   my $sth=$dbh->prepare($query);
    $sth->execute;
    $sth->finish;
    $dbh->disconnect;
! }
  
  sub modaddauthor {
--- 454,474 ----
    $sth->finish;
    $dbh->disconnect;
!   return($biblio->{'biblionumber'});
! } # sub modbiblio
! 
  
  sub modsubtitle {
!   my ($bibnum, $subtitle) = @_;
!   my $dbh   = C4Connect;
!   my $query = "update bibliosubtitle set
! subtitle = '$subtitle'
! where biblionumber = $bibnum";
!   my $sth   = $dbh->prepare($query);
! 
    $sth->execute;
    $sth->finish;
    $dbh->disconnect;
! } # sub modsubtitle
! 
  
  sub modaddauthor {
***************
*** 476,537 ****
  
  sub modsubject {
!   my ($bibnum,$force, at subject)=@_;
!   my $dbh=C4Connect;
!   my $count=@subject;
    my $error;
!   for (my $i=0;$i<$count;$i++){
!     $subject[$i]=~ s/^ //g;
!     $subject[$i]=~ s/ $//g;
!     my $query="select * from catalogueentry where entrytype='s' and
!     catalogueentry='$subject[$i]'";
!     my $sth=$dbh->prepare($query);
      $sth->execute;
!     if (my $data=$sth->fetchrow_hashref){
!       
      } else {
!       if ($force eq $subject[$i]){
!          #subject not in aut, chosen to force anway
! 	 #so insert into cataloguentry so its in auth file
! 	 $query="Insert into catalogueentry (entrytype,catalogueentry)
! 	 values ('s','$subject[$i]')";
! 	 my $sth2=$dbh->prepare($query);
! #	 print $query;
  	 $sth2->execute;
  	 $sth2->finish;
!       } else {      
!         $error="$subject[$i]\n does not exist in the subject authority file";
!         $query= "Select * from catalogueentry where
!         entrytype='s' and (catalogueentry like '$subject[$i] %' or 
!         catalogueentry like '% $subject[$i] %' or catalogueentry like
!         '% $subject[$i]')";
!         my $sth2=$dbh->prepare($query);
! #        print $query;
          $sth2->execute;
!         while (my $data=$sth2->fetchrow_hashref){
!           $error=$error."<br>$data->{'catalogueentry'}";
!         }
          $sth2->finish;
! #       $error=$error."<br>$query";
!      }
!    }
      $sth->finish;
!   }
!   if ($error eq ''){  
!     my $query="Delete from bibliosubject where biblionumber=$bibnum";
! #  print $query;
!     my $sth=$dbh->prepare($query);
! #  print $query;
      $sth->execute;
      $sth->finish;
!     for (my $i=0;$i<$count;$i++){
!       $sth=$dbh->prepare("Insert into bibliosubject values ('$subject[$i]',$bibnum)");
! #     print $subject[$i];
        $sth->execute;
        $sth->finish;
!     }
!   }
    $dbh->disconnect;
    return($error);
! }
  
  sub modbibitem {
--- 497,566 ----
  
  sub modsubject {
!   my ($bibnum, $force, @subject) = @_;
!   my $dbh   = C4Connect;
!   my $count = @subject;
    my $error;
!   for (my $i = 0; $i < $count; $i++) {
!     $subject[$i] =~ s/^ //g;
!     $subject[$i] =~ s/ $//g;
!     my $query = "select * from catalogueentry
! where entrytype = 's'
! and catalogueentry = '$subject[$i]'";
!     my $sth   = $dbh->prepare($query);
      $sth->execute;
! 
!     if (my $data = $sth->fetchrow_hashref) {
      } else {
!       if ($force eq $subject[$i]) {
! 
!          # subject not in aut, chosen to force anway
!          # so insert into cataloguentry so its in auth file
! 	 $query = "Insert into catalogueentry
! (entrytype,catalogueentry)
! values ('s','$subject[$i]')";
! 	 my $sth2 = $dbh->prepare($query);
! 
  	 $sth2->execute;
  	 $sth2->finish;
! 
!       } else {
! 
!         $error = "$subject[$i]\n does not exist in the subject authority file";
!         $query = "Select * from catalogueentry
! where entrytype = 's'
! and (catalogueentry like '$subject[$i] %'
! or catalogueentry like '% $subject[$i] %'
! or catalogueentry like '% $subject[$i]')";
!         my $sth2 = $dbh->prepare($query);
! 
          $sth2->execute;
!         while (my $data = $sth2->fetchrow_hashref) {
!           $error = $error."<br>$data->{'catalogueentry'}";
!         } # while
          $sth2->finish;
!       } # else
!     } # else
      $sth->finish;
!   } # else
! 
!   if ($error eq '') {
!     my $query = "Delete from bibliosubject where biblionumber = $bibnum";
!     my $sth   = $dbh->prepare($query);
! 
      $sth->execute;
      $sth->finish;
! 
!     for (my $i = 0; $i < $count; $i++) {
!       $sth = $dbh->prepare("Insert into bibliosubject
! values ('$subject[$i]', $bibnum)");
! 
        $sth->execute;
        $sth->finish;
!     } # for
!   } # if
! 
    $dbh->disconnect;
    return($error);
! } # sub modsubject
  
  sub modbibitem {

Index: Output.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Output.pm,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -r1.6 -r1.7
*** Output.pm	21 Apr 2002 04:45:21 -0000	1.6
--- Output.pm	9 May 2002 01:07:36 -0000	1.7
***************
*** 216,229 ****
  }
  
! sub mkform3{
!   my ($action,%inputs)=@_;
!   my $string="<form action=$action method=post>\n";
!   $string=$string.mktablehdr();
    my $key;
!   my @keys=sort keys %inputs;
    my @order;  
!   my $count=@keys;
!   my $i2=0;
!   while ( $i2<$count) {
      my $value=$inputs{$keys[$i2]};
      my @data=split('\t',$value);
--- 216,229 ----
  }
  
! sub mkform3 {
!   my ($action, %inputs) = @_;
!   my $string = "<form action=\"$action\" method=\"post\">\n";
!   $string   .= mktablehdr();
    my $key;
!   my @keys = sort(keys(%inputs));
    my @order;  
!   my $count = @keys;
!   my $i2 = 0;
!   while ($i2 < $count) {
      my $value=$inputs{$keys[$i2]};
      my @data=split('\t',$value);

Index: Search.pm
===================================================================
RCS file: /cvsroot/koha/koha/C4/Search.pm,v
retrieving revision 1.21
retrieving revision 1.22
diff -C2 -r1.21 -r1.22
*** Search.pm	7 May 2002 00:08:20 -0000	1.21
--- Search.pm	9 May 2002 01:07:36 -0000	1.22
***************
*** 726,751 ****
  
  sub bibdata {
!   my ($bibnum,$type)=@_;
!   my $dbh=C4Connect;
!   my $query="Select *,biblio.notes  
!   from biblio,biblioitems 
!   left join bibliosubtitle on                                                
!   biblio.biblionumber=bibliosubtitle.biblionumber
!   
!   where biblio.biblionumber=$bibnum
!   and biblioitems.biblionumber=$bibnum"; 
! #  print $query;
!   my $sth=$dbh->prepare($query);
    $sth->execute;
!   my $data=$sth->fetchrow_hashref;
    $sth->finish;
!   $query="Select * from bibliosubject where biblionumber='$bibnum'";
    $sth=$dbh->prepare($query);
    $sth->execute;
!   while (my $dat=$sth->fetchrow_hashref){
!     $data->{'subject'}.=" | $dat->{'subject'}";
  
    }
!   #print $query;
    $sth->finish;
    $dbh->disconnect;
--- 726,751 ----
  
  sub bibdata {
!   my ($bibnum, $type)=@_;
!   my $dbh   = C4Connect;
!   my $query = "Select *, biblio.notes  
! from biblio, biblioitems 
! left join bibliosubtitle on
! biblio.biblionumber = bibliosubtitle.biblionumber
! where biblio.biblionumber = $bibnum
! and biblioitems.biblionumber = $bibnum";
! 
!   my $sth   = $dbh->prepare($query);
    $sth->execute;
!   my $data  = $sth->fetchrow_hashref;
    $sth->finish;
! 
!   $query = "Select * from bibliosubject where biblionumber = '$bibnum'";
    $sth=$dbh->prepare($query);
    $sth->execute;
!   while (my $dat = $sth->fetchrow_hashref){
!     $data->{'subject'} .= " | $dat->{'subject'}";
  
    }
! 
    $sth->finish;
    $dbh->disconnect;




From truth_nz at users.sourceforge.net  Wed May  8 20:02:02 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Wed May  8 20:02:02 2002
Subject: [Koha-devel] CVS: koha/acqui addorder.pl,1.3,1.4 finishreceive.pl,1.2,1.3
Message-ID: <E175eBa-0004JB-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha/acqui
In directory usw-pr-cvs1:/tmp/cvs-serv16527/acqui

Modified Files:
	addorder.pl finishreceive.pl 
Log Message:
Update to catalogue to allow change of biblio abstracts.
Related modifications to acqui system to match changes in Acquisition.pm
detail.pm changed to show abstract - still working on how to show url's


Index: addorder.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui/addorder.pl,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -r1.3 -r1.4
*** addorder.pl	15 Apr 2002 05:33:33 -0000	1.3
--- addorder.pl	9 May 2002 03:01:40 -0000	1.4
***************
*** 8,18 ****
  use C4::Output;
  use C4::Acquisitions;
- #use Date::Manip;
  
  my $input = new CGI;
- #print $input->header;
- #print startpage();
- #print startmenu('acquisitions');
- #print $input->dump;
  my $existing=$input->param('existing');
  my $title=$input->param('title');
--- 8,13 ----
***************
*** 40,44 ****
  my $ecost=$input->param('ecost');
  my $gst=$input->param('GST');
- #check to see if orderexists
  my $orderexists=$input->param('orderexists');
  
--- 35,38 ----
***************
*** 48,59 ****
    if ($existing eq 'no'){
      #if it doesnt create it
!     $bibnum = &newbiblio({ title     => $title,
! 	                   author    =>$author,
! 	                   copyright => $copyright });
      $bibitemnum = &newbiblioitem({ biblionumber => $bibnum,
!  	                           itemtype     => $itemtype,
! 	                           isben        => $isbn });
      newsubtitle($bibnum);
!     modbiblio($bibnum,$title,$author,$copyright,$series);
    } else {
      $bibnum=$input->param('biblio');
--- 42,57 ----
    if ($existing eq 'no'){
      #if it doesnt create it
!     $bibnum = &newbiblio({ title     => $title?$title:"",
! 	                   author    => $author?$author:"",
! 	                   copyright => $copyright?$copyright:"" });
      $bibitemnum = &newbiblioitem({ biblionumber => $bibnum,
!  	                           itemtype     => $itemtype?$itemtype:"",
! 	                           isben        => $isbn?$isbn:"" });
      newsubtitle($bibnum);
!     modbiblio({ biblionumber  => $bibnum,
! 	        title         => $title?$title:"",
! 	        author        => $author?$author:"",
! 	        copyrightdate => $copyright?$copyright:"",
! 	        series        => $series?$series:"" });
    } else {
      $bibnum=$input->param('biblio');
***************
*** 63,69 ****
        $bibitemnum=newbiblioitem($bibnum,$itemtype,$isbn);
      }
!     modbiblio($bibnum,$title,$author,$copyright,$series);
    }
!   if ($orderexists ne ''){
      modorder($title,$ordnum,$quantity,$listprice,$bibnum,$basketno,$supplier,$who,$notes,$bookfund,$bibitemnum,$rrp,$ecost,$gst);
    }else {
--- 61,71 ----
        $bibitemnum=newbiblioitem($bibnum,$itemtype,$isbn);
      }
!     modbiblio({ biblionumber  => $bibnum,
! 	        title         => $title?$title:"",
! 	        author        => $author?$author:"",
! 	        copyrightdate => $copyright?$copyright:"",
! 	        series        => $series?$series:"" });
    }
!   if ($orderexists ne '') {
      modorder($title,$ordnum,$quantity,$listprice,$bibnum,$basketno,$supplier,$who,$notes,$bookfund,$bibitemnum,$rrp,$ecost,$gst);
    }else {
***************
*** 71,76 ****
    }
  } else {
-   #print $input->header;
-   #print "del";
    $bibnum=$input->param('biblio');
    delorder($bibnum,$ordnum);
--- 73,76 ----
***************
*** 78,82 ****
  
  print $input->redirect("newbasket.pl?id=$supplier&basket=$basketno");
- #print $input->dump;
- #print endmenu('acquisitions');
- #print endpage();
--- 78,79 ----

Index: finishreceive.pl
===================================================================
RCS file: /cvsroot/koha/koha/acqui/finishreceive.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -r1.2 -r1.3
*** finishreceive.pl	29 Apr 2002 05:25:41 -0000	1.2
--- finishreceive.pl	9 May 2002 03:01:40 -0000	1.3
***************
*** 14,18 ****
  my $user=$input->remote_user;
  #print $input->dump;
! my $biblio=$input->param('biblio');
  my $ordnum=$input->param('ordnum');
  my $quantrec=$input->param('quantityrec');
--- 14,18 ----
  my $user=$input->remote_user;
  #print $input->dump;
! my $biblionumber = $input->param('biblio');
  my $ordnum=$input->param('ordnum');
  my $quantrec=$input->param('quantityrec');
***************
*** 21,25 ****
  my $cost=$input->param('cost');
  my $invoiceno=$input->param('invoice');
- my $id=$input->param('id');
  my $bibitemno=$input->param('biblioitemnum');
  my $data=bibitemdata($bibitemno);
--- 21,24 ----
***************
*** 38,47 ****
  my $itemtype=$input->param('format');
  my $isbn=$input->param('ISBN');
! my $series=$input->param('Series');
! my $bookseller=$input->param('bookseller');
! $id=$bookseller;
! my $title=$input->param('title');
! my $author=$input->param('author');
! my $copyright=$input->param('copyright');
  
  if ($quantrec != 0){
--- 37,49 ----
  my $itemtype=$input->param('format');
  my $isbn=$input->param('ISBN');
! my $bookseller = $input->param('bookseller');
! my $id         = $bookseller;
! my $biblio = {
!     biblionumber  => $biblionumber,
!     title         => $input->param('title')?$input->param('title'):"",
!     author        => $input->param('author')?$input->param('author'):"",
!     copyrightdate => $input->param('copyright')?$input->param('copyright'):"",
!     series        => $input->param('Series')?$input->param('Series'):""
! }; # my $biblio
  
  if ($quantrec != 0){
***************
*** 60,69 ****
  #  print "$bibitemno";
    $class="Periodical";
!   $bibitemno=newbiblioitem($biblio,$itemtype,$isbn,$volinf,$class);
  #  print "here $bibitemno";
  }
  if ($quantity != 0){
!   receiveorder($biblio,$ordnum,$quantrec,$user,$cost,$invoiceno,$bibitemno,$freight,$bookfund);
!   modbiblio($biblio,$title,$author,$copyright,$series);
    modbibitem($bibitemno,$itemtype,$isbn,$publisher,$pubdate,$class,$dewey,$subclass,$illus,$pages,$volinf,$notes,$size);
    #print $notes;
--- 62,71 ----
  #  print "$bibitemno";
    $class="Periodical";
!   $bibitemno=newbiblioitem($biblionumber,$itemtype,$isbn,$volinf,$class);
  #  print "here $bibitemno";
  }
  if ($quantity != 0){
!   receiveorder($biblionumber,$ordnum,$quantrec,$user,$cost,$invoiceno,$bibitemno,$freight,$bookfund);
!   modbiblio($biblio);
    modbibitem($bibitemno,$itemtype,$isbn,$publisher,$pubdate,$class,$dewey,$subclass,$illus,$pages,$volinf,$notes,$size);
    #print $notes;
***************
*** 81,85 ****
    }
    my ($error) = newitems({ biblioitemnumber => $bibitemno,
! 	                   biblionumber     => $biblio,
  	                   replacementprice => $replacement,
  	                   price            => $cost,
--- 83,87 ----
    }
    my ($error) = newitems({ biblioitemnumber => $bibitemno,
! 	                   biblionumber     => $biblionumber,
  	                   replacementprice => $replacement,
  	                   price            => $cost,
***************
*** 100,104 ****
  } else {
    print $input->header;
!   delorder($biblio,$ordnum);
         print $input->redirect("/acquisitions/");
  }
--- 102,106 ----
  } else {
    print $input->header;
!   delorder($biblionumber,$ordnum);
         print $input->redirect("/acquisitions/");
  }




From truth_nz at users.sourceforge.net  Wed May  8 20:02:03 2002
From: truth_nz at users.sourceforge.net (Gynn Lomax)
Date: Wed May  8 20:02:03 2002
Subject: [Koha-devel] CVS: koha detail.pl,1.4,1.5 modbib.pl,1.1.1.1,1.2 updatebiblio.pl,1.1.1.1,1.2
Message-ID: <E175eBa-0004J5-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv16527

Modified Files:
	detail.pl modbib.pl updatebiblio.pl 
Log Message:
Update to catalogue to allow change of biblio abstracts.
Related modifications to acqui system to match changes in Acquisition.pm
detail.pm changed to show abstract - still working on how to show url's


Index: detail.pl
===================================================================
RCS file: /cvsroot/koha/koha/detail.pl,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -r1.4 -r1.5
*** detail.pl	3 May 2002 02:47:33 -0000	1.4
--- detail.pl	9 May 2002 03:01:40 -0000	1.5
***************
*** 14,31 ****
  my $title = $input->param('title');
  my @items = &ItemInfo(undef, $bib, $type);
  my $dat   = &bibdata($bib);
  my $count = @items;
! my ($count3, $addauthor) = &addauthor($bib);
  my $additional = $addauthor->[0]->{'author'};
- my @temp       = split('\t', $items[0]);
  my $main;
  my $secondary;
  
! if ($type eq ''){
      $type = 'opac';
  } # if
  
  # setup colours
! if ($type eq 'opac'){
      $main      = '#99cccc';
      $secondary = '#efe5ef';
--- 14,33 ----
  my $title = $input->param('title');
  my @items = &ItemInfo(undef, $bib, $type);
+ my @temp  = split('\t', $items[0]);
  my $dat   = &bibdata($bib);
  my $count = @items;
! my ($authorcount, $addauthor) = &addauthor($bib);
  my $additional = $addauthor->[0]->{'author'};
  my $main;
  my $secondary;
+ my $colour;
  
! 
! if ($type eq '') {
      $type = 'opac';
  } # if
  
  # setup colours
! if ($type eq 'opac') {
      $main      = '#99cccc';
      $secondary = '#efe5ef';
***************
*** 34,37 ****
--- 36,44 ----
      $secondary = '#ffffcc';
  } # else
+ $colour = $secondary;
+ 
+ for (my $i = 1; $i < $authorcount; $i++) {
+     $additional .= "|" . $addauthor->[$i]->{'author'};
+ } # for
  
  print $input->header;
***************
*** 41,52 ****
  if ($type ne 'opac'){
      print << "EOF";
! <a href=request.pl?bib=$bib><img height=42  WIDTH=120 BORDER=0 src=\"/images/requests.gif\" align=right border=0></a>
  EOF
  } # if
  
- for (my $i = 1; $i < $count3; $i++) {
-     $additional .= "|" . $addauthor->[$i]->{'author'};
- } # for
- 
  if ($type eq 'catmain'){
    print mkheadr(3,"Catalogue Maintenance");
--- 48,55 ----
  if ($type ne 'opac'){
      print << "EOF";
! <a href=request.pl?bib=$bib><img height=42  WIDTH=120 BORDER="0" src=\"/images/requests.gif\" align="right" border="0"></a>
  EOF
  } # if
  
  if ($type eq 'catmain'){
    print mkheadr(3,"Catalogue Maintenance");
***************
*** 57,97 ****
  } else {
    print mkheadr(3,"$dat->{'title'} $temp[4]");
! }
! print << "EOF";
! 
! <TABLE  CELLSPACING=0  CELLPADDING=5 border=1 align=left width="220">
  
  <!-----------------BIBLIO RECORD TABLE--------->
  
! 
! <form action=/cgi-bin/koha/modbib.pl method=post>
! <input type=hidden name=bibnum value=$bib>
! <TR VALIGN=TOP>
! 
! <td  bgcolor="$main" 
  EOF
  
- if ($type ne 'opac'){
-  print "background=\"/images/background-mem.gif\"";
- }
  print << "EOF";
! ><B>BIBLIO RECORD 
  EOF
  
! if ($type ne 'opac'){
    print "$bib";
  }
- print << "EOF";
- </TD></TR>
  
  
! <tr VALIGN=TOP  >
! <TD>
  EOF
  
- if ($type ne 'opac'){
-   print "<INPUT TYPE=\"image\" name=\"submit\"  VALUE=\"modify\" height=42  WIDTH=93 BORDER=0 src=\"/images/modify-mem.gif\"> 
-   <INPUT TYPE=\"image\" name=\"delete\"  VALUE=\"delete\" height=42  WIDTH=93 BORDER=0 src=\"/images/delete-mem.gif\">";
- }
  print << "EOF";
  <br>
--- 60,106 ----
  } else {
    print mkheadr(3,"$dat->{'title'} $temp[4]");
! } # if
  
+ print << "EOF";
+ <table cellspacing="0" callpadding="5" border="1" align="left" width="220">
  <!-----------------BIBLIO RECORD TABLE--------->
+ <tr valign="top">
+ EOF
  
! if ($type ne 'opac') {
!     print << "EOF";
! <td bgcolor="$main" background="/images/background-mem.gif">
  EOF
+ } else {
+     print << "EOF";
+ <td bgcolor="$main">
+ EOF
+ } # else
  
  print << "EOF";
! <b>BIBLIO RECORD</b>
  EOF
  
! if ($type ne 'opac') {
    print "$bib";
  }
  
+ print << "EOF";
+ </td>
+ </tr>
+ <tr valign="top">
+ <td>
+ EOF
  
! if ($type ne 'opac') {
!   print << "EOF";
! <form action="/cgi-bin/koha/modbib.pl" method="post">
! <input type="hidden" name="bibnum" value="$bib">
! <input type="image" name="submit" value="modify" height="42" width="93" border="0" src="/images/modify-mem.gif"> 
! <input type="image" name="delete" value="delete" height="42" width="93" border="0" src="/images/delete-mem.gif">
! </form>
  EOF
+ } # if
  
  print << "EOF";
  <br>
***************
*** 100,105 ****
  
  
! if ($type ne 'opac'){
! print << "EOF";
  <b>Subtitle:</b> $dat->{'subtitle'}<br>
  <b>Author:</b> $dat->{'author'}<br>
--- 109,114 ----
  
  
! if ($type ne 'opac') {
!     print << "EOF";
  <b>Subtitle:</b> $dat->{'subtitle'}<br>
  <b>Author:</b> $dat->{'author'}<br>
***************
*** 117,247 ****
  EOF
  
! }
! else {
! if ($dat->{'subtitle'} ne ''){
!   print "<b>Subtitle:</b> $dat->{'subtitle'}<br>";
! }
! if ($dat->{'author'} ne ''){
!   print "<b>Author:</b> $dat->{'author'}<br>";
! }
! #Additional Author: <br>
! if ($dat->{'seriestitle'} ne ''){
!   print "<b>Seriestitle:</b> $dat->{'seriestitle'}<br>";
! }
! if ($dat->{'subject'} ne ''){
!   print "<b>Subject:</b> $dat->{'subject'}<br>";
! }
! if ($dat->{'copyrightdate'} ne ''){
!   print "<b>Copyright:</b> $dat->{'copyrightdate'}<br>";
! }
! if ($dat->{'notes'} ne ''){
!   print "<b>Notes:</b> $dat->{'notes'}<br>";
! }
! if ($dat->{'unititle'} ne ''){
!   print "<b>Unititle:</b> $dat->{'unititle'}<br>";
! }
! #Analytical Author: <br>
! #Analytical Title: <br>
! if ($dat->{'serial'} ne '0'){
!  print "<b>Serial:</b> Yes<br>";
! }
! print "<b>Total Number of Items:</b> $count
  <p>
! ";
  
- }
  print << "EOF";
! </form>
! </font></TD>
! </TR>
  
! </TABLE>
! <img src="/images/holder.gif" width=16 height=300 align=left>
  EOF
  
- my $i=0;
  print center();
  print mktablehdr;
- if ($type eq 'opac'){
  
!   print mktablerow(6,$main,'Item Type','Class','Branch','Date Due','Last Seen'); 
  } else {
!   print mktablerow(6,$main,'Itemtype','Class','Location','Date Due','Last Seen','Barcode',"/images/background-mem.gif"); 
! }
! my $colour=1;
! while ($i < $count){
  
-   my @results = split('\t', $items[$i]);
-   if ($type ne 'opac'){
-     $results[1]=mklink("/cgi-bin/koha/moredetail.pl?item=$results[5]&bib=$bib&bi=$results[8]&type=$type",$results[1]);
-   }
-   if ($results[2] eq ''){
-     $results[2]='Available';
-   }
-   if ($type eq 'catmain'){
-     $results[10]=mklink("/cgi-bin/koha/maint/catmaintain.pl?type=fixitemtype&bi=$results[8]&item=$results[6]","Fix Itemtype");
-   }
-   if ($colour == 1){
      if ($type ne 'opac'){
!       if ($type eq 'catmain'){
!         print mktablerow(8,$secondary,$results[6],$results[4],$results[3],$results[2],$results[7],$results[1],$results[9],$results[10]);
!       } else {
!         print mktablerow(7,$secondary,$results[6],$results[4],$results[3],$results[2],$results[7],$results[1],$results[9]);
!       }
      } else {
!       $results[6]=ItemType($results[6]);
!       print mktablerow(6,$secondary,$results[6],$results[4],$results[3],$results[2],$results[7],$results[9]);
!     } 
!     $colour=0;                                                                                
!   } else{                                                                                     
!     if ($type ne 'opac'){
!       if ($type eq 'catmain'){
!         print mktablerow(8,'white',$results[6],$results[4],$results[3],$results[2],$results[7],$results[1],$results[9],$results[10]);
!       } else {
!         print mktablerow(7,'white',$results[6],$results[4],$results[3],$results[2],$results[7],$results[1],$results[9]);
!       }
      } else {
!       $results[6]=ItemType($results[6]);
!       print mktablerow(6,'white',$results[6],$results[4],$results[3],$results[2],$results[7],$results[9]);
!     }
!     $colour=1;                                                                                
!   }
!    $i++;
! }
  
  print mktableft();
  print "<p>";
  print mktablehdr();
! if ($type ne 'opac'){
! print << "EOF";
! <TR VALIGN=TOP>
! <TD  bgcolor="99cc33" background="/images/background-mem.gif" colspan=2><p><b>HELP</b><br>
  <b>Update Biblio for all Items:</b> Click on the <b>Modify</b> button [left] to amend the biblio.  Any changes you make will update the record for <b>all</b> the items listed above. <p>
  <b>Updating the Biblio for only ONE or SOME Items:</b> 
  EOF
  
! if ($type eq 'catmain'){
! print << "EOF";
  If some of the items listed above need a different biblio, 
  you need to click on the wrong item, then shift the group it belongs to, to the correct biblio.
  You will need to know the correct biblio number
! <p>
! 
!    </TR>
  EOF
  
! } else {
! print << "EOF";
  If some of the items listed above need a different biblio, or are on the wrong biblio, you must use the <a href="acquisitions/">acquisitions</a> process to fix this. You will need to "re-order" the items, and delete them from this biblio.
! <p>
! 
!    </TR>
  EOF
  
! }
! }
  print mktableft();
  print endcenter();
! print "<br clear=all>";
  print endmenu($type);
  print endpage();
--- 126,292 ----
  EOF
  
! } else {
!     if ($dat->{'subtitle'} ne ''){
! 	print "<b>Subtitle:</b> $dat->{'subtitle'}<br>";
!     } # if
!     if ($dat->{'author'} ne ''){
! 	print "<b>Author:</b> $dat->{'author'}<br>";
!     } # if
! 
! # Additional Author: <br>
!     if ($dat->{'seriestitle'} ne '') {
! 	print "<b>Seriestitle:</b> $dat->{'seriestitle'}<br>";
!     } # if
!     if ($dat->{'subject'} ne '') {
! 	print "<b>Subject:</b> $dat->{'subject'}<br>";
!     } # if
!     if ($dat->{'copyrightdate'} ne '') {
! 	print "<b>Copyright:</b> $dat->{'copyrightdate'}<br>";
!     } # if
!     if ($dat->{'notes'} ne '') {
! 	print "<b>Notes:</b> $dat->{'notes'}<br>";
!     } # if
!     if ($dat->{'unititle'} ne '') {
! 	print "<b>Unititle:</b> $dat->{'unititle'}<br>";
!     } # if
! 
! # Analytical Author: <br>
! # Analytical Title: <br>
!     if ($dat->{'serial'} ne '0') {
! 	print "<b>Serial:</b> Yes<br>";
!     } # if
! 
!     print << "EOF";
! <b>Total Number of Items:</b> $count
  <p>
! EOF
! 
! } # if
  
  print << "EOF";
! </font></td>
! </tr>
! </table>
  
! <img src="/images/holder.gif" width="16" height="300" align="left">
  EOF
  
  print center();
  print mktablehdr;
  
! if ($type eq 'opac') {
!     print mktablerow(6,$main,'Item Type','Class','Branch','Date Due','Last Seen');
!     if ($dat->{'url'} ne '') {
! 	$dat->{'url'} =~ s/^http:\/\///;
! 	print mktablerow(6, $colour, 'Website', 'WEB', 'Online', 'Available', "<a href=\"http://$dat->{'url'}\">$dat->{'url'}</a>");
!     } # if
  } else {
!     print mktablerow(7,$main,'Itemtype','Class','Location','Date Due','Last Seen','Barcode',"","/images/background-mem.gif");
!     if ($dat->{'url'} ne '') {
! 	$dat->{'url'} =~ s/^http:\/\///;
! 	print mktablerow(7, $colour, 'WEB', '', 'Online', 'Available', "<a href=\"http://$dat->{'url'}\">$dat->{'url'}</a>");
!     } # if
! } # else
! 
! $colour = 'white';
! for (my $i = 0; $i < $count; $i ++) {
!     
!     my @results = split('\t', $items[$i]);
! 
!     if ($type ne 'opac') {
! 	$results[1] = mklink("/cgi-bin/koha/moredetail.pl?item=$results[5]&bib=$bib&bi=$results[8]&type=$type",$results[1]);
!     } # if
! 
!     if ($results[2] eq '') {
! 	$results[2] = 'Available';
!     } # if
! 
!     if ($type eq 'catmain'){
! 	$results[10] = mklink("/cgi-bin/koha/maint/catmaintain.pl?type=fixitemtype&bi=$results[8]&item=$results[6]","Fix Itemtype");
!     } # if
  
      if ($type ne 'opac'){
! 	if ($type eq 'catmain'){
! 	    print mktablerow(8,$colour,$results[6],$results[4],$results[3],$results[2],$results[7],$results[1],$results[9],$results[10]);
! 	} else {
! 	    print mktablerow(7,$colour,$results[6],$results[4],$results[3],$results[2],$results[7],$results[1],$results[9]);
! 	} # else
      } else {
! 	$results[6] = ItemType($results[6]);
! 	print mktablerow(6,$colour,$results[6],$results[4],$results[3],$results[2],$results[7],$results[9]);
!     } # else
!     
!     if ($colour eq $secondary) {
! 	$colour = 'white';
      } else {
! 	$colour = $secondary;
!     } # else
! 
! } # for
  
  print mktableft();
  print "<p>";
  print mktablehdr();
! 
! if ($type ne 'opac') {
!     print << "EOF";
! <tr valign="top">
! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan="2"><p><b>HELP</b><br>
  <b>Update Biblio for all Items:</b> Click on the <b>Modify</b> button [left] to amend the biblio.  Any changes you make will update the record for <b>all</b> the items listed above. <p>
  <b>Updating the Biblio for only ONE or SOME Items:</b> 
  EOF
  
!     if ($type eq 'catmain') {
! 	print << "EOF";
  If some of the items listed above need a different biblio, 
  you need to click on the wrong item, then shift the group it belongs to, to the correct biblio.
  You will need to know the correct biblio number
! <p />
! </tr>
  EOF
  
!     } else {
! 	print << "EOF";
  If some of the items listed above need a different biblio, or are on the wrong biblio, you must use the <a href="acquisitions/">acquisitions</a> process to fix this. You will need to "re-order" the items, and delete them from this biblio.
! <p />
! </tr>
  EOF
  
!     } # else
! } # if
! 
  print mktableft();
  print endcenter();
! print << "EOF";
! <br clear=all>
! <p />
! EOF
! 
! if ($type ne 'opac') {
!     print << "EOF";
! <table border="1" cellspacing="0" cellpadding="5" width="90%">
! <tr valign="top">
! <td bgcolor="$main" background="/images/background-mem.gif"><b>Abstract</b></td>
! </tr>
! <tr valign="top">
! <td>$dat->{'abstract'}</td>
! </tr>
! </table>
! EOF
! } else {
!     if ($dat->{'abstract'} ne '') {
! 	print << "EOF";
! <table border="1" cellspacing="0" cellpadding="5" width="90%">
! <tr valign="top">
! <td bgcolor="$main"><b>Abstract</b></td>
! </tr>
! <tr valign="top">
! <td>$dat->{'abstract'}</td>
! </tr>
! </table>
! EOF
!     } # if
! } # else
! 
  print endmenu($type);
  print endpage();

Index: modbib.pl
===================================================================
RCS file: /cvsroot/koha/koha/modbib.pl,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -C2 -r1.1.1.1 -r1.2
*** modbib.pl	19 Dec 2000 23:45:52 -0000	1.1.1.1
--- modbib.pl	9 May 2002 03:01:40 -0000	1.2
***************
*** 13,84 ****
  my $input = new CGI;
  
! my $bibnum=$input->param('bibnum');
! my $data=bibdata($bibnum);
! my ($count,$subject)=subject($data->{'biblionumber'});
! my ($count2,$subtitle)=subtitle($data->{'biblionumber'});
! my ($count3,$addauthor)=addauthor($data->{'biblionumber'});
! my $submit=$input->param('submit.x');                                                                                              
! if ($submit eq ''){                                                                                                                
!   print $input->redirect("/cgi-bin/koha/delbiblio.pl?biblio=$bibnum");                                     
! }  
  
  print $input->header;
! #my ($analytictitle)=analytic($biblionumber,'t');
! #my ($analyticauthor)=analytic($biblionumber,'a');
  print startpage();
  print startmenu();
- my %inputs;
  
! #have to get all subtitles, subjects and additional authors
! my $sub=$subject->[0]->{'subject'};
! for (my $i=1;$i<$count;$i++){
!   $sub=$sub."|".$subject->[$i]->{'subject'};
! }
! my $additional=$addauthor->[0]->{'author'};
! for (my $i=1;$i<$count3;$i++){
!   $additional=$additional."|".$addauthor->[$i]->{'author'};
! }
! 
! 
! #hash is set up with input name being the key then
! #the value is a tab separated list, the first item being the input type
! $inputs{'Author'}="text\t$data->{'author'}\t0";
! $data->{'title'}=tidyhtml($data->{'title'});
! $inputs{'Title'}="text\t$data->{'title'}\t1";
! my $dewey = $data->{'dewey'};                                                      
! $dewey =~ s/0+$//;                                                                 
! if ($dewey eq "000.") { $dewey = "";};                                             
! if ($dewey < 10){$dewey='00'.$dewey;}                                              
! if ($dewey < 100 && $dewey > 10){$dewey='0'.$dewey;}                               
! if ($dewey <= 0){                                                                  
!   $dewey='';                                                                       
! } 
! $dewey=~ s/\.$//;
! #$inputs{'Class'}="text\t$data->{'classification'}$dewey$data->{'subclass'}\t2";
! #$inputs{'Item Type'}="text\t$data->{'itemtype'}\t3";
! $inputs{'Subject'}="textarea\t$sub\t4";
! #$inputs{'Publisher'}="text\t$data->{'publishercode'}\t5";
! $inputs{'Copyright date'}="text\t$data->{'copyrightdate'}\t6";
! #$inputs{'ISBN'}="text\t$data->{'isbn'}\t7";
! #$inputs{'Publication Year'}="text\t$data->{'publicationyear'}\t8";
! #$inputs{'Pages'}="text\t$data->{'pages'}\t9";
! #$inputs{'Illustrations'}="text\t$data->{'illustration'}\t10";
! $inputs{'Series Title'}="text\t$data->{'seriestitle'}\t11";
! $inputs{'Additional Author'}="text\t$additional\t12";
! $inputs{'Subtitle'}="text\t$subtitle->[0]->{'subtitle'}\t13";
! $inputs{'Unititle'}="text\t$data->{'unititle'}\t14";
! $inputs{'Notes'}="textarea\t$data->{'notes'}\t15";
! $inputs{'Serial'}="text\t$data->{'serial'}\t16";
! #$inputs{'Volume'}="text\t$data->{'volumeddesc'}\t17";
! $inputs{'Analytic author'}="text\t\t18";
! $inputs{'Analytic title'}="text\t\t19";
! 
! $inputs{'bibnum'}="hidden\t$data->{'biblionumber'}\t20";
! $inputs{'bibitemnum'}="hidden\t$data->{'biblioitemnumber'}\t21";
! 
! 
! print mkform3('updatebiblio.pl',%inputs);
! #print mktablehdr();
! #print mktableft();
  print endmenu();
  print endpage();
--- 13,128 ----
  my $input = new CGI;
  
! my $submit = $input->param('submit.x');
! my $bibnum = $input->param('bibnum');
! my $data   = &bibdata($bibnum);
! my ($subjectcount, $subject)     = &subject($data->{'biblionumber'});
! my ($subtitlecount, $subtitle)   = &subtitle($data->{'biblionumber'});
! my ($addauthorcount, $addauthor) = &addauthor($data->{'biblionumber'});
! my $sub        = $subject->[0]->{'subject'};
! my $additional = $addauthor->[0]->{'author'};
! my %inputs;
! my $dewey;
! 
! if ($submit eq '') {
!   print $input->redirect("/cgi-bin/koha/delbiblio.pl?biblio=$bibnum");
! } # if
  
  print $input->header;
! # my ($analytictitle)  = &analytic($biblionumber,'t');
! # my ($analyticauthor) = &analytic($biblionumber,'a');
  print startpage();
  print startmenu();
  
! # have to get all subtitles, subjects and additional authors
! for (my $i = 1; $i < $subjectcount; $i++) {
!   $sub = $sub . "|" . $subject->[$i]->{'subject'};
! } # for
! 
! for (my $i = 1; $i < $addauthorcount; $i++) {
!   $additional = $additional . "|" . $addauthor->[$i]->{'author'};
! } # for
! 
! 
! $dewey = $data->{'dewey'};
! $dewey =~ s/0+$//;
! if ($dewey eq "000.") {
!     $dewey = "";
! } # if
! if ($dewey < 10) {
!     $dewey = '00' . $dewey;
! } # if
! if ($dewey < 100 && $dewey > 10) {
!     $dewey = '0' . $dewey;
! } # if
! if ($dewey <= 0){
!   $dewey='';
! } # if
! $dewey = ~ s/\.$//;
! 
! $data->{'title'} = &tidyhtml($data->{'title'});
! 
! print << "EOF";
! <form action="updatebiblio.pl" method="post">
! <input type="hidden" name="biblionumber" value="$data->{'biblionumber'}">
! <input type="hidden" name="biblioitemnumber" value="$data=>{'biblioitemnumber'}">
! <table border="0" cellspacing="0" cellpadding="5">
! <tr valign="top">
! <td>Author</td>
! <td><input type="text" name="author" value="$data->{'author'}"></td>
! </tr>
! <tr valign="top">
! <td>Title</td>
! <td><input type="text" name="title" value="$data->{'title'}"></td>
! </tr>
! <tr valign="top">
! <td>Abstract</td>
! <td><textarea name="abstract" cols="40" rows="4">$data->{'abstract'}</textarea></td>
! </tr>
! <tr valign="top">
! <td>Subject</td>
! <td><textarea name="subject" cols="40" rows="4">$sub</textarea></td>
! </tr>
! <tr valign="top">
! <td>Copyright Date</td>
! <td><input type="text" name="copyrightdate" value="$data->{'copyrightdate'}"></td>
! </tr>
! <tr valign="top">
! <td>Series Title</td>
! <td><input type="text" name="seriestitle" value="$data->{'seriestitle'}"></td>
! </tr>
! <tr valign="top">
! <td>Additional Author</td>
! <td><input type="text" name="additionalauthor" value="$additional"></td>
! </tr>
! <tr valign="top">
! <td>Subtitle</td>
! <td><input type="text" name="subtitle" value="$data->{'subtitle'}"></td>
! </tr>
! <tr valign="top">
! <td>Unititle</td>
! <td><input type="text" name="unititle" value="$data->{'untitle'}"></td>
! </tr>
! <tr valign="top">
! <td>Notes</td>
! <td><textarea name="notes" cols="40" rows="4">$data->{'notes'}</textarea></td>
! </tr>
! <tr valign="top">
! <td>Serial</td>
! <td><input type="text" name="serial" value="$data->{'serial'}"></td>
! </tr>
! <tr valign="top">
! <td>Analytic Author</td>
! <td><input type="text" name="analyticauthor"></td>
! </tr>
! <tr valign="top">
! <td>Analytic Title</td>
! <td><input type="text" name="analytictitle"></td>
! </tr>
! </table>
! <br>
! <input type="submit" name="submit" value="Save Changes">
! </form>
! EOF
! 
  print endmenu();
  print endpage();

Index: updatebiblio.pl
===================================================================
RCS file: /cvsroot/koha/koha/updatebiblio.pl,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -C2 -r1.1.1.1 -r1.2
*** updatebiblio.pl	19 Dec 2000 23:45:53 -0000	1.1.1.1
--- updatebiblio.pl	9 May 2002 03:01:40 -0000	1.2
***************
*** 7,75 ****
  use C4::Output;
  
! my $input= new CGI;
! #print $input->header;
! #print $input->dump;
! 
! 
! my $title=checkinp($input->param('Title'));
! my $author=checkinp($input->param('Author'));
! my $bibnum=checkinp($input->param('bibnum'));
! my $copyright=checkinp($input->param('Copyright'));
! my $seriestitle=checkinp($input->param('Series'));
! my $serial=checkinp($input->param('Serial'));
! my $unititle=checkinp($input->param('Unititle'));
! my $notes=checkinp($input->param('Notes'));
! 
! modbiblio($bibnum,$title,$author,$copyright,$seriestitle,$serial,$unititle,$notes);
! 
! my $subtitle=checkinp($input->param('Subtitle'));
! modsubtitle($bibnum,$subtitle);
! 
! my $subject=checkinp($input->param('Subject'));
! $subject=uc $subject;
! my @sub=split(/\|/,$subject);
! #print @sub;
! #
! 
! my $addauthor=checkinp($input->param('Additional'));
! modaddauthor($bibnum,$addauthor);
! my $count1=@sub;
! 
! for (my $i=0; $i<$count1; $i++){
!   $sub[$i]=~ s/ +$//;
! }
! 
! #print $input->header;
! my $force=$input->param('Force');
! my $error=modsubject($bibnum,$force, at sub);
  
  if ($error ne ''){
!   print $input->header;
!   print startpage();
!   print startmenu();
!   print $error;
!   my @subs=split('\n',$error);
!   print "<p> Click submit to force the subject";
!   my @names=$input->param;
!   my %data;
!   my $count=@names;
!   for (my $i=0;$i<$count;$i++){
!     if ($names[$i] ne 'Force'){
!       my $value=$input->param("$names[$i]");
!       $data{$names[$i]}="hidden\t$value\t$i";
!     }
!   }
!   $data{"Force"}="hidden\t$subs[0]\t$count";
!   print mkform3('updatebiblio.pl',%data);
!   print endmenu();
!   print endpage();
  } else {
!   print $input->redirect("detail.pl?type=intra&bib=$bibnum");
! }
  
  sub checkinp{
    my ($inp)=@_;
!   $inp=~ s/\'/\\\'/g;
!   $inp=~ s/\"/\\\"/g;
    return($inp);
  }
--- 7,75 ----
  use C4::Output;
  
! my $input       = new CGI;
! my $bibnum      = checkinp($input->param('biblionumber'));
! my $biblio = {
!     biblionumber => $bibnum,
!     title        => $input->param('title')?$input->param('title'):"",
!     author       => $input->param('author')?$input->param('author'):"",
!     abstract     => $input->param('abstract')?$input->param('abstract'):"",
!     copyright    => $input->param('copyrightdate')?$input->param('copyrightdate'):"",
!     seriestitle  => $input->param('seriestitle')?$input->param('seriestitle'):"",
!     serial       => $input->param('serial')?$input->param('serial'):"",
!     unititle     => $input->param('unititle')?$input->param('unititle'):"",
!     notes        => $input->param('notes')?$input->param('notes'):"",
! }; # my $biblio
! my $subtitle    = checkinp($input->param('subtitle'));
! my $subject     = checkinp($input->param('subject'));
! my $addauthor   = checkinp($input->param('additionalauthor'));
! my $force       = $input->param('Force');
! my %data;
! my @sub;
! my @subs;
! my @names;
! my $count;
! my $error;
! 
! &modbiblio($biblio);
! &modsubtitle($bibnum, $subtitle);
! &modaddauthor($bibnum, $addauthor);
! 
! $subject = uc($subject);
! @sub     = split(/\|/, $subject);
! $count   = @sub;
! 
! for (my $i = 0; $i < $count; $i++) {
!     $sub[$i] =~ s/ +$//;
! } # for
! 
! $error = &modsubject($bibnum,$force, at sub);
  
  if ($error ne ''){
!     print $input->header;
!     print startpage();
!     print startmenu();
!     print $error;
!     @subs = split('\n',$error);
!     print "<p> Click submit to force the subject";
!     @names = $input->param;
!     $count = @names;
!     for (my $i = 0; $i < $count; $i++) {
! 	if ($names[$i] ne 'Force') {
! 	    my $value = $input->param("$names[$i]");
! 	    $data{$names[$i]} = "hidden\t$value\t$i";
! 	} # if
!     } # for
!     $data{"Force"} = "hidden\t$subs[0]\t$count";
!     print mkform3('updatebiblio.pl', %data);
!     print endmenu();
!     print endpage();
  } else {
!     print $input->redirect("detail.pl?type=intra&bib=$bibnum");
! } # else
  
  sub checkinp{
    my ($inp)=@_;
!   $inp =~ s/\'/\\\'/g;
!   $inp =~ s/\"/\\\"/g;
    return($inp);
  }




From dragon28 at users.sourceforge.net  Thu May  9 02:27:02 2002
From: dragon28 at users.sourceforge.net (Mike Mylonas)
Date: Thu May  9 02:27:02 2002
Subject: [Koha-devel] CVS: koha installer.pl,1.2.2.1,1.2.2.2
Message-ID: <E175kCH-0001SX-00@usw-pr-cvs1.sourceforge.net>

Update of /cvsroot/koha/koha
In directory usw-pr-cvs1:/tmp/cvs-serv5541/koha

Modified Files:
      Tag: rel-1-2
	installer.pl 
Log Message:
Added testing for Perl and dependancies

Index: installer.pl
===================================================================
RCS file: /cvsroot/koha/koha/installer.pl,v
retrieving revision 1.2.2.1
retrieving revision 1.2.2.2
diff -C2 -r1.2.2.1 -r1.2.2.2
*** installer.pl	26 Apr 2002 14:47:17 -0000	1.2.2.1
--- installer.pl	9 May 2002 09:26:47 -0000	1.2.2.2
***************
*** 10,15 ****
  
  
- 
- 
  This installer will prompt you with a series of questions.
  It assumes you (or your system administrator) has installed:
--- 10,13 ----
***************
*** 57,62 ****
  system("tar -x $answer"); #unpack fill out
  
  
! #test for Perl and Apache?
  print "Are you using MySql?(Y/[N]): ";
  $answer = $_;                      
--- 55,93 ----
  system("tar -x $answer"); #unpack fill out
  
+ #
+ # Test for Perl - Do we need to explicity check versions?
+ #
+ print "\nChecking perl modules ...\n";
+     unless (eval "require 5.004") {
+     die "Sorry, you need at least Perl 5.004\n";
+ }
+ 	
+ 
+ #
+ # Test for Perl Dependancies
+ #
+ my @missing = ();
+ unless (eval require DBI)               { push @missing,"DBI" };
+ unless (eval require Date::Manip)       { push @missing,"Datr::Manip" }
+ unless (eval require DBD::mysql)        { push @missing,"DBD::mysql" }
+ unless (eval require Set::Scalar)       { push @missing,"Set::Scalar" }
+ 
+ #
+ # Print out a list of any missing modules
+ #
+ 
+ if (@missing > 0) {
+     print "\n\n";
+     print "You are missing some Perl modules which are required by Koha.\n";
+     print "They can be installed by running (as root) the following:\n";
+     foreach my $module (@missing) {
+     print "   perl -MCPAN -e 'install \"$module\"'\n";
+     }
+     print "\n";
+     exit;
+ }
+ 
  
! #test for MySQL?
  print "Are you using MySql?(Y/[N]): ";
  $answer = $_;                      




From rachel at katipo.co.nz  Thu May  9 15:40:02 2002
From: rachel at katipo.co.nz (Rachel Hamilton-Williams)
Date: Thu May  9 15:40:02 2002
Subject: [Koha-devel] Re: irc meeting tomorrow
In-Reply-To: <Pine.LNX.4.30.0205081812310.6370-100000@bigfun.whirlycott.com>
Message-ID: <3CDBA35E.28378.49D5374@localhost>

Sorry guys I have a prior engagement at 2.30pm local time (at a library as 
luck would have it), but means I'll only be avail for 10 minutes or so.

I can stay logged in to read back, or I can do earlier or later.

Man, one meeting all day and you managed to hit it :-)

Cheers
Rachel

> After a brief poll on the irc channel, we've come up with a tentative
> start time of 2PM Katipo Time (GMT+12).  This seems to incovenience the
> majority of the people the least (sorry Sergey and Paul).  We can either
> run with Nick's full blown agenda, or the shorter one I proposed and just
> plan on more meetings to hit all the items.
> 
> Rachel, you seem to be the logical chair for the meeting, what do you
> think?  Anyone else?
> 
> -pate
> 
> 


_____________________________________________________________

Rachel Hamilton-Williams             Katipo Communications            
WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285 
mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
http://www.katipo.co.nz              New Zealand
Koha Open Source Library System
http://www.koha.org





From rachel at katipo.co.nz  Thu May  9 18:48:02 2002
From: rachel at katipo.co.nz (Rachel Hamilton-Williams)
Date: Thu May  9 18:48:02 2002
Subject: [Koha-devel] Re: Koha steering committee
In-Reply-To: <20020506211954.GB8738@katipo.co.nz>
Message-ID: <3CDBCF7C.5529.549AEA2@localhost>

Hi,

Firstly appologies for not getting back to you on this earlier in the week, and 
for likely missing most of the meeting today.  

My biggest question would be "what are the problems we're trying to solve"

If we can write those down in a coherant fashion then we can see if a board 
will solve them. 


I went and had a look at the Apache and Gnome committee/board sites 
(after I asked who else worked like this), and found the following things 
interesting.

1/. One of the prime reasons (given) for setting up a foundation (and they 
implied board but that my not be the case) was so that other organisations 
could contribute finacially to a central fund, that would then pay programmers.

2/. They only let people who have contributed be members and elect and be 
on the board.  Which is a bit different to what you're suggestiong.

3/. They weren't big on having people who were "just" users on the board etc.

> We're proposing an oversight board (steering committee) for koha.  The
> board would be elected by the body of koha developers, users, and
> related people. (We want to include people into the general body
> rather than excluding them, but probably need to think about
> controlling membership somehow.)
 
> The board should be responsible for activities such as:
>   * choosing functionality targets for upcoming releases
>   * making policy decisions regarding koha
>   * organizing a koha presence at trade shows and the like
>   * acting as a liason with outside groups and foundations (GNOME,
>     KDE, Apache, ALA, etc.) where needed
>   * creating guidelines for granting developer access to the koha cvs
>     tree

If we need to fund some of these activities (I don't know if we do or not) then 
we may need to set up Koha as a charity.

> The board should meet weekly or bi-weekly (via irc?) and post minutes of
> their meetings to the koha (and koha-devel?) mailing lists and to the koha
> wiki.
> 
> To reduce potentially improper concentrations of power, only 2
> representatives from any organization should be allowed to serve on
> the board at a time (e.g., a company providing development or support
> for koha, or a library using koha).
> 
> For now, the board should be something like this:
>   4 developer seats
>   4 librarian seats
>       These 8 positions should serve 2 year terms, and half of them
>       should be up for re-election any given year.  (In the first
>       election, half of the developer and half of the librarian seats
>       should be elected for a 1 year term.)
>   3 at-large seats
>       The three at-large seats should either serve 1 year terms or
>       staggered 3 year terms.

I think thats too many people.  Particularly meeting via IRC that's a lot of 
people to meet.  I'd rather see a smaller committee, but have meetings open 
to observers or something similar.

> The board members should elect a chair person from within their
> number, Chairs chould serve a one year term.

cheers

Rachel

_____________________________________________________________

Rachel Hamilton-Williams             Katipo Communications            
WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285 
mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
http://www.katipo.co.nz              New Zealand
Koha Open Source Library System
http://www.koha.org





From nsr at etome.net  Thu May  9 22:06:01 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Thu May  9 22:06:01 2002
Subject: [Koha-devel] Log
Message-ID: <NGBBLPDKODDLFDKEDCDKCEFLCBAA.nsr@etome.net>

I'll be posting the meeting log (if you want a look at it) after I get some
sleep, unless someone has an objection.

Nick




From pate at eylerfamily.org  Fri May 10 06:55:08 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 10 06:55:08 2002
Subject: [Koha-devel] koha development leadership
Message-ID: <Pine.LNX.4.30.0205100952110.31681-100000@bigfun.whirlycott.com>

---------------------------------------------------------------------------
NOTE:  The following should be considered beta quality documentation.  It
represents my understanding of the rough consensus that came out of an irc
meeting.  Please feel free to point out mistakes, to clarify points, or
suggest improvements.
---------------------------------------------------------------------------

During our inaugural irc meeting last night, we talked about providing
more of a leadership structure for koha to add some consistency,
motivation, and vision to koha development.

We talked about a couple of options, ranging from continued anarchy
("there's no leadership like no leadership") to an elected steering
committee ("if a camel is a horse designed by committee ...").  In the
end we settled on a happy medium ("The art of compromise is giving
everyone some of what they want so that, in the end, no one is
happy.")

The purpose of this email is to explain the basic structure that we
settled on as well as the roles and responsibilities of each
position.

We decided that we (the people on the development list) should elect a
'benevolent dictator' to serve us until he/she decides to pass along
the baton to someone else (or looses the mandate of the development
list).  This person would nominate several key assistants to oversee
specific areas of the koha project.  This 'cabinet' should look
something like this:

         Benevolent Dictator
	   Release Leader
	   Marketing Leader
	   Recruiter
	   Standards Liason

Each of these positions is described below:

Benevolent Dictator:
  This person is responsible for setting the overall tone of koha
  development.  They will determine which Major features belong in a
  given release, which outside organizations we should focus on building
  relationships with, etc.  Our dictator should be our visionary and
  strategic thinker.

Release Leader:
  This person is chosen to oversee the development of a specific
  release.  There may be more than one release leader concurrently
  (e.g., a 1.2 release leader and a 1.4 release leader), the one
  overseeing the tail end of development on an earlier release while
  the other is ramping up development on the next release.  This
  person should be; making tactical decisions about merging or removing
  code, resolving conflicts, and managing a release schedule by
  encouraging (harassing?) developers.

Marketing Leader:
  This person should be targeting specific organizations to approach
  about koha.  They are not the sales arm of katipo or any other koha
  support/development company, instead they should be trying to
  increase awareness (and acceptance) of koha.  Examples may be
  coordinating a presence at ALA regional meetings, collecting koha
  success stories for distribution on the devel list (and web site),
  and the like.

Recruiter:
  This persons role is to find solid developers and designers to bring
  into the koha development and support effort.  This should include
  international recruitment (esp. in markets determined to be important
  by the Marketing Leader and Benevolent Dictator).  It may also
  include helping/mentoring likely candidates from the koha users
  list.

Standards Liason:
  This person should help coordinate our standards compliance
  efforts.  They will be tasked with gathering standards documentation
  and writing (or finding people to write) developer oriented
  documentation about the standards documentation.  (An if you think
  that last sentence was evil, you should go read some standards
  documents.)






From pate at eylerfamily.org  Fri May 10 07:59:04 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 10 07:59:04 2002
Subject: [Koha-devel] cvs and branching
Message-ID: <Pine.LNX.4.30.0205101057540.31681-100000@bigfun.whirlycott.com>

Here's a quick picture of how we might use CVS branches to manage our
upcoming development.  An explanation follows.


                           +--MARC-+
                          /         \
                         /           \
-main line--+-----+-----+-------------+-+--------------+-> development
             \     \                 /   \            /
              \     \               /     +-rel_1_4-++---> 1.4 branch
               \     \             /               /
                \     +-rel_1_2-+-+---------------+------> 1.2 branch
                 \             /
                  \           /
                   +---NT----+


	    (This picture is a gross over-simplification.)

The main line is where all normal development should happen (e.g.,
seperation of presentation and logic and addition of http::template).
Sometimes it makes sense to create a branch.  This could be to
stabilize a release (e.g., re_1_2 and rel_1_4) or to integrate big
changes that have happened outside the tree (e.g., MARC or NT).
Branches represent temporary copies of the tree, and can be operated
on (cvs add, remove, commit, checkout, update, etc) without affecting
the main line.

Any time we create a branch, we should plan on merging (or
backporting) changes back to the main line (and perhaps to other
branches as well).  In the example above, we already have a rel_1_2
branch.  We should create an NT and a MARC branch to hold the changes
for these two development efforts.

As the NT tree is solidified, we can backport it into the rel_1_2 tree
and from there into the main line.  Once the code has been backported,
we can close this branch down.

As the MARC tree solidifies, we can merge it directly back into the
main line preparatory to creating the rel_1_4 branch.  Again, once
backported, this branch can be closed.

The rel_1_2 tree should never be closed down.  It will represent the
ongoing work on the 1.2 stable releases.  We will want to merge
changes from this branch into the main line on a regular basis.  Once
the rel_1_4 branch is created, we can backport rel_1_2 changes into
that branch as desired.

After the rel_1_4 branch has been created, we will want to merge
stabilization changes back into the main line from it on a regular
basis.


For hints on the technical bits involved in using CVS and branches,
please look at http://cvsbook.red-bean.com/cvsbook.html (or, even
better, buy a copy of the book).





From paul.poulain at free.fr  Fri May 10 08:14:03 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Fri May 10 08:14:03 2002
Subject: [Koha-devel] cvs and branching
References: <Pine.LNX.4.30.0205101057540.31681-100000@bigfun.whirlycott.com>
Message-ID: <3CDBE43F.8050702@free.fr>

Pat Eyler wrote:

>Here's a quick picture of how we might use CVS branches to manage our
>upcoming development.  An explanation follows.
>
>                           +--MARC-+
>                          /         \
>                         /           \
>-main line--+-----+-----+-------------+-+--------------+-> development
>             \     \                 /   \            /
>              \     \               /     +-rel_1_4-++---> 1.4 branch
>               \     \             /               /
>                \     +-rel_1_2-+-+---------------+------> 1.2 branch
>                 \             /
>                  \           /
>                   +---NT----+
>
I strongly agree with this schema, and am very impressed (great ASCII 
art ;-))

About version naming : if I understood our iirc, we will use the linux 
method (1.2 : stable release, 1.3 : unstable release)

An other remark : the next stable version will be 1.1.2, from 1.2 branch.
How (chris ?) do we solve this ? We should rename 1.2 branch 1.2.2 (as 
it's stable version), and maybe have a 1.1.3 release at anytime (with 
partial NT port or partial MARC support for example).

Last question : how do we build a version from branch ?

Lot of questions I think, but it's quite unclear in my mind...
--
Paul





From pate at eylerfamily.org  Fri May 10 08:24:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 10 08:24:02 2002
Subject: [Koha-devel] cvs and branching
In-Reply-To: <3CDBE43F.8050702@free.fr>
Message-ID: <Pine.LNX.4.30.0205101116380.31681-100000@bigfun.whirlycott.com>

On Fri, 10 May 2002, paul POULAIN wrote:

> Pat Eyler wrote:
>
> >Here's a quick picture of how we might use CVS branches to manage our
> >upcoming development.  An explanation follows.
> >
> >                           +--MARC-+
> >                          /         \
> >                         /           \
> >-main line--+-----+-----+-------------+-+--------------+-> development
> >             \     \                 /   \            /
> >              \     \               /     +-rel_1_4-++---> 1.4 branch
> >               \     \             /               /
> >                \     +-rel_1_2-+-+---------------+------> 1.2 branch
> >                 \             /
> >                  \           /
> >                   +---NT----+
> >
> I strongly agree with this schema, and am very impressed (great ASCII
> art ;-))

emacs is great isn't it?

>
> About version naming : if I understood our iirc, we will use the linux
> method (1.2 : stable release, 1.3 : unstable release)

Good point, 1.1 releases would be spun out of the rel_1_2 branch and 1.3
releases would be spun out of the rel_1_4 branch.  Sorry I wasn't clear
about this.


>
> An other remark : the next stable version will be 1.1.2, from 1.2 branch.
> How (chris ?) do we solve this ? We should rename 1.2 branch 1.2.2 (as
> it's stable version), and maybe have a 1.1.3 release at anytime (with
> partial NT port or partial MARC support for example).


My cut is that the next release should be 1.2.0 (just stabilization and
simple katipo mods).  If we can integrate the NT support, we should do
that in the 1.2.X series and backport it from the rel_1_2 tree into the
main line for ongoing support.  If people feel strongly, we could call
the first 1.2 release 1.2.2.

Once 1.2 is out and we're comfortable with it, we can start the rel_1_4
tree with MARC support and templates.  Shortly after we create the branch,
we should release 1.3.0

>
> Last question : how do we build a version from branch ?

A version is, to me, just a tarball of a given branch at a given
point.  It probably needs a bit of cleaning (get rid of CVS specific stuff
and the like), but the work could be scripted.

>
> Lot of questions I think, but it's quite unclear in my mind...

No problem.  Please keep asking questions until it is clear in everyone's
mind.

-pate

> --
> Paul
>
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From paul.poulain at free.fr  Fri May 10 08:29:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Fri May 10 08:29:02 2002
Subject: [Koha-devel] cvs and branching
References: <Pine.LNX.4.30.0205101116380.31681-100000@bigfun.whirlycott.com>
Message-ID: <3CDBE7E3.9000702@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020510/34ffac88/attachment.htm 

From pate at eylerfamily.org  Fri May 10 08:36:01 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 10 08:36:01 2002
Subject: [Koha-devel] cvs and branching
In-Reply-To: <3CDBE7E3.9000702@free.fr>
Message-ID: <Pine.LNX.4.30.0205101131490.31681-100000@bigfun.whirlycott.com>

On Fri, 10 May 2002, paul POULAIN wrote:

> Pat Eyler wrote:
>
>
>
>>  A version is, to me, just a tarball of a given branch at a given
>> point.  It probably needs a bit of cleaning (get rid of CVS specific
>> stuff and the like), but the work could be scripted
>
> That's what I thought.
> So, we should rename branches don't we ? It would be HIGHLY more
> comprehensive...

Do you mean having a rel_1_3 tree?  That could work, but since the 1.3
stuff just becomes 1.4 when the release manager waves her wand over it it
seems like a needless step.  (If I'm wrong, please let me know.)

-pate

> --
> Paul




From pate at eylerfamily.org  Fri May 10 20:35:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 10 20:35:02 2002
Subject: [Koha-devel] hola (fwd)
Message-ID: <Pine.LNX.4.30.0205102333090.7273-100000@bigfun.whirlycott.com>

Thought I'd pass this along to the list.   I'm trying to recruit some help
in developing and internationalizing koha ... this was my first shot at
it.

thoughts, comments, questions?

-pate

---------- Forwarded message ----------
Date: Thu, 9 May 2002 11:30:34 -0400 (EDT)
From: Pat Eyler <pate at eylerfamily.org>
To: webmasters at www.gnu.org.pe
Subject: hola

hola, yo habla un poco espanol, lo siento.

I hope english will work.

I'm working on a free software library automation project (for traditional
book/media collections) called koha (Maori for 'gift')[1].  It uses perl
and mysql, and will run on a variety of free unix-like systems.  Currently
koha works very well for smaller libraries, and is installed at a number
of libraries around the world.  Our goal is to turn it into a system
capable of handling large libraries, even to the point of supporting
National Libraries.

Given Peru's recent entrance into the limelight of the Free Software
world, it would seem that there is a opportunity for co-operation.  Do you
know of a Peruvian organization that we could work with us to:
 a) help localize koha for spanish speakers
 b) ensure the functionality that peruvian libraries (and the peruvian
    governmant) need is present in koha
 c) help build local (Peruvian) interest in and support for koha


From tonnesen at cmsd.bc.ca  Sat May 11 09:53:03 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Sat May 11 09:53:03 2002
Subject: [Koha-devel] templating
Message-ID: <Pine.LNX.3.96.1020511094410.5139l-100000@hss-labs.cmsd.bc.ca>

After a bit of playing with HTML::Template I have the following proposal


Templates stored in includes directory under templates subfolder, each
module (ie search, circ, catalog, etc.) has another subfolder, then
another subfolder for each template, and then subfolders for each version
of that template.


Includes 
   Templates
       Search
	  Opac Search
             default.tmpl
             polish.tmpl
             french.tmpl
             local.tmpl
          Librarian Search
              default.tmpl
              polish.tmpl
              french.tmpl
              local.tmpl
          Opac Results
              default.tmpl
          Librarian Results
	      default.tmpl


We could then have a preference order for choosing templates, ie:

  local
  french
  default


If a local template is available, it is used first, then the french
template, falling back on the default template if no other is available.

I don't know if this is too complicated, or too simple.  What do we do if
we have three different "default" opac results templates?  What about a
per-user preference for different templates?  Maybe language should be
dealt with completely separately...

Just airing some thoughts...

Steve.





From nsr at etome.net  Sat May 11 15:10:01 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Sat May 11 15:10:01 2002
Subject: [Koha-devel] Double checking m'self
Message-ID: <NGBBLPDKODDLFDKEDCDKMEFPCBAA.nsr@etome.net>

I've doubled checked my email, and I think I've updated (maybe not prettily,
but updated) the Wiki in spots based on recent requests and the best version
of the working list for the current version.  Please tell me if you want
anything else in there in the short term, as I may go back an clean things
up/de-cruftify.

Nick




From nsr at etome.net  Sat May 11 15:25:01 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Sat May 11 15:25:01 2002
Subject: [Koha-devel] Have fun...
Message-ID: <NGBBLPDKODDLFDKEDCDKIEGACBAA.nsr@etome.net>

No objections having been recorded ....
The log of the meeting (at least until it wound down and I left) is at
http://etome.net/Koha/minutes/meeting-Koha.txt if anyone wants to read
something like 3/4 hours of IRC :)  -- Simon said he'd get a who-does-what
email out soon based on the meeting (thank heaven, as at least I was running
principally on caffeine!).

Nick




From nsr at etome.net  Sat May 11 15:42:02 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Sat May 11 15:42:02 2002
Subject: [Koha-devel] templating
In-Reply-To: <Pine.LNX.3.96.1020511094410.5139l-100000@hss-labs.cmsd.bc.ca>
Message-ID: <NGBBLPDKODDLFDKEDCDKCEGBCBAA.nsr@etome.net>


> -----Original Message-----

> I don't know if this is too complicated, or too simple.  What do we do if
> we have three different "default" opac results templates?  What about a
> per-user preference for different templates?  Maybe language should be
> dealt with completely separately...
>

I know there was some thought (might've been on the users list) of
appearance (different color schemes, buttons, etc) templates (ie, skins) in
addition to language.  But that might just be following the open source pack
mentality that (apparently) everything must have a customizable
appearance... :)

Nick




From rachel at katipo.co.nz  Sun May 12 19:37:03 2002
From: rachel at katipo.co.nz (Rachel Hamilton-Williams)
Date: Sun May 12 19:37:03 2002
Subject: [Koha-devel] templating
In-Reply-To: <NGBBLPDKODDLFDKEDCDKCEGBCBAA.nsr@etome.net>
References: <Pine.LNX.3.96.1020511094410.5139l-100000@hss-labs.cmsd.bc.ca>
Message-ID: <3CDFCF84.14598.1248D05@localhost>

>  But that might just be following the open source pack
> mentality that (apparently) everything must have a customizable appearance... :)

Hmm - the work we were doing leading up to Koha was customising library 
OPAC's, so I've always felt that being able to change the look of it was fairly 
important 

Cheers
Rachel
_____________________________________________________________

Rachel Hamilton-Williams             Katipo Communications            
WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285 
mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
http://www.katipo.co.nz              New Zealand
Koha Open Source Library System
http://www.koha.org





From rog at saas.nsw.edu.au  Mon May 13 01:26:02 2002
From: rog at saas.nsw.edu.au (Roger Buck)
Date: Mon May 13 01:26:02 2002
Subject: [Koha-devel] templating
References: <Pine.LNX.3.96.1020511094410.5139l-100000@hss-labs.cmsd.bc.ca>
Message-ID: <3CDF7865.BA298893@saas.nsw.edu.au>

Hi Steve,

Tonnesen Steve wrote:
> 
> After a bit of playing with HTML::Template I have the
> following proposal

[--snip--]

> Templates stored in includes directory under templates
> subfolder, each module (ie search, circ, catalog, etc.)
> has another subfolder, then another subfolder for each
> template, and then subfolders for each version of that
> template.
>
> Includes 
>   Templates
>      Search
>         Opac Search
>            default.tmpl
>            polish.tmpl
>            french.tmpl
>            local.tmpl
>         Librarian Search

[--snip--]

> I don't know if this is too complicated, or too simple.
> What do we do if we have three different "default" opac
> results templates?  What about a per-user preference
> for different templates?  Maybe language should be
> dealt with completely separately...
> 
> Just airing some thoughts...

These are not direct answers to your question but I hope they are useful
nonetheless:

The first distinction i'd draw is between the html "active content"
versus the content "look and feel"

For example, in the current koha, the "active content" control is
partially implemented using the "type=" parameter in the *.pl files:
Where the "active content" is displayed differently depending on the
"type" of user accessing the file (the "active content" and "look and
feel" depend on whether the "type" param equals "intra" or "opac" for
example)

It looks to me like the "type" options in combination with the new
hierarchy might be getting overly complex? 

Raison d'etre for the "type" option is based on access level
considerations as much as "look and feel"? If that is so, then the
primary need may be for the admin to be able to specify an "html
template set" based on user access level, and only secondarily on "look
and feel"?

For example - there may be three distinctly different versions of

 /catalogue/index.html 

depending on whether the user is a "NonMember", "Member", "Librarian",
etc...

For ease of controlling user access via a webserver (various flavours of
auth), then the directory hierarchy might look more like:

Includes 
   Templates
      NonMember
	  Search
             default.tmpl
             polish.tmpl
             french.tmpl
             local.tmpl

      Member
	  Search
             default.tmpl
             polish.tmpl
             french.tmpl
             local.tmpl
	
      Librarian
	  Search
             default.tmpl
             polish.tmpl
             french.tmpl
             local.tmpl


This would allow webserver authentication control at the parent folder
level and possibly for the admin to specify root path based on a user
access level?

I dunno if this is useful input in relation to your central question
about HTML::Template -  but I hope it makes sense at least :)

R.



From paul.poulain at free.fr  Mon May 13 13:08:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Mon May 13 13:08:02 2002
Subject: [Koha-devel] templating
References: <Pine.LNX.3.96.1020511094410.5139l-100000@hss-labs.cmsd.bc.ca>
Message-ID: <3CE01DA5.4050400@free.fr>

Tonnesen Steve wrote:

>After a bit of playing with HTML::Template I have the following proposal
>
>Templates stored in includes directory under templates subfolder, each
>module (ie search, circ, catalog, etc.) has another subfolder, then
>another subfolder for each template, and then subfolders for each version
>of that template.
>
If we really want to have a "plug-in" system that permits many looks 
and/or many languages, we must have a directory for each plug-in. thus, 
we MUST have, under the template directory :
DEFAULT
    opac
        search.tmpl
        search_result.tmpl
    librarian
        search.tmpl
        search_result.tmpl
        biblio_add.tmpl
        circulation.tmpl
    images
        image1.gif
        anotherimage.gif
FRENCH
    opac
        search.tmpl
        search_result.tmpl
    librarian
        search.tmpl
        search_result.tmpl
        biblio_add.tmpl
        circulation.tmpl
    images
        image1.gif
        anotherimage.gif
MY_GREAT_NEW_LOOK
    opac
        search.tmpl
        search_result.tmpl
    librarian
        search.tmpl
        search_result.tmpl
        biblio_add.tmpl
        circulation.tmpl
    images
        image1.gif
        anotherimage.gif
AQUA_LOOK
    opac
        search.tmpl
        search_result.tmpl
    librarian
        search.tmpl
        search_result.tmpl
        biblio_add.tmpl
        circulation.tmpl
    images
        image1.gif
        anotherimage.gif

Thus we can easily create a new "look" (directory copy + modifiing it), 
and build a .tar.gz dedicated to the plug-in.
When koha is launched, you just have to scan the "template" directory 
and list all sub-directories.
We could even have 2 librarians with a different look. (which may be 
interesting for international libraries like mine ;-) )
This structure is used by softs like nuke / post-nuke, and are great.
--
Paul




From pate at eylerfamily.org  Mon May 13 17:29:05 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Mon May 13 17:29:05 2002
Subject: [Koha-devel] Re: [Koha] schema question
In-Reply-To: <E1779Ma-0006wB-00@orc.cs.waikato.ac.nz>
Message-ID: <Pine.LNX.4.30.0205132027240.11470-100000@bigfun.whirlycott.com>

Stuart,
I'm forwarding your message to the development list where it stands a
better chance of being answered.  If you're interested in implementing
functionality such as this, you may want to subscribe to the development
list.

thanks,
-pate

On Mon, 13 May 2002, <s.yeates at cs.waikato.ac.nz> wrote:

>
> Hello
>
> I've got a couple of quick questions about the Koha database schema. I think I've worked it out, but just want to double check. I'm working from the CVS version and data.
>
> I'm interested in implementing a collaborative recommendation feature which allowed users to see which books other people who borrowed the current book had also borrowed. Both Amazon and Barnes and Noble use a similar feature.
>
> In English the query I want is "Which books have been lent to the most people who have also borrowed the current book?" With the restriction that the books I recommend must be available for lending from the current library (it's pointless recommending a book that's not there) and must have more than N borrowers in common with the current book (to protect the privacy of borrowers, N is set to 5 or 10).
>
> Logically what I want to do is a join across biblio--> items--> issues--> borrowernumber--> issues--> items--> biblio with SELECT, a COUNT and a SORT. This, of course, gives huge intermediate tables, so I'd have to do several SELECTs as I go.
>
> I may also need to factor in a component of "how much has book A been borrowed by borrowers of book B compared to all other borrowers" to prevent very popular items (think Harry Potter) being recommended for every possible book. This effect would be similar to tf-idf ranking from classical information retrieval.
>
> My questions are:
> (1) How do I tell whether a book is 'available'? I think I need to check the items table and make sure that stack, notforloan, itemlost and wthdrawn are all zero does this sounds right?.
> (2) I don't understand the distinction between items and biblioitems
> (3) How to I differentiate between children's and adult's books, between fiction and non-fiction?
> (4) Would collaborative recommendation be useful in a small library catalog?
> (5) Would the small incursion of user privacy be acceptable in a small public library?
>
> thanks for your help
> stuart
>
>
>
>
> --    stuart yeates <s.yeates at cs.waikato.ac.nz> aka `loam'
>   "To err is human--but it feels divine."  --  Mae West
> X-no-archive:yes
>
> _______________________________________________
> Koha mailing list
> Koha at lists.katipo.co.nz
> http://lists.katipo.co.nz/mailman/listinfo/koha
>




From paul.poulain at free.fr  Tue May 14 01:29:03 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Tue May 14 01:29:03 2002
Subject: [Koha-devel] is it a bug ? or I need some explanations...
Message-ID: <3CE0CB74.7050306@free.fr>

Hi,

I'm working on koha-cvs. I've found a technical bug which hides maybe a 
functionnal problem. Let me explain :

Acquisition.
I search a supplier (one I've added recently).
It shows a basket (HLT-1064, created 3 days ago), which I click on.
I go to basket.pl. This basket contains 1 line, for an item called 
"madeleine samedi2", qty=1, $est=7 (ok, that's the item I had added. It 
was a new biblio)
When I click on the title, i go to newbiblio.pl. "92536 - Order Detail".
Item barcode/Actual cost/Invoice number is empty ( ?? I filled them at 
the first order).

When I validate, I get an error => acquisition.pm due to addorder.pl error :
at line 61,
      $bibitemnum=newbiblioitem($bibnum,$itemtype,$isbn);
should be :
      $bibitemnum= &newbiblioitem({ biblionumber => $bibnum,
                              itemtype => $itemtype?$itemtype:"",
                             isben => $isbn?$isbn:"" });

(thanks to use strict here, it must be a long time ago bug...)

Now, i get no technical bug, but... a new "biblioitems" record is 
created. I think it's a bug, but can someone explain me what's supposed 
to do the title link in basket.pl.

Thanks
--
Paul






From chris at katipo.co.nz  Tue May 14 01:35:03 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Tue May 14 01:35:03 2002
Subject: [Koha-devel] is it a bug ? or I need some explanations...
In-Reply-To: <3CE0CB74.7050306@free.fr>
References: <3CE0CB74.7050306@free.fr>
Message-ID: <1021365360.2436.2.camel@orbweb.katipo.co.nz>

On Tue, 2002-05-14 at 20:31, paul POULAIN wrote:
> Hi,
> 
> I'm working on koha-cvs. I've found a technical bug which hides maybe a 
> functionnal problem. Let me explain :
> 
> Acquisition.
> I search a supplier (one I've added recently).
> It shows a basket (HLT-1064, created 3 days ago), which I click on.
> I go to basket.pl. This basket contains 1 line, for an item called 
> "madeleine samedi2", qty=1, $est=7 (ok, that's the item I had added. It 
> was a new biblio)
> When I click on the title, i go to newbiblio.pl. "92536 - Order Detail".
> Item barcode/Actual cost/Invoice number is empty ( ?? I filled them at 
> the first order).
> 
> When I validate, I get an error => acquisition.pm due to addorder.pl error :
> at line 61,
>       $bibitemnum=newbiblioitem($bibnum,$itemtype,$isbn);
> should be :
>       $bibitemnum= &newbiblioitem({ biblionumber => $bibnum,
>                               itemtype => $itemtype?$itemtype:"",
>                              isben => $isbn?$isbn:"" });
> 
Ahh I think youve run into a new bug.

Gynn has been making changes to the acquisitions system. He's been
working on the Simple acquisitions version. But I watched a change to
C4::Acquisitions go whizzing past today, which may have caused the
technical bug.

Are you on the koha-cvs list paul?

Its the new list that just gets the cvs commits.

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From paul.poulain at free.fr  Tue May 14 01:50:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Tue May 14 01:50:02 2002
Subject: [Koha-devel] is it a bug ? or I need some explanations...
References: <3CE0CB74.7050306@free.fr> <1021365360.2436.2.camel@orbweb.katipo.co.nz>
Message-ID: <3CE0D058.4080006@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020514/ffc8b84f/attachment.htm 

From paul.poulain at free.fr  Tue May 14 02:26:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Tue May 14 02:26:02 2002
Subject: [Koha-devel] query optimization
Message-ID: <3CE0D8BF.3090109@free.fr>

Many queries are build with :

(title like '$key[0]%' or title like '% $key[0]%')

I was wondering why :
* title like '$key%' is index optimizable
* title like '% $key%' is NOT index optimizable.

optimizable OR not optimizable === NOT optimizable.

So the resulting query is not optimizable.

So, what's the interest of such a string, as "title like '%'.$key.'%'" 
has the same result ?
--
Paul




From chris at katipo.co.nz  Tue May 14 02:42:03 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Tue May 14 02:42:03 2002
Subject: [Koha-devel] query optimization
In-Reply-To: <3CE0D8BF.3090109@free.fr>
References: <3CE0D8BF.3090109@free.fr>
Message-ID: <1021369395.2436.10.camel@orbweb.katipo.co.nz>

On Tue, 2002-05-14 at 21:28, paul POULAIN wrote:
> Many queries are build with :
> 
> (title like '$key[0]%' or title like '% $key[0]%')
> 
> I was wondering why :
> * title like '$key%' is index optimizable
> * title like '% $key%' is NOT index optimizable.
> 
> optimizable OR not optimizable === NOT optimizable.
> 
> So the resulting query is not optimizable.
> 
> So, what's the interest of such a string, as "title like '%'.$key.'%'" 
> has the same result ?

If title like '%'.$key.'%'" does the same thing and is optimisable then
we should use that.
What the above is trying to do is find the word if its at the start of
the title, or is another word thats part of the title.
For eg if we are searching for 'host'
we want it to find titles such as 'Host of stuff' and 'Here come the
hosts'

We dont want to find 'ghosts'  Ie we only want wildcarding off the end
of each word. Not the front.

I hope this makes sense.

If your above construct can do this, that would be great :)

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From paul.poulain at free.fr  Tue May 14 03:43:03 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Tue May 14 03:43:03 2002
Subject: [Koha-devel] query optimization
References: <3CE0D8BF.3090109@free.fr> <1021369395.2436.10.camel@orbweb.katipo.co.nz>
Message-ID: <3CE0EAA9.5060706@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020514/e5f54968/attachment.htm 

From paul.poulain at free.fr  Tue May 14 04:01:03 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Tue May 14 04:01:03 2002
Subject: [Koha-devel] website table structure
Message-ID: <3CE0EF11.9080803@free.fr>

I can't find the website table structure anywere ? can someone send it 
or tell where it's hidden ?
--
Paul




From tonnesen at cmsd.bc.ca  Tue May 14 12:42:06 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Tue May 14 12:42:06 2002
Subject: [Koha-devel] templates
Message-ID: <Pine.LNX.3.96.1020514123509.1336C-100000@hss-labs.cmsd.bc.ca>


Still playing with templates...

I've implemented paul's hierarchy suggestion of "theme" directories at the
top.

What I'd like to be able to do is specifiy an ordered list of preferred
templates.  For example, one might want to specify:

  local
  french
  default

templates.  If a template exists in the "local" theme, it will always be
used.  If a template exists in "french" but not in "local" the "french"
template will be used.  As a last resort, the "default" template will
always be used.

Should we develop a naming scheme for themes that are distributed with
Koha, to keep them from squashing local or third party themes?  Maybe
koha-default, koha-french, koha-polish, etc?

I'm thinking that Koha will probably ship with at least themes for various
languages.  I suppose the other option would be to have separate
directories for shipped themes and local/third party themes?

Steve.





From nsr at etome.net  Tue May 14 14:06:04 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Tue May 14 14:06:04 2002
Subject: [Koha-devel] Heads up
Message-ID: <NGBBLPDKODDLFDKEDCDKIEGKCBAA.nsr@etome.net>

I'll be only sporadically connected to email for the next few days, just as
a warning.  I'm taking a look at the DocBook info (which is very new to me)
I've found.

Just a heads up,
Nick




From chris at katipo.co.nz  Tue May 14 14:42:04 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Tue May 14 14:42:04 2002
Subject: [Koha-devel] Forwarded on behalf of rosalie
Message-ID: <1021412580.20869.3.camel@orbweb.katipo.co.nz>

------- Forwarded message follows ------- 
To:             rosalie at library.org.nz 
Date sent:      Mon, 13 May 2002 23:26:57 -0700 
From:           "SOFYAN ROSYIDI" <sofyan.r at eudoramail.com> 
Send reply to:  sofyan.r at eudoramail.com 
Subject:        (No Subject)
Organization:   QUALCOMM Eudora Web-Mail  (http://www.eudoramail.com:80)

How to install KOHA on Windows operating system? 
thanks for your help, God bless u 

----

Anyone want to take a crack at this?
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From chris at katipo.co.nz  Tue May 14 16:40:02 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Tue May 14 16:40:02 2002
Subject: [Koha-devel] Marc Branch
Message-ID: <1021419639.20870.18.camel@orbweb.katipo.co.nz>

Hi all

As requested by Paul i have created a branch called rel-1-4-marc that
ppl can use to work on the marc version.

Id also like to see if we can organise some kind of group session to
knock out any bugs in the rel-1-2 branch. And see if we can progress
towards a 1.2.0 stable release.

Perhaps we need that Release manager to crack the whip :)

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From pate at eylerfamily.org  Tue May 14 19:18:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Tue May 14 19:18:02 2002
Subject: [Koha-devel] Marc Branch
In-Reply-To: <1021419639.20870.18.camel@orbweb.katipo.co.nz>
Message-ID: <Pine.LNX.4.30.0205142215210.25134-100000@bigfun.whirlycott.com>

On 15 May 2002, Chris Cormack wrote:

> Hi all
>
> As requested by Paul i have created a branch called rel-1-4-marc that
> ppl can use to work on the marc version.

Awesome!   It will be good to see Steve's work.

>
> Id also like to see if we can organise some kind of group session to
> knock out any bugs in the rel-1-2 branch. And see if we can progress
> towards a 1.2.0 stable release.
>

I think we need to identify the bugs and features as tasks and bugs in
either bugzilla or in the task managers on SourceForge before having a bug
day (or hackfest) makes too much sense.

> Perhaps we need that Release manager to crack the whip :)

It might help.  ;)

-pate

>
> Chris
>




From paul.poulain at free.fr  Wed May 15 07:43:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May 15 07:43:02 2002
Subject: [Koha-devel] adding biblio
Message-ID: <3CE2747B.7080107@free.fr>

I've just commited 2 small corrections in newbiblio and addorder scripts.

But my question is still here !
When you're on a basket and click on a biblio link, you're asking the 
system to do something strange...
I explain : you call "newbiblio.pl", which mean you want to ADD a 
biblio/biblioitem. See, for example, barcode calculation in newbiblio.pl.
Chris told me it was supposed to EDIT the biblio/biblioitem.

I dig 3 hours in this code, and still does not understand what happends, 
where it's wrong, and how to correct. What i'm sure, is that it has a 
strange behaviour.
Could someone (from katipo maybe) have a *deep* look and explain me or 
correct the problem ?
--
Paul




From paul.poulain at free.fr  Wed May 15 08:24:14 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May 15 08:24:14 2002
Subject: [Koha-devel] PLEASE, help me...
Message-ID: <3CE27E49.2050006@free.fr>

Yesterday I asked for the structure of the websites table. I still have 
no answers.

Today, I will ask for the  "uploadedmarc" table structure (in acqui.simple).

PLEASE, when you update you local mysql-DB, don't forget cvs ignore it, 
so update database.mysql immediatly, so I will be able to do the changes 
also...
I've searched "uploadedmarc" table everywhere and could'nt find it ;-(((

Thanks.
This day was a boring day : searching for biblio-adding problem without 
any result, and trying to work on marc stuff with no more success :-\\\\\\\
--
Paul




From paul.poulain at free.fr  Wed May 15 08:32:06 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May 15 08:32:06 2002
Subject: [Koha-devel] PLEASE, help me...
References: <3CE27E49.2050006@free.fr>
Message-ID: <3CE28016.50008@free.fr>

paul POULAIN wrote:

> Yesterday I asked for the structure of the websites table. I still 
> have no answers.
>
> Today, I will ask for the  "uploadedmarc" table structure (in 
> acqui.simple).

Same question for :
z3950queue
uploadedmarc
marcrecorddone
z3950results
--
Paul




From paul.poulain at free.fr  Wed May 15 08:38:03 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Wed May 15 08:38:03 2002
Subject: [Koha-devel] PLEASE, help me...
References: <3CE27E49.2050006@free.fr> <3CE28016.50008@free.fr>
Message-ID: <3CE2817F.8040400@free.fr>

paul POULAIN wrote:

> paul POULAIN wrote:
>
>> Yesterday I asked for the structure of the websites table. I still 
>> have no answers.
>>
>> Today, I will ask for the  "uploadedmarc" table structure (in 
>> acqui.simple).
>
>
> Same question for :
> z3950queue
> uploadedmarc
> marcrecorddone
> z3950results

Oops, the z3950 tables are defined in updatedatabase script. OK for those.
But the question is still here for the "marc" tables.
--
Paul





From tonnesen at cmsd.bc.ca  Wed May 15 08:46:36 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Wed May 15 08:46:36 2002
Subject: [Koha-devel] PLEASE, help me...
In-Reply-To: <3CE2817F.8040400@free.fr>
Message-ID: <Pine.LNX.3.96.1020515084354.1336H-100000@hss-labs.cmsd.bc.ca>

On Wed, 15 May 2002, paul POULAIN wrote:

> > uploadedmarc
> > marcrecorddone


mysql> show columns from marcrecorddone;
+---------------+----------+------+-----+---------+-------+
| Field         | Type     | Null | Key | Default | Extra |
+---------------+----------+------+-----+---------+-------+
| isbn          | char(40) | YES  |     | NULL    |       |
| issn          | char(40) | YES  |     | NULL    |       |
| lccn          | char(40) | YES  |     | NULL    |       |
| controlnumber | char(40) | YES  |     | NULL    |       |
+---------------+----------+------+-----+---------+-------+


mysql> show columns from uploadedmarc;
+--------+--------------+------+-----+---------+----------------+
| Field  | Type         | Null | Key | Default | Extra          |
+--------+--------------+------+-----+---------+----------------+
| id     | int(11)      |      | PRI | NULL    | auto_increment |
| marc   | longblob     | YES  |     | NULL    |                |
| hidden | smallint(6)  | YES  |     | NULL    |                |
| name   | varchar(255) | YES  |     | NULL    |                |
+--------+--------------+------+-----+---------+----------------+


Paul:  Do you want to meet on IRC to discuss MARC for a bit?

Steve.





From tonnesen at cmsd.bc.ca  Wed May 15 12:46:03 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Wed May 15 12:46:03 2002
Subject: [Koha-devel] public irc logs
Message-ID: <Pine.LNX.3.96.1020515123757.1336M-100000@hss-labs.cmsd.bc.ca>

Anybody have any feelings on making irc logs publically available?  I've
got a logger running on the channel now and a web page for viewing the
logs.  If nobody objects to public logs, I'll post a link on the wiki.

If somebody objects, I won't post the link, or I'll make the log site
password protected.

Steve.





From pate at eylerfamily.org  Wed May 15 13:46:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May 15 13:46:02 2002
Subject: [Koha-devel] public irc logs
In-Reply-To: <Pine.LNX.3.96.1020515123757.1336M-100000@hss-labs.cmsd.bc.ca>
Message-ID: <Pine.LNX.4.30.0205151643470.2251-100000@bigfun.whirlycott.com>

On Wed, 15 May 2002, Tonnesen Steve wrote:

>
> Anybody have any feelings on making irc logs publically available?  I've
> got a logger running on the channel now and a web page for viewing the
> logs.  If nobody objects to public logs, I'll post a link on the wiki.
>
> If somebody objects, I won't post the link, or I'll make the log site
> password protected.


Thanks for putting this together ... I think that there are a lot of
conversations on the irc that would be nice to capture more permanently.

I'd encourage people who participate in such conversations to grab the
logs (from Steve's archive or your own logs) and put an edited version up
on the wiki.

-pate

>
> Steve.
>
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From chris at katipo.co.nz  Wed May 15 14:47:05 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Wed May 15 14:47:05 2002
Subject: [Koha-devel] PLEASE, help me...
In-Reply-To: <3CE27E49.2050006@free.fr>
References: <3CE27E49.2050006@free.fr>
Message-ID: <1021499297.556.3.camel@orbweb.katipo.co.nz>

On Thu, 2002-05-16 at 03:27, paul POULAIN wrote:
> Yesterday I asked for the structure of the websites table. I still have 
> no answers.

The websites table is in the database.mysql file in cvs Paul.
Its in the main branch, not the rel-1-2 branch, since this new code gynn
has been working on is not destined for 1.2.

Revision 1.7 is where the update occured.
If you take a look at
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/koha/koha/database.mysql

You'll see it there. I think you have been looking at the rel-1-2 branch
database.mysql file ... Which in theory shouldnt have any of the new
stuff like marc, websites etc in it yet.

> 
> Today, I will ask for the  "uploadedmarc" table structure (in acqui.simple).
> 
> PLEASE, when you update you local mysql-DB, don't forget cvs ignore it, 
> so update database.mysql immediatly, so I will be able to do the changes 
> also...
> I've searched "uploadedmarc" table everywhere and could'nt find it ;-(((
> 

Im not sure about these other tables, but we do need to make sure we are
working on the correct branch. So that we dont miss things. Or commit
changes to places we dont want them.

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From chris at katipo.co.nz  Wed May 15 14:56:03 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Wed May 15 14:56:03 2002
Subject: [Koha-devel] adding biblio
In-Reply-To: <3CE2747B.7080107@free.fr>
References: <3CE2747B.7080107@free.fr>
Message-ID: <1021499857.15610.7.camel@orbweb.katipo.co.nz>

On Thu, 2002-05-16 at 02:45, paul POULAIN wrote:
> I've just commited 2 small corrections in newbiblio and addorder scripts.
> 
> But my question is still here !
> When you're on a basket and click on a biblio link, you're asking the 
> system to do something strange...
> I explain : you call "newbiblio.pl", which mean you want to ADD a 
> biblio/biblioitem. See, for example, barcode calculation in newbiblio.pl.
> Chris told me it was supposed to EDIT the biblio/biblioitem.
> 
No, its supposed to edit the Order for a biblio/biblioitem.
Its also supposed to add an Order, the script serves a double purpose.
Its badly named thats for sure. And when you are that the page after
coming from a biblio in basket.pl (IE coming from an existing order) it
should say Modify Order.

> I dig 3 hours in this code, and still does not understand what happends, 
> where it's wrong, and how to correct. What i'm sure, is that it has a 
> strange behaviour.
> Could someone (from katipo maybe) have a *deep* look and explain me or 
> correct the problem ?

Ill look into it after work today.

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From am12 at bolis.com  Wed May 15 16:50:25 2002
From: am12 at bolis.com (Alan Millar)
Date: Wed May 15 16:50:25 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
Message-ID: <20020515164928.A6129@hock.local>

Hi-  I hope this doesn't sound like criticism of the efforts so far; I think
Koha is excellent work.  However, I'm wondering about the DBI usage in
the code.  It appears that everything I've read on DBI says not to 
put variables into the SQL statement but to use placeholder parameters
instead.

For example, right now everything looks something like this:

  my $q_value=$dbh->quote($value);
  my $sth=$dbh->prepare("select my_field from my_table where my_criteria=$q_value");
  $sth->execute;

Whereas what I've read on the subject says it should be done like:

  my $sth=$dbh->prepare("select my_field from my_table where my_criteria=?");
  $sth->execute($value);

This doesn't require double the variables for all the quoting, and 
in a loop the prepare only has to be done once.

I'm especially confused about things I see in the code like:

 $biblioitem->{'volume'}          = $dbh->quote($biblioitem->{'volume'});

I think I'd be confused in keeping track of which things you have or haven't 
quoted already.

I'd like to contribute to the project, and I'm happy to clean up
things like this as I come across them.  

I'm wondering if there is a particular reason it's being
done the way it is, or did it "just happen" this way?

Thanks!

- Alan

-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From chris at katipo.co.nz  Wed May 15 17:03:02 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Wed May 15 17:03:02 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
In-Reply-To: <20020515164928.A6129@hock.local>
References: <20020515164928.A6129@hock.local>
Message-ID: <1021507413.15610.27.camel@orbweb.katipo.co.nz>

Hi Allan

On Thu, 2002-05-16 at 11:49, Alan Millar wrote:
> Hi-  I hope this doesn't sound like criticism of the efforts so far; I think
> Koha is excellent work.  However, I'm wondering about the DBI usage in
> the code.  It appears that everything I've read on DBI says not to 
> put variables into the SQL statement but to use placeholder parameters
> instead.
> 
> For example, right now everything looks something like this:
> 
>   my $q_value=$dbh->quote($value);
>   my $sth=$dbh->prepare("select my_field from my_table where my_criteria=$q_value");
>   $sth->execute;
> 
> Whereas what I've read on the subject says it should be done like:
> 
>   my $sth=$dbh->prepare("select my_field from my_table where my_criteria=?");
>   $sth->execute($value);
> 
And $value gets quoted by $dbh automagically?
Or do we build $value up but quoting variables as we go?

> This doesn't require double the variables for all the quoting, and 
> in a loop the prepare only has to be done once.
> 
> I'm especially confused about things I see in the code like:
> 
>  $biblioitem->{'volume'}          = $dbh->quote($biblioitem->{'volume'});
> 
> I think I'd be confused in keeping track of which things you have or haven't 
> quoted already.
> 
> I'd like to contribute to the project, and I'm happy to clean up
> things like this as I come across them.  
> 
> I'm wondering if there is a particular reason it's being
> done the way it is, or did it "just happen" this way?
> 

Just happened would be the answer :)

Code clean up is something we'd appreciate a lot.

Are you registered at sourceforge?

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From am12 at bolis.com  Wed May 15 18:51:05 2002
From: am12 at bolis.com (Alan Millar)
Date: Wed May 15 18:51:05 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
In-Reply-To: <1021507413.15610.27.camel@orbweb.katipo.co.nz>; from chris@katipo.co.nz on Thu, May 16, 2002 at 12:03:33PM +1200
References: <20020515164928.A6129@hock.local> <1021507413.15610.27.camel@orbweb.katipo.co.nz>
Message-ID: <20020515185038.A6542@hock.local>

> > Whereas what I've read on the subject says it should be done like:
> > 
> >   my $sth=$dbh->prepare("select my_field from my_table where my_criteria=?");
> >   $sth->execute($value);
> > 
> And $value gets quoted by $dbh automagically?
Yes.

> Or do we build $value up but quoting variables as we go?
No, that's the beauty; you never have to call $dbh->quote ever again.
 
> Code clean up is something we'd appreciate a lot.
> 
> Are you registered at sourceforge?

No, but I'm going to go figure it out.  I've written Perl, and done a
modest amount of DBI work with it in the last year, but I'm new to
SourceForge and CVS.  A new adventure :-)

- Alan

-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From am12 at bolis.com  Wed May 15 23:23:01 2002
From: am12 at bolis.com (Alan Millar)
Date: Wed May 15 23:23:01 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
In-Reply-To: <00f101c1fc8b$b5333410$8101a8c0@oz>; from Gynn@katipo.co.nz on Thu, May 16, 2002 at 03:42:30PM +1200
References: <20020515164928.A6129@hock.local> <00f101c1fc8b$b5333410$8101a8c0@oz>
Message-ID: <20020515232211.A9045@hock.local>

I definitely do not want to get into a flame war on this, so if
it turns that direction, I'll drop the subject.

On Thu, May 16, 2002 at 03:42:30PM +1200, Gynn Lomax wrote:
> The reason it has been done this way is simple:
> I like to be able to see what values I am assign to where.
 
> With the values embedded into the query it means I can directly see what
> they match up with, e.g.:
> 
> $query = "Insert into biblioitem set
> biblionumber = $biblioitem->{'biblionumber'},
> itemtype         = $biblioitem->{'itemtype'}";

I haven't looked at enough of the code, but I haven't see 
much of that in the code.  I see things like:

        $sth=$dbh->prepare("insert into biblioitems (biblioitemnumber, biblionum
ber, volume, number, itemtype, isbn, issn, dewey, subclass, publicationyear, pub
lishercode, volumedate, volumeddesc, illus, pages, notes, size, place, lccn, mar
c) values ($biblioitemnumber, $biblionumber, $q_volume, $q_number, $q_itemtype,
$q_isbn, $q_issn, $q_dewey, $q_subclass, $q_publicationyear, $q_publishercode, $
q_volumedate, $q_volumeddesc, $q_illus, $q_pages, $q_notes, $q_size, $q_place, $
q_lccn, $q_marc)");

and I'm definitely having a hard time matching up which variable goes
with which column name.
 
> With the bind values method you get:
> $query = "Insert into biblioitem set
> biblionumber = ?,
> itemtype         = ?";
> 
> followed by later:
> $sth->execute($biblioitem->{'biblionumber'}, $biblioitem->{'itemtype'});
> 
> While for this simple example it is easy to see which value matches up, for
> more complicated queries, and those that have a lot of values it can start
> to get mor confusing.

With this method, as well as the example above (straight from marcimport.pl),
in my opinion the main problem is formatting.

Compare, for example, the following actual code:

-------------------------------------------------------------

        my $q_isbn=$dbh->quote($isbn);
        my $q_issn=$dbh->quote($issn);
        my $q_lccn=$dbh->quote($lccn);
        my $q_volume=$dbh->quote($input->param('volume'));
        my $q_number=$dbh->quote($input->param('number'));
        my $q_itemtype=$dbh->quote($input->param('itemtype'));
        my $q_dewey=$dbh->quote($input->param('dewey'));
        my $q_subclass=$dbh->quote($input->param('subclass'));
        my $q_publicationyear=$dbh->quote($input->param('publicationyear'));
        my $q_publishercode=$dbh->quote($input->param('publishercode'));
        my $q_volumedate=$dbh->quote($input->param('volumedate'));
        my $q_volumeddesc=$dbh->quote($input->param('volumeddesc'));
        my $q_illus=$dbh->quote($input->param('illustrator'));
        my $q_pages=$dbh->quote($input->param('pages'));
        my $q_notes=$dbh->quote($input->param('note'));
        my $q_size=$dbh->quote($input->param('size'));
        my $q_place=$dbh->quote($input->param('place'));
        my $q_marc=$dbh->quote($input->param('marc'));

        $sth=$dbh->prepare("insert into biblioitems (biblioitemnumber, biblionum
ber, volume, number, itemtype, isbn, issn, dewey, subclass, publicationyear, pub
lishercode, volumedate, volumeddesc, illus, pages, notes, size, place, lccn, mar
c) values ($biblioitemnumber, $biblionumber, $q_volume, $q_number, $q_itemtype,
$q_isbn, $q_issn, $q_dewey, $q_subclass, $q_publicationyear, $q_publishercode, $
q_volumedate, $q_volumeddesc, $q_illus, $q_pages, $q_notes, $q_size, $q_place, $
q_lccn, $q_marc)");

-------------------------------------------------------------

with this functional equivalent:

-------------------------------------------------------------

        $sth=$dbh->prepare("insert into biblioitems 
	(biblioitemnumber, biblionumber,
	 volume, number, 
	 itemtype, isbn, issn,
	 dewey, subclass, 
	 publicationyear, publishercode,
	 volumedate, volumeddesc, 
	 illus, pages, notes,
	 size, place,
	 lccn, marc)
	values (?, ?, ?, ?, 
	 ?, ?, ?,
	 ?, ?, ?, ?,
	 ?, ?, 
	 ?, ?, ?,
	 ?, ?, ?, ?)   ");
        $sth=$dbh->execute(
	 $biblioitemnumber, $biblionumber,
	 $input->param{'volume'}, $input->param{'number'},
	 $input->param{'itemtype'},$input->param{'isbn'},$input->param{'issn'},
	 $input->param{'dewey'}, $input->param{'subclass'},
	 $input->param{'publicationyear'}, $input->param{'publishercode'},
	 $input->param{'volumedate'}, $input->param{'volumeddesc'},
	 $input->param{'illustrator'}, $input->param{'pages'}, $input->param{'note'},
	 $input->param{'size'}, $input->param{'place'},
	 $input->param{'lccn'}, $input->param{'marc)
	);

-------------------------------------------------------------

I'm sure it is just a matter of what each person is accustomed to,
but I can match up parameters easier in the second example than
I can in the original.

> For the very few queries I have run across that are executed more than once,
> the values being put into them are an unknown list (in terms of length),
> e.g.
> 
> $query = "Insert into deleteditems values ("
> foreach my $value (@results) {
>     $value  = $dbh->quote($value);
>     $query .= "$value,";
> } # foreach
> 
> and I'm unsure if the bind values method can handle this, so avoided it.

This code snippet looks like it is inserting an "unknown list" of 
column values into a table, on the assumption that the unknown 
list just happens to match up with the exact correct order of 
columns in the table.   This is different than the original issue
which is in the context of inserting multiple rows, not columns.

I'm definitely going to be stepping into hot water here, and so I must
apologize in advance for that.  But as to the columns, it seems to
me to be unsafe coding practice to insert values into a table 
without column names, because somebody somewhere is going to do 
some db modification, whether through custom changes or version 
upgrades, and some column will missing or out of order and it will
break.  Hashes perhaps are a good solution for this type of thing.

In any case, the bound parameter method works just fine for this:

 $query = "Insert into deleteditems values ("
 foreach my $dummy (@results) {
     $query .= "?,";
 } # foreach
 $query=~s/,$/\)/;
 $sth->execute(@results);

And there is probably a shorter way to do the correct number
of question marks via a count of @results.

> The other advantage of the method I have used is that you can print out the
> entire query before it is executed - so you can examine it for bugs. Whereas
> with the bind value method you never get to see the query in it's entirety.
 
OK, with the quoted method you only have to print one thing, while
with the bound method you have to print more.  That's true.  

I sure don't want to start a flame war, and if it sounds like I
am, please just ignore me and I'll drop it.  Thanks for the
education on another point of view.

- Alan


-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From paul.poulain at free.fr  Thu May 16 00:44:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Thu May 16 00:44:02 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
References: <20020515164928.A6129@hock.local> <00f101c1fc8b$b5333410$8101a8c0@oz> <20020515232211.A9045@hock.local>
Message-ID: <3CE363CC.9020101@free.fr>

Alan Millar wrote:
<SNIP>

>I'm definitely going to be stepping into hot water here, and so I must
>apologize in advance for that.  But as to the columns, it seems to
>me to be unsafe coding practice to insert values into a table 
>without column names, because somebody somewhere is going to do 
>some db modification, whether through custom changes or version 
>upgrades, and some column will missing or out of order and it will
>break.  Hashes perhaps are a good solution for this type of thing.
>
>In any case, the bound parameter method works just fine for this:
>
> $query = "Insert into deleteditems values ("
> foreach my $dummy (@results) {
>     $query .= "?,";
> } # foreach
> $query=~s/,$/\)/;
> $sth->execute(@results);
>
>And there is probably a shorter way to do the correct number
>of question marks via a count of @results.
>
I STRONGLY AGREE WITH YOU.
============================
I've submitted a patch a few days ago, modifying the "deletedbiblio" table.
This patch was needed because of such an "insert into XX values (XX)" 
that was not working properly...

Note also it's not recommended to do a 'select * from ...". We should 
always do "select field,field,field from ...". 2 reasons for this :
* the DBI structure permits use of another DB (in theory at least). Some 
databases don't enjoy a "select * from table1,table2 where 
join_between_table1_and_table2". the need "select table1.*,table2.* from 
..."
* If we build joins of 3 or more tables, the resulting row can be quite 
huge...

A third argument :
* if we have fields with the same name in a multi-table select, a select 
* results in a "ambiguous clause" failure, or something wrong like this 
(note it can be avoided if you plan to have all your fields differents)

>I sure don't want to start a flame war, and if it sounds like I
>am, please just ignore me and I'll drop it.  Thanks for the
>education on another point of view.
>
It's not a flame war beginning, as you don't say we are "dummies", 
"stupids", "we MUST do it as you want"... ;-) We are speaking of good 
coding practices.
--
Paul




From paul.poulain at free.fr  Thu May 16 00:48:02 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Thu May 16 00:48:02 2002
Subject: [Koha-devel] coding practices
Message-ID: <3CE364CB.5020302@free.fr>

I will try to build a page with "coding practices" for koha on the wiki.

It will contain Alan proposal about perl/mysql proposals (use of ? where 
it causes no read-havoc. For example, in a prepare("select x,y,z from 
table where param=?"). In this case, it's undoubtfully more readable.

I also want to ask about an eternal question :
Do we use tab or space for indenting our programs ?

I prefer tabs. For instance, soft is indented sometimes with spaces, 
sometimes with tabs, which makes them not easily readables.
what's your opinion ?
--
Paul





From paul.poulain at free.fr  Thu May 16 01:20:04 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Thu May 16 01:20:04 2002
Subject: [Koha-devel] about cvs usage
References: <3CE27E49.2050006@free.fr> <1021499297.556.3.camel@orbweb.katipo.co.nz>
Message-ID: <3CE36C6D.7070508@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020516/ff8f4a6e/attachment.htm 

From chris at katipo.co.nz  Thu May 16 02:59:05 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Thu May 16 02:59:05 2002
Subject: [Koha-devel] about cvs usage
In-Reply-To: <3CE36C6D.7070508@free.fr>
References: <3CE27E49.2050006@free.fr>
	<1021499297.556.3.camel@orbweb.katipo.co.nz>  <3CE36C6D.7070508@free.fr>
Message-ID: <1021543226.556.50.camel@orbweb.katipo.co.nz>

    
It seems i've problems with cvs...
so, what I do :
* if i want to work on rel_1_2 branch :
# cvs -z3 -b rel_1_2
-d:ext:tipaul at cvs.koha.sourceforge.net:/cvsroot/koha co koha
It update my local files to "rel_1_2" status.
Then I work.
Then I do 
# cvs commit file_modified
It commits file_modified to the rel_1_2 branch.

* if i want to work on main branch (development one), i do :
# cvs -z3 -d:ext:tipaul at cvs.koha.sourceforge.net:/cvsroot/koha co koha
It updates my local files to main branch.
Then I work.
Then I do
# cvs commit file_modified
It commits file_modified to main branch.

I just tried to do it on main branch, and it does nothing... So I think
i'm doing something wrong, but what ?


Hi Paul

What I have, is 3 checkouts running at the moment. What i did was
checkout the main branch and its now called koha-main.
Checked out the rel-1-2 branch and moved it to koha-rel-1-2 and checked
out the rel-1-4-marc one. 

This is probably a bit of a workaround on my part. But it seems to work
well, in terms of working in separate branches.

Id be interested in hearing how others work. 

Question for bugfixes : if i du a small bugfix that affect 1_2 branch as
well as main one, how do i commit the change in both ? or maybe i just
have to correct in 1_2 branch and we have a method to copy it to the
main one after.

Im fairly certain we can merge changes back from a branch into the main.
http://www.cvshome.org/docs/manual/cvs_5.html#SEC61 Tells you a little
bit about it. Im not sure whether there is a french version of these
documents.

Question 2 : how to avoid having to type my "#
tipaul at cvs.koha.sourceforge.net's password:" 50 times a day ?


Ahh this question i can actually answer with some certainty.
You can generate keys for use with ssh, if you do this it will use the
keys to connect instead. And you wont have to type your password.

https://sourceforge.net/docman/display_doc.php?docid=761&group_id=1

Tells you about it.

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From chris at katipo.co.nz  Thu May 16 03:03:05 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Thu May 16 03:03:05 2002
Subject: [Koha-devel] coding practices
In-Reply-To: <3CE364CB.5020302@free.fr>
References: <3CE364CB.5020302@free.fr>
Message-ID: <1021543477.556.56.camel@orbweb.katipo.co.nz>

On Thu, 2002-05-16 at 19:50, paul POULAIN wrote:
> I will try to build a page with "coding practices" for koha on the wiki.
> 
> It will contain Alan proposal about perl/mysql proposals (use of ? where 
> it causes no read-havoc. For example, in a prepare("select x,y,z from 
> table where param=?"). In this case, it's undoubtfully more readable.
>
This sounds like a great idea Paul.

And I agree with your response to Alan, his post was well thought out
and well written and in no way inflammatory.
Its always good to hear how others would do things. Thats how we learn.

 
> I also want to ask about an eternal question :
> Do we use tab or space for indenting our programs ?
> 
> I prefer tabs. For instance, soft is indented sometimes with spaces, 
> sometimes with tabs, which makes them not easily readables.
> what's your opinion ?

Hmm I use whatever emacs indents them as :)
Im of no fixed opinion either way, but if people can put forward a case
for a standard, ill stick to it :)

Chris

-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From douglas at katipo.co.nz  Thu May 16 03:16:01 2002
From: douglas at katipo.co.nz (Douglas Bagnall)
Date: Thu May 16 03:16:01 2002
Subject: [Koha-devel] DBI digest
Message-ID: <3CE38677.30603@katipo.co.nz>

Alan wrote:

 >  foreach my $dummy (@results) {
 >      $query .= "?,";
 >  } # foreach

 > And there is probably a shorter way to do the correct number
 > of question marks via a count of @results.


That would be the x operator.

'?,' x 4  eq  '?,?,?,?,'


cheers,

Douglas





From paul.poulain at free.fr  Thu May 16 05:20:04 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Thu May 16 05:20:04 2002
Subject: [Koha-devel] about cvs usage
References: <3CE27E49.2050006@free.fr>	<1021499297.556.3.camel@orbweb.katipo.co.nz>  <3CE36C6D.7070508@free.fr> <1021543226.556.50.camel@orbweb.katipo.co.nz>
Message-ID: <3CE3A4A1.9090705@free.fr>

An HTML attachment was scrubbed...
URL: http://lists.koha.org/pipermail/koha-devel/attachments/20020516/d990ac20/attachment.htm 

From pate at eylerfamily.org  Thu May 16 05:59:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Thu May 16 05:59:02 2002
Subject: [Koha-devel] about cvs usage
In-Reply-To: <1021543226.556.50.camel@orbweb.katipo.co.nz>
Message-ID: <Pine.LNX.4.30.0205160851100.12268-100000@bigfun.whirlycott.com>

On 16 May 2002, Chris Cormack wrote:

>
(I think this bit is from Paul)
> It seems i've problems with cvs...
> so, what I do :
> * if i want to work on rel_1_2 branch :
> # cvs -z3 -b rel_1_2
> -d:ext:tipaul at cvs.koha.sourceforge.net:/cvsroot/koha co koha
> It update my local files to "rel_1_2" status.
> Then I work.
> Then I do
> # cvs commit file_modified
> It commits file_modified to the rel_1_2 branch.
>
> * if i want to work on main branch (development one), i do :
> # cvs -z3 -d:ext:tipaul at cvs.koha.sourceforge.net:/cvsroot/koha co koha
> It updates my local files to main branch.
> Then I work.
> Then I do
> # cvs commit file_modified
> It commits file_modified to main branch.
>
> I just tried to do it on main branch, and it does nothing... So I think
> i'm doing something wrong, but what ?
>
>
> Hi Paul
>
> What I have, is 3 checkouts running at the moment. What i did was
> checkout the main branch and its now called koha-main.
> Checked out the rel-1-2 branch and moved it to koha-rel-1-2 and checked
> out the rel-1-4-marc one.
>
> This is probably a bit of a workaround on my part. But it seems to work
> well, in terms of working in separate branches.
>

This is what I do as well.  I have a koha directory with koha, rc, and
rel_1_2 subdirs.  koha contains a checkout from the main line, rc has an
unpacked copy of the latest RC tarball, and rel_1_2 contains a checkout
from the rel_1_2 branch.

For the moment I'm ignoring the rel-1-4 branch, but will eventually create
a dir for that as well (when we're ready to start merging 1.2 fixes into
1.3).

> Id be interested in hearing how others work.
>
> Question for bugfixes : if i du a small bugfix that affect 1_2 branch as
> well as main one, how do i commit the change in both ? or maybe i just
> have to correct in 1_2 branch and we have a method to copy it to the
> main one after.
>
> Im fairly certain we can merge changes back from a branch into the main.
> http://www.cvshome.org/docs/manual/cvs_5.html#SEC61 Tells you a little
> bit about it. Im not sure whether there is a french version of these
> documents.

Yes, this can be done.  Another source to read through is:

http://cvsbook.red-bean.com/cvsbook.html#Merging_Changes_From_Branch_To_Trunk

(which also has spanish, german, and japanese translations.  french isn't
there yet, but it is under an open license so there is nothing blocking
someone from starting a translation.)

>
> Question 2 : how to avoid having to type my "#
> tipaul at cvs.koha.sourceforge.net's password:" 50 times a day ?
>
>
> Ahh this question i can actually answer with some certainty.
> You can generate keys for use with ssh, if you do this it will use the
> keys to connect instead. And you wont have to type your password.
>
> https://sourceforge.net/docman/display_doc.php?docid=761&group_id=1
>
> Tells you about it.
>
> Chris
>




From tonnesen at cmsd.bc.ca  Thu May 16 06:22:01 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Thu May 16 06:22:01 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
In-Reply-To: <20020515232211.A9045@hock.local>
Message-ID: <Pine.LNX.3.96.1020516061659.1336P-100000@hss-labs.cmsd.bc.ca>


On Wed, 15 May 2002, Alan Millar wrote:

> I definitely do not want to get into a flame war on this, so if
> it turns that direction, I'll drop the subject.

No flame war from me.  I didn't know about the '?' method.  I like it a
lot, but did you _have_ to use _my_ code as an example?  ;)

As far as indenting goes, Paul, I'm with Chris, except I do whatever vim
does by default.  I'm all for setting a standard, I'm sure I can make vim
do whatever we decide.

Steve.



>         my $q_isbn=$dbh->quote($isbn);
>         my $q_issn=$dbh->quote($issn);
>         my $q_lccn=$dbh->quote($lccn);
>         my $q_volume=$dbh->quote($input->param('volume'));
>         my $q_number=$dbh->quote($input->param('number'));
>         my $q_itemtype=$dbh->quote($input->param('itemtype'));
>         my $q_dewey=$dbh->quote($input->param('dewey'));
>         my $q_subclass=$dbh->quote($input->param('subclass'));
>         my $q_publicationyear=$dbh->quote($input->param('publicationyear'));
>         my $q_publishercode=$dbh->quote($input->param('publishercode'));
>         my $q_volumedate=$dbh->quote($input->param('volumedate'));
>         my $q_volumeddesc=$dbh->quote($input->param('volumeddesc'));
>         my $q_illus=$dbh->quote($input->param('illustrator'));
>         my $q_pages=$dbh->quote($input->param('pages'));
>         my $q_notes=$dbh->quote($input->param('note'));
>         my $q_size=$dbh->quote($input->param('size'));
>         my $q_place=$dbh->quote($input->param('place'));
>         my $q_marc=$dbh->quote($input->param('marc'));
> 
>         $sth=$dbh->prepare("insert into biblioitems (biblioitemnumber, biblionum
> ber, volume, number, itemtype, isbn, issn, dewey, subclass, publicationyear, pub
> lishercode, volumedate, volumeddesc, illus, pages, notes, size, place, lccn, mar
> c) values ($biblioitemnumber, $biblionumber, $q_volume, $q_number, $q_itemtype,
> $q_isbn, $q_issn, $q_dewey, $q_subclass, $q_publicationyear, $q_publishercode, $
> q_volumedate, $q_volumeddesc, $q_illus, $q_pages, $q_notes, $q_size, $q_place, $
> q_lccn, $q_marc)");




From pate at eylerfamily.org  Thu May 16 07:28:04 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Thu May 16 07:28:04 2002
Subject: [Koha-devel] spanish work on koha
Message-ID: <Pine.LNX.4.30.0205160945330.12824-100000@bigfun.whirlycott.com>

Nick,
How far do we want to go in getting koha in front of hispanic developers
and users?  The recent moves in Mexico by Hispalinux may prove another
good avenue for us to approach this potential audience.

-pate




From paul.poulain at free.fr  Thu May 16 09:48:03 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Thu May 16 09:48:03 2002
Subject: [Koha-devel] marc stuff
Message-ID: <3CE3E37A.6000400@free.fr>

I've commited my marc stuff in the main branch.
I've done this because when i asked for a marc branch i thought the main 
branch was the stable one. As Chris explains me it was the dev one, i 
think we don't need a marc branch. Why ? Because I want the 
marc-compliance for september-02, so i will have a hard work on it, and 
it should be in the next release (1.4 ?)

Hope kiwis have had a good night, and americans will have to.

See you tomorrow

--
Paul




From tonnesen at cmsd.bc.ca  Thu May 16 11:28:03 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Thu May 16 11:28:03 2002
Subject: [Koha-devel] marc stuff
In-Reply-To: <3CE3E37A.6000400@free.fr>
Message-ID: <Pine.LNX.3.96.1020516111654.1336R-100000@hss-labs.cmsd.bc.ca>

On Thu, 16 May 2002, paul POULAIN wrote:

> I've commited my marc stuff in the main branch.
> I've done this because when i asked for a marc branch i thought the main 
> branch was the stable one. As Chris explains me it was the dev one, i 
> think we don't need a marc branch. Why ? Because I want the 
> marc-compliance for september-02, so i will have a hard work on it, and 
> it should be in the next release (1.4 ?)
> 
> Hope kiwis have had a good night, and americans will have to.

And Canadians?  :)

I have a Marc schema question for you Paul, if you're still around
today...

How do I store the following tag:

100  a Dolch, Edward W.
     q (Edward William),
     d 1889-1961

in marc_1XX_tag_table I'd put:
   
  bibcode=1234
  tagnumber=100
  tagorder=1
  indicator=##
  tagvalue=Dolch, Edward W.
  valuebloblink=NULL

I seem to be missing the subfield code, and I need a unique id for the
record for editing purposes.  Did you intend to put a separate record in
marc_1XX_tag_table for each subfield?  We'd also need some way to tie all
the subfields of a given tag together.

Steve.





From tonnesen at cmsd.bc.ca  Thu May 16 12:38:02 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Thu May 16 12:38:02 2002
Subject: [Koha-devel] marc stuff
In-Reply-To: <Pine.LNX.3.96.1020516111654.1336R-100000@hss-labs.cmsd.bc.ca>
Message-ID: <Pine.LNX.3.96.1020516122122.1336U-100000@hss-labs.cmsd.bc.ca>

On Thu, 16 May 2002, Tonnesen Steve wrote:

> I seem to be missing the subfield code, and I need a unique id for the
> record for editing purposes.  Did you intend to put a separate record in
> marc_1XX_tag_table for each subfield?  We'd also need some way to tie all
> the subfields of a given tag together.

Suggestion:

Add back in the subfield tables for storing subfield information:

        CREATE TABLE marc_0XX_tag_table (
                tagcode bigint(20) unsigned NOT NULL auto_increment,
                bibcode bigint(20) NOT NULL default '0',
                tagnumber char(3) NOT NULL default '',
                tagorder tinyint(4) NOT NULL default '0',
                indicator char(2) NOT NULL default '',
                PRIMARY KEY (tagcode),
                KEY  (bibcode,tagnumber,tagorder)
                ) TYPE=MyISAM;
        CREATE TABLE marc_0XX_subfield_table (
                subfieldcode bigint(20) unsigned NOT NULL auto_increment,
                tagcode bigint(20) NOT NULL default '0',
                bibcode bigint(20) NOT NULL default '0',
                subfieldorder tinyint(4) NOT NULL default '0',
                subfieldcode char(1) NOT NULL default '',
                subfieldvalue varchar(255) default NULL,
                valuebloblink bigint(20) default NULL,
                PRIMARY KEY (subfieldcode),
                KEY (bibcode,tagcode,subfieldcode)
                ) TYPE=MyISAM;


Then my previous example:

100  a Dolch, Edward W.
     q (Edward William),
     d 1889-1961


would be stored as:


marc_1XX_tag_table
  tagcode=658
  bibcode=154
  tagnumber=100
  tagorder=0
  indicator=00

marc_1XX_subfield_table
  subfieldcode=1532
  tagcode=658
  bibcode=154
  subfieldorder=1
  subfieldcode=a
  subfieldvalue=Dolch, Edward W.
  valuebloblink=NULL

  subfieldcode=1533
  tagcode=658
  bibcode=154
  subfieldorder=2
  subfieldcode=q
  subfieldvalue=(Edward William),
  valuebloblink=NULL

  subfieldcode=1534
  tagcode=658
  bibcode=154
  subfieldorder=1
  subfieldcode=d
  subfieldvalue=1889-1961
  valuebloblink=NULL



It would also be possible to merge these two tables into one, but all of
the subfields of a given tag would have to have a unique tag identifier to
tie them together.

Steve

PS:  If you're back on IRC this evening, you can beep me by typing:

  /msg steve Wake up already

that sends me a private message and makes my console beep.





From Gynn at katipo.co.nz  Thu May 16 18:08:04 2002
From: Gynn at katipo.co.nz (Gynn Lomax)
Date: Thu May 16 18:08:04 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
References: <20020515164928.A6129@hock.local> <00f101c1fc8b$b5333410$8101a8c0@oz> <20020515232211.A9045@hock.local>
Message-ID: <016001c1fd3f$a41fd0c0$8101a8c0@oz>

> I definitely do not want to get into a flame war on this, so if
> it turns that direction, I'll drop the subject.

No, it's good to discuss differences in code generation, you learn things
that you might have otherwise missed :)

It mightn't be such a bad idea to decide on a set way that the code should
look like, that way it would be easier for someone new comming in to
understand it all.

Gynn.




From pate at eylerfamily.org  Thu May 16 18:14:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Thu May 16 18:14:02 2002
Subject: [Koha-devel] Question on proper/preferred DBI usage?
In-Reply-To: <016001c1fd3f$a41fd0c0$8101a8c0@oz>
Message-ID: <Pine.LNX.4.30.0205162109170.19375-100000@bigfun.whirlycott.com>

On Fri, 17 May 2002, Gynn Lomax wrote:

> > I definitely do not want to get into a flame war on this, so if
> > it turns that direction, I'll drop the subject.
>
> No, it's good to discuss differences in code generation, you learn things
> that you might have otherwise missed :)
>
> It mightn't be such a bad idea to decide on a set way that the code should
> look like, that way it would be easier for someone new comming in to
> understand it all.

Anyone want to look at perltidy?  It would certainly make for a nice
pre-checkin step (maybe along with running testKoha.pl).

-pate

-pate

>
> Gynn.
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: bandwidth at sourceforge.net
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From paul.poulain at free.fr  Thu May 16 23:57:01 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Thu May 16 23:57:01 2002
Subject: [Koha-devel] marc stuff
References: <Pine.LNX.3.96.1020516111654.1336R-100000@hss-labs.cmsd.bc.ca>
Message-ID: <3CE4AA42.8050504@free.fr>

Tonnesen Steve wrote:

>On Thu, 16 May 2002, paul POULAIN wrote:
>
>And Canadians?  :)
>
In french, am?ricains, means people from notrh-America (mexico, US, 
Canada) AND people from USA. so in my mind yu were included ;-)

>I have a Marc schema question for you Paul, if you're still around
>today...
>
>How do I store the following tag:
>
>100  a Dolch, Edward W.
>     q (Edward William),
>     d 1889-1961
>
>in marc_1XX_tag_table I'd put:
>   
>  bibcode=1234
>  tagnumber=100
>  tagorder=1
>  indicator=##
>  tagvalue=Dolch, Edward W.
>  valuebloblink=NULL
>
>I seem to be missing the subfield code, and I need a unique id for the
>record for editing purposes.  Did you intend to put a separate record in
>marc_1XX_tag_table for each subfield?  We'd also need some way to tie all
>the subfields of a given tag together.
>
You did'nt undestand my idea : in the 1XX_tag_table, you store the full 
line. So, the record looks :

bibcode=1234
  tagnumber=100
  tagorder=1
  indicator=##
  tagvalue=$aDolch, Edward W.$q(Edward William)$d 1889-1961
  valuebloblink=NULL

Don't forget that the tag_tables are used only for presentation purposes 
only. We search all with tag_word table.
We can split thit record with a simple regexp, to get more user-friendly 
presentation.
A regexp is FASTER than reading 10 or 15 records from the database. More 
than that, with your structure, we have to join 3 tables (biblio, 
tag_table, subfield_table) before getting any information. With my 
structure, we need only 2.
So, I think (no, in fact I'm sure ;-)) that we don't need a subfield_table.

About other modifications :
FROM :

 CREATE TABLE marc_biblio (
! 		bibcode bigint(20) unsigned NOT NULL auto_increment,
  		datecreated date NOT NULL default '0000-00-00',
TO :
  	CREATE TABLE marc_biblio (
! 		bibid bigint(20) unsigned NOT NULL auto_increment,
  		datecreated date NOT NULL default '0000-00-00',

I agree.

FROM :

  	CREATE TABLE marc_0XX_tag_table (
! 		bibcode bigint(20) NOT NULL default '0',
  		tagnumber char(3) NOT NULL default '',
  		tagorder tinyint(4) NOT NULL default '0',
  		indicator char(2) NOT NULL default '',
! 		tagvalue varchar(255) default NULL,
! 		valuebloblink bigint(20) default NULL,
! 		PRIMARY KEY  (bibcode,tagnumber,tagorder)
  		) TYPE=MyISAM;

TO :

  	CREATE TABLE marc_0XX_tag_table (
! 		tagid bigint(20) unsigned NOT NULL auto_increment,
! 		bibid bigint(20) NOT NULL default '0',
  		tagnumber char(3) NOT NULL default '',
  		tagorder tinyint(4) NOT NULL default '0',
  		indicator char(2) NOT NULL default '',
! 		PRIMARY KEY (tagid),
! 		KEY (bibid,tagnumber,tagorder)
  		) TYPE=MyISAM;

I STRONGLY DISAGREE !
Why ?
because (bibid,tagnumber,tagorder) IS A PRIMARY KEY. You can 
undoubtfully find a record with those three informations. So we don't 
need a auto_increment field that is redundant. It's a DB-design mistake. 
I'm (almost) sure it's a bad idea.
Note tagvalue and valuebloblink deseappear and should also re-appear if 
we drop subfields_table.


I won't be reachable before 4PM-GMT. I'll try to be on irc for a few 
moment at 4PM-GMT to speak with you about the structure. Hoping we will 
be able to reach a "definitive" structure.
--
Paul






From am12 at bolis.com  Fri May 17 00:47:02 2002
From: am12 at bolis.com (Alan Millar)
Date: Fri May 17 00:47:02 2002
Subject: [Koha-devel] Catalogue API
Message-ID: <20020517004607.A15374@hock.local>

I'd like to help a little in development or code clean-up.  But, wow, it
looks like it's going to be a full time job just keeping track of the 
mailing list(s), Wiki, and IRC logs...   

I'd like to throw in my opinion on some development directions, but
I can't figure out where I should be doing it, so I guess I'll do
it here :-)

This is all hobby for me; I have about 1500 books in my personal
collection that I want to catalog.  I don't have the same issues that
"real" libraries have.   In that context, I really like MARC compatibility
so I can snarf data from elsewhere to avoid data entry, but I don't
want to eat/sleep/breath MARC records as my way of working on the data.  
Yes, I understand that some librarians do want that.

The library patron will never want to see MARC data, so if for no
other reason than that there will always need to be an abstraction
of the data, such as making bibliographic data separate from individual
item copy data.  I think that the current three-tier structure of
biblio, biblioitems, and items is actually a very good one.

There are some comments on the Wiki about the Catalogue API saying that
the kohadb functions would eventually go away when the Marc stuff is
done.  That looks like a bad move to me.  I think the functions
should definitely stay abstracted at the level of add/update/delete 
bilbio information and add/update/delete item copy information.

As long as updates are done through the API, the kohadb could go away
(although I'm not convinced that is a good idea, and if updates are
done through the API it wouldn't need to) but the data model should not
go away.

I'd like to see (and want to help) Koha extend to have some smoother
handling for other item types, such as music CD's or videos, including
using  EAN/UPC codes like how ISBN's are used for books.  Would the
pure MARC version handle this equally well?

Also, I've read a little on the Lib of Congress discussions for XML
representation of MARC data.  It seems short-sighted to me to
tie the database too closely to the text-only view of MARC, down
to the $ subfield delimiters.  I'm not at all suggesting putting 
XML in the Koha database; rather arguing for a higher-level
abstraction that can represent the MARC data without being too
file-format specific.

As a non-library person, I may be all wrong here, but thanks
for letting me share my thoughts.

- Alan

-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From tonnesen at cmsd.bc.ca  Fri May 17 09:30:03 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Fri May 17 09:30:03 2002
Subject: [Koha-devel] Catalogue API
In-Reply-To: <20020517004607.A15374@hock.local>
Message-ID: <Pine.LNX.3.96.1020517092213.1336e-100000@hss-labs.cmsd.bc.ca>

On Fri, 17 May 2002, Alan Millar wrote:

> There are some comments on the Wiki about the Catalogue API saying that
> the kohadb functions would eventually go away when the Marc stuff is
> done.  That looks like a bad move to me.  I think the functions
> should definitely stay abstracted at the level of add/update/delete 
> bilbio information and add/update/delete item copy information.

The user interface does not have to look anything like MARC at all.  Some
librarians will want to see and edit marc data directly, many will not,
very few patrons would have a clue what they were looking at.  The
HTML::Template work is intended to deal with exactly this issue.  We can
have 10 different templates for viewing bibliographic data about a book.
One for a simple MARC layout, one for a full MARC layout, one for
librarians, one for OPAC, one for children, one for small children, etc.

We just want to switch to storing the data in a MARC compatible format to
ease interchanging data with other libraries that are not using Koha. 
Think interlibrary loans, for example.  It will also allow librarians to
store information that cannot currently be stored in the kohadb without
modifying the database and the programming.

MARC doesn't make the distinction between biblio and biblioitems the way
the kohadb does, although I intend to use local MARC tags to continue to
make this distinction within Koha.  MARC _does_ allow multiple items to
share the same MARC record though. 


> I'd like to see (and want to help) Koha extend to have some smoother
> handling for other item types, such as music CD's or videos, including
> using  EAN/UPC codes like how ISBN's are used for books.  Would the
> pure MARC version handle this equally well?

I guarantee you that the MARC format has the capability to store this
information.  It is very comprehensive.


> Also, I've read a little on the Lib of Congress discussions for XML
> representation of MARC data.  It seems short-sighted to me to
> tie the database too closely to the text-only view of MARC, down
> to the $ subfield delimiters.  I'm not at all suggesting putting 
> XML in the Koha database; rather arguing for a higher-level
> abstraction that can represent the MARC data without being too
> file-format specific.

We will not be storing data in either MARC or XML format.  The data will
be stored in an SQL backend (MySQL at the moment).  The data will just be
stored in the SQL backend in such a way that MARC or MARC-XML data can be
imported/exported easily.


Hope I've clarified this a bit for you.

Steve.




From am12 at bolis.com  Fri May 17 15:31:02 2002
From: am12 at bolis.com (Alan Millar)
Date: Fri May 17 15:31:02 2002
Subject: [Koha-devel] Catalogue API
In-Reply-To: <Pine.LNX.3.96.1020517092213.1336e-100000@hss-labs.cmsd.bc.ca>; from tonnesen@cmsd.bc.ca on Fri, May 17, 2002 at 09:29:31AM -0700
References: <20020517004607.A15374@hock.local> <Pine.LNX.3.96.1020517092213.1336e-100000@hss-labs.cmsd.bc.ca>
Message-ID: <20020517153017.A18286@hock.local>

Hi Steve-

Thanks for discussing this.  I'm really not trying to pick
a fight; I'm just trying to see if Koha is going in a direction
that is compatible with my goals.  If not, I'm happy to look
elsewhere for solutions to my own personal needs.

On Fri, May 17, 2002 at 09:29:31AM -0700, Tonnesen Steve wrote:
> On Fri, 17 May 2002, Alan Millar wrote:
> > I think the functions
> > should definitely stay abstracted at the level of add/update/delete 
> > bilbio information and add/update/delete item copy information.
> 
> The user interface does not have to look anything like MARC at all.  Some
> librarians will want to see and edit marc data directly, many will not,
> very few patrons would have a clue what they were looking at.  The
> HTML::Template work is intended to deal with exactly this issue. 

Hmm, I don't see HTML templating addressing this issue at all.  I'm
looking at it in terms of being a programmer and wanting to operate
on the data in a reasonable fashion.  HTML templating does not address
the issues of data normalization/denormalization and how the
logic manipulates the data entities.

> We just want to switch to storing the data in a MARC compatible format to
> ease interchanging data with other libraries that are not using Koha. 

I agree with that goal, but disagree with what "MARC compatible" means.  Based
on the current development branch with acqui.simple/marcimport.pl, we
are already MARC compatible.  Compatibility is not a yes/no question,
it is a "how much" question.

> Think interlibrary loans, for example.  It will also allow librarians to
> store information that cannot currently be stored in the kohadb without
> modifying the database and the programming.

Ah, here we get to the meat of the issue.  I think things like the
MARC_nXX_subfield_table things should be used for *only* the MARC
elements that are *not* represented in the KohaDB.
 
> MARC doesn't make the distinction between biblio and biblioitems the way
> the kohadb does, although I intend to use local MARC tags to continue to
> make this distinction within Koha.  MARC _does_ allow multiple items to
> share the same MARC record though. 

This reminds me of "When all you have is a hammer" (or perhaps "your 
favorite tool is a hammer") then "everything starts to look like a nail".

Storing Koha-specific data in local Marc tags, just for the sake of
saying it is all Marc, seems to me to be arbitrary and inefficient.
 
> Hope I've clarified this a bit for you.

Honestly, I'm not trying to be difficult, but no, not yet.

Consider the following:

  select title, author, isbn, dewey
  from biblio, biblioitems
  where biblio.biblionumber=biblioitems.biblionumber

How would that be done with the new "pure Marc" database?

Take the earlier example:

marc_1XX_subfield_table
  subfieldcode=1532
  tagcode=658
  bibcode=154
  subfieldorder=1
  subfieldcode=a
  subfieldvalue=Dolch, Edward W.
  valuebloblink=NULL

What I'm gathering from your proposal is that the above query would be
replaced with something like:

  select authortable.subfieldvalue as author,
     titletable.subfieldvalue as title,
     isbntable.subfieldvalue as isbn,
     deweytable.subfieldvalue as dewey,
    from marc_1XX_subfield_table as authortable,
       marc_2XX_subfield_table as titletable,
       marc_0XX_subfield_table as isbntable,
       marc_0XX_subfield_table as deweytable,
       marc_1XX_tag_table as authortagtable,
       marc_2XX_tag_table as titletagtable,
       marc_0XX_tag_table as isbntagtable,
       marc_0XX_tag_table as deweytagtable
    where authortable.tagcode=authortagtable.tagcode
        and authortagtable.fieldcode='100'
    and titletable.tagcode=titletagtable.tagcode
        and titletagtable.fieldcode='245'
    and isbntable.tagcode=isbntagtable.tagcode
        and isbntagtable.fieldcode='020'
    and deweytable.tagcode=deweytagtable.tagcode
        and deweytagtable.fieldcode='082'
    and authortable.bibcode = titletable.bibcode
    and authortable.bibcode = isbntable.bibcode
    and authortable.bibcode = deweytable.bibcode

And *that* is only assembling the record set (and only 4 columns); it 
doesn't even include *which* records to select.

I can't even begin to figure out what the real one-to-many relationships
would be here.

As a programmer, I cannot see this being practical for my skill set
to work on.  I really just want to be able to select columns from tables
in a reasonable manner.

I don't want to sound harsh, but frankly, if this is the goal, I'd 
like to know now so I can wish you good luck on it and look
elsewhere for something that fits me better.  Thanks for taking
the time to discuss it.


- Alan

-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From chris at katipo.co.nz  Sun May 19 14:01:02 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Sun May 19 14:01:02 2002
Subject: [Koha-devel] [Fwd: Paul Poulain (Kohla)]
Message-ID: <1021842160.15610.256.camel@orbweb.katipo.co.nz>

-----Forwarded Message-----

> From: ccn info <ccn.informatique at libertysurf.fr>
> To: chris at katipo.co.nz
> Subject: Paul Poulain (Kohla)
> Date: 19 May 2002 19:13:51 +0200
> 
> Hello,
> 
> Paul Poulain was hospitalized. It's not very important but he can't repply
> you and Koha developpement list for a week. May you forward this new to the
> list ( it's important for Steve !!).
> Thank you very much
> 
> R. Salmon
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From rachel at katipo.co.nz  Sun May 19 22:57:02 2002
From: rachel at katipo.co.nz (Rachel Hamilton-Williams)
Date: Sun May 19 22:57:02 2002
Subject: [Koha-devel] Nominations etc etc
Message-ID: <3CE938E9.5025.64B5458@localhost>

Howdy,

so how are we getting on for nominations to the key post of Koha Dictator.

I notice a certain amount of shyness at the moment, so how about some 
nominations from the floor?  Oh look - I made some :-)  

/me hereby appologises in lieu of asking permission to nominate people

The candidates are ....

Me - well had to be really: Con's - am a Katipo person, haven't got a huge 
amount of time, am neither techy nor library, am likely to be influenced by 
what people are paying us (katipo) to do, have OOS so not fab at massive 
amounts of flame waring etc, can't spell (and this is important it seems). 
Pro's - good at being bossy and delegating, focused on getting things that 
matter done, have resources if necessary, have clear (in own head anyway) 
objectives for Koha, used to mediating between developers etc.

Pat - Con's - probably busy, Pro's - not an active developer, seems fairly 
organised (if you can judge these things off a few e-mails), not a Katipo 
person, so better "neutrality" and sense of Koha moving beyond being a 
Katipo project.

Rosalie - Con's -  busy, public library focus, has had some time off with a 
broken wrist and may already be over committed, also a bit prone to OOS so 
not good at flame wars etc, not techy.  Pro's - is good public "face" not at all 
open-source rabid hacker (appologies again to all who are offended :-), 
actually runs Koha in a live library, already answers lots of queries from 
libraries about koha, is a library person, has vested interest in Koha's 
sucess, also has resources behind her if necessary.

Nick - Con's, Probably busy; Pro's - does simple documents for users (FAQ 
etc) , so knows Koha well but isn't actually a developer, not a Katipo person, 
so better "neutrality" and sense of Koha moving beyond being a Katipo 
project.

Sorry - Nick I feel I should know more but them's the breaks.

Roger - Con's, Probably busy (well who isn't :-); Pro's - documents stuff for 
techys (install file etc), so knows Koha well but isn't actually a developer, not 
a Katipo person, so better "neutrality" and sense of Koha moving beyond 
being a Katipo project, has been "point man" on the koha list helping people 
with their install probs, in touch with novice uses.

Roger again sorry - you do such a lot and I know so little but please 
embelish.

Anyone else - sorry I don't know everyone that well - so "proper" pro and con 
statements would be a great addition, and anyone else keen to throw their 
hat in would be welcome I'm sure.


PEOPLE NOT NOMINATED

I haven't nominated anyone who's actually working on the code (I think). It 
seems too much for someone to work on the code and be the dictator and 
hold down a day job IMHO.  

Let the campaigning or furious backpeddling begin :-)


Cheers
Rachel
_____________________________________________________________

Rachel Hamilton-Williams             Katipo Communications            
WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285 
mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
http://www.katipo.co.nz              New Zealand
Koha Open Source Library System
http://www.koha.org





From chris at katipo.co.nz  Sun May 19 23:03:02 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Sun May 19 23:03:02 2002
Subject: [Koha-devel] Nominations etc etc
In-Reply-To: <3CE938E9.5025.64B5458@localhost>
References: <3CE938E9.5025.64B5458@localhost>
Message-ID: <1021874681.15610.280.camel@orbweb.katipo.co.nz>

On Mon, 2002-05-20 at 17:56, Rachel Hamilton-Williams wrote:
> Howdy,
> 
> so how are we getting on for nominations to the key post of Koha Dictator.
> 
[snip]
> 
> Pat - Con's - probably busy, Pro's - not an active developer, seems fairly 
> organised (if you can judge these things off a few e-mails), not a Katipo 
> person, so better "neutrality" and sense of Koha moving beyond being a 
> Katipo project.

Hmm, Pat does do development work on koha, but i wouldnt count that as a
con, so perhaps Pro: Active developer. :)

[snip]

> 
> Roger - Con's, Probably busy (well who isn't :-); Pro's - documents stuff for 
> techys (install file etc), so knows Koha well but isn't actually a developer, not 
> a Katipo person, so better "neutrality" and sense of Koha moving beyond 
> being a Katipo project, has been "point man" on the koha list helping people 
> with their install probs, in touch with novice uses.
> 
Roger has done a bit of hacking on koha to get it working the way he
wants it to. Im not sure whether he wants to be counted an active
developer or not tho :)

> Roger again sorry - you do such a lot and I know so little but please 
> embelish.
> 
> Anyone else - sorry I don't know everyone that well - so "proper" pro and con 
> statements would be a great addition, and anyone else keen to throw their 
> hat in would be welcome I'm sure.
> 
> 
> PEOPLE NOT NOMINATED
> 
> I haven't nominated anyone who's actually working on the code (I think). It 
> seems too much for someone to work on the code and be the dictator and 
> hold down a day job IMHO.  
> 
Probably a fair call.

Chris

-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From pate at eylerfamily.org  Mon May 20 06:15:01 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Mon May 20 06:15:01 2002
Subject: [Koha-devel] Nominations etc etc
In-Reply-To: <3CE938E9.5025.64B5458@localhost>
Message-ID: <Pine.LNX.4.30.0205200857060.30196-100000@bigfun.whirlycott.com>

On Mon, 20 May 2002, Rachel Hamilton-Williams wrote:

> Howdy,
>
> so how are we getting on for nominations to the key post of Koha Dictator.

Well, this is the first announcement I've heard since the irc meeting
which probably explains the shyness noted below ;)

In an case, thanks for starting the process.

>
> I notice a certain amount of shyness at the moment, so how about some
> nominations from the floor?  Oh look - I made some :-)
>
> /me hereby appologises in lieu of asking permission to nominate people
>
> The candidates are ....
>
> Me - well had to be really: Con's - am a Katipo person, haven't got a huge
> amount of time, am neither techy nor library, am likely to be influenced by
> what people are paying us (katipo) to do, have OOS so not fab at massive
> amounts of flame waring etc, can't spell (and this is important it seems).
> Pro's - good at being bossy and delegating, focused on getting things that
> matter done, have resources if necessary, have clear (in own head anyway)
> objectives for Koha, used to mediating between developers etc.

OOS?

A significant other Pro is that you have significant influence over and
history with Koha.  This is something that no one (except Rosalie) can
touch.

>
> Pat - Con's - probably busy, Pro's - not an active developer, seems fairly
> organised (if you can judge these things off a few e-mails), not a Katipo
> person, so better "neutrality" and sense of Koha moving beyond being a
> Katipo project.

hmm, I'd hoped to stay in the shadows, but I guess since I was one of the
folks bringing up the idea it's only fair that I be nominated as well.
I'll try to post a candidacy statement in a bit.  I will mention a
possible katipo-like conflict of interest.  I'm mulling over the idea of a
US based Koha support and development company.  (It's not serious yet, but
it may happen.)  Along similar lines, I'd like to see the koha community
have other commercial members (individual consultants and/or companies), I
think having a local source for support will help more organizations adopt
koha.

>
> Rosalie - Con's -  busy, public library focus, has had some time off with a
> broken wrist and may already be over committed, also a bit prone to OOS so
> not good at flame wars etc, not techy.  Pro's - is good public "face" not at all
> open-source rabid hacker (appologies again to all who are offended :-),
> actually runs Koha in a live library, already answers lots of queries from
> libraries about koha, is a library person, has vested interest in Koha's
> sucess, also has resources behind her if necessary.

I think Rosalie is a good candidate for the same reasons I like Rachel's
self-nomination.

>
> Nick - Con's, Probably busy; Pro's - does simple documents for users (FAQ
> etc) , so knows Koha well but isn't actually a developer, not a Katipo person,
> so better "neutrality" and sense of Koha moving beyond being a Katipo
> project.
>
> Sorry - Nick I feel I should know more but them's the breaks.
>
> Roger - Con's, Probably busy (well who isn't :-); Pro's - documents stuff for
> techys (install file etc), so knows Koha well but isn't actually a developer, not
> a Katipo person, so better "neutrality" and sense of Koha moving beyond
> being a Katipo project, has been "point man" on the koha list helping people
> with their install probs, in touch with novice uses.
>
> Roger again sorry - you do such a lot and I know so little but please
> embelish.
>

I wish I could speak more to Nick and Roger.  From what I've seen, both
are very committed, very capable, and care about the success of Koha.


> Anyone else - sorry I don't know everyone that well - so "proper" pro and con
> statements would be a great addition, and anyone else keen to throw their
> hat in would be welcome I'm sure.
>
>
> PEOPLE NOT NOMINATED
>
> I haven't nominated anyone who's actually working on the code (I think). It
> seems too much for someone to work on the code and be the dictator and
> hold down a day job IMHO.
>

This is a good point.   I think that the person needs to be able to at
least speak developer though, because their constituency is going to be
made up (largely) of developers.


> Let the campaigning or furious backpeddling begin :-)

I may campaign for someone else to be elected, but I shant back out ... I
helped start this boulder rolling, I feel obligated to stick with it.

-pate

>
>
> Cheers
> Rachel
> _____________________________________________________________
>
> Rachel Hamilton-Williams             Katipo Communications
> WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285
> mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
> http://www.katipo.co.nz              New Zealand
> Koha Open Source Library System
> http://www.koha.org
>
>
>
> _______________________________________________________________
> Hundreds of nodes, one monster rendering program.
> Now that's a super model! Visit http://clustering.foundries.sf.net/
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From pate at eylerfamily.org  Mon May 20 07:16:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Mon May 20 07:16:02 2002
Subject: [Koha-devel] my candidacy
Message-ID: <Pine.LNX.4.30.0205201014030.31012-100000@bigfun.whirlycott.com>

Given that I've been nominated as the Koha Dictator, people should
know where I stand on things.  Hopefully the following helps:

			       Overview
I'm most focused on a three issues: cleanliness of code (including
inline comments and a solid testsuite), inclusion of features for
other libraries (e.g., MARC), and the uptake of Koha in the larger
(international) market and the Open Source world.  Each of these is
discussed below:

   Code Cleanliness -
I believe that to be successful code need to be legible, testable, and
understandable.  Everyone working on it needs to have a sense of
ownership so that they can go in and fix problems, add functions, and
be able to contribute them back to the community at large.  I'm a firm
believer in test driven design, refactoring, and many other tenants of
the eXtreme Programming culture.

   Feature Inclusion -
I believe that Koha is a great system which can be made better.  As
the community adds features of interest to potential users, we need to
ensure that a) we're adding them in a maintainable way, b) we're not
excluding current users, and c) we're providing backwards-compatability
and/or migration tools.  Some of the features that seem most pressing
to me are:  an installer, MARC, Z39.50, and better front-end/back-end
modularization.

   Koha Uptake -
For Koha to be successful outside it's current market, I believe that
we must succeed in the two areas described above.  I also feel that we
need to reach out to potential users and developers.  We need to
develop a strategy of approaching (or creating) potential partners to
help push Koha into new territories (e.g., Latin America).

		   How do I propose getting there?

I think that our existing road map is a good place to start.  I'm
encouraged by the amount of coordination that already occurs on the
list and in irc, and encourage more of this.  If elected, I would like
to use a staff (described below) to help build and lead the community.

To encourage code cleanliness, I feel that we need to encourage the
development of tests and documentation.  Liberally seeding the
codebase will make a good start.  Encouraging the addition of tests for
new features before checkin (indeed, the successful passing of the
complete testsuite before checkin) will also be a great help.
Frequent building of the project's POD and automatically posting it to
a community website would be good too.  I'd also like to see bugzilla
(or the tracker in SourceForge) used to track problems and reward top
bughunters.

To drive feature inclusion, I believe that following a roadmap,
communicating within the community, and keeping a development
vs. stabilization separation (with release managers on both sides)
will be the key.  As librarians, developers, and commercial interests
work together to define release targets, then a release manager guides
development toward the target, We should see an organized inclusion of
features as we progress toward a Koha 2.0 release.

Building a larger Koha community through uptake of the project will
require evangelization and coordinated communication to selected
communities.  We will also want to encourage developers and
organizations to adopt Koha by supporting them through the learning
curve.  In some cases, this will mean encouraging commercial interests
to start supporting koha in their region (or helping to form
commercial interests to support koha in their region).


		       What are my liablities?

I'm not the perfect candidate, and may not even be the best
candidate.  Here are some reasons you may not want me to be the
Dictator.

1)  I'm pretty new to the whole project.

2)  I come from a different coding background.  I'm a sys-admin who
    really believes that OO and XP are better.

3)  I'm likely to be very busy with other things during the summer.
    This might mean that I can't put in as much time as I'd like to.

4)  I have the typical hacker personality ... I can come off as
    abrasive, annoying, and abrubt.

5)  I can be quite a pest about getting things done.





From pate at eylerfamily.org  Mon May 20 07:31:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Mon May 20 07:31:02 2002
Subject: [Koha-devel] my candidacy
In-Reply-To: <Pine.LNX.4.30.0205201014030.31012-100000@bigfun.whirlycott.com>
Message-ID: <Pine.LNX.4.30.0205201018031.31012-100000@bigfun.whirlycott.com>

On Mon, 20 May 2002, Pat Eyler wrote:

> I think that our existing road map is a good place to start.  I'm
> encouraged by the amount of coordination that already occurs on the
> list and in irc, and encourage more of this.  If elected, I would like
> to use a staff (described below) to help build and lead the community.
>
hmmm, I guess I should probably describe the staff if I say I'm going to.


If elected, I would nominate people to the following positions:

1.2 Release Manager
   Responsible for coordinating stabilization of the 1.2 release, and
merging of 1.2 enhancements into the main tree.  They will be a presence
on the koha-devel mailing list.  They will be the owner of a 1.2 release
task list at SourceForge.

1.4 Release Manager
   Responsible for coordinating development on the 1.3 series and then
stabilization of the 1.4 release.  They will be a presence on the
koha-devel mailing list.   They will be the owner of a 1.4 release task
list at SourceForge.

Marketing Manager
   Responsible for helping drive the uptake of Koha into selected
communities and organizations.  Also reponsible for coordinating a koha
presence at selected shows/conferences.  They should also be a presence on
the koha mailing list.

Recruiter
   Responsible for helping individuals and companies begin to develop and
support koha.  They should be a presence on both the koha and koha-devel
lists.

Library Liason
   Responsible for ensuring that the customer (libraries) isn't being
ignored while developers run off to 'do their own thing'.  Ideally, this
person could help to organize/start a koha users group.  They should also
be a presence on the koha mailing list.


thanks,
-pate




From am12 at bolis.com  Mon May 20 16:27:03 2002
From: am12 at bolis.com (Alan Millar)
Date: Mon May 20 16:27:03 2002
Subject: [Koha-devel] my candidacy
In-Reply-To: <Pine.LNX.4.30.0205201014030.31012-100000@bigfun.whirlycott.com>; from pate@eylerfamily.org on Mon, May 20, 2002 at 10:14:59AM -0400
References: <Pine.LNX.4.30.0205201014030.31012-100000@bigfun.whirlycott.com>
Message-ID: <20020520162623.A9675@hock.local>

On Mon, May 20, 2002 at 10:14:59AM -0400, Pat Eyler wrote:
 
> To encourage code cleanliness, I feel that we need to encourage the
> development of tests and documentation.  Liberally seeding the
> codebase will make a good start.  Encouraging the addition of tests for
> new features before checkin (indeed, the successful passing of the
> complete testsuite before checkin) will also be a great help.

Sounds like a great idea.  How do we start?  Does anyone have
pointers on where to read up on writing testing code?
I see how Perl CPAN modules go through tests on install, but I
don't have any idea how they do it.  

I'd love to see us come up with some automated install/upgrade
software.  I *love* the Koha database updater that figures out what tables
and columns need to be added; it's a great start.   Along similar
lines, I recently installed the Linux terminal server software
LTSP 3.0 from ltsp.org.  I was impressed that it is not a bunch of
new software, but rather a tool to configure all the existing software
on your system to have the correct settings. That may give us
some inspiriation (configuring Apache for OPAC, etc.)

- Alan

-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From pate at eylerfamily.org  Mon May 20 16:34:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Mon May 20 16:34:02 2002
Subject: [Koha-devel] my candidacy
In-Reply-To: <20020520162623.A9675@hock.local>
Message-ID: <Pine.LNX.4.30.0205201927570.3208-100000@bigfun.whirlycott.com>

On Mon, 20 May 2002, Alan Millar wrote:

> On Mon, May 20, 2002 at 10:14:59AM -0400, Pat Eyler wrote:
>
> > To encourage code cleanliness, I feel that we need to encourage the
> > development of tests and documentation.  Liberally seeding the
> > codebase will make a good start.  Encouraging the addition of tests for
> > new features before checkin (indeed, the successful passing of the
> > complete testsuite before checkin) will also be a great help.
>
> Sounds like a great idea.  How do we start?  Does anyone have
> pointers on where to read up on writing testing code?

One good place to start looking is at the Test::Harness and Test::More
docs (you can also look at the tests I've started to write testKoha.pl and
t/*.t).

For more info about the idea, I'd look at <www.extremeprogramming.org> and
<www.refactoring.com>.  <www.rubygarden.org/ruby?UsingTestUnit> is also a
good read.

If these aren't enough, I'll happily spen time in irc or email with ppl.


> I see how Perl CPAN modules go through tests on install, but I
> don't have any idea how they do it.
>
> I'd love to see us come up with some automated install/upgrade
> software.  I *love* the Koha database updater that figures out what tables
> and columns need to be added; it's a great start.   Along similar
> lines, I recently installed the Linux terminal server software
> LTSP 3.0 from ltsp.org.  I was impressed that it is not a bunch of
> new software, but rather a tool to configure all the existing software
> on your system to have the correct settings. That may give us
> some inspiriation (configuring Apache for OPAC, etc.)
>

Mike and Nick have started installer.pl.  My hope is that we can start
small, get it to do some simple bits, and then start adding functionality
(testing as we go).

happy hacking,
-pate

> - Alan
>
>




From tonnesen at cmsd.bc.ca  Tue May 21 13:42:01 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Tue May 21 13:42:01 2002
Subject: [Koha-devel] Catalogue API (fwd)
Message-ID: <Pine.LNX.3.96.1020521133751.1336h-100000@hss-labs.cmsd.bc.ca>


Alan brings up some valid points regarding switching to a MARC compatible
backend database.  He is not the first to raise concerns with MARC.  I
believe that Rosa called it "icky"?  :)   We definitely need to get this
worked out.

Here's how I see the problem:

Alan is looking to use Koha for a small home collection.  Let's call this
a 2,000 item library and call it the low end of the Koha user spectrum. 
Note that low end here is not intended to be an insult or a brush off,
it's just an indication of the number of items in the collection.  At the
high end, we'd have collections with 1,000,000 items or more. 

I believe that most of those large libraries would insist on being able to
directly view and edit bibliographic data using a MARC interface.  In
other words, if they were going to enter an author for a book, they'd want
to see a 100 tag with an 'a' subfield to enter the name in, and a 'd'
subfield to enter the date of birth/death in. 

In the small libraries, they'd just want the word author with a text field
beside it.


From am12 at bolis.com  Tue May 21 23:33:03 2002
From: am12 at bolis.com (Alan Millar)
Date: Tue May 21 23:33:03 2002
Subject: [Koha-devel] Catalogue API (fwd)
References: <Pine.LNX.3.96.1020521133751.1336h-100000@hss-labs.cmsd.bc.ca>
Message-ID: <3CEB3B66.4080305@bolis.com>

Hi Steve-  Sorry I missed the IRC chat.  However, the IRC web logs are 
great!  Glad I could catch up at least after the fact.  You've written 
an excellent summary here.  I'm beginning to see the light :-) and I 
think Pat's IRC comment is correct that we do have more in common in 
view here than it may have first appeared.

> I'm hopeful that we can develop a cataloguing API that will alleviate some
> of these problems.  

> getinfo(1563,'author')  returns Herman Melville  from the 100 a subfield
> setinfo(1563,'author', 'Melville, Herman')  updates author info 

Yes, this will go a long way towards simplifying it for the random 
contributing developer like myself.   I can imagine that such a map 
could be database driven, with a table of values along the lines of:

  author,100,a
  title,245,a
  isbn,020,a

and so on.  Perhaps even multiple MARC flavors could be handled that way 
with no (or minimal) coding changes.

> 1.  acqui.simple and marcimport.pl == MARC compatible
> 
>   acqui.simple and marcimport.pl will import marc records and "squash" the
>   data into the standard Koha database.  There can be considerable loss of
>   information in this process.  

Right.  It would only be viable if combined with the next item, Marc 
tables for non-kohadb data:

> 2.  Use Marc tables only for data that is not already represented by the
>     koha databases.
> 
>   I think this is a bad idea.  It'd be too confusing about what
>   information was stored where.

Perhaps it is.  However, it might work if we adopted some sort of 
table-driven field structure like the above, such as

    title = 100a = kohadb:biblio.title
    author = 245a = kohadb:additionalauthors.name
    lccall = 050a = marc

>   I envision separate indexes being
>   generated to facilitate searching.  It would be easy, for example, to
>   create an index that contained the following information:
> 
>       bibid, title, author, dewey, isbn
> 
>   Then a search for bibid would be identical to the search that you gave
>   in your example using the koha database.

OK, I think this is the piece that I was missing from the picture.  That 
would allow simple queries like I'm looking for.

>  Not [Note?] that you could potentially
>   lose information stored in the marc record if there is more than one
>   author, for example.

Or, there could also be another index table that paralleled the current 
"additionalauthors" table.

 >  These "seach indexes" are still vaporware.  Paul
 >   and I are trying to work out the specifics of what the new backend
 >   database will look like.

My suggestion: what about using the existing structure of the KohaDB 
(perhaps with minor mods) for these search index tables?  Code 
transition would happen by first isolating all the writes to the 
existing tables and making them go through API's.  Then any existing 
code that is just reading the data wouldn't have to change.

> 5.  You mention MARC-XML and suggest that we not tie ourselves to the MARC
>     format.
> 
>   We are not proposing that bibliographic data be stored in MARC format,
>   only that the back end database be capable of storing any and all
>   information that a MARC record can store (whether it is a conventional
>   MARC record or the as-yet-unspecified MARC-XML format record).  The
>   existing MARC format is just a flat file that uses control character
>   separators and a directory index for the tags.  The MARC-XML
>   specification will be the same format, but will use XML tags for
>   separating the data instead of control characters.  We would not want to
>   use either of these formats internally, although we would probably want
>   to be capable of importing/exporting those formats.

I definitely agree here.  I'm just now understanding that file format 
with the tag index and control character separators.  It seems to me 
that the other (original?) Marc representation can be considered yet a 
third format.  I'm thinking of ones I see where the tag number is at the 
beginning of each line and the $ character separates the subfields.  I'm 
presuming that this is what Marc-familiar librarians work on, and then 
it is translated to be stored in the control-character file format (or 
something else like the database we are discussing).

Based on this idea of the abstraction of the Marc data being the 
important part, where "100a = Author" regardless of storage, then I 
really like your suggestion on IRC of

 > The schema has columns like bibid,tag,subfieldcode,subfieldvalue, so...
 >  (bibid, tag, subfieldcode, subfieldvalue) = (16654, 165, 'a', 
'http://www.mysite.com/')

In my opinion, then, I would vote against the other suggestion of 
putting all subfields into one record separated by "$" characters.
It appears to be an artifact of the "straight-text" Marc format that 
doesn't exist in the control-character file format or proposed XML 
format, and therefore isn't really part of the "true" abstracted data.

It also increases the complexity of getting at any one subfield and 
potentially restricts the types of languages or tool sets that could 
work on the data. I love perl and regexps but I don't think we want a 
database that excludes non-perl access by design.

And relational database engines are built by design to support data 
growth by adding rows.  Perhaps the list of additional authors won't 
ever be that big for any book I know of, but it seems short-sighted to 
me to design it so an arbitrary-length list of subfields would be 
limited by column width or db-engine support for non-conventional data 
types just to handle wider and wider text strings.

Thanks for the comprehensive view; I'm starting to get the picture :-)

- Alan


-- 
Alan Millar                  Email: am12 at bolis.com




From tonnesen at cmsd.bc.ca  Wed May 22 08:55:01 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Wed May 22 08:55:01 2002
Subject: [Koha-devel] Catalogue API (fwd)
In-Reply-To: <3CEB3B66.4080305@bolis.com>
Message-ID: <Pine.LNX.3.96.1020522082057.1336i-100000@hss-labs.cmsd.bc.ca>

On Tue, 21 May 2002, Alan Millar wrote:

> My suggestion: what about using the existing structure of the KohaDB 
> (perhaps with minor mods) for these search index tables?  Code 
> transition would happen by first isolating all the writes to the 
> existing tables and making them go through API's.  Then any existing 
> code that is just reading the data wouldn't have to change.

Of course, if we have such an API, there is no longer any need to maintain
two backend databases.  :)   This API is in the works, and will be an
integral part of MARC development.


> It seems to me 
> that the other (original?) Marc representation can be considered yet a 
> third format.  I'm thinking of ones I see where the tag number is at the 
> beginning of each line and the $ character separates the subfields.  I'm 
> presuming that this is what Marc-familiar librarians work on, and then 
> it is translated to be stored in the control-character file format (or 
> something else like the database we are discussing).

What you are talking about is just a universal format for displaying marc
records to an end user (usually a librarian).  It is never used for
storing marc records, as far as I now.



Steve.





From tonnesen at cmsd.bc.ca  Wed May 22 09:29:02 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Wed May 22 09:29:02 2002
Subject: [Koha-devel] IRC meeting and IRC logs
Message-ID: <Pine.LNX.3.96.1020522092449.1336j-100000@hss-labs.cmsd.bc.ca>

Just a reminder of a Koha IRC meeting:

   When:   May 30  10PM GMT
   Where:  irc.katipo.co.nz:6667  #koha
   Topics: To Be Announced



Also, there is a log of IRC traffic available now at:


  http://www.haz.cmsd.bc.ca/cgi-bin/kohalog.pl


You can set your timezone and record important discussions so that others
can find them easily.


Steve Tonnesen




From pate at eylerfamily.org  Wed May 22 10:33:04 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May 22 10:33:04 2002
Subject: [Koha-devel] IRC meeting agenda (proposed draft)
In-Reply-To: <Pine.LNX.3.96.1020522092449.1336j-100000@hss-labs.cmsd.bc.ca>
Message-ID: <Pine.LNX.4.30.0205221328450.23632-100000@bigfun.whirlycott.com>

Items for meeting:
 Community
   Benevolent Dictator election status (Nick?)
     We've got nominations, what's the next step?  Who's going to make
     it happen?
   koha advocacy (Pat?)
     What efforts are currently going on?  How are they going?  What
     else should we be doing?
 Development
   progress toward 1.2 (Chris?)
     What's the current status?  What obstacles do we face?
   tentative targets for 1.2 (Chris?)
     What are our milestones on the march to 1.2?
   1.3 issues (Paul?)
     What issues are we facing in 1.3 development land?
   HTML::Template (Steve?/Chris?)
     What is the current status of templating?  What needs to happen
     next?
   MARCification (Paul?/Steve?)
     What is the current status of MARC?  What needs to happen
     next?
   Unit Testing (Pat?)
     What is this?  How can it help koha?  Do we want to do it?
 Docs
   Install Guide (Nick?)
     Current Status?  What's next?  What help is needed?
   User's Guide (Rosalie?)
     Current Status?  What's next?  What help is needed?
   Admin's Guide (Pat?)
     What is this?  What's next?  Do we want to do this?
   Developer's Handbook (Pat?)
     What is this?  What's next?  Do we want to do this?
   DocBook Tutorial & Templates (Pat?)
     What is this?  What's next?  Do we want to do this?





From nsr at etome.net  Wed May 22 10:41:04 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Wed May 22 10:41:04 2002
Subject: [Koha-devel] candidacy
Message-ID: <NGBBLPDKODDLFDKEDCDKCEGPCBAA.nsr@etome.net>

Since my hat (which I should have been wearing while I was out of town a few
days ago -- a goodly portion of my head is now a truly fetching shade of
red/pink) seems to have been chucked into the ring, I suppose I should say
something.

I'm a little more... taciturn? than Pat, but since what he has sent out has
made sense...

I'd be looking for
Release managers/Coders in Chief --
Stable and Devel [yeah, most likely Chris and Paul]
I'd like to see us integrate usable MARC with an eye to moving a MARC
version to stable by September.

Advocacy people --
International, and English [Pat, and someone else, I suppose]
Ideally, I'd like to see Koha acquire more of an installed based, as I would
hope to attract developers interested in making it meet there needs.  The
usual reasons of 'more users better' for open source apply here, and don't
really need repeating :).  These people would also have a brief for creating
a more visible koha presence (at things like oss4lib, and for e-mailings,
etc).  I'd also like to see an organized effort for translations, hopefully
not just by a developer.

Chief Librarian --
Self explanatory, I hope.

Support manager --
Responsible for coordinating documentation, and support tools (like the
installer, and the conversion utils allowing you to upgrade), and for
packaging for a user-friendly application.

Standards Specialist --
Someone who "gets it" (more than we do) on how the commercial apps implement
these standards -- preferably this would be someone from a library currently
using commercial tools who is willing to let us do testing against them for
compliance sake.

------
My primary goals for Koha relate directly to the above spots.

* Creation of a 'pipeline' for features and versions
  (ie request -> schedule -> devel -> release -> tested/stable/mature ->
repeat)
  with the logical things to make that easier (good introductory
documentation, clean code, etc)

* Increase of installed copies and int'l support
  Free software has stronger adherents where the expense of the commercial
version is insupportable.  Logically Koha should 'play' to that community.
More installed copies means more people thinking about how Koha can be
better.

* A move towards becoming a viable replacement for the midsize library
(short term) that participates in a larger framework (Inter Library Loan,
circulation protocols).  (Long term) The capability to support a national
library [obviously, on larger hardware] -- especially one with more than one
official language.

* The creation of a community (both business and individual) that can use
koha effectively -- ie, flexible enough to support a large library with
specific needs and configuration requirements, but with enough user and
configuration support that the small guy :) [which, btw, includes me] can
use it for his home or small business library.  Modularity in things like
barcodes, circulation setup, and membership should permit this to happen.
--
The fine print:
I'm waaaay behind the coders here.  I know just enough about Perl to know
how much I don't know!
I'm not a librarian, either.  I know a little about libraries, I've worked
for one, but I'll confess I don't fit firmly into either of the two primary
koha demographic groups!
I'm an American -- surrounded by Kiwis, Frenchman, and Canadians -- with all
the viewpoint baggage :) that implies.
By background, I'm a scheduling and documentation geek.  I would be obliged
(if elected) to lead mainly by persuasion -- I am not sufficiently skilled
in perl to do an all night code-a-thon to build something.  This would also
makes me hands off about coding -- I'd much rather get my news on Where We
Are from the wiki than the CVS updates.
By temperment, I'm a tad rententive -- I much prefer things orderly, and the
engineer in me can get a little obnoxious about scheduling and process.
You should (before voting) ask someone else's opinion of my contributions to
the project as such, as it sure as heck isn't coded features.
---
All that Having Been Said, I have enjoyed being on the project, I'd like to
think I've been useful, and I would be ecstatically happy to work for
someone else, either as a manager/whatever, as Deputy Geek in Chief, or
simply as Documentation Wonk.

Best,
Nick




From pate at eylerfamily.org  Wed May 22 12:18:05 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May 22 12:18:05 2002
Subject: [Koha-devel] Re: [Koha] feature idea
In-Reply-To: <20020522121340.A9686@whitesalmon.net>
Message-ID: <Pine.LNX.4.30.0205221512140.23632-100000@bigfun.whirlycott.com>

On Wed, 22 May 2002, Emile Snyder wrote:

> Hi all,
>
> The desire for a new feature struck me while using my local library catalog
> system recently, and I thought I would toss it out on the list.  Don't know
> if anyone else will find it attractive...

Emile,
this is an interesting idea (one I'd like to see as well), although there
may be privacy concerns for some libraries.  An extension to your idea
might be to link out of a book/movie/something else in koha to grab an
amazon (or imdb, or something else) review.

As a side note, addressing ideas like these to both the koha and
koha-devel lists.

thanks,
-pate

>
> I live in a fairly rural location and while the library system is fairly
> large the number of volumes at the local branch is relatively small.  So I
> place lots of holds on books which I can then pick up later.  I have found
> that the way I most often select books these days is to have the telnet
> interface to my library catalog open next to a browser window, and explore
> various reviews at amazon, then see if the library system has a book and
> place a hold on it if possible.  The problem is I usually find many more
> books that look really interesting than I can possibly read in the month or
> so that a checkout covers ;)  So the feature I wish I had is an "interest
> list" that the catalog could keep for me.  It kind of sounds like feature
> bloat on the one hand... why don't I just keep a notepad handy?  But
> never the less, I keep wishing it was there.
>
> thanks,
> -emile
> _______________________________________________
> Koha mailing list
> Koha at lists.katipo.co.nz
> http://lists.katipo.co.nz/mailman/listinfo/koha
>




From nsr at etome.net  Wed May 22 12:39:03 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Wed May 22 12:39:03 2002
Subject: [Koha-devel] Paul
Message-ID: <NGBBLPDKODDLFDKEDCDKCEHACBAA.nsr@etome.net>

Those of you wanting to send get well cards to Paul, I got ahold of his
address (some of you may've already heard this, for which I apologize for
overlap... but I've not seen it on the list).

Paul Poulain
Beauvallon C?dre B?t 2
155 Chemin de Morgiou
13009 Marseille France

I also gather we've had a Birthday on the devel list, but I didn't hear
which of us had it.... what I get (again!) for being out of town.

Nick




From chris at katipo.co.nz  Thu May 23 02:14:02 2002
From: chris at katipo.co.nz (Chris Cormack)
Date: Thu May 23 02:14:02 2002
Subject: [Koha-devel] New rc1 tarball
Message-ID: <1022145325.15610.339.camel@orbweb.katipo.co.nz>

Hi All

Ive put a new tarball at 
http://developer.koha.org/koha-1.1.2-rc1-1.tgz

Ive changed the directory structure a bit, to make installing less
painful (I hope).
See what you think, if it meets with approval we can amend the INSTALL
doc to reflect it.

Chris
-- 
Chris Cormack                                      chris at katipo.co.nz
Programmer                                                025 500 579
Katipo Communications                                www.katipo.co.nz



From pate at eylerfamily.org  Thu May 23 05:52:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Thu May 23 05:52:02 2002
Subject: [Koha-devel] New rc1 tarball
In-Reply-To: <1022145325.15610.339.camel@orbweb.katipo.co.nz>
Message-ID: <Pine.LNX.4.30.0205230849160.6773-100000@bigfun.whirlycott.com>

On 23 May 2002, Chris Cormack wrote:

> Hi All
>
> Ive put a new tarball at
> http://developer.koha.org/koha-1.1.2-rc1-1.tgz
>

You're awesome!

> Ive changed the directory structure a bit, to make installing less
> painful (I hope).
> See what you think, if it meets with approval we can amend the INSTALL
> doc to reflect it.

I'm installing it now.  At first blush, I think the intranet-html
directory should be renamed to intra-html to match intra-cgi -- it may be
confusing to have non-matching names as compared to opac-foo.


thanks,
-pate

>
> Chris
>




From tonnesen at cmsd.bc.ca  Thu May 23 10:05:03 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Thu May 23 10:05:03 2002
Subject: [Koha-devel] Agenda Update
Message-ID: <Pine.LNX.3.96.1020523093219.1336q-100000@hss-labs.cmsd.bc.ca>

Items for IRC Meeting
May 30, 2002  10PM GMT
irc.katipo.co.nz  #koha


===============
  Community
===============
1.  Benevolent Dictator election status (Nick?)
      We've got nominations, what's the next step? Who's going to make it
      happen?
2.  koha advocacy (Pat?)
      What efforts are currently going on? How are they going? What else
should
      we be doing?

===============
  Development
===============
3.  progress toward 1.2 (Chris?)
      What's the current status? What obstacles do we face?
4.  tentative targets for 1.2 (Chris?)
      What are our milestones on the march to 1.2?
5.  1.3 issues (Paul?)
      What issues are we facing in 1.3 development land?
6.  HTML::Template (Steve?/Chris?)
      What is the current status of templating? What needs to happen next?
7.  MARCification (Paul/Steve)
      What is the current status of MARC? What needs to happen next?
8.  Bugzilla (Steve)
      Can we use Katipo's bugzilla for centralized bug reporting?
9.  Unit Testing (Pat?)
      What is this? How can it help koha? Do we want to do it?
   
===============
     Docs
===============
10. Install Guide (Nick?)
      Current Status? What's next? What help is needed?
11. User's Guide (Rosalie?)
      Current Status? What's next? What help is needed?
12. Admin's Guide (Pat?)
      What is this? What's next? Do we want to do this?
13. Developer's Handbook (Pat?)
      What is this? What's next? Do we want to do this?
14. DocBook Tutorial & Templates (Pat?)
      What is this? What's next? Do we want to do this?





From nsr at etome.net  Thu May 23 12:00:03 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Thu May 23 12:00:03 2002
Subject: [Koha-devel] Nominees
Message-ID: <NGBBLPDKODDLFDKEDCDKKEHDCBAA.nsr@etome.net>

If you've been mentioned for (or are interested in) the Benevolent Dictator
post, would you mind dropping either a 'thank you, no' or a
candidacy-comments email to the list?  Just so we know who is interested and
who wants off any potential ballots before next Thursday?

Thanks
Nick




From paul.poulain at free.fr  Fri May 24 02:32:01 2002
From: paul.poulain at free.fr (paul POULAIN)
Date: Fri May 24 02:32:01 2002
Subject: [Koha-devel] Hello, I'm back
References: <1021842160.15610.256.camel@orbweb.katipo.co.nz>
Message-ID: <3CEE0938.2000601@free.fr>

Hello everybody,

I'm back at home, and behind my computer.
I won't work on koha today, but monday I'll be back.

Happy to be here again.
--
Paul





From nsr at etome.net  Fri May 24 17:34:02 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Fri May 24 17:34:02 2002
Subject: [Koha-devel] OpenBook
Message-ID: <NGBBLPDKODDLFDKEDCDKMEHICBAA.nsr@etome.net>

As an FYI, I checked the address I keep for queries from the FAQ, and low
and behold, someone handed me a pointer to the openbook technical beta
tarball, and said he was interested in advancing the project.  I said we
were moving to incorporate most of their ideas, anyway, and that as far as I
knew it was dead.

Idly, we may eventually want to write some sort of conversion util so these
people can move to Koha.  I'd suggest if we had a new developer show up we
might "start them off" on such a thing.  Disclaimer:  Just a thought (from
someone busily investigating the fridge with one hand, and typing with the
other).

Sooner or later I'll arrange for the tarball to live in our CVS tree, with a
Big Ole' Note saying it isn't supported.

Nick





From rachel at katipo.co.nz  Fri May 24 20:18:01 2002
From: rachel at katipo.co.nz (Rachel Hamilton-Williams)
Date: Fri May 24 20:18:01 2002
Subject: [Koha-devel] OpenBook
In-Reply-To: <NGBBLPDKODDLFDKEDCDKMEHICBAA.nsr@etome.net>
Message-ID: <3CEFAB0D.7963.93708@localhost>


> As an FYI, I checked the address I keep for queries from the FAQ, and low
> and behold, someone handed me a pointer to the openbook technical beta
> tarball, and said he was interested in advancing the project.  I said we
> were moving to incorporate most of their ideas, anyway, and that as far as I
> knew it was dead.

I've heared stuff about openbook on the OSS-Lib list from time to time which 
indicates that the developer is still working on it- so I don't know if it's just 
resting :-)

R
_____________________________________________________________

Rachel Hamilton-Williams             Katipo Communications            
WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285 
mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
http://www.katipo.co.nz              New Zealand
Koha Open Source Library System
http://www.koha.org





From am12 at bolis.com  Sat May 25 15:09:04 2002
From: am12 at bolis.com (Alan Millar)
Date: Sat May 25 15:09:04 2002
Subject: [Koha-devel] Need help on CVS branches
Message-ID: <20020525150756.A10539@hock.local>

Hi-  I'm confused on how to work on the 1.2 branch.  I've been reading
the docs at cvsbook.red-bean.com, but it doesn't match with what
I'm seeing in the koha cvs.

I made a new directory to pull my stuff into:

  mkdir koha-cvs-12dev
  cd koha-cvs-12dev

If I do this:

  cvs checkout -r rel-1-2 koha

then I get files that are definitely snapshots from a week ago, but the
cvs docs imply that any changes I make will go back into the main branch.

Also, I can't get the koha-html directory; it says it is getting it
but doesn't create anything

If I do this:

  cvs -b rel_1_2 checkout koha

I get koha, and I can get koha-html too, but the files are all
the latest main branch versions.

Help!  What am I missing here?  Thanks.

- Alan
  

-- 

----
Alan Millar     --==> am12 at bolis.com <==--



From rosalie at library.org.nz  Sun May 26 15:51:01 2002
From: rosalie at library.org.nz (Rosalie Blake)
Date: Sun May 26 15:51:01 2002
Subject: [Koha-devel] Nominees 
In-Reply-To: <Pine.LNX.4.30.0205231505070.8066-100000@bigfun.whirlycott.com>
Message-ID: <3CF20FC6.9719.1ADE5D@localhost>

On 23 May 2002, at 15:05, Pat Eyler wrote:

> 
 
> If you've been mentioned for (or are interested in) the Benevolent
> Dictator post, would you mind dropping either a 'thank you, no' or a
> candidacy-comments email to the list?  Just so we know who is
> interested and who wants off any potential ballots before next
> Thursday?

I have picked myself up off the floor, and stopped giggling 
hysterically. Thank you for the nomination, I am very flattered to 
have been considered, but I don't think I'm the person for the job of 
Dictator, Benevolent or otherwise. I will get the Users' manual done, 
but I lack the technical knowledge for the main job.

Rosalie Blake 



From rachel at katipo.co.nz  Tue May 28 20:09:03 2002
From: rachel at katipo.co.nz (Rachel Hamilton-Williams)
Date: Tue May 28 20:09:03 2002
Subject: [Koha-devel] Katipo Koha projects on the Koha developers site
Message-ID: <3CF4EEED.17598.652366B@localhost>

Hi

I've made a list of the projects that Katipo has "on the books" for koha over 
the next month to six weeks at

http://www.saas.nsw.edu.au/wiki/index.php?page=RachelsKatipoPlan

Jeremy is our project manager on these jobs, so I've asked him to do an 
update on it.  

My thoughts at the moment are that it would probably be useful for people to 
see what the "spec" for each project is, and to issue any warning etc about 
duplicate work or whatever.


From pate at eylerfamily.org  Tue May 28 22:07:02 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Tue May 28 22:07:02 2002
Subject: [Koha-devel] Katipo Koha projects on the Koha developers site
In-Reply-To: <3CF4EEED.17598.652366B@localhost>
Message-ID: <Pine.LNX.4.30.0205290058420.18078-100000@bigfun.whirlycott.com>

On Wed, 29 May 2002, Rachel Hamilton-Williams wrote:

> Hi
>
> I've made a list of the projects that Katipo has "on the books" for koha over
> the next month to six weeks at
>
> http://www.saas.nsw.edu.au/wiki/index.php?page=RachelsKatipoPlan

Awesome, thanks for getting this up for us to see.

>
> Jeremy is our project manager on these jobs, so I've asked him to do an
> update on it.
>
> My thoughts at the moment are that it would probably be useful for people to
> see what the "spec" for each project is, and to issue any warning etc about
> duplicate work or whatever.

Hopefully we can shake out any other private projects and roll the sum
into a solid release plan.

>
> >From my POV these projects have probably gone past the "negotiation"
> stage unless whatevers wanted isn't going to cost any additional hours.
>
> I'd like to see these features go into the general release as soon as possible
> after they are installed and verified as working on the client sites, so that
> they get the satisfaction of seeing them released on the list etc (good feel
> good factor), and nice for the list to see development.
>

I think we can roll things out prety cleanly in a series of 1.2.X
releases.  I'm hoping that we can get 1.2.0 out in June, and would be
happy to see a minor version every month until we roll 1.4.0 out.


> I perceive that our work is somewhat at odds with the current versioning
> system on the Road Map, because we will have things ready before the rest
> of the release is probably even scheduled to be ready.

At odds is probably too strong a term, 'not fully integrated' would be my
choice.  :)

>
> I'm afraid I've already been acting the benevolent dictator to some extent, and
> for example have had my designers working on a new koha.org site over the
> last few months. It has been a project for my designer to practice her HTML
> on.

I don't see that as a problem.  It's been your project and you've been
doing a good job with it.


ahppy hacking,
-pate

>
> Cheers
> Rachel
> _____________________________________________________________
>
> Rachel Hamilton-Williams             Katipo Communications
> WEBMISTRESS                          ph  021 389 128 or +64 04 934 1285
> mailto:rachel at katipo.co.nz           PO Box 12487, Wellington
> http://www.katipo.co.nz              New Zealand
> Koha Open Source Library System
> http://www.koha.org
>
>
>
> _______________________________________________________________
>
> Don't miss the 2002 Sprint PCS Application Developer's Conference
> August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From nsr at etome.net  Wed May 29 07:18:02 2002
From: nsr at etome.net (Nicholas Rosasco)
Date: Wed May 29 07:18:02 2002
Subject: [Koha-devel] Order from Chaos, maybe
Message-ID: <NGBBLPDKODDLFDKEDCDKMEIDCBAA.nsr@etome.net>

After seeing Rachel's (thankyouthankyouthankyouthankyouthankyou for that
info.  It seriously demystifys some things for me at least) wiki posted
Katipo Plan, I have gone and Japanese chef'd the Roadmap (see the Sliced and
Diced link off the original) to reflect her comments and (hopefully)
Katipo's priorities/client requests ... particularly her (painfully correct)
"ack! you want one release manager to handle all of _that_" line of thought.

My hope was to divvy it into each version (yes, they are un-numbered... if
someone wants to go back and adjust, go ahead) getting a major and a minor
goal.  Major features are usually things like MARC, minor things like shelf
lists.  The only exception of the moment is the current Katipo version,
which has all kinds of nifty things, including the early (and highly groovy)
templating and info-display-options-controls stuff.

Is Jeremy on the devel list?  Rachel, any comments (esp on if I've got the
Katipan bullet points right?)?

Ref'd:
http://www.saas.nsw.edu.au/wiki/index.php?page=RachelsKatipoPlan

New: http://www.saas.nsw.edu.au/wiki/index.php?page=SlicedAndDiced
Old: http://www.saas.nsw.edu.au/wiki/index.php?page=KohaRoadmap

[The old is intact, for the moment, for comparison reasons, and
anti-stupidity reasons (ie, to prevent me from losing a feature in cutting
and pasting)]

Nick




From pate at eylerfamily.org  Wed May 29 07:45:03 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Wed May 29 07:45:03 2002
Subject: [Koha-devel] Order from Chaos, maybe
In-Reply-To: <NGBBLPDKODDLFDKEDCDKMEIDCBAA.nsr@etome.net>
Message-ID: <Pine.LNX.4.30.0205291036000.21735-100000@bigfun.whirlycott.com>

On Wed, 29 May 2002, Nicholas Rosasco wrote:

> After seeing Rachel's (thankyouthankyouthankyouthankyouthankyou for that
> info.  It seriously demystifys some things for me at least) wiki posted
> Katipo Plan, I have gone and Japanese chef'd the Roadmap (see the Sliced and
> Diced link off the original) to reflect her comments and (hopefully)
> Katipo's priorities/client requests ... particularly her (painfully correct)
> "ack! you want one release manager to handle all of _that_" line of thought.

I think a big point to make here is that the 1.2 release manager shouldn't
just be making one release.  Instead, he/she should be looking at a series
of releases which encompass new development during their tenure.  Only the
really big stuff (MARC, templating, Z3950, etc) which impact the way most
or all of the system works are actually scheduled in specific releases.
(Of course, this is only my take on things.)

>
> My hope was to divvy it into each version (yes, they are un-numbered... if
> someone wants to go back and adjust, go ahead) getting a major and a minor
> goal.  Major features are usually things like MARC, minor things like shelf
> lists.  The only exception of the moment is the current Katipo version,
> which has all kinds of nifty things, including the early (and highly groovy)
> templating and info-display-options-controls stuff.
>
> Is Jeremy on the devel list?  Rachel, any comments (esp on if I've got the
> Katipan bullet points right?)?

If Jeremy isn't on the list, maybe we could set up a time to irc about it.
I'm sure that there are several people who'd love to share their own two
small units of local currency. ;)

-pate

>
> Ref'd:
> http://www.saas.nsw.edu.au/wiki/index.php?page=RachelsKatipoPlan
>
> New: http://www.saas.nsw.edu.au/wiki/index.php?page=SlicedAndDiced
> Old: http://www.saas.nsw.edu.au/wiki/index.php?page=KohaRoadmap
>
> [The old is intact, for the moment, for comparison reasons, and
> anti-stupidity reasons (ie, to prevent me from losing a feature in cutting
> and pasting)]
>
> Nick
>
>
> _______________________________________________________________
>
> Don't miss the 2002 Sprint PCS Application Developer's Conference
> August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/koha-devel
>




From tonnesen at cmsd.bc.ca  Thu May 30 11:34:02 2002
From: tonnesen at cmsd.bc.ca (Tonnesen Steve)
Date: Thu May 30 11:34:02 2002
Subject: [Koha-devel] proposed marc schema
Message-ID: <Pine.LNX.3.96.1020530110706.1336M-100000@hss-labs.cmsd.bc.ca>


I ran some benchmarks on Sergey's proposed marc schema, because I was a
little concerned about the performance problems of having to do a join to
retrieve a biblio.


To recap, here are the schemas that I used.  The first table is my
"all-in-one" schema, the second two are Sergey's:

CREATE TABLE marc_subfield_table (
                subfieldid bigint(20) unsigned NOT NULL auto_increment,
                tagid bigint(20) NOT NULL default '0',
                tag char(3) NOT NULL default '',
                bibid bigint(20) NOT NULL default '0',
                subfieldorder tinyint(4) NOT NULL default '0',
                subfieldcode char(1) NOT NULL default '',
                subfieldvalue varchar(255) default NULL,
                valuebloblink bigint(20) default NULL,
                PRIMARY KEY (subfieldid),
                KEY (bibid,tagid,tag,subfieldcode),
                KEY (bibid,tag,subfieldcode,subfieldvalue)
                ) TYPE=MyISAM;


CREATE TABLE marc_field_table_sergey (
       fieldid  bigint(20) unsigned NOT NULL auto_increment,
       bibid    bigint(20) NOT NULL default '0',
       tagid    bigint(20) NOT NULL default '0',
       tag      char(3) NOT NULL default '',
       PRIMARY KEY (fieldid),
       KEY (bibid),
       KEY (tagid),
       KEY (tag)
);

CREATE TABLE marc_subfield_table_sergey (
       subfieldid  bigint(20) unsigned NOT NULL auto_increment,
       fieldid bigint(20),
       subfieldorder tinyint(4) NOT NULL default '0',
       subfieldcode char(1) NOT NULL default '',
       subfieldvalue varchar(255) default NULL,
       valuebloblink bigint(20) default NULL,
       PRIMARY KEY (subfieldid),
       KEY (fieldid)
);




Here are the results of my benchmark:

getdata-steve:  0:08.29 0:08.36 0:08.24 0:08.25 0:08.28
getdata-sergey: 0:07.96 0:07.86 0:07.88 0:07.87 0:07.98

Times shown are for retrieving 2000 random records from a database of 5000
entries.  It's close, but Sergey's schema is marginally faster, and
unarguably better SQL, so let's go with splitting tag and subfield tables.

Note that I didn't use 80,000 records in my benchmark this time, mainly
because I didn't want to wait to generate a database that large.  With
only 5000 entries in the database, mysqld was able to cache the entire
database in ram on my test machine.  There was basically no hard drive
access during the benchmark (after I ran it a couple of times to make sure
all the data was cached).

Before the data was all cached, the lookups were taking more like 12-15
seconds for 2000 records.

Steve.




From pate at eylerfamily.org  Fri May 31 05:46:05 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 31 05:46:05 2002
Subject: [Koha-devel] May 30th irc meeting
Message-ID: <Pine.LNX.4.30.0205310842570.17804-100000@bigfun.whirlycott.com>

Just a quick note to let everyone know that meeting notes from the May
30th meeting are posted at:

http://www.saas.nsw.edu.au/wiki/index.php?page=IrcMeetingNotes

 a full log is at:

http://www.haz.cmsd.bc.ca/cgi-bin/kohalog.pl?date=30May02&refresh=&firstline=314&lastline=859&eventid=7

Thanks,
-pate




From pate at eylerfamily.org  Fri May 31 07:19:05 2002
From: pate at eylerfamily.org (Pat Eyler)
Date: Fri May 31 07:19:05 2002
Subject: [Koha-devel] Acceptance Letter
Message-ID: <Pine.LNX.4.30.0205311017070.17804-100000@bigfun.whirlycott.com>

                                                   31 May, 2002
To the Koha community;
I'd like to take a moment to accept the role of Kaitiaki[1] of Koha,
to thank those who have done so much work already, and to give an
overview of where I think we need to be going as a community.

Let me start with a bit of background: for the last month or so, there
has been an ongoing discussion between the developers about the
desirability of an official management/leadership function for the
Koha project.  The good folks at Katipo have been doing an admirable
job in this area, and are voluntarily opening this process up to the
larger community.

The result of these discussions was a decision to elect a person to
oversee the project.  This person's role is to work with the other
developers and the users of Koha to guide its development into a
library system that can serve the needs of any library; large or
small, english speaking or not.  The Kaitiaki will help craft a
strategy for growth and development, encourage organizations to use
Koha, improve support for Koha, and recruit additional
developers for the project.

In our last meeting, 30 May 2002, the developers present decided to
name me, Pat Eyler, as the Kaitiaki.  I'm honored and humbled by this
decision.  I'd like to pledge to all of you, users and developers,
that I'll do my best to make Koha as successful, as complete, as
user-friendly, and as capable as it can possibly be.

Koha would not exist if not for the efforts of the Horowhenua Library
Trust (HLT) and Katipo.  I'll mention only three people by name, not
because they are the only ones to have worked on it, but because I'm
afraid I'd leave people out if I tried to mention everyone.  Rosalie
Blake (Head of Libraries for HLT), Rachel Hamilton-Williams (General
Manager at Katipo), and Chris Cormack (Programmer at Katipo) should be
well recognized for their courage and efforts.  I hope that we'll be
working together for a long time to come.

Since Koha's initial release to the world outside Katipo and HLT, many
others have contributed to the project.  I'd like to thank all of them
for their efforts, and encourage them to keep up their good work.

I'll close with a quick overview of my hopes for Koha in the coming
year or so.  In the near term, we'll be releasing Koha 1.2.0 featuring
a number of bug fixes and improvements.  We'll likely release a few
more 1.2 series releases as well featuring yet more improvements and
bug fixes. Sometime in the late summer or early fall, we'll begin
releasing the 1.4 series.  This release series will feature MARC
capabilities as well as continuing improvements.

In parallel to these efforts, we'll be trying to internationalize
Koha.  Our first targets will be Polish (updating an earlier
translation) and Spanish (a brand new translation).  The experience we
gain from these two efforts should help us make additional
translations much easier.

We're also going to work hard to raise community awareness of Koha in
both the Open Source/Free Software and the professional library
communities.  This work will involve announcements, appearances at
conferences, and more work on documentation.

If you'd like to participate in any of these efforts, or if you would
like to suggest additional projects for us to take on, please feel
free to email me at <pate at gnu.org>.

thanks,
-pate


Pat Eyler
Kaitiaki of the Koha Project

[1] Kaitiaki, pronounced kah-ee-tee-ah-kee (unless my Maori
pronunciation is badly off), means guardian.