[Koha-devel] Question on proper/preferred DBI usage?

[Tonnesen Steve]

On Wed, 15 May 2002, Alan Millar wrote:

> I definitely do not want to get into a flame war on this, so if
> it turns that direction, I'll drop the subject.

No flame war from me.  I didn't know about the '?' method.  I like it a
lot, but did you _have_ to use _my_ code as an example?  ;)

As far as indenting goes, Paul, I'm with Chris, except I do whatever vim
does by default.  I'm all for setting a standard, I'm sure I can make vim
do whatever we decide.

Steve.



>         my $q_isbn=$dbh->quote($isbn);
>         my $q_issn=$dbh->quote($issn);
>         my $q_lccn=$dbh->quote($lccn);
>         my $q_volume=$dbh->quote($input->param('volume'));
>         my $q_number=$dbh->quote($input->param('number'));
>         my $q_itemtype=$dbh->quote($input->param('itemtype'));
>         my $q_dewey=$dbh->quote($input->param('dewey'));
>         my $q_subclass=$dbh->quote($input->param('subclass'));
>         my $q_publicationyear=$dbh->quote($input->param('publicationyear'));
>         my $q_publishercode=$dbh->quote($input->param('publishercode'));
>         my $q_volumedate=$dbh->quote($input->param('volumedate'));
>         my $q_volumeddesc=$dbh->quote($input->param('volumeddesc'));
>         my $q_illus=$dbh->quote($input->param('illustrator'));
>         my $q_pages=$dbh->quote($input->param('pages'));
>         my $q_notes=$dbh->quote($input->param('note'));
>         my $q_size=$dbh->quote($input->param('size'));
>         my $q_place=$dbh->quote($input->param('place'));
>         my $q_marc=$dbh->quote($input->param('marc'));
> 
>         $sth=$dbh->prepare("insert into biblioitems (biblioitemnumber, biblionum
> ber, volume, number, itemtype, isbn, issn, dewey, subclass, publicationyear, pub
> lishercode, volumedate, volumeddesc, illus, pages, notes, size, place, lccn, mar
> c) values ($biblioitemnumber, $biblionumber, $q_volume, $q_number, $q_itemtype,
> $q_isbn, $q_issn, $q_dewey, $q_subclass, $q_publicationyear, $q_publishercode, $
> q_volumedate, $q_volumeddesc, $q_illus, $q_pages, $q_notes, $q_size, $q_place, $
> q_lccn, $q_marc)");