[Koha-devel] Bug in Mail::Sendmail.pm used in Koha

[Ambrose Li]

Hello,

I have found that Mail::Sendmail.pm contains a bug which *might*
prevent mail from being sent at all on some systems (e.g., my
own). This is related to conformance to the RFC821 standard
(section 4.1.2, "Command Syntax"), so whether the bug affects
a particular Koha depends on how strict the SMTP server is
regarding syntactical correctness of SMTP commands.

I am trying to contact the module's author about the problem. In
the meantime, if the bug hits anyone, the patch to fix it is the
following very short one:

--- Sendmail.pm.orig	Thu Feb  6 17:47:21 2003
+++ Sendmail.pm	Mon Mar  1 11:32:02 2004
@@ -332,13 +332,13 @@
         || return fail("send HELO error");
     socket_read()
         || return fail("HELO error ($_)");
-    socket_write("MAIL FROM: <$fromaddr>$CRLF")
+    socket_write("MAIL FROM:<$fromaddr>$CRLF")
         || return fail("send MAIL FROM: error");
     socket_read()
         || return fail("MAIL FROM: error ($_)");
 
     foreach $to (@recipients) {
-        socket_write("RCPT TO: <$to>$CRLF")
+        socket_write("RCPT TO:<$to>$CRLF")
             || return fail("send RCPT TO: error");
         socket_read()
             || return fail("RCPT TO: error ($_)");