[Koha-devel] [Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;

[Mason James]

On 2008/08/27, at 3:34 PM, Joe Atzberger wrote:

>
> On Tue, Aug 26, 2008 at 7:00 PM, MJ Ray <mjr at phonecoop.coop> wrote:
> Mason James <mason.loves.sushi at gmail.com> wrote:
> > On 2008/07/29, at 11:37 PM, MJ Ray wrote:
> > > Consider this the first, then!
> > > http://rt.cpan.org/Ticket/Display.html?id=38013
> > [...]
> > I've just built HTML-Template-Pro-0.70 fine on my OSX 10.4 box, 1st
> > go even.
> > MJR, This may well be an issue with your specific system alone?,
>
> I don't see why.  The then-current H:T:P built fine for me too on the
> same system under 10.4, but fails under 10.5.  The maintainer hasn't
> yet suggested that it's a local configuration error and it's hard to
> see how it could be - I've changed very few settings.  It might be a
> problem with fink or perl on 10.5, but I probably won't be the only
> user of those versions.
>
>
> See the Known Problems section of the perlmacos perldoc:
>
> If you have installed extra libraries such as GDBM through Fink (in  
> other words, you have libraries under /sw/lib), or libdlcompat to / 
> usr/local/lib, you may need to be extra careful when running  
> Configure to not to confuse Configure and Perl about which  
> libraries to use.
>
> Sounds like a likely vector.


>
> > I think we do need to properly prove that H:T:P's ELSIF's are buggy
> > before we remove them,
> > as they make the template logic a lot saner
>
> IF ... ELSIF ... /IF isn't much saner than IF ... ELSE IF ... /IF /IF
>
> It is saner.  And as you increase the depth, it is exceedingly saner.
>
> <!-- TMPL_IF NAME="var1" -->
> <!-- TMPL_ELSE -->
>      <!-- TMPL_IF NAME="var2" -->
>      <!-- TMPL_ELSE -->
>          <!-- TMPL_IF NAME="var3" -->
>          <!-- TMPL_ELSE -->
>              <!-- TMPL_IF NAME="var4" -->
>              <!-- /TMPL_IF -->
>          <!-- /TMPL_IF -->
>      <!-- /TMPL_IF -->
> <!-- /TMPL_IF -->
>
> vs.
>
> <!-- TMPL_IF NAME="var1" -->
> <!-- TMPL_ELSIF NAME="var2" -->
> <!-- TMPL_ELSIF NAME="var3" -->
> <!-- TMPL_ELSIF NAME="var4" -->
> <!-- /TMPL_IF -->
>

Hi Guys,

Yeah, its those examples that make my eyes water too!! ;)

Ok so we are at a bit of a stalemate for now...

I'm gonna ping walter at katipo and see if he can compile H:T:P on his  
OSX-10.5 boxes

MJR: can you replicate it easily on another 10.5 box?

PS: they (read: OSX boxes) can be tricky to set up LAMP/WAMP? stuff  
on for new admins,
I got veeeery close to getting a koha3 running on my OSX after a few  
weeks of futzing (Ryan says it can be done ;),
but gave into a deb VM instead.

On a final note, I think some of the newer features in H:T:P are  
(when proven stable) going to really help bring the templates  to a  
level of cleanliness and readability that most of the other areas of  
code are now looking (thanks everyone)

Anyone else on the list have a 10.5 box to have a go at this?

$ cpan HTML::Template::Pro


Mason.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-devel/attachments/20080828/b06c433a/attachment-0003.htm>