[Koha-devel] Large patch series for bug 2000

[Galen Charlton]

Hi,

I have submitted a series of patches to fix the blocker bug 2000.
Since the patches are extensive, I wanted to point them out, not just
rely on people catching them on the patches list.

The bug has to do with the separate admin scripts for editing fines
rules and loan rules.  Since both scripts edit rows in the
issuingrules table but don't directly tie the fine and loan rules
together, it was possible for a user to subtly misconfigure their
circulation rules.  For example, if a user creates a loan rule for a
default patron category, then creates a fine rule for a more specific
one, the new fine rule will have an empty loan component that silently
overrides the first loan rule.

Please read the patch description for the complete details, but here's
a summary of what I did:

* made some improvements to smart-rules.pl (the "alternate" circ rules
editor) to allow it to replace issuingrules.pl and finesrules.pl
* created several new database tables to store maximum allowed
checkouts across item types without having to rely on a special
interpretation of the wildcard character in issuingrules.itemtype
* clarified how issuingrules is searched: when trying to find a loan
rule for a given branch, itemtype, and patron category, Koha now
searches for the most specific rule that matches, then looks for less
specific ones.

Regards,

Galen
-- 
Galen Charlton
Koha Application Developer
LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel