[Koha-devel] [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies

[MJ Ray]

Warning: Reply-To set to koha-devel.

"Andrew Moore" <andrew.moore at liblime.com> wrote:
> I guess it should be optional. Good point. If it's an optional
> dependency, how should I indicate that? Should I leave it out of
> Makefile.PL altogether?

I know no good way to indicate optional modules in Makefile.PL.
Three choices that I think are better than total omission:-

1. put it in as a comment and POD string;

2. put it in as something like %CURRENT_PM like spamassassin does
http://spamassassin.apache.org/full/3.0.x/dist/Makefile.PL

3. switch on META.yml generation and add a recommends line
http://module-build.sourceforge.net/META-spec.html

Which do people prefer?  I'd lean towards doing (1 or 2) and 3.

> > Why does this patch covertly reindent everything?
>
> I didn't intend for it to be covert. [...]

OK.  Please try to mention these things in comments.  It'd be a bit of
a pain to cherry-pick a patch described as "adding SMS::Send ..." and
have the dep's rewritten without warning.

> I'd really like to be able to use perltidy to make the code that I
> edit and contribute more readable. Is there a particular indentation
> style that you think would be good to use on code that I change in
> Koha? I couldn't find much about this on the wiki.

If my notes from 1.9 are accurate, we used to use
  perltidy -bar -ce -pt=2 -vt=2 -en=4
which is almost what is in the perlstyle manual, except cuddled elses.
However, it's not been enforced much and "more readable" depends on
what you're using to read it...

The wiki really isn't in good shape and I find it too much of a pain
to edit.  Searching the mailing list and IRC is usually more useful.
Should we create a HACKING file (which is what I think GNU software
calls the file) with the above sort of info in it?

Regards,
-- 
MJ Ray (slef)
Webmaster for hire, statistician and online shop builder for a small
worker cooperative http://www.ttllp.co.uk/ http://mjr.towers.org.uk/
(Notice http://mjr.towers.org.uk/email.html) tel:+44-844-4437-237
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel