[Koha-devel] [Koha-patches] [PATCH] Bug 2176: adding SMS::Send to list of dependencies

[Andrew Moore]

Hi Henri -

thanks for your input on this.

On Mon, Jun 23, 2008 at 5:08 PM, Henri-Damien LAURENT
<laurenthdl at alinto.com> wrote:
> For instance, I have been said that SMS::Send even if not used or not
> desired would be required just becaus it was loaded in some core
> modules. If not, then error 500 would come out.

I have really tried to avoid that, but if you find that is the case,
please let me know. I'm happy to try to fix it.

> I havenot investigated. But maybe we should be aware of the fact that
> adding a new dependency, should be done quite conciously and cautiously.

I thought I did that. Please let me know if there are more steps I
should take next time.

> And if dependency is not require, try and test on a fresh build bot so
> that it is proven that it is not generating errors not to install the
> perl module added.

I would like to do that very much. I've been struggling to get toward
to state of having a smoke tester or a build server or a buildbot or
something like that. If you have one set up, I encourage you to show
us how we can get test results from it.

Thanks!
-Andy