[Koha-devel] RFC on ISBN sanitisations, was: [Koha-patches] [PATCH] Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

[MJ Ray]

Joe Atzberger <joe.atzberger at liblime.com> wrote: [...]
> +++ b/opac/opac-detail.pl
[...]
> +sub isbn_cleanup ($) {
> +	my $isbn=shift;
> +	if (
> +		$isbn =~ /\b(\d{13})\b/ or
> +		$isbn =~ /\b(\d{10})\b/ or 
> +		$isbn =~ /\b(\d{9}X)\b/i
> +	) {
> +		return $1;
> +	}
> +	return undef;
> +}
> +

Should this be moved into C4 somewhere, expanded to strip non-[0-9X]s
and convert UPC barcodes into ISBNs (for barcode wedge users during
cataloguing) before checking, and used more widely?

Looking for comments,
-- 
MJ Ray (slef)
Webmaster for hire, statistician and online shop builder for a small
worker cooperative http://www.ttllp.co.uk/ http://mjr.towers.org.uk/
(Notice http://mjr.towers.org.uk/email.html) tel:+44-844-4437-237