[Koha-devel] RFC on ISBN sanitisations, was: [Koha-patches] [PATCH] Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

[MJ Ray]

Jesse <pianohacker at gmail.com> wrote:
[ Galen wrote (I think):]
> > Yes, I think this should be moved to C4.  I've been noodling around
> > with the notion of creating a C4::Normalize or the like to centralize
> > these kinds of normalizations (as ISSNs, LC card numbers, OCLC
> > numbers, etc. could benefit from this as well), but haven't done
> > anything yet.
[...]
>
> Do you think we could also put standard formatting of these types of numbers
> in there, and make a naming scheme?

For some reason, emails from liblime.com aren't reaching me promptly
today, so I'll reply to both of the above at once:-

I suspect C4::Normalize would have poor cohesion (probably logical
cohesion) so would prefer creating C4::ISBN and similar, with methods
like new($), raw(), normal(), display() and so on.

Would the display() methods be best if they use a syspref?

Anyway, if this isn't already in there, maybe we should hesitate on
adding this new feature.  Seems pretty damn compelling to me, though.

Hope that helps,
-- 
MJ Ray (slef)
Webmaster for hire, statistician and online shop builder for a small
worker cooperative http://www.ttllp.co.uk/ http://mjr.towers.org.uk/
(Notice http://mjr.towers.org.uk/email.html) tel:+44-844-4437-237