[Koha-devel] RFC on ISBN sanitisations, was: [Koha-patches] [PATCH] Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

[jmf at arwen.metavore.com]

On Thu, May 15, 2008 at 12:20:24PM -0400, Joe Atzberger wrote:
> MJ --
> 
> "Should this be moved into C4 somewhere?"
> 
> My commit message for that piece concluded:
> Next we should move the sanitize function into C4 for widespread consumption
> and consistency.
> 
> Short answer: yes!
I've pushed up Joe's patch to solve the immediate issue raised, but will
be happy to see a patch for a C4::Normalize::* if someone has time for
that; otherwise, perhaps we can slate that for 3.2.

Josh

> 
> --Joe
> 
> On Wed, May 14, 2008 at 2:01 PM, Galen Charlton <galen.charlton at liblime.com>
> wrote:
> 
> > Hi,
> >
> > On Wed, May 14, 2008 at 12:32 PM, MJ Ray <mjr at phonecoop.coop> wrote:
> > > Joe Atzberger <joe.atzberger at liblime.com> wrote: [...]
> > >  > +++ b/opac/opac-detail.pl
> > >  [...]
> > >  > +sub isbn_cleanup ($) {
> > [snip]
> > >  Should this be moved into C4 somewhere, expanded to strip non-[0-9X]s
> > >  and convert UPC barcodes into ISBNs (for barcode wedge users during
> > >  cataloguing) before checking, and used more widely?
> >
> > Yes, I think this should be moved to C4.  I've been noodling around
> > with the notion of creating a C4::Normalize or the like to centralize
> > these kinds of normalizations (as ISSNs, LC card numbers, OCLC
> > numbers, etc. could benefit from this as well), but haven't done
> > anything yet.
> >
> > Regards,
> >
> > Galen
> > --
> > Galen Charlton
> > Koha Application Developer
> > LibLime
> > galen.charlton at liblime.com
> > p: 1-888-564-2457 x709
> >

> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-devel