[Koha-devel] koha code cleaning bug?

[Galen Charlton]

Hi,

On Mon, Sep 29, 2008 at 1:37 PM, Marc Chantreux
<marc.chantreux at biblibre.com> wrote:
> On Mon, Sep 29, 2008 at 12:43:52PM -0400, Joe Atzberger wrote:
>> Case in point though, here I agree it is better to add a variable rather
>> than assign to $_.  But more broadly, coding to avoid $_ altogether is
>> working against the language unnecessarily and, imho, unproductively.
>
> Joe++
>
> For the moment, we have guys pro and 2 cons. Is it possible to poll and
> add it in the coding style?

We could, but it regardless of the decision, it would be of little
practical effect unless it turns out people *really* care one way or
the other.  You know my opinion on the use of $_ as an implicit
iterator, but I would not use that as a primary criterion for
accepting or rejecting patches.

There are much bigger coding and stylistic problems to fix, including
lack of use of the warnings pragma, circular module dependencies
resulting in funky @EXPORT problems,  inconsistent indentation,
out-of-date, POD, low test suite coverage, and so on.  I would rather
that the style guide focus on the larger issues.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt