[Koha-devel] Due Date check in C4::Circulation::CanBookBeIssued?
Galen Charlton
galen.charlton at liblime.com
Mon Apr 27 23:42:00 CEST 2009
Hi,
On Mon, Apr 27, 2009 at 5:26 PM, Michael Hafen <mdhafen at tech.washk12.org> wrote:
> The Due Date check is commented out in CanBookBeIssued. I'm planning
> uncomment and expand it. Before I do that I want to know why it's
> commented out. I seem to recall it being a problem for Offline Circ,
> but looking at process_koc.pl CanBookBeIssued isn't even called.
git blame is your friend here. As far as I can work out, the line was
commented out with the expectation that any code that calls
CanBookBeIssued() would have already verified that the due date, in
this case set via a global due date or a due date specified by the
operator, is valid. Note that in this context, the $datedue parameter
passed to CanBookBeIssued() is allowed to be undef, since most of the
time you'll be having AddIssue() calculate the due date.
Regards,
Galen
--
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt
More information about the Koha-devel
mailing list