[Koha-devel] Use of TMPL_IF EXPR

[LAURENT Henri-Damien]

In fact,
from what I know and experienced
TMPL_IF EXPR is quite demanding
if variable is undefined, it writes a log message, and would sometimes fail.
So that decision was taken to remove that.
hopes that helps.
-- 
Henri-Damien LAURENT

Garry Collum wrote:
> The one time I used EXPR in one of my patches, Galen figuratively
> smacked me around because it added a bunch of garbage to the apache
> logs.  I rewrote the patch without EXPR.
>
> Garry
>
> On Wed, Dec 30, 2009 at 3:20 PM, MJ Ray <mjr at phonecoop.coop> wrote:
>   
>> Owen Leonard asked:
>>     
>>> Re: Bug 2670 (http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2670)
>>>
>>> Is it possible to set up guidelines under which EXPR is allowed? If we
>>> can confirm that variables will be output under all circumstances
>>> would an EXPR be allowed?
>>>       
>> hdl's bug report doesn't explain why it had to be removed.
>> Is it a performance worry or a security worry?
>>
>> If it's a performance worry, we should probably try to remove it
>> whenever possible.  If security, being sure that variables are
>> output every time should be good enough IMO.
>>
>> Hope that helps,
>> --
>> MJ Ray (slef)  Webmaster and LMS developer at     | software
>> www.software.coop http://mjr.towers.org.uk        |  .... co
>> IMO only: see http://mjr.towers.org.uk/email.html |  .... op
>> _______________________________________________
>> Koha-devel mailing list
>> Koha-devel at lists.koha.org
>> http://lists.koha.org/mailman/listinfo/koha-devel
>>
>>     
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-devel
>
>