[Koha-devel] {Disarmed} Re: Label generator broken?

[Bernard Shiundu]

Hi Chris,

Sorry I took so long to get back to you. Just tested. Fixed for layouts + profiles but problem still persists for templates. Logs below

1. Log output when I choose a template to edit:

[Thu Oct 15 19:40:46 2009] [error] [client ....] [Thu Oct 15 19:40:46 2009] label-edit-template.pl: operation = edit, referer: http://.../cgi-bin/koha/labels/label-manage.pl?label_element=template<http://localhost:8008/cgi-bin/koha/labels/label-manage.pl?label_element=template>
[Thu Oct 15 19:40:46 2009] [error] [client ...] [Thu Oct 15 19:40:46 2009] label-edit-template.pl: Use of uninitialized value in numeric eq (==) at /.../labels/label-edit-template.pl line 103., referer: http://.../cgi-bin/koha/labels/label-manage.pl?label_element=template<http://localhost:8008/cgi-bin/koha/labels/label-manage.pl?label_element=template>

2. Log output on save
[Thu Oct 15 19:41:04 2009] [error] [client ...] [Thu Oct 15 19:41:04 2009] label-edit-template.pl: operation = save, referer: http://..../cgi-bin/koha/labels/label-edit-template.pl?op=edit&amp;element_id=2<http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=edit&element_id=2>
[Thu Oct 15 19:41:04 2009] [error] [client ...] [Thu Oct 15 19:41:04 2009] label-edit-template.pl: Can't bless non-reference value at /..../C4/Labels/Profile.pm line 89., referer: http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=edit&amp;element_id=2<http://localhost:8008/cgi-bin/koha/labels/label-edit-template.pl?op=edit&element_id=2>



On Wed, 2009-10-14 at 20:45 +0300, Chris Nighswonger wrote:
Hi Bernard,

On Mon, Oct 12, 2009 at 12:20 PM, Chris Nighswonger <cnighswonger at foundations.edu<mailto:cnighswonger at foundations.edu>> wrote:
On Mon, Oct 12, 2009 at 11:30 AM, Chris Nighswonger

<cnighswonger at foundations.edu<mailto:cnighswonger at foundations.edu>> wrote:
> On Mon, Oct 12, 2009 at 9:36 AM, Chris Nighswonger
> <cnighswonger at foundations.edu<mailto:cnighswonger at foundations.edu>> wrote:
>> On Mon, Oct 12, 2009 at 5:36 AM, Bernard Shiundu
>> <BShiundu at strathmore.edu<mailto:BShiundu at strathmore.edu>> wrote:
>>> Still no joy.
>>>
>>> Applied the patch and it sorted out the bug with the printer profiles (they are now saved correctly when editing) however I still have the same error when trying to save templates/layouts after editing and the changes are not saved. The error also comes when creating new templates/layouts - however these are saved.
>>>
>>> Additional info:
>>> The logs show:
>>> [Mon Oct 12 12:32:07 2009] [error] [client ...] label-edit-template.pl<http://label-edit-template.pl>: Use of uninitialized value in numeric eq (==) at /../labels/label-edit-template.pl<http://label-edit-template.pl> line 100., referer: http://../cgi-bin/koha/labels/label-manage.pl?label_element=template<http://label-manage.pl?label_element=template>
>>> [Mon Oct 12 12:32:12 2009] [error] [client ...] label-edit-template.pl<http://label-edit-template.pl>: Can't bless non-reference value at /.../C4/Labels/Profile.pm line 89., referer: http://.../cgi-bin/koha/labels/label-edit-template.pl?op=edit&amp;element_id=1<http://label-edit-template.pl?op=edit&amp;element_id=1>
>>
>> I'm working on a fix for this bug. Would you mind filing a bug report
>> at http://bugs.koha.org and include this information?
>
> Ok, I'm submitting a patch to fix this.
>
> I'll also file the bug.


Bug 3706 submitted
(http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3706) along
with a patch to fix.

Bernard, If you have time, please apply the patch and test.


I am wondering if you have had time to test if the patches I submitted fixed the issues you were having? They have been pushed to the HEAD, so you could get them that way as well.

If this does resolve the issue, just let me know so I can close the bug.

Kind Regards,
Chris

________________________________
Strathmore University provides all-round education in an atmosphere of freedom and responsibility.
This email and any files transmitted with it are intended solely for use by the recipient(s) to whom it is addressed and may contain confidential information. If you have received this email in error please notify the sender immediately and permanently delete this email and/or any files attached to it from your computer. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Strathmore University. The University accepts no liability whatsoever for any loss or damages incurred, or suffered, resulting, or arising, from the use of this email and/or its attachments. The University warrants neither the integrity of the e-mail nor its freedom from errors, viruses, interception or any other form of interference.
………………………………………………………………….
Website: www.strathmore.edu


-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-devel/attachments/20091015/9108b40d/attachment-0003.htm>