[Koha-devel] Change requested: XSLT syspref changes in 3.0.x

[Galen Charlton]

Hi,

I would like to request that the following 3.0.x commits be reverted
or modified before the release of 3.0.6.

4b04de209aa25816f5d97c05ce71ea9619027484
3057a7afb98c9224d3fd987131ae88956eb513d3

The upshot of these changes are that XSLTDetailsDisplay and
XSLTResultsDisplay were changed from a Boolean to a free text field
containing the full path to the desired XSLT stylesheets.
Unfortunately, this has a defect that I would really prefer not get
propagated, and I would not have accepted this change for HEAD as is.

Specifically, unlike every other syspref that specifies an override of
a template or CSS file, the proposed change requires the operator to
know and enter the server path of the stylesheet, *including* the
language directory (assuming that the operator is specifying a local
stylesheet).  For example:

../koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl

Besides forcing the operator to get the path right (and OPAC results
and/or details display breaks if the operator gets it wrong), which no
other syspref requires, it prevents a multi-lingual OPAC from being
able to use a different stylesheet for each translation it uses.
Local template and XSL files referred to by a syspreef should always
be presented to the operator relative to the translation, i.e., a
plain 'MARC21slim2OPACDetail.xsl' instead of
'../koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl', with
code to select the appropriate translation.  Furthermore, it should
degrade more gracefully if the XSLT file specified in the syspref
doesn't exist.

In the short term, I would like to see one of the following happen:

[1] The changes get reverted in 3.0.x, leaving the sysprefs as Boolean
and allowing this enhancement to be dealt with in HEAD for 3.2.
[2] The changes get improved so that there is a fallback and the
syspref will respect the translation system.

Regards,

Galen
-- 
Galen Charlton
Koha 3.2 Release Manager
gmcharlt at gmail.com