No subject

All patches should have at least 1 signoff before the Release Manager
looks at them, (exceptions will be made for trivial patches).
Preferably 2 signoffs, 1 from the QA manager and 1 from someone else.
Although 1 from the QA manager will suffice.

All patches should refer to a bug number

Chris

2010/11/11 Ian Walls <ian.walls at bywatersolutions.com>:
> Everyone,
>
> While there can be no guarantees as to whether a patch will be committed
> into the Koha codebase, I think in practice there are several requirement=
s.
> =A0This email is an attempt to identify a few of them, and hopefully star=
t a
> discussion about whether they are truly requirements, and what others cou=
ld
> possibly be added.
> 1. =A0The patch must do what it claims to do, in all commonly-supported K=
oha
> environments
> 2. =A0The patch must not break existing functionality
> 3. =A0The patch must apply to the current HEAD of the master branch of th=
e
> code
> 4. =A0The patch must follow the Coding Style Guidelines
> 5. =A0The patch must be MARC-flavour agnostic
> 6. =A0The patch must contain appropriate copyright information
> 7. =A0If a database update is require, the patch must handle the update b=
oth
> for new installs and upgrades
> 8. =A0If a new feature is added, the patch must include appropriate Help
> documentation
> What do people think of these requirements? =A0Are they reasonable? =A0Sh=
ould
> there be more? =A0I understand that there may not be any set of requireme=
nts
> that's completely sufficient, but if we can identify as many as possible,=
 it
> would make developers lives a bit easier, since we'd all have a better id=
ea
> what is needed for our patches to be committable.
> Cheers,
>
> -Ian
> --
> Ian Walls
> Lead Development Specialist
> ByWater Solutions
> Phone # (888) 900-8944
> http://bywatersolutions.com
> ian.walls at bywatersolutions.com
> Twitter: @sekjal
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>