[Koha-devel] [Koha-patches] [PATCH] [SIGNED-OFF] Bug 6614: Remove newlines from order notes when exporting to CSV

[Colin Campbell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 27/07/11 01:38, Robin Sheat wrote:
> Nicole C. Engard schreef op di 26-07-2011 om 14:22 [-0400]:
>> If an order contained a note with a newline in it, that line would 
>> come out as a blank entry in the exported CSV.  This patch strips 
>> such characters, globally.
> 
> It should be OK to have \r and \n in CSVs, provided the fields are 
> correctly wrapped in a quote characters>

> I would expect Text::CSV to be able to understand such quoting and 
> escaping properly.
> 
Yes but the problem is that the Text::CSV object is not created as
binary. So that the problem is not only with end of lines but with
non-ascii characters. see Text::CSV's documentation
Colin

- -- 
Colin Campbell
Chief Software Engineer,
PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 845 557 5634 (phone)
+44 (0) 7759 633626  (mobile)
colin.campbell at ptfs-europe.com
skype: colin_campbell2

http://www.ptfs-europe.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4v53oACgkQiPfkNnpIKz+ghgCeJxUBGyffZ+iGQrGJPAOkjzn2
RwEAoKe+TASJZr2O1N1H5A8Ddn3vtjLr
=mKT3
-----END PGP SIGNATURE-----