[Koha-devel] Perl style point, was: tt style point

Paul Poulain paul.poulain at biblibre.com
Tue Oct 25 10:37:59 CEST 2011


Le 24/10/2011 19:18, MJ Ray a écrit :
>> ok.... But is there a perltidy option to be sure to abide by this
>> "perlstyle"
> 
> As I understand it, perltidy defaults to perlstyle, so just run it
> with no options or rc file.

Reminder: we've said during the last IRC monthly meeting that:
  * new code should be perlstyled
  * perltidying must not be done in a file mixed with other things
  * we don't perltidy everything for now, as it would result in git
blame returning the perltidy submitter as author of everything.

Side question : if someone has an idea to perltidy everything and not
loose the blame, he's welcomed. I've checked git blame --help, and it
seems we have a friend here :
       -w
           Ignore whitespace when comparing the parent’s version and the
           child’s to find where the lines came from.
except it's just for whitespace, and perltidy often update more than
space...

QUESTION/DISCUSSION =
I feel that just tidying new code will result in a mixing of style that
will be uncomfortable. OTOH, tidying everything would resuld in git
blame being unsusable.
It mean both situations are unsatisfying. Does anyone have an idea to
improve the situation ?

-- 
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
Tel : (33) 4 91 81 35 08


More information about the Koha-devel mailing list