[Koha-devel] Koha Calendar

[Galen Charlton]

Hi Elliott,

On May 16, 2012, at 12:00 PM, Elliott Davis wrote:
> As I’m sure everybody running master has realized, bug 5549 introduced a new module Koha::Calendar.  After digging around in the module I realized that the table special_holidays had separate columns for year, month, and date.  I am wondering what the rationale is behind this decision.  If it was simply I preference I would like to propose that we move it to replace the 3 current columns with a timestamp so that the calendar can take advantage of setting open and closed hours and fining for hourly based items accordingly.

The table special_holidays itself currently just sets closed days, but just using a date field rather than year/month/day seems reasonable.  I'm less sure about using a timestamp field; if we extend special_holidays to cover not just closures but alternative opening and closing times, I think it might be better to use two time fields to set the opening and closing times, e.g.

special_holidays:
  the_date date
  open_time time
  close_time time
  is_open_at_all boolean

Regards,

Galen
--
Galen Charlton
Director of Support and Implementation
Equinox Software, Inc. / The Open Source Experts
email:  gmc at esilibrary.com
direct: +1 770-709-5581
cell:   +1 404-984-4366
skype:  gmcharlt
web:    http://www.esilibrary.com/
Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org