[Koha-devel] Signing-off a patch for a customer

[Marcel de Rooy]

I agree with most responses in this thread: If a company makes a patch, a customer of that company signs off, it should not be QAed by that company, but by a "neutral" party. The QAer should even be allowed to ask for a second outside signoff if he feels the patch needs that additional proof.
As Paul mentioned earlier (he does QA but does not set the status): In order to prevent the appearance of pushing the process, you could even ask if it would be wiser to refrain from such QA comments. (Or just mail them to the author.)

Marcel
________________________________________
Van: koha-devel-bounces at lists.koha-community.org [koha-devel-bounces at lists.koha-community.org] namens Kyle Hall [kyle.m.hall at gmail.com]
Verzonden: dinsdag 29 mei 2012 12:30
To: Dobrica Pavlinusic
Cc: koha-devel at lists.koha-community.org
Onderwerp: Re: [Koha-devel] Signing-off a patch for a customer

I am also of the mind the sign-off should be allowed by another
employee of the same organization as the developer, provided they
signer has no history of signing off on patches without testing. I do
strongly also believe that QA must then be done by a disinterested
party.

Kyle