[Koha-devel] QA Re: FIX in qa-tools

[Mason James]

On 2012-10-25, at 1:40 AM, Jonathan Druart wrote:

> Hi Mason,
> 
> I did not rebase my qa-tools repo and I found a bug in the check of perlcritic.
> So I fixed it and ... I was not able to push, I was not up-to-date :)
> 
> In fact you already tried to fix it in the commit "fixed perlcritic test".
> But It is not the good way:
>     # If the tested file is deleted in the commit,  we return 0
>     return 0 unless -e $self->path;
> 
>     # If the tested file is newly created int the commit, (ie: nothing existing to compare too),  we call Perl::Critic, not Test::Perl::Critic::Progressive
>      unless (-e $self->path)  {
> 
> if the path does not exist, the routine returns 0 and does not execute the second unless statement. (and print a warning launching tests: An error occured : Can't use string ("0") as an ARRAY ref while "strict refs" in use at t/Perl.t line 72.).
> 
> I think my last commit ("add a new flag "new_file" to mark a file if it is a newly created") fixes correctly the problem but... be careful :)
> 
> Jonathan

heya Jonathan

thanks for this, ill do some testing then push your changes up to the kc.rg github repo
https://github.com/Koha-Community/koha-qa-tools