[Koha-devel] Fwd: Re: Bug Numbers in Update Database
Jared Camins-Esakov
jcamins at cpbibliography.com
Tue Sep 25 01:08:21 CEST 2012
Mark,
Can we start putting our bug references in our updates?
>
>
[to the mailing list at large] I have no objection.
> mveron:
>
> This rule should be written down somewhere in the Wiki.
>> But where?
>>
>
> It took some hunting, but I think it is already written down:
> http://wiki.koha-community.**org/wiki/Guidelines_for_Patch_**
> Acceptance/Rejection<http://wiki.koha-community.org/wiki/Guidelines_for_Patch_Acceptance/Rejection>
> "9. The patch must refer to a bug number"
>
> And if you follow the bug number link:
> http://wiki.koha-community.**org/wiki/Coding_Guidelines#**Bug_numbers<http://wiki.koha-community.org/wiki/Coding_Guidelines#Bug_numbers>
> "... include Bug + the bug number at the beginning of your commit message
> ..."
>
I think Coding Guidelines is the right place to put it, but Nicole is
asking about the messages in updatedatabase not commit messages.
> Though, these both could be clarified to expressly say in the first line
> of the commit message. I must have read this at some point in time, because
> I have been doing this. I just didn't remember why.
>
I suspect you're doing it because I failed your first patch for not having
the bug number in the first line of the commit message.
Regards,
Jared
--
Jared Camins-Esakov
Bibliographer, C & P Bibliography Services, LLC
(phone) +1 (917) 727-3445
(e-mail) jcamins at cpbibliography.com
(web) http://www.cpbibliography.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-devel/attachments/20120924/62ac31b1/attachment-0001.htm>
More information about the Koha-devel
mailing list