[Koha-devel] Broken url in arabic facets.. and fix

[Bernardo Gonzalez Kriegel]

I did some tests, and for me Bug 9579 is fixed by Bug 10176,
and now arabic facets are working, I will put a comment on the bug.

That symbol was explicitly added on Bug 8888
(
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12849&action=diff
),
I don't have the faintest idea about the reason.

Regards


-- 
Bernardo Gonzalez Kriegel
bgkriegel at gmail.com


On Wed, Jun 5, 2013 at 5:55 AM, Fridolyn SOMERS <
fridolyn.somers at biblibre.com> wrote:

> Very interesting.
> I think this charaters are escaped to not beak CCL syntaxe.
> But in this syntaxe, there is no ؟
> Will you create a patch for this or do you think it may fix Bug 9579 ?
>
> Regards,
>
> Le 05/05/2013 03:33, Bernardo Gonzalez Kriegel a écrit :
>
>> Hi,
>> Karam made an interesting discovery for Bug 10176 [1],
>> putting "use utf8;" on Search.pm fixes URL of facets (not
>> display well for me, but url works).
>>
>> Digging a little I found that on line 574 of master Search.pm
>> there is a strange symbol (last between []). Seems to be an
>> inverted question mark. Karam saids that is Arabic one.
>>
>> 572:# Sanitize the link value : parenthesis, question and exclamation mark
>> will cause errors with CCL
>> 573-                                my $facet_link_value = $one_facet;
>> 574-                                $facet_link_value =~ s/[()!?¡¿؟]/ /g;
>> 575-
>>
>> Question: this char is a typo? Was introduced on Bug 9183 [2]
>>
>> 'use utf8;' fixes the substitute, and the URLs.
>> Also removing that char gives the same effect (without 'use utf8:'
>>
>> Patch is from jcamins
>>
>> Regards,
>> bernardo
>>
>> [1] http://bugs.koha-community.**org/bugzilla3/show_bug.cgi?id=**10176<http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176>
>> [2] http://bugs.koha-community.**org/bugzilla3/show_bug.cgi?id=**9183<http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9183>
>>
>>
>>
>> ______________________________**_________________
>> Koha-devel mailing list
>> Koha-devel at lists.koha-**community.org<Koha-devel at lists.koha-community.org>
>> http://lists.koha-community.**org/cgi-bin/mailman/listinfo/**koha-devel<http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel>
>> website : http://www.koha-community.org/
>> git : http://git.koha-community.org/
>> bugs : http://bugs.koha-community.**org/<http://bugs.koha-community.org/>
>>
>>
> --
> Fridolyn SOMERS
> Biblibre - Pôle support
> fridolyn.somers at biblibre.com
> ______________________________**_________________
> Koha-devel mailing list
> Koha-devel at lists.koha-**community.org<Koha-devel at lists.koha-community.org>
> http://lists.koha-community.**org/cgi-bin/mailman/listinfo/**koha-devel<http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel>
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.**org/ <http://bugs.koha-community.org/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20130605/b8231da2/attachment.html>