[Koha-devel] upcoming_digest?!

[Barton Chittenden]

>
> Mark,

You were spot on when you said "there must be some side-effect obscuring
the code"

$upcoming_digest is set on line 281:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/advance_notices.pl;h=62e36e4a92920b2bafc67c79043bf0a197491842;hb=HEAD#l281

Here's the code snippit

281             my $digest =
$upcoming_digest->{$upcoming->{'borrowernumber'}} ||= {};

This is saying

If $upcoming_digest->{$upcoming->{'borrowernumber'}} is false, set it to an
empy hashref.

Then set the $digest to the value
of $upcoming_digest->{$upcoming->{'borrowernumber'}}.

It just so happens that advance_notices.pl was the first piece of Koha code
that I read through in detail ,and I remember griping about it in #koha:

http://irc.koha-community.org/koha/2014-01-22#i_1455327

Your reply was

15:39 mtompset > Oh my! That is perl abuse. :P

;-) ;-)

Unfortunately, I didn't file a bug report as suggested by tcohen.

--Barton

On Tue, Nov 18, 2014 at 4:27 PM, Mark Tompsett <mtompset at hotmail.com> wrote:

>   Greetings,
>
> I was reading misc/cronjobs/advance_notices.pl and was trying to make
> sense of where $upcoming_digest is set. I think there must be some
> side-effect obscuring the code. I was wondering if a second pair of eyes
> might find it. I was trying to determine how $digest->{email} gets set for
> the from_address call to C4::Letters::EnqueueLetter.
>
> GPML,
> Mark Tompsett
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20141125/fc86e91c/attachment.html>