[Koha-devel] New coding guidelines on adding a syspref (INSERTIGNORE)

[Kyle Hall]

Actually, I think your idea of Koha::SystemPreference is the best way to
go, but I've no issue with other solutions in the mean time.

Kyle

http://www.kylehall.info
ByWater Solutions ( http://bywatersolutions.com )
Meadville Public Library ( http://www.meadvillelibrary.org )
Crawford County Federated Library System ( http://www.ccfls.org )
Mill Run Technology Solutions ( http://millruntech.com )

On Tue, Apr 7, 2015 at 1:57 PM, Mark Tompsett <mtompset at hotmail.com> wrote:

> Greetings,
>
> Kyle Hall wrote:
>
>> We could move to using DBIC's find_or_create method as an
>> alternative:
>> http://search.cpan.org/~ribasushi/DBIx-Class-0.082820/
>> lib/DBIx/Class/ResultSet.pm#find_or_create
>>
>> I know I've submitted at least one patch that uses that instead of the
>> classic INSERT statement.
>>
>
> Bug number? I’d like to see.
>
> Galen does have a point that it is grep-able for future fixing, which is
> why I didn’t object so heavily, but perhaps something nicer if easy enough
> to suggest would be good too.
>
>
> Chris Nighswonger wrote:
>
>> I would think that this is a quick-and-easy, have-it-today fix,
>> with the ultimate goal to be DB agnostic.
>>
>
> Does this mean someone else is going to work on it? I was thinking perhaps
> we need a Koha::SystemPreferences put together. This would also help us
> step towards cleaning up the mess that is C4::Context.
>
> GPML,
> Mark Tompsett
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20150407/e8e7cfc2/attachment-0001.html>