[Koha-devel] QA script - New check for spelling

Jonathan Druart jonathan.druart at biblibre.com
Wed Jul 8 15:33:40 CEST 2015


2015-06-25 13:53 GMT+01:00 Marcel de Rooy <M.de.Rooy at rijksmuseum.nl>:
>> Maybe the script should not process this check if codespell is not
>> installed. Patch welcomed ;-)
>
> Sorry, but I would rather prefer that you wrote that patch ;)

Done. Now the script warn instead of die and mark the test "spelling"
as skipped.

>> It's in test for the moment, we will see if the number of false positive
>> is high or not. Why do you worry about them?
>
> We should spend our QA time on the code not the spelling of comments.

That's why it's good to make a script do the job :)


More information about the Koha-devel mailing list