[Koha-devel] Koha::RecordProcessor question

Tomas Cohen Arazi tomascohen at gmail.com
Fri Jul 24 23:27:10 CEST 2015


When I first read it I felt something needed re-organization. But in the
end I understood it was almost as we wanted.
What I changed was this:
https://github.com/tomascohen/koha/commit/8e7ec43bc0cfda24ef264c7144f9fc60a8d807a4

And if you notice, $param already contains the initialization options on
his 'options' attribute.

Kind regards

2015-07-24 16:40 GMT-03:00 Mark Tompsett <mtompset at hotmail.com>:

>   Greetings,
>
> I am beginning my work on bug 11592 the filter version. I was curious if
> this patch makes sense:
>
> diff --git a/Koha/RecordProcessor.pm b/Koha/RecordProcessor.pm
> index 9bb1fc2..a345156 100644
> --- a/Koha/RecordProcessor.pm
> +++ b/Koha/RecordProcessor.pm
> @@ -103,7 +103,7 @@ sub new {
>          my $filter_module = $filter =~ m/:/ ? $filter :
> "Koha::Filter::${schema}::${filter}";
>          if (can_load( modules => { $filter_module => undef } )) {
>              my $object = $filter_module->new();
> -            $filter_module->initialize($param);
> +            $object->initialize($param);
>              push @filters, $object;
>          }
>      }
>
> Because otherwise, how can I properly set some parameters?
>
> GPML,
> Mark Tompsett
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>



-- 
Tomás Cohen Arazi
Prosecretaría de Informática
Universidad Nacional de Córdoba
✆ +54 351 5353750 ext 13168
GPG: B76C 6E7C 2D80 551A C765  E225 0A27 2EA1 B2F3 C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20150724/e333a098/attachment.html>


More information about the Koha-devel mailing list