[Koha-devel] getFrameworkLanguages

[Mark Tompsett]

Greetings,

Indranil Das Gupta found this painful to see typo in getFrameworkLanguages: 
'native_descrition'=>$language_set->{language_native_description}.
I told him, tweaking C4/Languages requires writing a test (good rule of 
thumb). So, I wake up, and discover no tests were yet written, and I was 
itching for a sign off. So, I attempt and discover the hole is deeper than 
initially thought. In fact, Indranil Das Gupta pointed out to me that it 
doesn't seem to be used anywhere.

mtompset at debian:~/kohaclone$ git grep getFrameworkLanguages
C4/Languages.pm:        memoize_memcached('getFrameworkLanguages' , 
memcached => C4::Context->memcached);

Part of an export --
C4/Languages.pm:        &getFrameworkLanguages

More exporting --
C4/Languages.pm:    @EXPORT_OK = qw(getFrameworkLanguages 
getTranslatedLanguages getAllLanguages getLanguages get_bidi 
regex_lang_subtags language_get_description accept_language getlanguage);

POD stuff --
C4/Languages.pm:=head2 getFrameworkLanguages

POD stuff example --
C4/Languages.pm: my $languages = getFrameworkLanguages();

Actual function head --
C4/Languages.pm:sub getFrameworkLanguages {


As you can tell I didn't comment on one piece: that memoize_memcached line. 
Is there another thing to trace to figure out if it is used in the memoize 
logic somewhere, or is it safe to remove this function? Feedback 
appreciated.

What bug 14284 becomes is dependent on feedback.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284

GPML,
Mark Tompsett