[Koha-devel] Add rule for no subroutines in PL scripts

Frédéric Demians frederic at tamil.fr
Fri Oct 2 08:59:19 CEST 2015


> Another scary one is opac/oai.pl, although that's actually created packages
> in the pl script which I think is actually worse in a way.

Even if I am on Philippe Blouin side on this discusion (overengineering has
its drawbacks), concerning Koha OAI server, it has been done in one unique .pl
file because there wasn't any object model or rules in the Koha project when
it has been coded. But it's OO (with something like Moose, it would be even
cleaner...) It's just a matter of modularization: putting each class in a
separate file in a Koha::OAI namespace.

I've created a bug for that:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939


More information about the Koha-devel mailing list