[Koha-devel] Question about Schema

[David Cook]

Olli:

While I can't speak for Owen, I think he might have been taking issue with
your language. Even if he wasn't, I do. 

I don't think it's helpful or in the team spirit to say that someone else's
idea "degrades my dignity as a programmer" or "Fix the problems, don't
exaggerate them". More importantly, I think it's unacceptable to say "This
is so retarded I can't believe this is happening". If that were said at a
Koha event, I think it would violate the Community Code of Conduct
(http://koha-community.org/about/policy/code-of-conduct/). While "retarded"
was common in colloquial English, especially American English, in the '90s,
it's not really acceptable anymore. Feel free research ableism for
explanations why.

That all said, I agree with what you're saying technically. While the
DBIx::Class::Schema::Loader had a function at the start, I don't think we
should be relying on it anymore. Feel free to look at
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5837 and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11390 and
http://wiki.koha-community.org/wiki/DB_schema_bugs#Koha_DBIx::Class_Problems
for more information on moving forward using DBIx::Class for deploying the
schema. I'm no longer working on these issues, as I have other more pressing
concerns, but I'm in total agreement that we should be managing the database
using DBIx::Class rather than the hybrid model we're currently using. Feel
free to pick up where I left off, or just make the manual modifications,
which you've mentioned, or advocate for the manual modifications without
disparaging other developers.

I know sometimes I get worked up over what I perceive to be foolishness or
insanity. I think we've all lost our composure at one time or another on
IRC, or Bugzilla, or the listserv. But I don't think it's helpful to vent
that frustration at others. I think what Owen was indicating with his
message was that it is helpful to outline why an idea is bad, but it's not
helpful to attach additional value judgements to that idea or the people
behind it. That has the potential to discourage developers (both new and
established), cause tensions within the team which hinders cooperation, and
generally isn't a very nice thing to do, which is important since I think
Koha is a nice place to be overall.

In any case, I don't mean this as an attack. I agree with what you're saying
technically, even if I don't agree with the way it was said. 

David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St, Ultimo, NSW 2007

> -----Original Message-----
> From: koha-devel-bounces at lists.koha-community.org [mailto:koha-devel-
> bounces at lists.koha-community.org] On Behalf Of Kivilahti Olli-Antti
> Sent: Tuesday, 8 September 2015 11:02 PM
> To: koha-devel at lists.koha-community.org
> Subject: Re: [Koha-devel] Question about Schema
> 
> I did provide a improvement suggestion,
> 
> > Eg. fix the silly join-relations itemnumber, biblionumber,
biblioitemnumber.
> > Those are easily overridden in the manual modifications section at the
> > bottom of the Koha/Schema/Result/*.pm-files.
> 
> 
> but here is a link to the DBIx::Class manual reagrding join mapping:
> 
> https://metacpan.org/pod/distribution/DBIx-
> Class/lib/DBIx/Class/Manual/Joining.pod
> 
> Here is a code example from Koha/Schema/Result/Serial.pm
> 
> # Created by DBIx::Class::Schema::Loader v0.07039 @ 2015-08-18 18:03:03 #
> DO NOT MODIFY THIS OR ANYTHING ABOVE!
> md5sum:Q42+PuyJqQu7t1AuVaVdig
> 
> __PACKAGE__->belongs_to(
>    "subscription",
>    "Koha::Schema::Result::Subscription",
>    { "foreign.subscriptionid" => "self.subscriptionid" },
>    { cascade_copy => 0, cascade_delete => 0 }, );
> 
> Olli-Antti Kivilahti
> Järjestelmäkeittäjä
> vaarakirjastot.fi
> +358 50 449 7763
> --Powered by Kubuntu Linux!
> 
> On 08.09.2015 15:18, Owen Leonard wrote:
> >> Fix the problems, don't exaggerate them!
> > Can you please make constructive suggestions without resorting to
> > childish insults?
> >
> > Thanks,
> >
> >    -- Owen
> >
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/ git : http://git.koha-
> community.org/ bugs : http://bugs.koha-community.org/