[Koha-devel] Koha-devel Digest, Vol 129, Issue 18

Tue Aug 16 13:00:01 CEST 2016

________________________________________
Fra: koha-devel-bounces at lists.koha-community.org <koha-devel-bounces at lists.koha-community.org> på vegne av koha-devel-request at lists.koha-community.org <koha-devel-request at lists.koha-community.org>
Sendt: 16. august 2016 12:00
Til: koha-devel at lists.koha-community.org
Emne: Koha-devel Digest, Vol 129, Issue 18

Send Koha-devel mailing list submissions to
        koha-devel at lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
        http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
or, via email, send a message with subject or body 'help' to
        koha-devel-request at lists.koha-community.org

You can reach the person managing the list at
        koha-devel-owner at lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-devel digest..."

Today's Topics:

   1. Re: What's on in Koha devel #3 (RESTful API) (Tomas Cohen Arazi)
   2. Re: What's on in Koha devel #3 (RESTful API) (Katrin Fischer)

----------------------------------------------------------------------

Message: 1
Date: Mon, 15 Aug 2016 12:54:06 +0000
From: Tomas Cohen Arazi <tomascohen at gmail.com>
To: Marcel de Rooy <M.de.Rooy at rijksmuseum.nl>,
        "koha-devel at lists.koha-community.org"
        <koha-devel at lists.koha-community.org>
Subject: Re: [Koha-devel] What's on in Koha devel #3 (RESTful API)
Message-ID:
        <CABZfb=WXTfeiMjO7zjccDTjSK7N=-E-MnQC3SPKNvR0VtZUttw at mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

El lun., 15 ago. 2016 a las 4:28, Marcel de Rooy (<M.de.Rooy at rijksmuseum.nl>)
escribi?:

> > = RESTful API =
> > I also would like to know who is willing to maintain this code? For
> instance on bug 16330 (REST API: add routes to add, update and delete
> > patrons)  the delete route is calling
> >    # check if loans, reservations, debarrment, etc. before deletion!
> >    my $res = $patron->delete
> > So no check is done from the API.
> > But if bug 16907 (Move DelMember and HandleDelBorrower to
> > Koha::Patron) is pushed, $patron->delete will take care of the holds,
> etc. My question is simple: are we expecting from devs, signoffers and >
> QAers to update and maintain these routes?
> > Or a dedicated person will update them before each release?
>
> Should our scripts go via REST some day and should all business logic
> remain in Objects? Etc. etc.
>

Exactly! What Jonathan noticed, is that no one realized there was a bug on
the REST api, this should be reported, and fixed. The more we use the API
the more bugs we will find, and the more we will enhance it.

I think Marseille will be a good place to work on this.

Regards

--
Tom?s Cohen Arazi
Theke Solutions (https://theke.io <http://theke.io/>)
? +54 9351 3513384
GPG: B2F3C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20160815/37898276/attachment-0001.html>

------------------------------

Message: 2
Date: Mon, 15 Aug 2016 23:01:23 +0200
From: Katrin Fischer <Katrin.Fischer.83 at web.de>
To: koha-devel at lists.koha-community.org
Subject: Re: [Koha-devel] What's on in Koha devel #3 (RESTful API)
Message-ID: <48032621-172b-4c44-6bce-e57f2e82c768 at web.de>
Content-Type: text/plain; charset=windows-1252

Am 15.08.2016 um 14:54 schrieb Tomas Cohen Arazi:
>
>
> El lun., 15 ago. 2016 a las 4:28, Marcel de Rooy
> (<M.de.Rooy at rijksmuseum.nl <mailto:M.de.Rooy at rijksmuseum.nl>>) escribi?:
>
>     > = RESTful API =
>     > I also would like to know who is willing to maintain this code?
>     For instance on bug 16330 (REST API: add routes to add, update and
>     delete
>     > patrons)  the delete route is calling
>     >    # check if loans, reservations, debarrment, etc. before deletion!
>     >    my $res = $patron->delete
>     > So no check is done from the API.
>     > But if bug 16907 (Move DelMember and HandleDelBorrower to
>     > Koha::Patron) is pushed, $patron->delete will take care of the
>     holds, etc. My question is simple: are we expecting from devs,
>     signoffers and > QAers to update and maintain these routes?
>     > Or a dedicated person will update them before each release?
>
>     Should our scripts go via REST some day and should all business
>     logic remain in Objects? Etc. etc.
>
>
> Exactly! What Jonathan noticed, is that no one realized there was a bug
> on the REST api, this should be reported, and fixed. The more we use the
> API the more bugs we will find, and the more we will enhance it.
>
> I think Marseille will be a good place to work on this.
>
> Regards

> Maybe Marseille will also be a good place for a 'beginners tutorial'?
> I'd like to learn more about the RESTful API and how to use/test it in
> order to help with improving it :)

> Katrin

Great with some attention on the RESTful API!
My initial reaction on reading this is that the primary resposibility should be on the
community and developers that push new code need to run all tests. Test coverage
and a more automatic Signoff/QA would save everyone some headaches.

The REST api is something we make heavy use of for any non-staff operation, and we
develop it mainly as an abstraction on existing Koha modules or, if existing, preferrably
Koha Objects. So much great work has been done recently on Koha Objects and 
refactoring Koha modules that expanding the API is mere joy. The API should, as
Jonathan's keen eye spotted, have as little business logic as possible. CRUD operations
are best if they simply use Koha objects.

Hope to be able to attend Marseille so we can talk more and agree on rules on the API!

Benjamin
Oslo Public Library

------------------------------

_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

End of Koha-devel Digest, Vol 129, Issue 18
*******************************************