[Koha-devel] Proposal - Deal with modules versioning ($VERSION)

[Jonathan Druart]

Well, they all can be removed with 2 sed basically.
Ok let's keep them and remove them during the next 10 years :)

2016-03-02 15:54 GMT+00:00 Marcel de Rooy <M.de.Rooy at rijksmuseum.nl>:
> I would prefer to leave them as-is and remove them when you are working on a module.
> Spending much more time on it decreases the time we could spend on more important issues in the code.
>
> Marcel
>
> ________________________________________
> Van: koha-devel-bounces at lists.koha-community.org [koha-devel-bounces at lists.koha-community.org] namens Galen Charlton [gmc at esilibrary.com]
> Verzonden: woensdag 2 maart 2016 16:46
> Aan: Jonathan Druart
> CC: koha-devel at lists.koha-community.org
> Onderwerp: Re: [Koha-devel] Proposal - Deal with modules versioning ($VERSION)
>
> Hi,
>
> On Wed, Mar 2, 2016 at 9:56 AM, Jonathan Druart
> <jonathan.druart at bugs.koha-community.org> wrote:
>> What are your thoughts? Are you more a, b, c, d or ... e?
>
> I'm in favor of option a (remove $VERSION from internal modules) or
> option e (drop PERL12 outright, but don't necessarily bother to remove
> $VERSION from the existing modules).  I take this position on the
> following basis:
>
> - we don't explicitly promise that C4:: and Koha:: provide a _public_ API
> - no, really, we don't; if we did, we would have been taking much more
> care about keeping function and method signatures stable the past
> decade
> - any third-party code that nonetheless relies on Perl modules in C4::
> and Koha:: should just check $Koha::VERSION
> - if we want to provide a public API via a set of Perl modules, we're
> of course free to do so, but should then keep questions of API
> versioning segregated to a special namespace
> - in light of all of the above considerations, any of the other
> options requires effort that doesn't solve a particular problem
>
> Regards,
>
> Galen
> --
> Galen Charlton
> Infrastructure and Added Services Manager
> Equinox Software, Inc. / The Open Source Experts
> email:  gmc at esilibrary.com
> direct: +1 770-709-5581
> cell:   +1 404-984-4366
> skype:  gmcharlt
> web:    http://www.esilibrary.com/
> Supporting Koha and Evergreen: http://koha-community.org &
> http://evergreen-ils.org
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/