[Koha-devel] Clarification on build_browser_and_cloud.pl

Tue Jan 23 14:26:10 CET 2018

Thanks, that helped.

On Jan 23, 2018 04:55, "Paul Poulain" <paul.poulain at biblibre.com> wrote:

> Hi Barton,
>
> Look at the file history : http://git.koha-community.org/
> gitweb/?p=koha.git;a=history;f=misc/cronjobs/build_browser_and_cloud.pl;h=
> d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD
>
> It's a VERY OLD script, that has never been updated. That's probably why
> it's so ugly. I think it's worth a rewrite.
>
> And about the *use MARC::File::USMARC*, we use it in UNIMARC as well,
> because, in fact, the package should be called MARC::File::iso2709, and not
> USMARC. It applies to any MARC flavour, and is only related to the file
> format, not the file content.
>
> HTH
>
> Le 17/01/2018 à 19:46, Barton Chittenden a écrit :
>
> The documentation for
>
> misc/cronjobs/build_browser_and_cloud.pl
>
> States
>
>
>> *Important *
>
>
>
>> This preference and cron job should only be used on French systems.
>
>
> (see https://koha-community.org/manual/18.05/en/html/16_cron_
> jobs.html?highlight=cronjobs#authorities-browser)
>
> The associated OpacBrowser syspref says:
>
> Important
>>
>
>
>> This preference only applies to installations using UNIMARC at this time.
>
>
> ... but the script itself seems to use MARC::File::USMARC exclusively:
>
> 13
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l13>
> use C4::Koha;
> 14
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l14>
> use C4::Context;
> 15
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l15>
> use C4::Biblio;
> 16
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l16>
> use Date::Calc;
> 17
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l17>
> use Time::HiRes qw(gettimeofday);
> 18
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l18>
> use ZOOM;
> 19
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l19>
> *use MARC::File::USMARC;*
> 20
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l20>
> use Getopt::Long;
> 21
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l21>
> use C4::Log;
> (see http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=
> misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de
> 8132cac5f1;hb=HEAD)
> The subroutine dewey_french obviously isn't translatable (I've filed bug
> Bug 20007 - build_browser_and_cloud.pl contains hard-coded text in French
> for thatt
> 173
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l173>
> sub dewey_french {
> 174
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l174>
> return {
> 175
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l175>
>     "0" => "Généralités (Ouvrages généraux (encyclopédies, bibliographies,
>  etc.) et informatique)",
> 176
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l176>
>     "00" => "Savoir et communication",
> 177
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l177>
>     "001.42" => "Collecte, agencement, analyse des données",
> 178
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l178>
>     "003" => "Systémique, systèmes",
> 179
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l179>
>     "003.1" => "Identification de système",
> 180
> <http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/build_browser_and_cloud.pl;h=d5e0d1a8f5ab96ec10a38ffe2070de8132cac5f1;hb=HEAD#l180>
>     "003.2" => "Prévisions. Futurologie",
> ...
> The French text seems to be at cross purposes with MARC::File::USMARC,
> because French catalogers would probably use UNIMARC; at the same time the
> use of USMARC contradicts the documentation.
> Ideally, I'd to get the I18N *and* the marc flavor fixed so that everyone
> can use this, and I'd like to file bug reports that accurately show what
> needs to be fixed. Any clarification is welcome.
> Thanks,
> --Barton
>
>
> _______________________________________________
> Koha-devel mailing listKoha-devel at lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
>
> --
> Paul Poulain, Associé-gérant / co-owner
> BibLibre, Services en logiciels libres pour les bibliothèques
> BibLibre, Open Source software and services for libraries
>
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20180123/280cdff8/attachment.html>