[Koha-devel] Good commit messages

[David Cook]

Hi all,

 

So Jonathan linked me to this the other day:
<https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2
>
https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2


 

I don't understand one of the "Bad commit messages" though. I thought
everyone always starts a good commit message with "Bug 12345 - ". Am I
missing something there?

 

Personally, I don't think you can always explain what the *bug* is in 50
characters, although I'm super on board for the commit message containing
what the *fix* does. 

 

I'm writing a commit message for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 and
struggling a bit as the bug is actually kind of convoluted. 

 

David Cook

Systems Librarian

Prosentient Systems

72/330 Wattle St

Ultimo, NSW 2007

Australia

 

Office: 02 9212 0899

Direct: 02 8005 0595

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20180730/6c3ad1c7/attachment.html>