[Koha-devel] Autorenewals renewing an item then sending a renew failure email the next day

[David Cook]

Hi Holger,

 

Nope, I don't want to change autorenewal being stopped when a hold is
placed. 

 

Yes, I would like to get the "too soon" error message instead of the "on
reserve" error message if both apply. 

 

Here's my reasoning:

 

1)      Book A is due on September 1 2018

2)      Book A is autorenewed until September 15 2018

3)      Person B places a hold on Book A

4)      Koha shouldn't do anything until the threshold for autorenewal (e.g.
September 15 2018), because the item's status is on loan. 

 

In other words, autorenewal should be treated the exact same as manual
renewal. If Person A manually renews Book A on September 1 2018 making a new
due date of September 15 2018 and Person B puts a hold on Book A on
September 2 2018, nothing would happen until Person A tried to manually
renew Book A on September 15 2018. At that point, Koha would say they can't
renew because of a hold. 

 

Currently, people are getting emails telling them they can't autorenew their
book on September 2 2018 because someone has placed a hold, but this is a
misleading email, because on September 1 2018 their book was autorenewed
until September 15 2018. The email is illogical. 

 

It shouldn't be trying to autorenew because it's "too soon". Only when it's
otherwise renewable should we be checking for holds. 

 

David Cook

Systems Librarian

Prosentient Systems

72/330 Wattle St

Ultimo, NSW 2007

Australia

 

Office: 02 9212 0899

Direct: 02 8005 0595

 

From: Holger Meissner [mailto:Holger.Meissner at hs-gesundheit.de] 
Sent: Wednesday, 28 November 2018 4:37 AM
To: David Cook <dcook at prosentient.com.au>;
koha-devel at lists.koha-community.org
Subject: AW: [Koha-devel] Autorenewals renewing an item then sending a renew
failure email the next day

 

Hi David,

 

could you expand on this? It's intentional that autorenewal stops when a
hold is placed. Do you want to change this behaviour?

 

Or would you like to get the "too soon" error message instead of the "on
reserve" error message if both apply? Or a new message informing you about
both?

 

What's the benefit of checking whether it's too early first?

 

Regards,

Holger

 

 

Von: koha-devel-bounces at lists.koha-community.org
<koha-devel-bounces at lists.koha-community.org> Im Auftrag von David Cook
Gesendet: Freitag, 16. November 2018 05:58
An: koha-devel at lists.koha-community.org
Betreff: [Koha-devel] Autorenewals renewing an item then sending a renew
failure email the next day

 

Hi all,

 

I've found a case where autorenewals will renew an item one day (e.g.
Monday) and the next day (e.g. Tuesday) it will say that a hold has been
found and that it can't renew the item. (Someone must've put a hold on the
item between the two cronjob runs.)

 

It seems to me this is a bug in how C4::Circulation::CanBookBeRenewed is
written. 

 

The first check it makes is for holds and if it finds a hold it returns an
error. 

 

However, if you're using autorenewals, you should first check to see if it's
too early to even bother renewing. 

 

I'm just emailing here to see if anyone else is having this issue, or if
anyone knows if there is already a Bugzilla issue open for it. It seems like
there are a lot of autorenewal Bugzilla issues but I couldn't find anything.
Figure asking first lessens the need for someone to mark one as a duplicate
later.

 

David Cook

Systems Librarian

Prosentient Systems

72/330 Wattle St

Ultimo, NSW 2007

Australia

 

Office: 02 9212 0899

Direct: 02 8005 0595

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20181128/b520ca79/attachment-0001.html>