[Koha-devel] Master broken by 20521 (sql modes)

[Katrin Fischer]

I've tested the Bywater sandboxes - can confirm some of the basics 
features are broken.

On 18.10.18 10:09, Renvoize, Martin wrote:
> The Bywater one's may be stuffed by this (assuming they all set 
> dev_install inside their koha-testing-docker based setup).. but the 
> ptfs-e one's don't yet set dev_install so they should be fine I think.
>
>
> *Martin Renvoize*
>
> 	
>
> <https://www.ptfs-europe.com>
>
> Development Team Manager
>
> *Phone:* +44 (0) 1483 378728
>
> 	
>
> *Mobile:* +44 (0) 7725 985 636
>
> *Email:* martin.renvoize at ptfs-europe.com 
> <mailto:martin.renvoize at ptfs-europe.com>
>
> 	
>
> *Fax:* +44 (0) 800 756 6384
>
>
> 	
>
> www.ptfs-europe.com <https://www.ptfs-europe.com>
>
> Registered in the United Kingdom No. 06416372   VAT Reg No. 925 7211 30
>
>
> The information contained in this email message may be privileged, 
> confidential and protected from disclosure. If you are not the 
> intended recipient, any dissemination, distribution or copying is 
> strictly prohibited. If you think that you have received this email 
> message in error, please email the sender at info at ptfs-europe.com 
> <mailto:info at ptfs-europe.com>
>
>
>
>
> On Thu, 18 Oct 2018 at 06:11, Katrin Fischer <katrin.fischer.83 at web.de 
> <mailto:katrin.fischer.83 at web.de>> wrote:
>
>     Hi all,
>
>     I guess this effects the sandboxes as well? This afternoon and
>     tomorrow morning is a hackday in Sweden and I was hoping for some
>     sign-offs!
>
>     Katrin
>
>     On 18.10.18 01:38, Jonathan Druart wrote:
>>     Hi devs,
>>
>>     I quick email to let you know that master and tests are
>>     (completely) broken because of the recent push of bug 20521.
>>     It turned on the "problematic SQL modes" for dev installs (I let
>>     you search for that in your emails if it did not ring you the bell).
>>
>>     I am working on fixing the different test failures (the ones we
>>     introduced since bug 20144, 6 months ago). They are all
>>     regressions and there are a lot!
>>
>>     This shows us that we absolutely need this change, to alert us
>>     when we are doing something wrong, that's why I would not
>>     recommend a revert.
>>
>>     If you are stuck in something urgent/important you can revert
>>       commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f
>>       Bug 20521: Enable problematic SQL modes for dev installs
>>     Or easier, remove the dev_install flag in your koha-conf (but do
>>     not forget to switch it back in a few days!).
>>
>>     Cheers,
>>     Jonathan
>>
>>     _______________________________________________
>>     Koha-devel mailing list
>>     Koha-devel at lists.koha-community.org  <mailto:Koha-devel at lists.koha-community.org>
>>     http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>>     website :http://www.koha-community.org/
>>     git :http://git.koha-community.org/
>>     bugs :http://bugs.koha-community.org/
>     _______________________________________________
>     Koha-devel mailing list
>     Koha-devel at lists.koha-community.org
>     <mailto:Koha-devel at lists.koha-community.org>
>     http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>     website : http://www.koha-community.org/
>     git : http://git.koha-community.org/
>     bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20181018/b30caee3/attachment-0001.html>