[Koha-devel] The order of "use"

Jonathan Druart jonathan.druart at bugs.koha-community.org
Wed Oct 24 19:21:03 CEST 2018


See
  commit ce96080f3005be5a63c9f2cab8d4b6c81e9b5b27
  Bug 21133: Fix use statements order


On Wed, 24 Oct 2018 at 13:42 Mark Tompsett <mtompset at hotmail.com> wrote:

> Greetings,
>
> I was looking at bug 21641, and noticed the patch was explicitly stating
> C4::Accounts:: on the function in question. I vaguely recalled this sort
> of
> symptom shows itself in a knotted “use” mess.
>
> C4::Circulation –> C4::Members –> C4::Accounts
> C4::Circulation –> C4::Accounts
> C4::Circulation –> C4::Overdues –> C4::Accounts
>
> What is the best order to list these? C4::Accounts last?
> Is putting the C4::Accounts:: on the function in question still something
> we
> should do anyways?
>
> Feedback appreciated,
> Mark Tompsett
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20181024/48b2ed07/attachment-0001.html>


More information about the Koha-devel mailing list