[Koha-devel] DateTime->now usage

[Jonathan Druart]

Hi,

Yes, we must use dt_from_string.
Note that some occurrences could stay as it: when the time_zone is passed.

Cheers,
Jonathan

Le mar. 30 avr. 2019 à 12:59, Tomas Cohen Arazi <tomascohen at gmail.com> a écrit :
>
> Hi, on testnig bug 22453 [1] I noticed that we do the wrong thing in many places, actually:
>
> $ git grep 'DateTime\->new'
>
> Do you agree we should be using dt_from_string instead? The consequences are for those having the DB server and/or the plack server running on some timezone and having koha-conf.xml point to another one.
>
> [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
>
> --
> Tomás Cohen Arazi
> Theke Solutions (http://theke.io)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/