[Koha-devel] Autorenewals renewing an item then sending a renew failure email the next day

[David Cook]

Just letting folk know that I've refactored the logic for the autorenewals at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333. It's the exact same behaviour as before but it deduplicates some code by using an existing function and it just writes it in a way that is more readable/maintainable.

Locally, I've also duplicated a section of the code into automatic_renewals.pl (and wrapped it with a system preference) so that the first thing checked is the earliest renewal date and if it's in the future, then I skip CanBookBeRenewed all together (so as to avoid the issues with holds, max checkouts, etc causing confusing email notices to go out). After some local testing, I'll post a patch with that too, which hopefully will meet everyone's needs between the current behaviour and what I (and some others) consider the more logical behaviour. 

David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St
Ultimo, NSW 2007
Australia

Office: 02 9212 0899
Direct: 02 8005 0595


-----Original Message-----
From: koha-devel-bounces at lists.koha-community.org [mailto:koha-devel-bounces at lists.koha-community.org] On Behalf Of Holger Meissner
Sent: Tuesday, 11 December 2018 9:30 PM
To: koha-devel at lists.koha-community.org
Subject: Re: [Koha-devel] Autorenewals renewing an item then sending a renew failure email the next day

On Mon, Dec 10, 2018 at 06:02 PM McGowan, Janet <mailto:mailto:janet.mcgowan at ptfs-europe.com> wrote:
> Yes, using the PREDUE notice is a way around this, however it would 
> only work if No renewal before is set to 1.

I disagree. For example, we set "no renewal before" to 11 days and send PREDUE 10 days in advance. We locally prevent patrons from changing that setting. Nobody complained about it so far. A more elegant and more user-friendly solution would be a feature enforcing PREDUE <= no renewal before. Or maybe just a warning popup for spam producing values.

Regards,
Holger
_______________________________________________
Koha-devel mailing list
Koha-devel at lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/