[Koha-devel] Discussion of account types / labels

[Chris Cormack]

It's Fine Unreturned

Whatever they are changed to needs to be translatable.

Chris 

On 25 February 2019 11:50:17 PM NZDT, Victor Grousset <victor.grousset at biblibre.com> wrote:
>Hi,
>
>On 19-02-22 21:00, Barton Chittenden wrote:
>> The accounts system uses the following codes to show what kind of fee
>or 
>> credit has been issued:
> >
> > [...]
> >
>> The labels, such as 'Account management fee' and 'Overdue fine' are
>hard 
>> coded in various template toolkit files. This is problematic for a 
>> number of reasons:
>> 
>> 1) It's not obvious where these are defined -- most other constants
>in 
>> Koha are in authorized values. 
>> https://koha-community.org/manual/18.05/en/html/faq.html#fines-table
>is 
>> the only place where a koha user can find them all in one place.
>> 2) Because they're not in the database, they can't be used in reports
>
>> (at least without kludgy case statements).
>> 3) They're not available outside the web interface, so SIP2 and any
>API 
>> endpoints must show the raw codes.
>> 4) 'FU' is a common abbreviation for an obscenity in English, and
>this 
>> has a tendency to show in up in a lot of places where it really
>shouldn't.
>
>Thanks for bringing that up.
>Indeed, and the codes doesn't really speak for themselves so having
>very 
>minimal doc doesn't help
>I don't even know how FU relates it's description.
>Maybe it's the actual obscenity. To express discontent with the
>accruing 
>overdue 😱
>
>Joking aside, is there one obvious clean way that this would have been 
>done today?
>Authorized values?
>
>Would there be downsides of the clean alternative(s) compared to now?
>(hopefully it was like that because of "historical reasons")
>
>
>À++
>
>-- 
>Victor Grousset, dev support/maintenance
>BibLibre, Services en logiciels libres pour les bibliothèques
>BibLibre, Libre/Open Source software and services for libraries
>_______________________________________________
>Koha-devel mailing list
>Koha-devel at lists.koha-community.org
>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
>website : http://www.koha-community.org/
>git : http://git.koha-community.org/
>bugs : http://bugs.koha-community.org/

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20190226/5b3de32e/attachment.html>