[Koha-devel] A case against some uses of C4::Context->userenv

[Tomas Cohen Arazi]

Hi all, I've been looking at the 'Claims returned' work (awesome!) [1] and
I've noticed a pattern we should, in my opinion, start avoiding and
reverting.

It is quite common to find uses of C4::Context->userenv in the Koha::*
namespace, either as a plain requirement (if the borrowernumber is not set
we bail out) or just as a fallback. I think it is wrong to expect such
environment status in our logic. It complicates things in various ways. [2]

It is done this way because:
- We come from the CGI era, in which it made perfect sense
- Cookie auth is well established on the UI
- When migrating from C4:* into Koha:* it is easier to just keep the
current behavior and then evolve.

I propose we leave them out, and add as a parameter whatever we are
expecting to find in the userenv hashref. That way we could use this new
libs in the API (which is not cookie-only).

Looking forward to hear your opinions

[1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
[2] CLI scripts are using Koha::* libraries, and we then need to 'emulate'
that userenv or even add code to detect we don't have a userenv.

-- 
Tomás Cohen Arazi
Theke Solutions (http://theke.io)
✆ +54 9351 3513384
GPG: B2F3C15F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20190927/6a4fad50/attachment.html>