From paul.poulain at biblibre.com Mon Jan 6 14:02:12 2020 From: paul.poulain at biblibre.com (Paul Poulain) Date: Mon, 6 Jan 2020 14:02:12 +0100 Subject: [Koha-devel] Urungi for building dashboards on Koha database Message-ID: <4b727b21-6a10-1d28-f3af-c3e2d9d5ac23@biblibre.com> Hello koha-devel, First of all, happy new year ! This new year comes with a finalized version of Urungi and availability of some dashboards & layers for building your own dashboards & reports. I'm happy to share all our work with the Koha community, and would be even happier with some feedback, suggestions, and contributions ! Urungi Urungi can be downloaded here : https://github.com/biblibre/urungi/releases Some new features since v1: * export reports and dashboards in PDF or PNG * theme management. Urungi 2.1.0 is provided with 2 themes for theming your dashboards in a few clicks. More themes can be added easily, it's just a CSS * a reports or dashboard can now be made public, ie available through an URL, without any login * Minor improvements: o you can rename a field when building a report, to have a more meaningful legend o crossed reports are based on HTML table, more consistency with other reports Urungi-data Urungi is pretty an empty box without the proper layers and some dashboards for Koha. That's why we've created another repo, where we store & publish them. You can find them on a specific repository, available at : https://github.com/biblibre/urungi-data You'll find there what we made for french UNIMARC libraries. I'm looking for some volunteers who would like to translated them to English. It's pretty easy even if you don't speak french for the French>English translation, a little bit more tricky for the MARC21 specific things. If you want to work on that, just drop me an email, I'll give your some directions on how to do that. Note that someone is already working on a translation to Spanish Contributing How to contribute ? As usual you can submit issues on github if you face any problem or would like a feature to be added. Urungi is currently available only in English and French. If you want to translate (Urungi, not Koha layers/reports/dashboards), welcome https://github.com/biblibre/urungi/tree/master/language Demo platform our demo, based on our koha demo, is available at: https://intranet-demo.biblibre.com/urungi/ login bibliotheque password 9sDDn3o11T It contains layers, reports and dashboards that are available on urungi-data Feedback welcomed ! I would be more than happy to have feedback on Urungi, urungi-data, features, bugs, dashboards. Feel free to share any work you do. Note that in march we will replace the static page urungi.org by a brand new website (based on WordPress) -- Paul Poulain, Associé-gérant / co-owner BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Open Source software and services for libraries -------------- next part -------------- An HTML attachment was scrubbed... URL: From oleonard at myacpl.org Mon Jan 6 20:47:08 2020 From: oleonard at myacpl.org (Owen Leonard) Date: Mon, 6 Jan 2020 14:47:08 -0500 Subject: [Koha-devel] Question about correct hold availability checking in the OPAC Message-ID: Bug 19298, "allow_onshelf_holds is not calculated correctly in opac-shelves" added a check of circulation rules to control whether the "Place hold" button should appear on the OPAC list contents page. I'm trying to restart my work on Bug 13121, "Move search results "action" links ("Place hold," "Add tag," etc) into include file" and so I'm interested in having unified template logic. Does anyone know if there was a reason the change made in Bug 19298 wasn't made to the OPAC search results page? Thanks, -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org From jonathan.druart at bugs.koha-community.org Mon Jan 6 21:54:59 2020 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Mon, 6 Jan 2020 21:54:59 +0100 Subject: [Koha-devel] Question about correct hold availability checking in the OPAC In-Reply-To: References: Message-ID: Hi Owen, I am not sure we are ready for that, it could impact performance if several records have a lot of items. That should be confirmed, or unconfirmed (benchmark) to evaluate this impact. Cheers, Jonathan Le lun. 6 janv. 2020 à 20:47, Owen Leonard a écrit : > > Bug 19298, "allow_onshelf_holds is not calculated correctly in > opac-shelves" added a check of circulation rules to control whether > the "Place hold" button should appear on the OPAC list contents page. > > I'm trying to restart my work on Bug 13121, "Move search results > "action" links ("Place hold," "Add tag," etc) into include file" and > so I'm interested in having unified template logic. > > Does anyone know if there was a reason the change made in Bug 19298 > wasn't made to the OPAC search results page? > > Thanks, > > -- Owen > > -- > Web Developer > Athens County Public Libraries > (740) 737-6006 > https://www.myacpl.org > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ From oleonard at myacpl.org Tue Jan 7 01:58:27 2020 From: oleonard at myacpl.org (Owen Leonard) Date: Mon, 6 Jan 2020 19:58:27 -0500 Subject: [Koha-devel] Question about correct hold availability checking in the OPAC In-Reply-To: References: Message-ID: > > Does anyone know if there was a reason the change made in Bug 19298 > > wasn't made to the OPAC search results page? > > I am not sure we are ready for that, it could impact performance if > several records have a lot of items. I certainly understand this concern. I think it's important to also weigh the fact that with this feature only in place on some OPAC pages the user potentially has a confusing or conflicting idea of what they can put on hold. -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org From dcook at prosentient.com.au Thu Jan 9 07:56:05 2020 From: dcook at prosentient.com.au (dcook at prosentient.com.au) Date: Thu, 9 Jan 2020 17:56:05 +1100 Subject: [Koha-devel] "Get desktop application" link Message-ID: <0d0f01d5c6b9$dcebfbc0$96c3f340$@prosentient.com.au> Hi all, I'm just poking around on 19.11 and I notice the "Get desktop application" link on /cgi-bin/koha/circ/circulation-home.pl points to ByWater's Github. Is that an optimal link or should it be pointing to a Koha Community resource? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 484 bytes Desc: not available URL: From kyle.m.hall at gmail.com Thu Jan 9 18:10:57 2020 From: kyle.m.hall at gmail.com (Kyle Hall) Date: Thu, 9 Jan 2020 12:10:57 -0500 Subject: [Koha-devel] "Get desktop application" link In-Reply-To: <0d0f01d5c6b9$dcebfbc0$96c3f340$@prosentient.com.au> References: <0d0f01d5c6b9$dcebfbc0$96c3f340$@prosentient.com.au> Message-ID: David, that is the canonical source for the offline circ desktop app. There is no community source for it, but I wouldn't be opposed to that if I can be given full rights to such a repo for bug fixes, releases and such. Kyle --- http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) On Thu, Jan 9, 2020 at 1:56 AM wrote: > Hi all, > > > > I’m just poking around on 19.11 and I notice the “Get desktop application” > link on /cgi-bin/koha/circ/circulation-home.pl points to ByWater’s > Github. Is that an optimal link or should it be pointing to a Koha > Community resource? > > > > David Cook > > Systems Librarian > > Prosentient Systems > > 72/330 Wattle St > > Ultimo, NSW 2007 > > Australia > > > > Office: 02 9212 0899 > > Direct: 02 8005 0595 > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From marco.wahls at gmx.de Fri Jan 10 01:32:20 2020 From: marco.wahls at gmx.de (M.Wahls) Date: Fri, 10 Jan 2020 01:32:20 +0100 Subject: [Koha-devel] Build the easy way throws error Message-ID: hi folks, I'm new to: koha, this community and the debian-build process I'm familiar with: linux (archlinux), software development I'm struggling while building the koha package. And get the following errors (here are the last few lines the build-script throws): make[1]: Leaving directory '/tmp/buildd/koha-19.05.09+20200110003754.96ab4982'  fakeroot debian/rules binary dh binary --fail-missing --with bash-completion    dh_testroot -O--fail-missing    dh_prep -O--fail-missing    dh_installdirs -O--fail-missing /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 1: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: etc/koha/sites: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 2: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/cache/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 3: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/lib/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 4: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/log/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 5: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/lock/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 6: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/spool/koha: not found dh_installdirs: problem reading debian/koha-common.dirs: debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 127 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 E: Failed autobuilding of package I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build//1505 and its subdirectories Don't know if it's problematic but following the build output there are a lot fail-missings: dh_auto_build dh_auto_clean dh_auto_configure dh_auto_test dh_binary dh_build dh_clean dh_installdirs dh_prep dh_testdir dh_testroot dh_update_autotools_config changing the compatability-level of pbuilder wasn't helpful. My VirtualBox looks like this: 4GB Ram, variable filesystem size (max 32GB). Debian 8 (Jessie) is used (but Stretch has the exact same issues). Used the default installation from Debian, but XFCE as desktop environment. These packages where installed by myself: git, libmodern-perl-perl, pbuilder, dh-make, gnupg2, devscripts, dput, build-essential, module-assistant As root: m-a prepare; mount /usr/lib/virtualbox/additions/VBoxGuestAdditions.iso sh /media/cdrom/VBoxLinuxAdditions.run adduser marco vboxsfsu mounting host partition under /media/sf_Share as root: pbuilder create --distribution jessie ...and as root (like in the tutorial for building packages the easy way): pbuilder --login --save-after-login echo "deb http://debian.koha-community.org/koha stable main" > /etc/apt/sources.list.d/koha.list apt-get install wget gnupg2 wget -O- http://debian.koha-community.org/koha/gpg.asc | apt-key add - apt-get update exit checkout koha: cd /media/sf_Share (mounted host-partition) git clone git://git.koha-community.org/koha.git git checkout -b 19.05.x origin/19.05.x cd /media/sf_Share cp -rf koha koha-build cd /media/sf_Share/koha-build as root: /media/sf_Share/koha-build/debian/build-git-snapshot -v 19.05.09 -d Thats all i did. What am i doing wrong? Any ideas or more information needed? Best wishes Marco From philippe.blouin at inlibro.com Fri Jan 10 22:30:04 2020 From: philippe.blouin at inlibro.com (Philippe Blouin) Date: Fri, 10 Jan 2020 16:30:04 -0500 Subject: [Koha-devel] Out of sort memory, consider increasing server sort buffer size In-Reply-To: <2744e3d3-84f1-7f82-3bfd-822ecf437c5e@inlibro.com> References: <83af010e-9625-62a5-8fdf-0dd7f0d31cfc@inlibro.com> <2744e3d3-84f1-7f82-3bfd-822ecf437c5e@inlibro.com> Message-ID: <409d4a06-d2e1-e9ec-b03a-6cab410a3f4e@inlibro.com> A month later... Maryse found a (recommanded) solution for the aqspent.pl crashes: -    aqorders.biblionumber, aqorders.basketno, aqorders.ordernumber, -    quantity-quantityreceived AS tleft, -    budgetdate, entrydate, -    aqbasket.booksellerid, +    MAX(aqorders.biblionumber) AS biblionumber, MAX(aqorders.basketno) AS basketno, aqorders.ordernumber, +    MAX(quantity)-MAX(quantityreceived) AS tleft, +    MAX(budgetdate) AS budgetdate, MAX(entrydate) AS entrydate, +    MAX(aqbasket.booksellerid) AS booksellerid,      GROUP_CONCAT(DISTINCT itype SEPARATOR '|') as itypes, -    title, -    aqorders.invoiceid, -    aqinvoices.invoicenumber, -    quantityreceived, -    unitprice_tax_included, -    datereceived, -    aqbooksellers.name as vendorname +    MAX(title) AS title, +    MAX(aqorders.invoiceid) AS invoiceid, +    MAX(aqinvoices.invoicenumber) AS invoicenumber, +    MAX(quantityreceived) AS quantityreceived, +    MAX(unitprice_tax_included) AS unitprice_tax_included, +    MAX(datereceived) AS datereceived, +    MAX(aqbooksellers.name) as vendorname We'll hack that in all our distributions.  But I'd really like to have an official distributed solution to the problem.  To me, it's not that much uglier than the fix adding all the column to avoid the problem with ONLY_FULL_GROUP_BY. What's your take on it? Regards, Philippe Blouin, Directeur de la technologie Tél.  : (833) 465-4276, poste 230 philippe.blouin at inLibro.com inLibro | pour esprit libre | www.inLibro.com On 2019-12-13 11:25 a.m., Philippe Blouin wrote: > > minuscule: > > * 2000 biblio, 12000 items > * 8 aqbudgets, 200 invoices, 25 booksellers, 60 baskets, 240 orders. > > That makes little sense... > > Philippe Blouin, > Directeur de la technologie > > Tél.  : (833) 465-4276, poste 230 > philippe.blouin at inLibro.com > > inLibro | pour esprit libre | www.inLibro.com > On 2019-12-13 9:49 a.m., Jonathan Druart wrote: >> How big is your tables? >> As you can see SQL query is really ugly, and can be good to split it anyway... >> >> Le ven. 13 déc. 2019 à 15:26, Philippe Blouin >> a écrit : >>> Thanks, >>> >>> Ok, I've never seen the "$field is not in group by" error. Interesting. >>> >>> I've followed the bread crumbs: 21622 -> 20182 -> 21723 -> 22260... read it all. It's "damned if you do, damned if you don't". >>> >>> ONLY_FULL_GROUP_BY mode is the SQL Standard, I don't think it would be wise to stray from that. (I can do it locally, but I don't think Koha should, philosophically) >>> >>> But my client can't click on spent.pl. And no memory setting seems to fix it. So what's my solution? Could the query be reworked in two steps? This is not a screen where 0.2s will make a difference in the user experience. >>> >>> Suggestions welcomed. >>> >>> Philippe Blouin, >>> Directeur de la technologie >>> >>> Tél. : (833) 465-4276, poste 230 >>> philippe.blouin at inLibro.com >>> >>> inLibro | pour esprit libre |www.inLibro.com >>> On 2019-12-13 4:33 a.m., Jonathan Druart wrote: >>> >>> Hi Philippe, >>> >>> See bug 21622. >>> It is necessary to not explode with "$field is not in group by" (when >>> sql_mode has ONLY_FULL_GROUP_BY) >>> However we may need to discuss the need of this flag if it brings us >>> performance issues. >>> >>> Cheers, >>> Jonathan >>> >>> Le jeu. 12 déc. 2019 à 23:23, Philippe Blouin >>> a écrit : >>> >>> Good morning Koha, >>> >>> Newbie question: why do we have 16 fields in GROUP BYs ? Are they really all necessary to eliminate duplicate lines in budgets? Genuine question. >>> >>> When in acqui-home.pl, clicking certain entries linking to spent.pl just crashes with the error listed in the mail's object: Out of memory. Although I hate that solution, I went with it, increased sort_buffer_size 64x fold (I'm a generous guy). Still not enough. >>> >>> Removing most lines in GROUP BY of spent.pl solves it all, of course. >>> >>> -- >>> Philippe Blouin, >>> Directeur de la technologie >>> >>> Tél. : (833) 465-4276, poste 230 >>> philippe.blouin at inLibro.com >>> >>> inLibro | pour esprit libre |www.inLibro.com >>> _______________________________________________ >>> Koha-devel mailing list >>> Koha-devel at lists.koha-community.org >>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>> website :http://www.koha-community.org/ >>> git :http://git.koha-community.org/ >>> bugs :http://bugs.koha-community.org/ > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From marco.wahls at gmx.de Sun Jan 12 17:03:19 2020 From: marco.wahls at gmx.de (M.Wahls) Date: Sun, 12 Jan 2020 17:03:19 +0100 Subject: [Koha-devel] Build the easy way throws error In-Reply-To: References: Message-ID: <27ae4846-8305-45f5-1844-6660d88b68fe@gmx.de> Hehe, silly me! i used a mounted directory from the host system within the virtualbox guest. May be some write permission issues occured. The mounted directory lays on an ext4 partition. Using ~/.debian as directory (as described in the tutorial) was the solution. Now i have problems with some tests. connection to memcached server failed. 'would sugest some package is missing. Stay tuned... best wishes Marco From tomascohen at gmail.com Sun Jan 12 19:39:40 2020 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Sun, 12 Jan 2020 15:39:40 -0300 Subject: [Koha-devel] Build the easy way throws error In-Reply-To: <27ae4846-8305-45f5-1844-6660d88b68fe@gmx.de> References: <27ae4846-8305-45f5-1844-6660d88b68fe@gmx.de> Message-ID: I recommend you try the koha-dpkg docker image. El dom., 12 de enero de 2020 13:08, M.Wahls escribió: > Hehe, silly me! > i used a mounted directory from the host system within the virtualbox > guest. May be some write permission issues occured. The mounted > directory lays on an ext4 partition. > > Using ~/.debian as directory (as described in the tutorial) was the > solution. > > Now i have problems with some tests. > connection to memcached server failed. > > 'would sugest some package is missing. Stay tuned... > > best wishes > Marco > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Mon Jan 13 07:49:05 2020 From: dcook at prosentient.com.au (dcook at prosentient.com.au) Date: Mon, 13 Jan 2020 17:49:05 +1100 Subject: [Koha-devel] Build the easy way throws error In-Reply-To: References: <27ae4846-8305-45f5-1844-6660d88b68fe@gmx.de> Message-ID: <0e6301d5c9dd$8c745fd0$a55d1f70$@prosentient.com.au> Probably a good idea to use koha-dpkg, as I think that’s fairly widely used now. However, if you’re feeling adventurous, you can try https://gitlab.com/minusdavid/koha-deb-builder-docker. It probably won’t work the first time, as I’m having issues where some dependencies (libcache-perl libconvert-basen-perl libcrypt-gcrypt-perl liblocale-maketext-lexicon-perl) aren’t being automagically detected. But if you install those manually in the Docker container and then run the build script, it should work a treat. (One of these days I’ll investigate that dependency issue. They’re missing from the Debian control file but in theory koha-dpkg doesn’t have this problem.) Personally, I use koha-deb-builder-docker (which I wrote), because I use Windows as my host, and I recall having issues running older versions of koha-dpkg on it. I haven’t had much luck mounting Windows based Git repositories into Docker containers. In this case, you can do your dev work anywhere, export a Koha tarball, and then provide that to koha-deb-builder-docker. Anyway, I’m use koha-dpkg will meet your needs. (Also, I imagine warnings about “connection to Memcached server failed” will just be warnings and not errors. I think they can safely be ignored, since you shouldn’t need a real Memcached server running when doing a build/running unit tests…) David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: Koha-devel On Behalf Of Tomas Cohen Arazi Sent: Monday, 13 January 2020 5:40 AM To: M.Wahls Cc: koha-devel Subject: Re: [Koha-devel] Build the easy way throws error I recommend you try the koha-dpkg docker image. El dom., 12 de enero de 2020 13:08, M.Wahls > escribió: Hehe, silly me! i used a mounted directory from the host system within the virtualbox guest. May be some write permission issues occured. The mounted directory lays on an ext4 partition. Using ~/.debian as directory (as described in the tutorial) was the solution. Now i have problems with some tests. connection to memcached server failed. 'would sugest some package is missing. Stay tuned... best wishes Marco _______________________________________________ Koha-devel mailing list Koha-devel at lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 484 bytes Desc: not available URL: From dcook at prosentient.com.au Mon Jan 13 08:50:22 2020 From: dcook at prosentient.com.au (dcook at prosentient.com.au) Date: Mon, 13 Jan 2020 18:50:22 +1100 Subject: [Koha-devel] "Get desktop application" link In-Reply-To: References: <0d0f01d5c6b9$dcebfbc0$96c3f340$@prosentient.com.au> Message-ID: <0e9f01d5c9e6$1c3ae320$54b0a960$@prosentient.com.au> That sounds reasonable. I don’t really have a solution in mind, but just wondered about it from a branding perspective. Maybe https://gitlab.com/koha-community/koha-offline-circulation? Then again, maybe it’s worthwhile keeping it affiliated with Bywater, since it’s not part of Koha per se? I suppose the “Get Firefox add-on” isn’t really that different in that regard? Perhaps both should be put under a “Third-party” heading? Admittedly, I’m not familiar with the KOC functionality. (Historically, we’ve used our own custom desktop application to fill this niche.) I don’t have a strong stance in any way. I’m just curious. As the REST API grows, I imagine more and more third-party tools will develop around Koha, and I wonder how those should be recommended to end users. (I suppose that’s a parallel line of thinking with how Koha plugins are published and shared amongst people.) I’m probably just overthinking it, but it’s something I ponder. Happy to let sleeping dogs lie too. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: Kyle Hall Sent: Friday, 10 January 2020 4:11 AM To: David Cook Cc: Koha Devel Subject: Re: [Koha-devel] "Get desktop application" link David, that is the canonical source for the offline circ desktop app. There is no community source for it, but I wouldn't be opposed to that if I can be given full rights to such a repo for bug fixes, releases and such. Kyle --- http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) On Thu, Jan 9, 2020 at 1:56 AM > wrote: Hi all, I’m just poking around on 19.11 and I notice the “Get desktop application” link on /cgi-bin/koha/circ/circulation-home.pl points to ByWater’s Github. Is that an optimal link or should it be pointing to a Koha Community resource? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 _______________________________________________ Koha-devel mailing list Koha-devel at lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 484 bytes Desc: not available URL: From jonathan.druart at bugs.koha-community.org Mon Jan 13 12:26:01 2020 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Mon, 13 Jan 2020 12:26:01 +0100 Subject: [Koha-devel] Out of sort memory, consider increasing server sort buffer size In-Reply-To: <409d4a06-d2e1-e9ec-b03a-6cab410a3f4e@inlibro.com> References: <83af010e-9625-62a5-8fdf-0dd7f0d31cfc@inlibro.com> <2744e3d3-84f1-7f82-3bfd-822ecf437c5e@inlibro.com> <409d4a06-d2e1-e9ec-b03a-6cab410a3f4e@inlibro.com> Message-ID: Hi Philippe, I really do not understand the fix. If think you are going to get random data. My understanding of this change is that you are going to get only 1 row that will be populated with the MAX of each column. What am I missing? Le ven. 10 janv. 2020 à 22:30, Philippe Blouin a écrit : > > A month later... > > Maryse found a (recommanded) solution for the aqspent.pl crashes: > > - aqorders.biblionumber, aqorders.basketno, aqorders.ordernumber, > - quantity-quantityreceived AS tleft, > - budgetdate, entrydate, > - aqbasket.booksellerid, > + MAX(aqorders.biblionumber) AS biblionumber, MAX(aqorders.basketno) AS basketno, aqorders.ordernumber, > + MAX(quantity)-MAX(quantityreceived) AS tleft, > + MAX(budgetdate) AS budgetdate, MAX(entrydate) AS entrydate, > + MAX(aqbasket.booksellerid) AS booksellerid, > GROUP_CONCAT(DISTINCT itype SEPARATOR '|') as itypes, > - title, > - aqorders.invoiceid, > - aqinvoices.invoicenumber, > - quantityreceived, > - unitprice_tax_included, > - datereceived, > - aqbooksellers.name as vendorname > + MAX(title) AS title, > + MAX(aqorders.invoiceid) AS invoiceid, > + MAX(aqinvoices.invoicenumber) AS invoicenumber, > + MAX(quantityreceived) AS quantityreceived, > + MAX(unitprice_tax_included) AS unitprice_tax_included, > + MAX(datereceived) AS datereceived, > + MAX(aqbooksellers.name) as vendorname > > We'll hack that in all our distributions. But I'd really like to have an official distributed solution to the problem. To me, it's not that much uglier than the fix adding all the column to avoid the problem with ONLY_FULL_GROUP_BY. > > What's your take on it? > > Regards, > > Philippe Blouin, > Directeur de la technologie > > Tél. : (833) 465-4276, poste 230 > philippe.blouin at inLibro.com > > inLibro | pour esprit libre | www.inLibro.com > On 2019-12-13 11:25 a.m., Philippe Blouin wrote: > > minuscule: > > 2000 biblio, 12000 items > 8 aqbudgets, 200 invoices, 25 booksellers, 60 baskets, 240 orders. > > That makes little sense... > > Philippe Blouin, > Directeur de la technologie > > Tél. : (833) 465-4276, poste 230 > philippe.blouin at inLibro.com > > inLibro | pour esprit libre | www.inLibro.com > On 2019-12-13 9:49 a.m., Jonathan Druart wrote: > > How big is your tables? > As you can see SQL query is really ugly, and can be good to split it anyway... > > Le ven. 13 déc. 2019 à 15:26, Philippe Blouin > a écrit : > > Thanks, > > Ok, I've never seen the "$field is not in group by" error. Interesting. > > I've followed the bread crumbs: 21622 -> 20182 -> 21723 -> 22260... read it all. It's "damned if you do, damned if you don't". > > ONLY_FULL_GROUP_BY mode is the SQL Standard, I don't think it would be wise to stray from that. (I can do it locally, but I don't think Koha should, philosophically) > > But my client can't click on spent.pl. And no memory setting seems to fix it. So what's my solution? Could the query be reworked in two steps? This is not a screen where 0.2s will make a difference in the user experience. > > Suggestions welcomed. > > Philippe Blouin, > Directeur de la technologie > > Tél. : (833) 465-4276, poste 230 > philippe.blouin at inLibro.com > > inLibro | pour esprit libre | www.inLibro.com > On 2019-12-13 4:33 a.m., Jonathan Druart wrote: > > Hi Philippe, > > See bug 21622. > It is necessary to not explode with "$field is not in group by" (when > sql_mode has ONLY_FULL_GROUP_BY) > However we may need to discuss the need of this flag if it brings us > performance issues. > > Cheers, > Jonathan > > Le jeu. 12 déc. 2019 à 23:23, Philippe Blouin > a écrit : > > Good morning Koha, > > Newbie question: why do we have 16 fields in GROUP BYs ? Are they really all necessary to eliminate duplicate lines in budgets? Genuine question. > > When in acqui-home.pl, clicking certain entries linking to spent.pl just crashes with the error listed in the mail's object: Out of memory. Although I hate that solution, I went with it, increased sort_buffer_size 64x fold (I'm a generous guy). Still not enough. > > Removing most lines in GROUP BY of spent.pl solves it all, of course. > > -- > Philippe Blouin, > Directeur de la technologie > > Tél. : (833) 465-4276, poste 230 > philippe.blouin at inLibro.com > > inLibro | pour esprit libre | www.inLibro.com > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ From oleonard at myacpl.org Tue Jan 14 15:06:46 2020 From: oleonard at myacpl.org (Owen Leonard) Date: Tue, 14 Jan 2020 09:06:46 -0500 Subject: [Koha-devel] "Get desktop application" link In-Reply-To: <0e9f01d5c9e6$1c3ae320$54b0a960$@prosentient.com.au> References: <0d0f01d5c6b9$dcebfbc0$96c3f340$@prosentient.com.au> <0e9f01d5c9e6$1c3ae320$54b0a960$@prosentient.com.au> Message-ID: > (Historically, we’ve used our own custom desktop application to fill this niche.) Your own custom super-secret desktop application! -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org From kohanews at gmail.com Wed Jan 15 03:48:03 2020 From: kohanews at gmail.com (kohanews) Date: Tue, 14 Jan 2020 18:48:03 -0800 Subject: [Koha-devel] Call for news: January 2020 Koha Newsletter Message-ID: I'm collecting news for the January newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --------------------------- ** For events **:    - Please include dates for past events. If I can't find dates I may not add it.    - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon    - For past events , **** one month back is the cut-off  ****. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the 26th of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. Thank you! -- Chad Roseburg Editor, Koha Community Newsletter From katrin.fischer.83 at web.de Wed Jan 15 08:12:28 2020 From: katrin.fischer.83 at web.de (Katrin Fischer) Date: Wed, 15 Jan 2020 08:12:28 +0100 Subject: [Koha-devel] Out of sort memory, consider increasing server sort buffer size In-Reply-To: References: <83af010e-9625-62a5-8fdf-0dd7f0d31cfc@inlibro.com> <2744e3d3-84f1-7f82-3bfd-822ecf437c5e@inlibro.com> <409d4a06-d2e1-e9ec-b03a-6cab410a3f4e@inlibro.com> Message-ID: Hi Philippe, same here as Jonathan, it looks to me like you will get quite different data than the original query. Katrin On 13.01.20 12:26, Jonathan Druart wrote: > Hi Philippe, > I really do not understand the fix. > If think you are going to get random data. My understanding of this > change is that you are going to get only 1 row that will be populated > with the MAX of each column. > What am I missing? > > Le ven. 10 janv. 2020 à 22:30, Philippe Blouin > a écrit : >> A month later... >> >> Maryse found a (recommanded) solution for the aqspent.pl crashes: >> >> - aqorders.biblionumber, aqorders.basketno, aqorders.ordernumber, >> - quantity-quantityreceived AS tleft, >> - budgetdate, entrydate, >> - aqbasket.booksellerid, >> + MAX(aqorders.biblionumber) AS biblionumber, MAX(aqorders.basketno) AS basketno, aqorders.ordernumber, >> + MAX(quantity)-MAX(quantityreceived) AS tleft, >> + MAX(budgetdate) AS budgetdate, MAX(entrydate) AS entrydate, >> + MAX(aqbasket.booksellerid) AS booksellerid, >> GROUP_CONCAT(DISTINCT itype SEPARATOR '|') as itypes, >> - title, >> - aqorders.invoiceid, >> - aqinvoices.invoicenumber, >> - quantityreceived, >> - unitprice_tax_included, >> - datereceived, >> - aqbooksellers.name as vendorname >> + MAX(title) AS title, >> + MAX(aqorders.invoiceid) AS invoiceid, >> + MAX(aqinvoices.invoicenumber) AS invoicenumber, >> + MAX(quantityreceived) AS quantityreceived, >> + MAX(unitprice_tax_included) AS unitprice_tax_included, >> + MAX(datereceived) AS datereceived, >> + MAX(aqbooksellers.name) as vendorname >> >> We'll hack that in all our distributions. But I'd really like to have an official distributed solution to the problem. To me, it's not that much uglier than the fix adding all the column to avoid the problem with ONLY_FULL_GROUP_BY. >> >> What's your take on it? >> >> Regards, >> >> Philippe Blouin, >> Directeur de la technologie >> >> Tél. : (833) 465-4276, poste 230 >> philippe.blouin at inLibro.com >> >> inLibro | pour esprit libre | www.inLibro.com >> On 2019-12-13 11:25 a.m., Philippe Blouin wrote: >> >> minuscule: >> >> 2000 biblio, 12000 items >> 8 aqbudgets, 200 invoices, 25 booksellers, 60 baskets, 240 orders. >> >> That makes little sense... >> >> Philippe Blouin, >> Directeur de la technologie >> >> Tél. : (833) 465-4276, poste 230 >> philippe.blouin at inLibro.com >> >> inLibro | pour esprit libre | www.inLibro.com >> On 2019-12-13 9:49 a.m., Jonathan Druart wrote: >> >> How big is your tables? >> As you can see SQL query is really ugly, and can be good to split it anyway... >> >> Le ven. 13 déc. 2019 à 15:26, Philippe Blouin >> a écrit : >> >> Thanks, >> >> Ok, I've never seen the "$field is not in group by" error. Interesting. >> >> I've followed the bread crumbs: 21622 -> 20182 -> 21723 -> 22260... read it all. It's "damned if you do, damned if you don't". >> >> ONLY_FULL_GROUP_BY mode is the SQL Standard, I don't think it would be wise to stray from that. (I can do it locally, but I don't think Koha should, philosophically) >> >> But my client can't click on spent.pl. And no memory setting seems to fix it. So what's my solution? Could the query be reworked in two steps? This is not a screen where 0.2s will make a difference in the user experience. >> >> Suggestions welcomed. >> >> Philippe Blouin, >> Directeur de la technologie >> >> Tél. : (833) 465-4276, poste 230 >> philippe.blouin at inLibro.com >> >> inLibro | pour esprit libre | www.inLibro.com >> On 2019-12-13 4:33 a.m., Jonathan Druart wrote: >> >> Hi Philippe, >> >> See bug 21622. >> It is necessary to not explode with "$field is not in group by" (when >> sql_mode has ONLY_FULL_GROUP_BY) >> However we may need to discuss the need of this flag if it brings us >> performance issues. >> >> Cheers, >> Jonathan >> >> Le jeu. 12 déc. 2019 à 23:23, Philippe Blouin >> a écrit : >> >> Good morning Koha, >> >> Newbie question: why do we have 16 fields in GROUP BYs ? Are they really all necessary to eliminate duplicate lines in budgets? Genuine question. >> >> When in acqui-home.pl, clicking certain entries linking to spent.pl just crashes with the error listed in the mail's object: Out of memory. Although I hate that solution, I went with it, increased sort_buffer_size 64x fold (I'm a generous guy). Still not enough. >> >> Removing most lines in GROUP BY of spent.pl solves it all, of course. >> >> -- >> Philippe Blouin, >> Directeur de la technologie >> >> Tél. : (833) 465-4276, poste 230 >> philippe.blouin at inLibro.com >> >> inLibro | pour esprit libre | www.inLibro.com >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : http://www.koha-community.org/ >> git : http://git.koha-community.org/ >> bugs : http://bugs.koha-community.org/ >> >> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : http://www.koha-community.org/ >> git : http://git.koha-community.org/ >> bugs : http://bugs.koha-community.org/ > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ From joy at bywatersolutions.com Wed Jan 15 19:55:11 2020 From: joy at bywatersolutions.com (Joy Nelson) Date: Wed, 15 Jan 2020 12:55:11 -0600 Subject: [Koha-devel] String Freeze Message-ID: Greetings! Just a quick note that string freeze is effect today 01/15/2020 for the maintenance branches. Maintenance releases scheduled for the 22rd. Let the translations begin! Thanks! joy -- Joy Nelson President, Koha Division ByWater Solutions Support and Consulting for Open Source Software Phone/Fax (888)900-8944 What is Koha? -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Thu Jan 16 01:14:24 2020 From: dcook at prosentient.com.au (dcook at prosentient.com.au) Date: Thu, 16 Jan 2020 11:14:24 +1100 Subject: [Koha-devel] "Get desktop application" link In-Reply-To: References: <0d0f01d5c6b9$dcebfbc0$96c3f340$@prosentient.com.au> <0e9f01d5c9e6$1c3ae320$54b0a960$@prosentient.com.au> Message-ID: <004801d5cc01$e8714a70$b953df50$@prosentient.com.au> Hehe. Yep. I don't think that it's widely used, but it's used out in the wild in Australia. I keep meaning to look at the one from ByWater so that we could retire ours. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 -----Original Message----- From: Koha-devel On Behalf Of Owen Leonard Sent: Wednesday, 15 January 2020 1:07 AM To: Koha Devel Subject: Re: [Koha-devel] "Get desktop application" link > (Historically, we’ve used our own custom desktop application to fill > this niche.) Your own custom super-secret desktop application! -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel at lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 484 bytes Desc: not available URL: From M.de.Rooy at rijksmuseum.nl Tue Jan 21 09:04:37 2020 From: M.de.Rooy at rijksmuseum.nl (Marcel de Rooy) Date: Tue, 21 Jan 2020 08:04:37 +0000 Subject: [Koha-devel] [Koha] run koha without mpm_itk In-Reply-To: References: , Message-ID: Would this be interesting too for containerization? Make it possible to run Koha in Docker without cap-add's ? ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl ​ ​Nu te zien: ​​​​​Rembrandt-Velázquez. Nederlandse & Spaanse meesters Document Nederland: Martijn van de Griendt ON/OFF Operatie Nachtwacht​ ​ ​T/m 18 jaar gratis Please think before you print ________________________________ Van: Koha namens Tomas Cohen Arazi Verzonden: dinsdag 21 januari 2020 00:43 Aan: Alvaro Cornejo CC: Koha Onderwerp: Re: [Koha] run koha without mpm_itk For testing purposes you could comment the itk related lines, and make Apache run as the Koha instance user. El lun., 20 de enero de 2020 20:40, Alvaro Cornejo escribió: > Hi > > Is it posible to run koha without mpm_itk? I want to test apache2 > performance with apache2buddy.pl but it does not support mpm_itk > > I tried to replace it with mod_suexec and suexecUserGroup unsuccessfully. > > Regards > > Alvaro -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image460241.png Type: image/png Size: 2974 bytes Desc: image460241.png URL: From dcook at prosentient.com.au Tue Jan 21 10:34:24 2020 From: dcook at prosentient.com.au (dcook at prosentient.com.au) Date: Tue, 21 Jan 2020 20:34:24 +1100 Subject: [Koha-devel] Missing optional Net::Z3950::SimpleServer dependency causes ~/koha prove t to fail Message-ID: <02e801d5d03d$f7929960$e6b7cc20$@prosentient.com.au> Technically, Net::Z3950::SimpleServer is an optional dependency, so the test suite probably shouldn't fail if it's not installed? I'll just look at installing it, so it shouldn't be a big drama, but just wondering what people think about this. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 484 bytes Desc: not available URL: From fridolin.somers at biblibre.com Wed Jan 22 16:57:05 2020 From: fridolin.somers at biblibre.com (Fridolin SOMERS) Date: Wed, 22 Jan 2020 16:57:05 +0100 Subject: [Koha-devel] Koha plugin MRPP Message-ID: Hi, I'd like to present a small plugin of my own : https://github.com/biblibre/koha-plugin-mrpp A library asked for this to be able to fastly add a lot of records into a list. Full Javascript so its neatly a hack \o/. Can be a performance killer that's why it's only for staff interface. Best regards, -- Fridolin SOMERS BibLibre, France - software and system maintainer From joy at bywatersolutions.com Wed Jan 22 23:45:58 2020 From: joy at bywatersolutions.com (Joy Nelson) Date: Wed, 22 Jan 2020 16:45:58 -0600 Subject: [Koha-devel] Koha 19.11.02 released Message-ID: The Koha community is proud to announce the release of Koha 19.11.02. This is a maintenance release which includes 13 enhancements, 48 bugfixes. The full release notes are available at https://koha-community.org/koha-19-11-02-release/ Debian packages will be updated within a few days. -- Joy Nelson President, Koha Division ByWater Solutions Support and Consulting for Open Source Software Phone/Fax (888)900-8944 What is Koha? -------------- next part -------------- An HTML attachment was scrubbed... URL: From paul.poulain at biblibre.com Mon Jan 27 11:15:05 2020 From: paul.poulain at biblibre.com (Paul Poulain) Date: Mon, 27 Jan 2020 11:15:05 +0100 Subject: [Koha-devel] hackfest 2020 in Marseille, registrations are open ! Message-ID: <0fa78ab6-75f2-a373-dadb-d61205548434@biblibre.com> Hello everyone, almost everything is in the title : you can register for the hackfest by sending me an email. As announced previously, it will take place in BibLibre office, Marseille, France, March 23-27 Some explanations for those who need them: * the hackfest is NOT a developer week. it's a week for anyone willing to contribute to Koha, whatever the kind of contribution (testing, documenting, ...) * the hackfest is free of charge (but you'll have to deal with your traveling costs, of course) * you can come for 5 days, or less. Don't come for 1 day, it's useless. coming for 2 days is very frustrating. Coming for 3 to 5 days is perfect ! * 40-45 ppl fit in our office. If we're more than this, we'll have to book an additional room [thanks to the company just next door] So register as soon as possible * there's no schedule, everyone comes with it's own ideas/goals/expectations * that's not a training session * if you need an official invitation, just ask by email Hoping to see you next month !!! -- Paul Poulain, Associé-gérant / co-owner BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Open Source software and services for libraries -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Tue Jan 28 08:45:38 2020 From: dcook at prosentient.com.au (dcook at prosentient.com.au) Date: Tue, 28 Jan 2020 18:45:38 +1100 Subject: [Koha-devel] External Independent Security Audits of Koha Message-ID: <077a01d5d5ae$ef10f770$cd32e650$@prosentient.com.au> Hi all, Sending this first to the dev list, and might send to the general list depending on responses. Has anyone in the Koha community commissioned an external independent security audit of Koha? I know people do their own pen testing and security audits, but has anyone paid for an external independent firm to certify Koha? Apologies for the vagueness. I'm asking this question on behalf of someone else. I don't think it's a source code audit (like has been done for open source encryption software like TrueCrypt). Rather, I think it's an audit of an implemented Koha. Of course, any audit of an implementation would be implementation specific, so I'm not quite sure of the intentions behind the original question, but there you have it. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 484 bytes Desc: not available URL: From M.de.Rooy at rijksmuseum.nl Wed Jan 29 17:24:56 2020 From: M.de.Rooy at rijksmuseum.nl (Marcel de Rooy) Date: Wed, 29 Jan 2020 16:24:56 +0000 Subject: [Koha-devel] Coding guidelines Message-ID: Referring to the dev meeting and bug 22407, I propose the following rewording: PERL15 Using Koha::Object[s] PERL15(a) Code added to the Koha:: namespace should be object-oriented unless there is a very good reason to do otherwise. In that case the reason should be documented clearly. PERL15(b) Code in Koha::Object[s] should normally not refer back to C4. Obviously, this cannot be enforced harshly until the refactoring has been completed. PERL15(c) Use DBIC relations to (pre)fetch a related Koha object rather than searching it explicitly. (See bug 22407) PERL28 Other object oriented code guidelines (in addition to PERL15) I think we need to move the Accessor and idiom for -> new rules from PERL15 to another rule. I opened rule 28 for that depending on discussing the following: Class::Accessor is a great way to provide access to member variables. => My suggestion would be to remove this rule. It is true but we do not say that it is the only way to do it. (We are not even using Class::Accessor in Koha objects.) Or just say PERL28(a) To provide access to member variables, there are several ways including but not limited to using Class::Accessor. A useful idiom for the ->new() routine in object-oriented classes that do not need to process the arguments passed in as a hashref but merely need to save them for future processing => This suggestion is fine. It says use a parameter hash for sub new. We normally do that. Reworded: PERL 28(b) Use a hashref as second parameter in sub new when passing arguments. Any feedback? Marcel ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl ​ ​Nu te zien: Operatie Nachtwacht​ ​ ​Verwacht: ​Caravaggio-Bernini. Barok in Rome ​Dankzij Waller 2010-2020 ​ ​T/m 18 jaar gratis Please think before you print -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image826795.png Type: image/png Size: 2974 bytes Desc: image826795.png URL: From rooy.de.m at gmail.com Thu Jan 30 09:17:04 2020 From: rooy.de.m at gmail.com (Marcel de Rooy) Date: Thu, 30 Jan 2020 09:17:04 +0100 Subject: [Koha-devel] Signoff request for bug 21190 [GDPR logging] Message-ID: Hi, See bug 21190. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 GDPR: Log successful/unsuccessful login attempts [part 1] Some people asked for it. I wrote something. I do not really need it myself. I waited three months, but to no avail. This is my last resort ;) If you are interested in such changes, please test and signoff. If no one is, I will not keep waiting but just happily close the report. Thanks, Marcel -------------- next part -------------- An HTML attachment was scrubbed... URL: From rooy.de.m at gmail.com Thu Jan 30 09:20:06 2020 From: rooy.de.m at gmail.com (Marcel de Rooy) Date: Thu, 30 Jan 2020 09:20:06 +0100 Subject: [Koha-devel] Just a test Message-ID: Testing from another address. -------------- next part -------------- An HTML attachment was scrubbed... URL: From martin.renvoize at ptfs-europe.com Thu Jan 30 12:27:07 2020 From: martin.renvoize at ptfs-europe.com (Renvoize, Martin) Date: Thu, 30 Jan 2020 11:27:07 +0000 Subject: [Koha-devel] Global Bug Squashing Day - February 14th 2020 Message-ID: Hi All, At the last Koha Developers Meeting, it was proposed that we bring back regular Global Bug Squashing Day events to help keep the bug queue moving along and encourage more people to get involved. As such, we are arranging such a day to take place on the 14th of February. We hope to see some new names added to the list of contributors: Testing, Signoff, Quality Assurance, Patch Writing, Documentation additions all count, and there will be friendly developers available to help throughout the day on IRC ! If you have always wanted to get involved now is a good time, so spin up a devbox, try out a sandbox, or just visit us in IRC and ask everything you wanted to know about Koha and we will help as best as we can. Please see https://wiki.koha-community.org/wiki/2020-02-14_Global_bug_squashing_day for more information. *Martin Renvoize* Development Team Manager Community Release Manager (19.11, 20.05) *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize at ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info at ptfs-europe.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Fri Jan 31 11:51:48 2020 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Fri, 31 Jan 2020 11:51:48 +0100 Subject: [Koha-devel] Write good commit messages Message-ID: Hi devs, This is a gently reminder about the bug report titles and commit messages. At the last dev meeting we discussed if we should or not reinforce, at QA and RM step, the coding codeline about how commit messages are written. We voted yes :) Can you please read again the following wiki page:https://wiki.koha-community.org/wiki/Commit_messages And especially the "examples" section: https://wiki.koha-community.org/wiki/Commit_messages#Examples The main point is: the bug report title must describe what the bug is, while the commit title must describe what the patch does, so most of the time you must not copy the bug report title to the commit title. Previous message to the list: https://lists.koha-community.org/pipermail/koha-devel/2017-August/043991.html Cheers, Jonathan From claire.hernandez at biblibre.com Fri Jan 31 17:25:27 2020 From: claire.hernandez at biblibre.com (Claire Hernandez) Date: Fri, 31 Jan 2020 17:25:27 +0100 Subject: [Koha-devel] Elasticsearch recent works at BibLibre Message-ID: <93ef6121-d100-af89-8e6d-4f61497acd0f@biblibre.com> Hi, This week, some devs work together to move forward concretely on Elasticsearch issues encountered. You will find below a focus on some points (some are at poc state today) written by Alex and Jajm from BibLibre. We would be glad to discuss these topics at hackfest in march and having user feedbacks too :) #1 Proof of concept for language analyzers bug 21357 - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357#c32 It's an attempt at having a default ES configuration with stemming, elision, etc. that works with multi-languages catalogs You can read the comments and patch for more information. #2 Compatibilites for tomorrow Compatibility with latest version of Search::Elasticsearch - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Compatibility with Elasticsearch 7.x : Problem: Search::Elasticsearch is not yet compatible with ES 7.x, so we are stuck with  ES 6.x (unless we use something else...) #3 Querying Elasticsearch in a better way POC query_string => boolean query https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 This POC is about replacing the use of full text queries (query_string) with Boolean queries for biblio search Advantage:     => No search craches with special character ( "!", ")" etc...)     => Separate query context and filter context:          - Search scores are not altered by facets,         - Ability to use range filter  (i.e for publication date facet) Regards, Claire. -------------- next part -------------- An HTML attachment was scrubbed... URL: From eric.begin at inLibro.com Fri Jan 31 18:38:33 2020 From: eric.begin at inLibro.com (=?UTF-8?Q?Eric_B=c3=a9gin?=) Date: Fri, 31 Jan 2020 12:38:33 -0500 Subject: [Koha-devel] [Koha] Elasticsearch recent works at BibLibre In-Reply-To: <93ef6121-d100-af89-8e6d-4f61497acd0f@biblibre.com> References: <93ef6121-d100-af89-8e6d-4f61497acd0f@biblibre.com> Message-ID: <0286c88f-a1cf-47fa-2e58-aeef613b9845@inLibro.com> Hello Claire, Bouzid at inLibro worked on some of those issues. Do not hesitated to contact him (he speak French). You can get its email on Bugzilla. Cheers, Eric Bégin Solutions inLibro inc. Le 20-01-31 à 11 h 25, Claire Hernandez a écrit : > > Hi, > > This week, some devs work together to move forward concretely on > Elasticsearch issues encountered. You will find below a focus on some > points (some are at poc state today) written by Alex and Jajm from > BibLibre. We would be glad to discuss these topics at hackfest in > march and having user feedbacks too :) > > #1 Proof of concept for language analyzers > > bug 21357 - > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357#c32 > It's an attempt at having a default ES configuration with stemming, > elision, etc. that works with multi-languages catalogs > You can read the comments and patch for more information. > > #2 Compatibilites for tomorrow > > Compatibility with latest version of Search::Elasticsearch - > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 > > Compatibility with Elasticsearch 7.x : Problem: Search::Elasticsearch > is not yet compatible with ES 7.x, so we are stuck with >  ES 6.x (unless we use something else...) > > #3 Querying Elasticsearch in a better way > > POC query_string => boolean query > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 > This POC is about replacing the use of full text queries > (query_string) with Boolean queries for biblio search > > Advantage: > => No search craches with special character ( "!", ")" etc...) > => Separate query context and filter context: > - Search scores are not altered by facets, > - Ability to use range filter  (i.e for publication date facet) > > Regards, > Claire. > > > > > > > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ -- Eric Bégin Tél.  : 833-465-4276, poste 200 Eric.Begin at inLibro.com INLiBRO | Spécialistes en technologies documentaires | www.inLibro.com -------------- next part -------------- An HTML attachment was scrubbed... URL: