[Koha-devel] Second look needed on a few (2!) lines related to plugins

[Fridolin SOMERS]

Hi,

In my opinion this syntax looks strange.
I'd prefer :
         my $filter = { uploadcategorycode => $browsecategory };
         $filter{public} = 1 if $plugin;
         $uploads = Koha::UploadedFiles->search($filter)->unblessed;

Super cool enhancement BTW ;)

Best regards,

Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
> Hi :)
> 
> It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
> 
> There are two lines in the patch that are out of my knowledge to QA:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
> 
> [% PROCESS plugin_pars %]
> [...]
> $plugin? ( public => 1 ): ()
> 
> Does this look familiar to anyone?
> 
> Cheers,
> 

-- 
Fridolin SOMERS <fridolin.somers at biblibre.com>
Software and system maintainer 🦄
BibLibre, France