[Koha-devel] TT loop count VS size

[Fridolin SOMERS]

Hi community,

I've been on a mindblowing search on a template error :D

I was thinking that "loop.count" was wrong for testing if loop is not 
empty, the method is "loop.size".

See doc 
http://template-toolkit.org/docs/manual/Directives.html#section_FOREACH

Looks like we use both actually :
  > git grep 'IF.*\.count ' origin/master | wc -l
602
  > git grep 'IF.*\.size ' origin/master | wc -l
1636

So using count seems to work because it starts with 1.
But in my opinion it is a wrong call.

We can see for example :
  <a href="#images">Images ([% localimages.count || 0 | html %])</a>
This is wrong no ?

Should be create a coding guideline ?

-- 
Fridolin SOMERS <fridolin.somers at biblibre.com>
Software and system maintainer 🦄
BibLibre, France