[Koha-devel] Request about running QA test tool on bug 26346

[Alex Buckley]

Hi all,

I hope those of you at the Marseille hackfest are having fun :)

I have a request that I would be very grateful for some help with please:

Could someone please apply the three patches on bug 26346 onto master,
run the QA test tool (
https://wiki.koha-community.org/wiki/QA_Test_Tools ) and paste their QA
test output onto the bug report?

When I run my QA test tool on the three patches all the tests pass (see
attached output), however, I've heard others are seeing some failures.
It would be great to find out what these failures are so I can fix them
and get 26346 upstreamed.

For context: The patches on bug 26346 (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 ) add
the option for staff to edit/add-to public lists (not just list owners
only, or anyone seeing the list). This is something that both our
library clients and those in the community sound like they would find
useful.

Many thanks,

Alex


-- 
Alex Buckley (he/him)
Koha Developer | Implementation Lead

Catalyst IT - Expert Open Source Solutions
www.catalyst.net.nz <http://www.catalyst.net.nz>

CONFIDENTIALITY NOTICE: This email is intended for the named recipients
only. It may contain privileged, confidential or copyright information.
If you are not the named recipient, any use, reliance upon, disclosure
or copying of this email or its attachments is unauthorised. If you have
received this email in error, please reply via email or call +64 4 499 2267.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220329/0e03c805/attachment.htm>
-------------- next part --------------
Processing files after patches
|========================>| 13 / 13 (100.00%)

 OK	Koha/Patron.pm
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  pod coverage
   OK	  spelling
   OK	  valid

 OK	Koha/Schema/Result/Virtualshelve.pm
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  pod coverage
   OK	  spelling
   OK	  valid

 OK	Koha/Virtualshelf.pm
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  pod coverage
   OK	  spelling
   OK	  valid

 OK	Koha/Virtualshelves.pm
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  pod coverage
   OK	  spelling
   OK	  valid

 OK	installer/data/mysql/kohastructure.sql
   OK	  boolean_vs_tinyint
   OK	  charset_collate
   OK	  git manipulation
   OK	  tinyint_has_boolean_flag

 OK	koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
   OK	  filters
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  js_in_body
   OK	  spelling
   OK	  tt_valid
   OK	  valid_template

 OK	koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
   OK	  filters
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  js_in_body
   OK	  spelling
   OK	  tt_valid
   OK	  valid_template

 OK	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
   OK	  filters
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  js_in_body
   OK	  spelling
   OK	  tt_valid
   OK	  valid_template

 OK	opac/opac-addbybiblionumber.pl
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  spelling
   OK	  valid

 OK	opac/opac-shelves.pl
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  spelling
   OK	  valid

 OK	t/db_dependent/Koha/Patron.t
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  spelling
   OK	  valid

 OK	t/db_dependent/Virtualshelves.t
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  spelling
   OK	  valid

 OK	virtualshelves/shelves.pl
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   OK	  spelling
   OK	  valid


Processing additional checks OK!