[Koha-devel] Bug 30684: Requesting community feedback on change to restart behaviour of koha-* scripts

[dcook at prosentient.com.au]

I’m happy for this change. I think it would make the koha-* scripts more in line with the standard methodology of restarting Linux services.

 

Another reason to do this… *I think* if you try to do a “koha-plack --restart" against 10 instances where the 5th instance isn’t running, the first 4 will restart but then the script will error out, and it won’t restart the last 5 instances. So this change would make batch updates much safer.

 

(As an aside, Bug 21366 is about adding a --reload (ie graceful restart) to koha-plack, so I’m also holding off on doing that patch until Bug 30684 is resolved…)

 

David Cook

Senior Software Engineer

Prosentient Systems

Suite 7.03

6a Glen St

Milsons Point NSW 2061

Australia

 

Office: 02 9212 0899

Online: 02 8005 0595

 

From: Koha-devel <koha-devel-bounces at lists.koha-community.org> On Behalf Of Alex Buckley
Sent: Friday, 20 May 2022 2:11 PM
To: koha-devel at lists.koha-community.org
Subject: [Koha-devel] Bug 30684: Requesting community feedback on change to restart behaviour of koha-* scripts

 

Kia ora Koha community,

I'd love to hear your thoughts please on adding the following behaviour across all koha-* scripts when passing the --restart parameter:

1. If the service is not running

2. You run sudo koha-<service> --restart <instancename> , e.g. sudo koha-plack --restart kohadev

3. Koha stops the service, then starts it

Context

Bug 30684 was initially written to resolve the below error that is thrown when you try restarting plack, if it's not already running:

[FAIL] Error: Plack not running for <instancename>: failed!

However, as Marcel noted the error is thrown by design: If you didn't start it, you cannot restart it. 

So it would be better to stop and then start the service. Also to ensure this change was consistent, it should be implemented in all koha-* scripts, not just koha-plack.

Is everyone happy for this change to be implemented in all koha-* scripts?

Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/1a82a87d/attachment.htm>