From dcook at prosentient.com.au Wed Feb 1 01:53:54 2023 From: dcook at prosentient.com.au (David Cook) Date: Wed, 1 Feb 2023 11:53:54 +1100 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> Message-ID: <095b01d935d7$ae7e16c0$0b7a4440$@prosentient.com.au> Well that’s interesting. Reading through the following links, you have to wonder what Gitea Ltd were really thinking… https://blog.gitea.io/2022/10/open-source-sustainment-and-the-future-of-gitea/ https://blog.gitea.io/2022/10/a-message-from-lunny-on-gitea-ltd.-and-the-gitea-project/ I had forgotten that Gitea itself is a fork of another project called Gogs: https://blog.gitea.io/2016/12/welcome-to-gitea/ Looks like the community wrote the “elected owners” an open letter about the switch: https://gitea-open-letter.coding.social/ Sounds like Forgejo would be more in the spirit of Koha, although https://forgejo.org/2023-01-31-monthly-update/ makes it seem like it might be wise to wait a bit until its infrastructure/processes stabilize a bit more before switching over… David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel On Behalf Of Jonathan Druart Sent: Wednesday, 1 February 2023 2:32 AM To: Victor Grousset/tuxayo Cc: koha-devel Subject: Re: [Koha-devel] Trouble for the Gitea project: forked to Forgejo Some updates: https://forgejo.org/2023-01-31-monthly-update/ I think Victor's email is missing questions: what do we do? If we decide to migrate to forgejo, when? Le mer. 25 janv. 2023 à 03:45, Victor Grousset/tuxayo > a écrit : Hi :) Thanks David Nind for sharing this info on the last dev meeting: > Use of Gitea: We use Gitea for git.koha-community.org . Gitea was "forked" and is now Forgejo[1] - see the links update and related links[2] (sounds eerily familiar 8-(.. ). The community needs to look at what to do next, such as whether to continue to use Gitea, update to Forgejo, do something else.... (David Nind) > [1] https://forgejo.org/ > [2] https://forgejo.org/2022-12-26-monthly-update Comments during the meeting: > forgejo is the 'good' one? > that's what it looks like ^^ > "After Gitea Ltd confirmed the takeover of the Gitea project on 30 October 2022, a group of people proposed that Codeberg e.V. should become the custodian of a fork of Gitea. The proposal was accepted 16 November 2022" - e.V. is a German thing actually More details: e. V. is the legal form for associations in Germany and Codeberg e. V. is known for their Gitea (well, now Forgejo) instance that became host to a decent number of libre projects in the last two years. (likely they moved away from GitHub and not wanted the not libre GitLab instance at GitLab.com (open-core)) Trivia: > Forgejo (pronounced /forˈd͡ʒe.jo/ ) is inspired by forĝejo, the Esperanto word for forge. 😃😃😃 I knew the name spelling looked familiar! Cheers, -- Victor Grousset/tuxayo _______________________________________________ Koha-devel mailing list Koha-devel at lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From veron at veron.ch Wed Feb 1 09:44:17 2023 From: veron at veron.ch (=?UTF-8?Q?Marc_V=c3=a9ron?=) Date: Wed, 1 Feb 2023 09:44:17 +0100 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> Message-ID: <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> Hi everybody Why not https://codeberg.org/ ? Regards Marc Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo: > Hi :) > > Thanks David Nind for sharing this info on the last dev meeting: > >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was >> "forked" and is now Forgejo[1] - see the links update and related >> links[2] (sounds eerily familiar 8-(.. ). The community needs to look >> at what to do next, such as whether to continue to use Gitea, update >> to Forgejo, do something else.... (David Nind) >> [1] https://forgejo.org/ > > [2] https://forgejo.org/2022-12-26-monthly-update > > Comments during the meeting: > >> forgejo is the 'good' one? > >> that's what it looks like ^^ > >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30 >> October 2022, a group of people proposed that Codeberg e.V. should >> become the custodian of a fork of Gitea. The proposal was accepted 16 >> November 2022" - e.V. is a German thing actually > > More details: > > e. V. is the legal form for associations in Germany and Codeberg e. V. > is known for their Gitea (well, now Forgejo) instance that became host > to a decent number of libre projects in the last two years. > (likely they moved away from GitHub and not wanted the not libre > GitLab instance at GitLab.com (open-core)) > > > Trivia: > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the > Esperanto word for forge. > > 😃😃😃 I knew the name spelling looked familiar! > > > Cheers, > From jonathan.druart at bugs.koha-community.org Wed Feb 1 10:07:04 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Wed, 1 Feb 2023 10:07:04 +0100 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> Message-ID: See https://codeberg.org/forgejo/forgejo and https://forgejo.org/2022-12-15-hello-forgejo/ "To this end we are very proud that Codeberg e.V. has decided to become our project’s custodian." Le mer. 1 févr. 2023 à 09:44, Marc Véron a écrit : > Hi everybody > Why not https://codeberg.org/ ? > Regards > Marc > > Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo: > > Hi :) > > > > Thanks David Nind for sharing this info on the last dev meeting: > > > >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was > >> "forked" and is now Forgejo[1] - see the links update and related > >> links[2] (sounds eerily familiar 8-(.. ). The community needs to look > >> at what to do next, such as whether to continue to use Gitea, update > >> to Forgejo, do something else.... (David Nind) > >> [1] https://forgejo.org/ > > > [2] https://forgejo.org/2022-12-26-monthly-update > > > > Comments during the meeting: > > > >> forgejo is the 'good' one? > > > >> that's what it looks like ^^ > > > >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30 > >> October 2022, a group of people proposed that Codeberg e.V. should > >> become the custodian of a fork of Gitea. The proposal was accepted 16 > >> November 2022" - e.V. is a German thing actually > > > > More details: > > > > e. V. is the legal form for associations in Germany and Codeberg e. V. > > is known for their Gitea (well, now Forgejo) instance that became host > > to a decent number of libre projects in the last two years. > > (likely they moved away from GitHub and not wanted the not libre > > GitLab instance at GitLab.com (open-core)) > > > > > > Trivia: > > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the > > Esperanto word for forge. > > > > 😃😃😃 I knew the name spelling looked familiar! > > > > > > Cheers, > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From tomascohen at gmail.com Wed Feb 1 14:51:42 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Wed, 1 Feb 2023 10:51:42 -0300 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> Message-ID: Can't we just use Gitlab for now? El mié, 1 feb 2023 a las 6:08, Jonathan Druart (< jonathan.druart at bugs.koha-community.org>) escribió: > See https://codeberg.org/forgejo/forgejo and > https://forgejo.org/2022-12-15-hello-forgejo/ > "To this end we are very proud that Codeberg e.V. has decided to become > our project’s custodian." > > Le mer. 1 févr. 2023 à 09:44, Marc Véron a écrit : > >> Hi everybody >> Why not https://codeberg.org/ ? >> Regards >> Marc >> >> Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo: >> > Hi :) >> > >> > Thanks David Nind for sharing this info on the last dev meeting: >> > >> >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was >> >> "forked" and is now Forgejo[1] - see the links update and related >> >> links[2] (sounds eerily familiar 8-(.. ). The community needs to look >> >> at what to do next, such as whether to continue to use Gitea, update >> >> to Forgejo, do something else.... (David Nind) >> >> [1] https://forgejo.org/ >> > > [2] https://forgejo.org/2022-12-26-monthly-update >> > >> > Comments during the meeting: >> > >> >> forgejo is the 'good' one? >> > >> >> that's what it looks like ^^ >> > >> >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30 >> >> October 2022, a group of people proposed that Codeberg e.V. should >> >> become the custodian of a fork of Gitea. The proposal was accepted 16 >> >> November 2022" - e.V. is a German thing actually >> > >> > More details: >> > >> > e. V. is the legal form for associations in Germany and Codeberg e. V. >> > is known for their Gitea (well, now Forgejo) instance that became host >> > to a decent number of libre projects in the last two years. >> > (likely they moved away from GitHub and not wanted the not libre >> > GitLab instance at GitLab.com (open-core)) >> > >> > >> > Trivia: >> > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the >> > Esperanto word for forge. >> > >> > 😃😃😃 I knew the name spelling looked familiar! >> > >> > >> > Cheers, >> > >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : https://www.koha-community.org/ >> git : https://git.koha-community.org/ >> bugs : https://bugs.koha-community.org/ >> > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From kyle.m.hall at gmail.com Wed Feb 1 15:14:04 2023 From: kyle.m.hall at gmail.com (Kyle Hall) Date: Wed, 1 Feb 2023 09:14:04 -0500 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> Message-ID: +1 for gitlab --- http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) On Wed, Feb 1, 2023 at 8:52 AM Tomas Cohen Arazi wrote: > Can't we just use Gitlab for now? > > El mié, 1 feb 2023 a las 6:08, Jonathan Druart (< > jonathan.druart at bugs.koha-community.org>) escribió: > >> See https://codeberg.org/forgejo/forgejo and >> https://forgejo.org/2022-12-15-hello-forgejo/ >> "To this end we are very proud that Codeberg e.V. has decided to become >> our project’s custodian." >> >> Le mer. 1 févr. 2023 à 09:44, Marc Véron a écrit : >> >>> Hi everybody >>> Why not https://codeberg.org/ ? >>> Regards >>> Marc >>> >>> Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo: >>> > Hi :) >>> > >>> > Thanks David Nind for sharing this info on the last dev meeting: >>> > >>> >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was >>> >> "forked" and is now Forgejo[1] - see the links update and related >>> >> links[2] (sounds eerily familiar 8-(.. ). The community needs to look >>> >> at what to do next, such as whether to continue to use Gitea, update >>> >> to Forgejo, do something else.... (David Nind) >>> >> [1] https://forgejo.org/ >>> > > [2] https://forgejo.org/2022-12-26-monthly-update >>> > >>> > Comments during the meeting: >>> > >>> >> forgejo is the 'good' one? >>> > >>> >> that's what it looks like ^^ >>> > >>> >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30 >>> >> October 2022, a group of people proposed that Codeberg e.V. should >>> >> become the custodian of a fork of Gitea. The proposal was accepted 16 >>> >> November 2022" - e.V. is a German thing actually >>> > >>> > More details: >>> > >>> > e. V. is the legal form for associations in Germany and Codeberg e. V. >>> > is known for their Gitea (well, now Forgejo) instance that became host >>> > to a decent number of libre projects in the last two years. >>> > (likely they moved away from GitHub and not wanted the not libre >>> > GitLab instance at GitLab.com (open-core)) >>> > >>> > >>> > Trivia: >>> > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the >>> > Esperanto word for forge. >>> > >>> > 😃😃😃 I knew the name spelling looked familiar! >>> > >>> > >>> > Cheers, >>> > >>> _______________________________________________ >>> Koha-devel mailing list >>> Koha-devel at lists.koha-community.org >>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>> website : https://www.koha-community.org/ >>> git : https://git.koha-community.org/ >>> bugs : https://bugs.koha-community.org/ >>> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : https://www.koha-community.org/ >> git : https://git.koha-community.org/ >> bugs : https://bugs.koha-community.org/ >> > > > -- > Tomás Cohen Arazi > Theke Solutions (http://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Wed Feb 1 15:15:16 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Wed, 1 Feb 2023 15:15:16 +0100 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> Message-ID: I like gitea, it's faster than gitlab and it's good to have a self-hosted solution that is not draining a 16G 8cores server resources (I just put random numbers here) Le mer. 1 févr. 2023 à 14:51, Tomas Cohen Arazi a écrit : > Can't we just use Gitlab for now? > > El mié, 1 feb 2023 a las 6:08, Jonathan Druart (< > jonathan.druart at bugs.koha-community.org>) escribió: > >> See https://codeberg.org/forgejo/forgejo and >> https://forgejo.org/2022-12-15-hello-forgejo/ >> "To this end we are very proud that Codeberg e.V. has decided to become >> our project’s custodian." >> >> Le mer. 1 févr. 2023 à 09:44, Marc Véron a écrit : >> >>> Hi everybody >>> Why not https://codeberg.org/ ? >>> Regards >>> Marc >>> >>> Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo: >>> > Hi :) >>> > >>> > Thanks David Nind for sharing this info on the last dev meeting: >>> > >>> >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was >>> >> "forked" and is now Forgejo[1] - see the links update and related >>> >> links[2] (sounds eerily familiar 8-(.. ). The community needs to look >>> >> at what to do next, such as whether to continue to use Gitea, update >>> >> to Forgejo, do something else.... (David Nind) >>> >> [1] https://forgejo.org/ >>> > > [2] https://forgejo.org/2022-12-26-monthly-update >>> > >>> > Comments during the meeting: >>> > >>> >> forgejo is the 'good' one? >>> > >>> >> that's what it looks like ^^ >>> > >>> >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30 >>> >> October 2022, a group of people proposed that Codeberg e.V. should >>> >> become the custodian of a fork of Gitea. The proposal was accepted 16 >>> >> November 2022" - e.V. is a German thing actually >>> > >>> > More details: >>> > >>> > e. V. is the legal form for associations in Germany and Codeberg e. V. >>> > is known for their Gitea (well, now Forgejo) instance that became host >>> > to a decent number of libre projects in the last two years. >>> > (likely they moved away from GitHub and not wanted the not libre >>> > GitLab instance at GitLab.com (open-core)) >>> > >>> > >>> > Trivia: >>> > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the >>> > Esperanto word for forge. >>> > >>> > 😃😃😃 I knew the name spelling looked familiar! >>> > >>> > >>> > Cheers, >>> > >>> _______________________________________________ >>> Koha-devel mailing list >>> Koha-devel at lists.koha-community.org >>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>> website : https://www.koha-community.org/ >>> git : https://git.koha-community.org/ >>> bugs : https://bugs.koha-community.org/ >>> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : https://www.koha-community.org/ >> git : https://git.koha-community.org/ >> bugs : https://bugs.koha-community.org/ >> > > > -- > Tomás Cohen Arazi > Theke Solutions (http://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F > -------------- next part -------------- An HTML attachment was scrubbed... URL: From tomascohen at gmail.com Wed Feb 1 15:17:47 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Wed, 1 Feb 2023 11:17:47 -0300 Subject: [Koha-devel] Trouble for the Gitea project: forked to Forgejo In-Reply-To: References: <00a437c9-aa85-a32c-f5df-b6710b944730@tuxayo.net> <75480650-a324-a191-b2af-3bec2e4028b4@veron.ch> Message-ID: Yeah, I meant the not-self hosted Gitlab, which we don't need to maintain. El mié, 1 feb 2023 a las 11:15, Jonathan Druart (< jonathan.druart at bugs.koha-community.org>) escribió: > I like gitea, it's faster than gitlab and it's good to have a self-hosted > solution that is not draining a 16G 8cores server resources (I just put > random numbers here) > > Le mer. 1 févr. 2023 à 14:51, Tomas Cohen Arazi a > écrit : > >> Can't we just use Gitlab for now? >> >> El mié, 1 feb 2023 a las 6:08, Jonathan Druart (< >> jonathan.druart at bugs.koha-community.org>) escribió: >> >>> See https://codeberg.org/forgejo/forgejo and >>> https://forgejo.org/2022-12-15-hello-forgejo/ >>> "To this end we are very proud that Codeberg e.V. has decided to become >>> our project’s custodian." >>> >>> Le mer. 1 févr. 2023 à 09:44, Marc Véron a écrit : >>> >>>> Hi everybody >>>> Why not https://codeberg.org/ ? >>>> Regards >>>> Marc >>>> >>>> Am 25.01.23 um 03:45 schrieb Victor Grousset/tuxayo: >>>> > Hi :) >>>> > >>>> > Thanks David Nind for sharing this info on the last dev meeting: >>>> > >>>> >> Use of Gitea: We use Gitea for git.koha-community.org. Gitea was >>>> >> "forked" and is now Forgejo[1] - see the links update and related >>>> >> links[2] (sounds eerily familiar 8-(.. ). The community needs to >>>> look >>>> >> at what to do next, such as whether to continue to use Gitea, update >>>> >> to Forgejo, do something else.... (David Nind) >>>> >> [1] https://forgejo.org/ >>>> > > [2] https://forgejo.org/2022-12-26-monthly-update >>>> > >>>> > Comments during the meeting: >>>> > >>>> >> forgejo is the 'good' one? >>>> > >>>> >> that's what it looks like ^^ >>>> > >>>> >> "After Gitea Ltd confirmed the takeover of the Gitea project on 30 >>>> >> October 2022, a group of people proposed that Codeberg e.V. should >>>> >> become the custodian of a fork of Gitea. The proposal was accepted >>>> 16 >>>> >> November 2022" - e.V. is a German thing actually >>>> > >>>> > More details: >>>> > >>>> > e. V. is the legal form for associations in Germany and Codeberg >>>> e. V. >>>> > is known for their Gitea (well, now Forgejo) instance that became >>>> host >>>> > to a decent number of libre projects in the last two years. >>>> > (likely they moved away from GitHub and not wanted the not libre >>>> > GitLab instance at GitLab.com (open-core)) >>>> > >>>> > >>>> > Trivia: >>>> > > Forgejo (pronounced /forˈd͡ʒe.jo/) is inspired by forĝejo, the >>>> > Esperanto word for forge. >>>> > >>>> > 😃😃😃 I knew the name spelling looked familiar! >>>> > >>>> > >>>> > Cheers, >>>> > >>>> _______________________________________________ >>>> Koha-devel mailing list >>>> Koha-devel at lists.koha-community.org >>>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>>> website : https://www.koha-community.org/ >>>> git : https://git.koha-community.org/ >>>> bugs : https://bugs.koha-community.org/ >>>> >>> _______________________________________________ >>> Koha-devel mailing list >>> Koha-devel at lists.koha-community.org >>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>> website : https://www.koha-community.org/ >>> git : https://git.koha-community.org/ >>> bugs : https://bugs.koha-community.org/ >>> >> >> >> -- >> Tomás Cohen Arazi >> Theke Solutions (http://theke.io) >> ✆ +54 9351 3513384 >> GPG: B2F3C15F >> > -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Thu Feb 2 06:38:46 2023 From: dcook at prosentient.com.au (David Cook) Date: Thu, 2 Feb 2023 16:38:46 +1100 Subject: [Koha-devel] debian/control file updates are automated In-Reply-To: <7a434405-7e90-bf8c-ff78-139d47a6ad1c@web.de> References: <26fcdff8-e5ab-9c7e-2acb-66a331310671@catalyst.net.nz> <028e01d92adb$59912870$0cb37950$@prosentient.com.au> <9a26fe5f-09ef-33eb-79e6-da44ed8af5d5@kohaaloha.com> <7a434405-7e90-bf8c-ff78-139d47a6ad1c@web.de> Message-ID: <0a9901d936c8$a97d4aa0$fc77dfe0$@prosentient.com.au> For some reason, I don't have a copy of Mason's original email about this so replying to Katrin's email... It looks like the "master" branch still has an out-of-date debian/control file. When should that get updated? Bumped into this when testing "Bug 32609 - Remove compiled files from src" David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Koha-devel On Behalf Of Katrin Fischer Sent: Saturday, 21 January 2023 6:42 AM To: koha-devel at lists.koha-community.org Subject: Re: [Koha-devel] debian/control file updates are automated I've updated the wiki page for Release Maintenance: https://wiki.koha-community.org/wiki/Release_maintenance#Daily_maintenance_workflow Please feel free to improve :) Katrin On 19.01.23 06:49, Mason James wrote: > On 18/01/23 2:22 pm, David Cook wrote: >> Hi all, >> >> I already talked to Aleisha about this on IRC, but I figured I'd >> mention it here too. >> >> I emailed last week with a subject line of "debian/control out of >> date in master". That's what caused the problem that Aleisha >> mentioned below. >> >> I resolved the issue by stealing the control file out of the 22.11.01 >> Debian packages and sticking that into my local git. >> >> But we need to update the master and at least the 22.11.x branch. The >> 22.11.02 tag should also have an updated control file. >> >> I imagine as the year goes on, more people are going to try to build >> 22.11 and run into this same problem due to the outdated >> debian/control file... > > hi all > we now have some BZ bugs, that track the d/control file updates > > after a debian package is generated, the new changes are automatically > uploaded to the bug > > 22.11 > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32666 > > 22.05 > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 > > 21.11 > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 > > 21.05 > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32669 > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ git : > https://git.koha-community.org/ bugs : > https://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel at lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/ From mtj at kohaaloha.com Fri Feb 3 03:24:25 2023 From: mtj at kohaaloha.com (Mason James) Date: Fri, 3 Feb 2023 15:24:25 +1300 Subject: [Koha-devel] debian/control file updates are automated In-Reply-To: <0a9901d936c8$a97d4aa0$fc77dfe0$@prosentient.com.au> References: <26fcdff8-e5ab-9c7e-2acb-66a331310671@catalyst.net.nz> <028e01d92adb$59912870$0cb37950$@prosentient.com.au> <9a26fe5f-09ef-33eb-79e6-da44ed8af5d5@kohaaloha.com> <7a434405-7e90-bf8c-ff78-139d47a6ad1c@web.de> <0a9901d936c8$a97d4aa0$fc77dfe0$@prosentient.com.au> Message-ID: hi David oops, i forgot to unable this for 'master' branch you can track the updates here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 perhaps, we can arrange for an automated PUSH to the koha.git repo, for this? On 2/02/23 6:38 pm, David Cook wrote: > For some reason, I don't have a copy of Mason's original email about this so replying to Katrin's email... > > It looks like the "master" branch still has an out-of-date debian/control file. When should that get updated? > > Bumped into this when testing "Bug 32609 - Remove compiled files from src" > > David Cook > Senior Software Engineer > Prosentient Systems > Suite 7.03 > 6a Glen St > Milsons Point NSW 2061 > Australia > > Office: 02 9212 0899 > Online: 02 8005 0595 > > -----Original Message----- > From: Koha-devel On Behalf Of Katrin Fischer > Sent: Saturday, 21 January 2023 6:42 AM > To: koha-devel at lists.koha-community.org > Subject: Re: [Koha-devel] debian/control file updates are automated > > I've updated the wiki page for Release Maintenance: > > https://wiki.koha-community.org/wiki/Release_maintenance#Daily_maintenance_workflow > > Please feel free to improve :) > > Katrin > > On 19.01.23 06:49, Mason James wrote: >> On 18/01/23 2:22 pm, David Cook wrote: >>> Hi all, >>> >>> I already talked to Aleisha about this on IRC, but I figured I'd >>> mention it here too. >>> >>> I emailed last week with a subject line of "debian/control out of >>> date in master". That's what caused the problem that Aleisha >>> mentioned below. >>> >>> I resolved the issue by stealing the control file out of the 22.11.01 >>> Debian packages and sticking that into my local git. >>> >>> But we need to update the master and at least the 22.11.x branch. The >>> 22.11.02 tag should also have an updated control file. >>> >>> I imagine as the year goes on, more people are going to try to build >>> 22.11 and run into this same problem due to the outdated >>> debian/control file... >> >> hi all >> we now have some BZ bugs, that track the d/control file updates >> >> after a debian package is generated, the new changes are automatically >> uploaded to the bug >> >> 22.11 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32666 >> >> 22.05 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 >> >> 21.11 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 >> >> 21.05 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32669 >> >> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : https://www.koha-community.org/ git : >> https://git.koha-community.org/ bugs : >> https://bugs.koha-community.org/ > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/ > From dcook at prosentient.com.au Fri Feb 3 03:26:43 2023 From: dcook at prosentient.com.au (David Cook) Date: Fri, 3 Feb 2023 13:26:43 +1100 Subject: [Koha-devel] debian/control file updates are automated In-Reply-To: References: <26fcdff8-e5ab-9c7e-2acb-66a331310671@catalyst.net.nz> <028e01d92adb$59912870$0cb37950$@prosentient.com.au> <9a26fe5f-09ef-33eb-79e6-da44ed8af5d5@kohaaloha.com> <7a434405-7e90-bf8c-ff78-139d47a6ad1c@web.de> <0a9901d936c8$a97d4aa0$fc77dfe0$@prosentient.com.au> Message-ID: <00c601d93776$fac7ffa0$f057fee0$@prosentient.com.au> Sounds good to me. Thanks, Mason 😊 David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Mason James Sent: Friday, 3 February 2023 1:24 PM To: David Cook ; koha-devel at lists.koha-community.org Subject: Re: [Koha-devel] debian/control file updates are automated hi David oops, i forgot to unable this for 'master' branch you can track the updates here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32809 perhaps, we can arrange for an automated PUSH to the koha.git repo, for this? On 2/02/23 6:38 pm, David Cook wrote: > For some reason, I don't have a copy of Mason's original email about this so replying to Katrin's email... > > It looks like the "master" branch still has an out-of-date debian/control file. When should that get updated? > > Bumped into this when testing "Bug 32609 - Remove compiled files from src" > > David Cook > Senior Software Engineer > Prosentient Systems > Suite 7.03 > 6a Glen St > Milsons Point NSW 2061 > Australia > > Office: 02 9212 0899 > Online: 02 8005 0595 > > -----Original Message----- > From: Koha-devel On > Behalf Of Katrin Fischer > Sent: Saturday, 21 January 2023 6:42 AM > To: koha-devel at lists.koha-community.org > Subject: Re: [Koha-devel] debian/control file updates are automated > > I've updated the wiki page for Release Maintenance: > > https://wiki.koha-community.org/wiki/Release_maintenance#Daily_mainten > ance_workflow > > Please feel free to improve :) > > Katrin > > On 19.01.23 06:49, Mason James wrote: >> On 18/01/23 2:22 pm, David Cook wrote: >>> Hi all, >>> >>> I already talked to Aleisha about this on IRC, but I figured I'd >>> mention it here too. >>> >>> I emailed last week with a subject line of "debian/control out of >>> date in master". That's what caused the problem that Aleisha >>> mentioned below. >>> >>> I resolved the issue by stealing the control file out of the >>> 22.11.01 Debian packages and sticking that into my local git. >>> >>> But we need to update the master and at least the 22.11.x branch. >>> The >>> 22.11.02 tag should also have an updated control file. >>> >>> I imagine as the year goes on, more people are going to try to build >>> 22.11 and run into this same problem due to the outdated >>> debian/control file... >> >> hi all >> we now have some BZ bugs, that track the d/control file updates >> >> after a debian package is generated, the new changes are >> automatically uploaded to the bug >> >> 22.11 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32666 >> >> 22.05 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32667 >> >> 21.11 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 >> >> 21.05 >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32669 >> >> >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel at lists.koha-community.org >> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : https://www.koha-community.org/ git : >> https://git.koha-community.org/ bugs : >> https://bugs.koha-community.org/ > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ git : > https://git.koha-community.org/ bugs : > https://bugs.koha-community.org/ > From jonathan.druart at bugs.koha-community.org Tue Feb 7 14:30:06 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Tue, 7 Feb 2023 14:30:06 +0100 Subject: [Koha-devel] koha-testing-docker is now installing pre-commit git hooks Message-ID: Hi, We have a pre-commit hook in the wiki but people forget to install it. And it was not easy to update and propagate the changes. We decided to embed it in koha-testing-docker and install it automatically. So if you see a message telling you your commit is missing something, don't ignore it ;) Note that you can force the commit with --no-verify. It's working inside and outside a ktd shell. Cheers, Jonathan original issue in misc4dev which was then moved to ktd: https://gitlab.com/koha-community/koha-misc4dev/-/issues/59 https://gitlab.com/koha-community/koha-testing-docker/-/issues/347 -------------- next part -------------- An HTML attachment was scrubbed... URL: From tomascohen at gmail.com Tue Feb 7 19:12:32 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Tue, 7 Feb 2023 15:12:32 -0300 Subject: [Koha-devel] koha-testing-docker is now installing pre-commit git hooks In-Reply-To: References: Message-ID: Excellent, thanks Jonathan. El mar, 7 feb 2023 a las 10:31, Jonathan Druart (< jonathan.druart at bugs.koha-community.org>) escribió: > Hi, > > We have a pre-commit hook in the wiki but people forget to install it. And > it was not easy to update and propagate the changes. We decided to embed it > in koha-testing-docker and install it automatically. > > So if you see a message telling you your commit is missing something, > don't ignore it ;) > > Note that you can force the commit with --no-verify. > > It's working inside and outside a ktd shell. > > Cheers, > Jonathan > > original issue in misc4dev which was then moved to ktd: > https://gitlab.com/koha-community/koha-misc4dev/-/issues/59 > https://gitlab.com/koha-community/koha-testing-docker/-/issues/347 > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Fri Feb 10 01:51:24 2023 From: dcook at prosentient.com.au (David Cook) Date: Fri, 10 Feb 2023 11:51:24 +1100 Subject: [Koha-devel] Automatically managing generated configuration files like log4perl.conf Message-ID: <05bb01d93ce9$ccde7d80$669b7880$@prosentient.com.au> Hey all, Updating configuration files like log4perl.conf can be really painful. Surely, there has to be a better way? Jonathan and I talk a bit about this on "Bug 32791 - Log4perl configuration files need a tool for updating on package upgrade". My first draft uses a bespoke tool, but this morning I learned about the "ucf" utility, which was designed to manage dynamically generated configuration in a similar way to how we manage configuration files packaged in koha-common! If the installed file hasn't been manually updated locally, it will be replaced with the newest generated version. If the installed file has been changed, then the user will be prompted with some options about installing the package version, retaining the local version, viewing a diff of the two files, or even doing a 3 way merge. I think 99.9% of cases will show a lot of these files never get locally changed, so it would just automagically provide updated configuration. And for that 0.1% of cases where the sysadmin has updated the configuration, they'd have a familiar industry standard UI to work with. I'm happy to provide a patch, but I'd like to get some more feedback first. I think it would work very well for log4perl, and it could be useful for other configuration files too. (The only danger I see is when you have a large number of instances with local changes, and you get bogged down with the UI. But there are some ENV variables that can be used to auto-choose which version to install. The utility leaves behind files with extensions like ".ucf-dist" and ".ucf-old" as well so you can always go back and fix up your conf after the fact manually.) Anyway, food for thought! David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: From tomascohen at gmail.com Fri Feb 10 15:59:27 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Fri, 10 Feb 2023 11:59:27 -0300 Subject: [Koha-devel] Compiled files removal from source tree Message-ID: Hi all, there's been chatter and work about this subject in the last weeks. This is something we postponed until after the 22.11 release, which includes Vue files and forced us to rethink our build pipeline. Today we've done two important things you need to be aware of: * Compiled CSS and JS files of all sorts removed from the tree [1] * misc4dev (hence KTD) will now recomplile things for you when you start KTD or when you run `reset_all` [2] >From now on, you will be able to run `yarn build` and all the things will be built as required. Feel free to inspect the package.json file for more fine-grained commands that have been added. Particularly, you might find the *watch commands useful if you are developing. And there are *prod commands that will be used by the release maintainers and packaging manager. Any enhancements you might want to propose are welcome. Kudos to Jonathan, David Cook, Martin and Mason for the great work they did. [1] https://gitlab.com/joubu/Koha/-/commits/bug_32609 [2] https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/58 -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Mon Feb 13 00:31:57 2023 From: dcook at prosentient.com.au (David Cook) Date: Mon, 13 Feb 2023 10:31:57 +1100 Subject: [Koha-devel] Fixing perltidy in ktd Message-ID: <067401d93f3a$3f980240$bec806c0$@prosentient.com.au> Hi Tomas, I saw you, Katrin, and Jonathan writing in #koha about perltidy. When I've tried previously to perltidy in ktd using the ":Tidy" command, it seemed to change the style to something incompatible with https://wiki.koha-community.org/wiki/Coding_Guidelines If I type "vi Koha.pm", then ":echo $MYVIMRC", it tells me I'm using the /root/.vimrc file. I'm not overwriting that, so it's the default file that ships with ktd. I don't have a good example off the top of my head though. I've just tried perltidying debian/scripts/koha-log4perl from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791. There are things that look weird to me but after reviewing the coding guidelines, maybe I've been wrong all this time. For example: - my $snippet = get_snippet({ - instance => $instance, - component => $component, - }); - if ($snippet){ + my $snippet = get_snippet( + { + instance => $instance, + component => $component, + } + ); I always thought we preferred to keep the brackets on the same line (like in all the JS examples on the wiki). It looks like perltidy sometimes mangles the whitespace for comments as well. I'd correctly indented a comment and then perltidy stripped all the whitespace except for 2 leading spaces. That all said. overall it probably does look better, so maybe the out of the box perltidy is good enough, and if the same perltidy file is applied across the board I suppose it doesn't matter. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Mon Feb 13 03:01:47 2023 From: dcook at prosentient.com.au (David Cook) Date: Mon, 13 Feb 2023 13:01:47 +1100 Subject: [Koha-devel] Using "ucf" to manage log4perl.conf Message-ID: <06aa01d93f4f$321518f0$963f4ad0$@prosentient.com.au> Hi all, I've attached an "alternative" patch on "Bug 32791 - Log4perl configuration files need a tool for updating on package upgrade". It uses the utility "ucf" to manage log4perl.conf. It works well for handling upgrades to log4perl.conf configuration, but it needs more testing and some more consideration for koha-create, koha-remove, and apt-get purge. Is anyone else interested in working on this with me? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: From kohanews at gmail.com Mon Feb 13 08:40:37 2023 From: kohanews at gmail.com (Koha Newsletter) Date: Mon, 13 Feb 2023 08:40:37 +0100 Subject: [Koha-devel] Call for news - Newsletter February 2023 Message-ID: Hi I'm collecting news for the February 2023 Koha Community Newsletter. Please send anything noteworthy to: kohanews (at) gmail (dot) com News criteria: * News items can be of any length. * Images are fine. * Anything and everything Koha. * Submit by the 26th of the month. Text format criteria: * Just structured plain text, or * HTML text to include tables or similar For events: * Consider adding your event to the Koha Community calendar at https://koha-community.org/calendar/ Thank you! Michael Kuhn Editor, Koha Community Newsletter -------------- next part -------------- An HTML attachment was scrubbed... URL: From kyle.m.hall at gmail.com Mon Feb 13 15:10:32 2023 From: kyle.m.hall at gmail.com (Kyle Hall) Date: Mon, 13 Feb 2023 09:10:32 -0500 Subject: [Koha-devel] Fixing perltidy in ktd In-Reply-To: <067401d93f3a$3f980240$bec806c0$@prosentient.com.au> References: <067401d93f3a$3f980240$bec806c0$@prosentient.com.au> Message-ID: I believe we use the default perltidy settings ( https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy ). I'm not aware of KTD having an installed perltidyrc ( there is one in git in xt that's been in there since 2008 presumably unused ). Kyle --- http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) On Sun, Feb 12, 2023 at 6:32 PM David Cook wrote: > Hi Tomas, > > > > I saw you, Katrin, and Jonathan writing in #koha about perltidy. When I’ve > tried previously to perltidy in ktd using the “:Tidy” command, it seemed to > change the style to something incompatible with > https://wiki.koha-community.org/wiki/Coding_Guidelines > > > > If I type “vi Koha.pm”, then “:echo $MYVIMRC”, it tells me I’m using the > /root/.vimrc file. I’m not overwriting that, so it’s the default file that > ships with ktd. > > > > I don’t have a good example off the top of my head though. > > > > I’ve just tried perltidying debian/scripts/koha-log4perl from > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791. There > are things that look weird to me but after reviewing the coding guidelines, > maybe I’ve been wrong all this time. > > > > For example: > > > > - my $snippet = get_snippet({ > > - instance => $instance, > > - component => $component, > > - }); > > - if ($snippet){ > > + my $snippet = get_snippet( > > + { > > + instance => $instance, > > + component => $component, > > + } > > + ); > > > > I always thought we preferred to keep the brackets on the same line (like > in all the JS examples on the wiki). > > > > It looks like perltidy sometimes mangles the whitespace for comments as > well. I’d correctly indented a comment and then perltidy stripped all the > whitespace except for 2 leading spaces. > > > > That all said… overall it probably does look better, so maybe the out of > the box perltidy is good enough, and if the same perltidy file is applied > across the board I suppose it doesn’t matter… > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From trmurakami at gmail.com Mon Feb 13 19:24:09 2023 From: trmurakami at gmail.com (Tiago Murakami) Date: Mon, 13 Feb 2023 15:24:09 -0300 Subject: [Koha-devel] Permissions on Pootle Message-ID: Hi, I´m a librarian in Brazil. I had Pootle permissions for translation, but, I only have them for suggestions. What is the best way to ask for permission to translate Pootle in pt-BR? Thanks in advance, -- Tiago Murakami -------------- next part -------------- An HTML attachment was scrubbed... URL: From katrin.fischer.83 at web.de Mon Feb 13 20:24:07 2023 From: katrin.fischer.83 at web.de (Katrin Fischer) Date: Mon, 13 Feb 2023 20:24:07 +0100 Subject: [Koha-devel] Permissions on Pootle In-Reply-To: References: Message-ID: <48d83df8-ff3d-7603-033d-425335994b9b@web.de> Hi Tiago, we had a change/correction to the permission system a while ago. I have made you part of the pt-BR translation team now. You should be able to submit translations. Katrin On 13.02.23 19:24, Tiago Murakami wrote: > Hi, > > I´m a librarian in Brazil. I had Pootle permissions for translation, > but, I only have them for suggestions. What is the best way to ask for > permission to translate Pootle in pt-BR? > > Thanks in advance, > > -- > Tiago Murakami > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website :https://www.koha-community.org/ > git :https://git.koha-community.org/ > bugs :https://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From mtj at kohaaloha.com Tue Feb 14 03:40:30 2023 From: mtj at kohaaloha.com (Mason James) Date: Tue, 14 Feb 2023 15:40:30 +1300 Subject: [Koha-devel] Fixing perltidy in ktd In-Reply-To: References: <067401d93f3a$3f980240$bec806c0$@prosentient.com.au> Message-ID: <43c4ca1f-1f13-ae31-36dc-baa5c62dcd7e@kohaaloha.com> hi David, i ran perltidy -nopro on debian/scripts/koha-log4perl the brackets and whitespace changes look 'as expected' to me... https://git.kohaaloha.com/?p=ktd_koha/.git;a=commit;h=c3324709c9c86e8241b7010e99e6628ac9677345 https://git.kohaaloha.com/?p=ktd_koha/.git;a=commitdiff;h=c3324709c9c86e8241b7010e99e6628ac9677345;hp=a0fa46cb48e400e141156b42377e5a0b303fe98f as Kyle said, we decided to use the 'default' style of perltidy this can be forced using 'perltidy -nopro', to override any .perltidyrc found in $PATH xt/perltidyrc was added before a style was decided on, so was only a suggestion - perhaps we remove it too as its incorrect/confusing? On 14/02/23 3:10 am, Kyle Hall wrote: > I believe we use the default perltidy settings ( https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy ). I'm not aware of KTD having an installed perltidyrc ( there is one in git in xt that's been in there since 2008 presumably unused ). > > Kyle > > --- > http://www.kylehall.info > ByWater Solutions ( http://bywatersolutions.com ) > Meadville Public Library ( http://www.meadvillelibrary.org ) > Crawford County Federated Library System ( http://www.ccfls.org ) > > > On Sun, Feb 12, 2023 at 6:32 PM David Cook > wrote: > > Hi Tomas,____ > > __ __ > > I saw you, Katrin, and Jonathan writing in #koha about perltidy. When I’ve tried previously to perltidy in ktd using the “:Tidy” command, it seemed to change the style to something incompatible with https://wiki.koha-community.org/wiki/Coding_Guidelines ____ > > __ __ > > If I type “vi Koha.pm”, then “:echo $MYVIMRC”, it tells me I’m using the /root/.vimrc file. I’m not overwriting that, so it’s the default file that ships with ktd.____ > > __ __ > > I don’t have a good example off the top of my head though. ____ > > __ __ > > I’ve just tried perltidying debian/scripts/koha-log4perl from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32791 . There are things that look weird to me but after reviewing the coding guidelines, maybe I’ve been wrong all this time.____ > > __ __ > > For example:____ > > __ __ > > -                my $snippet = get_snippet({____ > > -                    instance => $instance,____ > > -                    component => $component,____ > > -                });____ > > -                if ($snippet){____ > > +                my $snippet = get_snippet(____ > > +                    {____ > > +                        instance  => $instance,____ > > +                        component => $component,____ > > +                    }____ > > +                );____ > > __ __ > > I always thought we preferred to keep the brackets on the same line (like in all the JS examples on the wiki). ____ > > __ __ > > It looks like perltidy sometimes mangles the whitespace for comments as well. I’d correctly indented a comment and then perltidy stripped all the whitespace except for 2 leading spaces. ____ > > __ __ > > That all said… overall it probably does look better, so maybe the out of the box perltidy is good enough, and if the same perltidy file is applied across the board I suppose it doesn’t matter…____ > > __ __ > > David Cook____ > > Senior Software Engineer____ > > Prosentient Systems____ > > Suite 7.03____ > > 6a Glen St____ > > Milsons Point NSW 2061____ > > Australia____ > > __ __ > > Office: 02 9212 0899____ > > Online: 02 8005 0595____ > > __ __ > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ From fridolin.somers at biblibre.com Tue Feb 14 08:01:53 2023 From: fridolin.somers at biblibre.com (Fridolin SOMERS) Date: Mon, 13 Feb 2023 21:01:53 -1000 Subject: [Koha-devel] koha-testing-docker is now installing pre-commit git hooks In-Reply-To: References: Message-ID: Great :D GIT is such an amazing tool +++ Le 07/02/2023 à 08:12, Tomas Cohen Arazi a écrit : > Excellent, thanks Jonathan. > > El mar, 7 feb 2023 a las 10:31, Jonathan Druart > ( >) escribió: > > Hi, > > We have a pre-commit hook in the wiki but people forget to install > it. And it was not easy to update and propagate the changes. We > decided to embed it in koha-testing-docker and install it automatically. > > So if you see a message telling you your commit is missing > something, don't ignore it ;) > > Note that you can force the commit with --no-verify. > > It's working inside and outside a ktd shell. > > Cheers, > Jonathan > > original issue in misc4dev which was then moved to ktd: > https://gitlab.com/koha-community/koha-misc4dev/-/issues/59 > > https://gitlab.com/koha-community/koha-testing-docker/-/issues/347 > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > > website : https://www.koha-community.org/ > > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > > > > > -- > Tomás Cohen Arazi > Theke Solutions (http://theke.io ) > ✆ +54 9351 3513384 > GPG: B2F3C15F > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ -- Fridolin SOMERS Software and system maintainer 🦄 BibLibre, France From mtj at kohaaloha.com Wed Feb 15 08:04:45 2023 From: mtj at kohaaloha.com (Mason James) Date: Wed, 15 Feb 2023 20:04:45 +1300 Subject: [Koha-devel] Using "ucf" to manage log4perl.conf In-Reply-To: <06aa01d93f4f$321518f0$963f4ad0$@prosentient.com.au> References: <06aa01d93f4f$321518f0$963f4ad0$@prosentient.com.au> Message-ID: <6425d478-1404-5287-bbc7-ac5fb4665702@kohaaloha.com> On 13/02/23 3:01 pm, David Cook wrote: > Hi all, > > I’ve attached an “alternative” patch on “Bug 32791 - Log4perl configuration files need a tool for updating on package upgrade”. > > It uses the utility “ucf” to manage log4perl.conf. > > It works well for handling upgrades to log4perl.conf configuration, but it needs more testing and some more consideration for koha-create, koha-remove, and apt-get purge. > > Is anyone else interested in working on this with me? hi David i'm keen to help with this one :) From tomascohen at gmail.com Wed Feb 15 11:57:02 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Wed, 15 Feb 2023 07:57:02 -0300 Subject: [Koha-devel] KTD and (Linux) Docker Desktop issues Message-ID: Hi all, community members have reported permissions issues breaking ktd initialization when launching it fresh. It's been narrowed down to be an issue with the Docker Desktop for Linux product. Please use the Docker Engine/server install instructions as pointed by the readme. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Wed Feb 15 14:09:35 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Wed, 15 Feb 2023 14:09:35 +0100 Subject: [Koha-devel] Vue improvements/refactorings Message-ID: Hi, Pedro and I have been working on improving the way we request the Koha REST API from Vue components. We ended up with the implementation that is available on the following remote branch: https://gitlab.com/joubu/Koha/-/commits/bug_32925 It contains the patches from the following bug reports: *Bug 32898* - Cypress tests are failing *Bug 32923* - x-koha-embed must a header of collectionFormat csv *Bug 32806* - Some Vue files need to be moved for better reusability *Bug 32939* - Have generic fetch functions in vue modules *Bug 32925* - Display loading info when a form is submitted First, make the tests pass (32898)! We forgot to include the cypress test in the jenkins pipeline and we missed regressions! There have been regressions on the REST API specs, that are fixed on 32923. We noticed that the code we provided for the ERM module was not flexible enough and too ERM oriented. Some directories have been moved and code split a bit to make it more reusable for other modules (32806). Finally there are 32939 that introduce generic fetch functions, to have all the error handling (catch exceptions and display the error on the UI) in a single place. On top of that we added a "loading" message when a form (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only a couple of lines of code! All this must be considered a base for future Vue enhancements, and I would like people interested in the Vue work to have a look at it. Cheers, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: From pedro.amorim at ptfs-europe.com Wed Feb 15 14:17:30 2023 From: pedro.amorim at ptfs-europe.com (Amorim, Pedro) Date: Wed, 15 Feb 2023 12:17:30 -0100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: References: Message-ID: Thanks for involving me in this work Jonathan. To be clear, my contribution was very light compared to the work Jonathan did and is doing. I'm very excited to have all of this in master and see what's next for Vue in Koha. Pedro Amorim Software Engineer E: pedro.amorim at ptfs-europe.com www.ptfs-europe.com On Wed, 15 Feb 2023 at 12:09, Jonathan Druart < jonathan.druart at bugs.koha-community.org> wrote: > Hi, > > Pedro and I have been working on improving the way we request the Koha > REST API from Vue components. > We ended up with the implementation that is available on the following > remote branch: > https://gitlab.com/joubu/Koha/-/commits/bug_32925 > > It contains the patches from the following bug reports: > *Bug 32898* > - Cypress > tests are failing > *Bug 32923* > - x-koha-embed > must a header of collectionFormat csv > *Bug 32806* > - Some > Vue files need to be moved for better reusability > *Bug 32939* > - Have > generic fetch functions in vue modules > *Bug 32925* > - Display > loading info when a form is submitted > > First, make the tests pass (32898)! We forgot to include the cypress test > in the jenkins pipeline and we missed regressions! There have been > regressions on the REST API specs, that are fixed on 32923. > We noticed that the code we provided for the ERM module was not flexible > enough and too ERM oriented. Some directories have been moved and code > split a bit to make it more reusable for other modules (32806). > Finally there are 32939 that introduce generic fetch functions, to have > all the error handling (catch exceptions and display the error on the UI) > in a single place. On top of that we added a "loading" message when a form > (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only > a couple of lines of code! > > All this must be considered a base for future Vue enhancements, and I > would like people interested in the Vue work to have a look at it. > > Cheers, > Jonathan > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From tomascohen at gmail.com Wed Feb 15 20:27:29 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Wed, 15 Feb 2023 16:27:29 -0300 Subject: [Koha-devel] CI and packaging Message-ID: Hi all, we've been talking for a while by different means (IRC, pm, hackfests, etc) about the need to build a solid pipeline for our testing infrastructure, package building and testing and also the docker images. Several individuals have implemented different things over time, for building the packages. Today we had a nice Zoom session with Kyle, and this is the result of picking the best ideas from each thing we found: https://gitlab.com/koha-community/koha-dpkg-docker We are still working on the README, but basically, with: - Docker - A Koha clone - An environment variable passed we can build the Debian packages. I think this is a great achievement and kudos to Kyle for his contribution. Thanks Kyle! Now to integrate it! -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Wed Feb 15 23:18:40 2023 From: dcook at prosentient.com.au (David Cook) Date: Thu, 16 Feb 2023 09:18:40 +1100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: References: Message-ID: <019901d9418b$75a334b0$60e99e10$@prosentient.com.au> I’ve started playing more with Vue for some other projects, so I wouldn’t mind taking a look. Is there anything particular you want us to look at with these patches? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel On Behalf Of Jonathan Druart Sent: Thursday, 16 February 2023 12:10 AM To: koha-devel Subject: [Koha-devel] Vue improvements/refactorings Hi, Pedro and I have been working on improving the way we request the Koha REST API from Vue components. We ended up with the implementation that is available on the following remote branch: https://gitlab.com/joubu/Koha/-/commits/bug_32925 It contains the patches from the following bug reports: Bug 32898 - Cypress tests are failing Bug 32923 - x-koha-embed must a header of collectionFormat csv Bug 32806 - Some Vue files need to be moved for better reusability Bug 32939 - Have generic fetch functions in vue modules Bug 32925 - Display loading info when a form is submitted First, make the tests pass (32898)! We forgot to include the cypress test in the jenkins pipeline and we missed regressions! There have been regressions on the REST API specs, that are fixed on 32923. We noticed that the code we provided for the ERM module was not flexible enough and too ERM oriented. Some directories have been moved and code split a bit to make it more reusable for other modules (32806). Finally there are 32939 that introduce generic fetch functions, to have all the error handling (catch exceptions and display the error on the UI) in a single place. On top of that we added a "loading" message when a form (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only a couple of lines of code! All this must be considered a base for future Vue enhancements, and I would like people interested in the Vue work to have a look at it. Cheers, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Thu Feb 16 08:41:07 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Thu, 16 Feb 2023 08:41:07 +0100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: <019901d9418b$75a334b0$60e99e10$@prosentient.com.au> References: <019901d9418b$75a334b0$60e99e10$@prosentient.com.au> Message-ID: Bug 32806 modifies the directory structure and how Vue files are organised. Bug 32939 is centralising the way we request the Koha REST API by having a single place where the fetch is made. I want people to be aware of these changes, and see them agree (or disagree and provide follow-ups) quickly. There are many changes to build on top of that, and we don't want to provide them before getting the suggestion approved. Le mer. 15 févr. 2023 à 23:18, David Cook a écrit : > I’ve started playing more with Vue for some other projects, so I wouldn’t > mind taking a look. > > > > Is there anything particular you want us to look at with these patches? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Koha-devel *On > Behalf Of *Jonathan Druart > *Sent:* Thursday, 16 February 2023 12:10 AM > *To:* koha-devel > *Subject:* [Koha-devel] Vue improvements/refactorings > > > > Hi, > > > > Pedro and I have been working on improving the way we request the Koha > REST API from Vue components. > > We ended up with the implementation that is available on the following > remote branch: > > https://gitlab.com/joubu/Koha/-/commits/bug_32925 > > > > It contains the patches from the following bug reports: > > *Bug 32898* > - > Cypress tests are failing > > *Bug 32923* > - > x-koha-embed must a header of collectionFormat csv > > *Bug 32806* > - Some > Vue files need to be moved for better reusability > > *Bug 32939* > - Have > generic fetch functions in vue modules > > *Bug 32925* > - > Display loading info when a form is submitted > > > > First, make the tests pass (32898)! We forgot to include the cypress test > in the jenkins pipeline and we missed regressions! There have been > regressions on the REST API specs, that are fixed on 32923. > > We noticed that the code we provided for the ERM module was not flexible > enough and too ERM oriented. Some directories have been moved and code > split a bit to make it more reusable for other modules (32806). > > Finally there are 32939 that introduce generic fetch functions, to have > all the error handling (catch exceptions and display the error on the UI) > in a single place. On top of that we added a "loading" message when a form > (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only > a couple of lines of code! > > > > All this must be considered a base for future Vue enhancements, and I > would like people interested in the Vue work to have a look at it. > > > > Cheers, > > Jonathan > -------------- next part -------------- An HTML attachment was scrubbed... URL: From M.de.Rooy at rijksmuseum.nl Thu Feb 16 10:28:43 2023 From: M.de.Rooy at rijksmuseum.nl (Marcel de Rooy) Date: Thu, 16 Feb 2023 09:28:43 +0000 Subject: [Koha-devel] Compiled files removal from source tree In-Reply-To: References: Message-ID: Thx Tomas. Whats the plan for stable, oldstable, etc ? Marcel ________________________________ Van: Koha-devel namens Tomas Cohen Arazi Verzonden: vrijdag 10 februari 2023 15:59 Aan: koha-devel Onderwerp: [Koha-devel] Compiled files removal from source tree Hi all, there's been chatter and work about this subject in the last weeks. This is something we postponed until after the 22.11 release, which includes Vue files and forced us to rethink our build pipeline. Today we've done two important things you need to be aware of: * Compiled CSS and JS files of all sorts removed from the tree [1] * misc4dev (hence KTD) will now recomplile things for you when you start KTD or when you run `reset_all` [2] From now on, you will be able to run `yarn build` and all the things will be built as required. Feel free to inspect the package.json file for more fine-grained commands that have been added. Particularly, you might find the *watch commands useful if you are developing. And there are *prod commands that will be used by the release maintainers and packaging manager. Any enhancements you might want to propose are welcome. Kudos to Jonathan, David Cook, Martin and Mason for the great work they did. [1] https://gitlab.com/joubu/Koha/-/commits/bug_32609 [2] https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/58 -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From martin.renvoize at ptfs-europe.com Thu Feb 16 11:34:38 2023 From: martin.renvoize at ptfs-europe.com (Renvoize, Martin) Date: Thu, 16 Feb 2023 10:34:38 +0000 Subject: [Koha-devel] Compiled files removal from source tree In-Reply-To: References: Message-ID: At the moment, we've marked this as an enhancement and not backported to stable. I'm still somewhat on the fence, playing it safe and not backporting. We were already only building css and vue at release times on the stable branch with this new approach in mind. I believe the older branches are continuing to build css as required per patch they backport. Martin Martin Renvoize, MPhys (Hons) Head of Development and Community Engagement E: martin.renvoize at ptfs-europe.com P: +44 (0) 1483 378728 M: +44 (0) 7725 985636 www.ptfs-europe.com On Thu, 16 Feb 2023 at 09:28, Marcel de Rooy wrote: > Thx Tomas. > Whats the plan for stable, oldstable, etc ? > > Marcel > ------------------------------ > *Van:* Koha-devel namens > Tomas Cohen Arazi > *Verzonden:* vrijdag 10 februari 2023 15:59 > *Aan:* koha-devel > *Onderwerp:* [Koha-devel] Compiled files removal from source tree > > Hi all, there's been chatter and work about this subject in the last > weeks. This is something we postponed until after the 22.11 release, which > includes Vue files and forced us to rethink our build pipeline. > > Today we've done two important things you need to be aware of: > * Compiled CSS and JS files of all sorts removed from the tree [1] > * misc4dev (hence KTD) will now recomplile things for you when you start > KTD or when you run `reset_all` [2] > > From now on, you will be able to run `yarn build` and all the things will > be built as required. Feel free to inspect the package.json file for more > fine-grained commands that have been added. Particularly, you might find > the *watch commands useful if you are developing. And there are *prod > commands that will be used by the release maintainers and packaging manager. > > Any enhancements you might want to propose are welcome. > > Kudos to Jonathan, David Cook, Martin and Mason for the great work they > did. > > [1] https://gitlab.com/joubu/Koha/-/commits/bug_32609 > > [2] https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/58 > > > > -- > Tomás Cohen Arazi > Theke Solutions (http://theke.io > > ) > ✆ +54 9351 3513384 > GPG: B2F3C15F > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Tue Feb 21 07:08:45 2023 From: dcook at prosentient.com.au (David Cook) Date: Tue, 21 Feb 2023 17:08:45 +1100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: References: <019901d9418b$75a334b0$60e99e10$@prosentient.com.au> Message-ID: <027401d945ba$fbb9ed40$f32dc7c0$@prosentient.com.au> I’ve spent the past few days working with Vue.js on a different app, so it’s certainly on my mind, but I’ve also had a build up of tasks. I took a look at “routes.js” for https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html &bug=32806&attachment=146664 and all the import statements looked a bit cumbersome. I quizzed ChatGPT earlier about my design for the different app, and was impressed with what it had to say. My prompt: “With Vue.js 3, is there an easy way to import multiple components without having to specify each one separately?” ChatGPT: It gave some explanatory text and the following code: import { defineAsyncComponent } from 'vue'; const components = [ 'MyComponent1', 'MyComponent2', 'MyComponent3', ]; const asyncComponents = components.map(name => defineAsyncComponent(() => import(`@/components/${name}.vue`))); export default { components: { ...asyncComponents.reduce((obj, component, index) => { obj[components[index]] = component; return obj; }, {}), }, }; I haven’t looked enough at Koha’s Vue.js code for ERM, but doing something along those lines could reduce the copy/paste text from routes.js. Anyway, I have to run, but I thought you might find that interesting. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel On Behalf Of Jonathan Druart Sent: Thursday, 16 February 2023 6:41 PM To: koha-devel Subject: Re: [Koha-devel] Vue improvements/refactorings Bug 32806 modifies the directory structure and how Vue files are organised. Bug 32939 is centralising the way we request the Koha REST API by having a single place where the fetch is made. I want people to be aware of these changes, and see them agree (or disagree and provide follow-ups) quickly. There are many changes to build on top of that, and we don't want to provide them before getting the suggestion approved. Le mer. 15 févr. 2023 à 23:18, David Cook > a écrit : I’ve started playing more with Vue for some other projects, so I wouldn’t mind taking a look. Is there anything particular you want us to look at with these patches? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel > On Behalf Of Jonathan Druart Sent: Thursday, 16 February 2023 12:10 AM To: koha-devel > Subject: [Koha-devel] Vue improvements/refactorings Hi, Pedro and I have been working on improving the way we request the Koha REST API from Vue components. We ended up with the implementation that is available on the following remote branch: https://gitlab.com/joubu/Koha/-/commits/bug_32925 It contains the patches from the following bug reports: Bug 32898 - Cypress tests are failing Bug 32923 - x-koha-embed must a header of collectionFormat csv Bug 32806 - Some Vue files need to be moved for better reusability Bug 32939 - Have generic fetch functions in vue modules Bug 32925 - Display loading info when a form is submitted First, make the tests pass (32898)! We forgot to include the cypress test in the jenkins pipeline and we missed regressions! There have been regressions on the REST API specs, that are fixed on 32923. We noticed that the code we provided for the ERM module was not flexible enough and too ERM oriented. Some directories have been moved and code split a bit to make it more reusable for other modules (32806). Finally there are 32939 that introduce generic fetch functions, to have all the error handling (catch exceptions and display the error on the UI) in a single place. On top of that we added a "loading" message when a form (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only a couple of lines of code! All this must be considered a base for future Vue enhancements, and I would like people interested in the Vue work to have a look at it. Cheers, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: From uzair.metro at gmail.com Tue Feb 21 10:52:50 2023 From: uzair.metro at gmail.com (Muhammad Uzair) Date: Tue, 21 Feb 2023 14:52:50 +0500 Subject: [Koha-devel] Login API for Authentication Message-ID: Dear Developers; I am currently developing a system for my university in which I want to connect users logged in oracle web applications with koha and directly authenticate users to koha from my system portal. For this purpose I want an API to directly send the user id and password to the server of Koha and skip the login screen. I have tried many APIs that were available but none did my work. My requirement is that the user logs in to the oracle portal once and does not need to login to koha again. He gets logged in to koha through api using static userid and password (which are available to me) and lands on the OPAC homepage in which they are already logged in. Kindly provide me with a valid API so that I can do my work easily or any possible solution. Regards -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Tue Feb 21 15:57:29 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Tue, 21 Feb 2023 15:57:29 +0100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: References: Message-ID: A quick update. There are several bug reports, and the tree is at https://gitlab.com/joubu/Koha/-/commits/bug_32991 It's ~40 commits on top of master, a lot of architecture changes in the erm/vue files. It would be great to have them pushed ASAP, they are blocking other works. Most important is that people will read, learn and copy the code that is in master, which will be obsolete (and generate conflicts) one this tree will be pushed. How can we coordinate to make it move forward? Who is willing to help here? Cheers, Jonathan Le mer. 15 févr. 2023 à 14:09, Jonathan Druart < jonathan.druart at bugs.koha-community.org> a écrit : > Hi, > > Pedro and I have been working on improving the way we request the Koha > REST API from Vue components. > We ended up with the implementation that is available on the following > remote branch: > https://gitlab.com/joubu/Koha/-/commits/bug_32925 > > It contains the patches from the following bug reports: > *Bug 32898* > - Cypress > tests are failing > *Bug 32923* > - x-koha-embed > must a header of collectionFormat csv > *Bug 32806* > - Some > Vue files need to be moved for better reusability > *Bug 32939* > - Have > generic fetch functions in vue modules > *Bug 32925* > - Display > loading info when a form is submitted > > First, make the tests pass (32898)! We forgot to include the cypress test > in the jenkins pipeline and we missed regressions! There have been > regressions on the REST API specs, that are fixed on 32923. > We noticed that the code we provided for the ERM module was not flexible > enough and too ERM oriented. Some directories have been moved and code > split a bit to make it more reusable for other modules (32806). > Finally there are 32939 that introduce generic fetch functions, to have > all the error handling (catch exceptions and display the error on the UI) > in a single place. On top of that we added a "loading" message when a form > (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only > a couple of lines of code! > > All this must be considered a base for future Vue enhancements, and I > would like people interested in the Vue work to have a look at it. > > Cheers, > Jonathan > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Tue Feb 21 16:03:49 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Tue, 21 Feb 2023 16:03:49 +0100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: <027401d945ba$fbb9ed40$f32dc7c0$@prosentient.com.au> References: <019901d9418b$75a334b0$60e99e10$@prosentient.com.au> <027401d945ba$fbb9ed40$f32dc7c0$@prosentient.com.au> Message-ID: Yes, David, we can lazy load the components. I have not considered it a high priority for now. I've opened a bug to keep track of the need bug 33024 (Lazy load the components in the routes definition) Le mar. 21 févr. 2023 à 07:08, David Cook a écrit : > I’ve spent the past few days working with Vue.js on a different app, so > it’s certainly on my mind, but I’ve also had a build up of tasks. > > > > I took a look at “routes.js” for > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32806&attachment=146664 > and all the import statements looked a bit cumbersome. > > > > I quizzed ChatGPT earlier about my design for the different app, and was > impressed with what it had to say. > > > > My prompt: “With Vue.js 3, is there an easy way to import multiple > components without having to specify each one separately?” > > > > ChatGPT: It gave some explanatory text and the following code: > > > > import { defineAsyncComponent } from 'vue'; > > > > const components = [ > > 'MyComponent1', > > 'MyComponent2', > > 'MyComponent3', > > ]; > > > > const asyncComponents = components.map(name => defineAsyncComponent(() => > import(`@/components/${name}.vue`))); > > > > export default { > > components: { > > ...asyncComponents.reduce((obj, component, index) => { > > obj[components[index]] = component; > > return obj; > > }, {}), > > }, > > }; > > > > I haven’t looked enough at Koha’s Vue.js code for ERM, but doing something > along those lines could reduce the copy/paste text from routes.js. > > > > Anyway, I have to run, but I thought you might find that interesting. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Koha-devel *On > Behalf Of *Jonathan Druart > *Sent:* Thursday, 16 February 2023 6:41 PM > *To:* koha-devel > *Subject:* Re: [Koha-devel] Vue improvements/refactorings > > > > Bug 32806 modifies the directory structure and how Vue files are organised. > > Bug 32939 is centralising the way we request the Koha REST API by having a > single place where the fetch is made. > > I want people to be aware of these changes, and see them agree (or > disagree and provide follow-ups) quickly. There are many changes to build > on top of that, and we don't want to provide them before getting the > suggestion approved. > > > > Le mer. 15 févr. 2023 à 23:18, David Cook a > écrit : > > I’ve started playing more with Vue for some other projects, so I wouldn’t > mind taking a look. > > > > Is there anything particular you want us to look at with these patches? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Koha-devel *On > Behalf Of *Jonathan Druart > *Sent:* Thursday, 16 February 2023 12:10 AM > *To:* koha-devel > *Subject:* [Koha-devel] Vue improvements/refactorings > > > > Hi, > > > > Pedro and I have been working on improving the way we request the Koha > REST API from Vue components. > > We ended up with the implementation that is available on the following > remote branch: > > https://gitlab.com/joubu/Koha/-/commits/bug_32925 > > > > It contains the patches from the following bug reports: > > *Bug 32898* > - > Cypress tests are failing > > *Bug 32923* > - > x-koha-embed must a header of collectionFormat csv > > *Bug 32806* > - Some > Vue files need to be moved for better reusability > > *Bug 32939* > - Have > generic fetch functions in vue modules > > *Bug 32925* > - > Display loading info when a form is submitted > > > > First, make the tests pass (32898)! We forgot to include the cypress test > in the jenkins pipeline and we missed regressions! There have been > regressions on the REST API specs, that are fixed on 32923. > > We noticed that the code we provided for the ERM module was not flexible > enough and too ERM oriented. Some directories have been moved and code > split a bit to make it more reusable for other modules (32806). > > Finally there are 32939 that introduce generic fetch functions, to have > all the error handling (catch exceptions and display the error on the UI) > in a single place. On top of that we added a "loading" message when a form > (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only > a couple of lines of code! > > > > All this must be considered a base for future Vue enhancements, and I > would like people interested in the Vue work to have a look at it. > > > > Cheers, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From michael.hafen at washk12.org Tue Feb 21 18:57:36 2023 From: michael.hafen at washk12.org (Michael Hafen) Date: Tue, 21 Feb 2023 10:57:36 -0700 Subject: [Koha-devel] Login API for Authentication In-Reply-To: References: Message-ID: Maybe the RESTBasicAuth or RESTOAuth2ClientCredentials System Preferences would be useful in this case, particularly the RESTBasicAuth System Preference (which is disabled on my install, is that the default setting?). I expect that the user's browser could establish an authenticated session with the Opac server using Basic Auth to a REST endpoint, and then access the Opac pages using that session. On Tue, Feb 21, 2023 at 2:52 AM Muhammad Uzair wrote: > Dear Developers; > I am currently developing a system for my university in which I want to > connect users logged in oracle web applications with koha and directly > authenticate users to koha from my system portal. > For this purpose I want an API to directly send the user id and password > to the server of Koha and skip the login screen. I have tried many APIs > that were available but none did my work. > My requirement is that the user logs in to the oracle portal once and does > not need to login to koha again. He gets logged in to koha through api > using static userid and password (which are available to me) and lands on > the OPAC homepage in which they are already logged in. > Kindly provide me with a valid API so that I can do my work easily or any > possible solution. > Regards > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -- Michael Hafen Washington County School District Technology Department Systems Analyst -------------- next part -------------- An HTML attachment was scrubbed... URL: From michael.hafen at washk12.org Tue Feb 21 19:08:59 2023 From: michael.hafen at washk12.org (Michael Hafen) Date: Tue, 21 Feb 2023 11:08:59 -0700 Subject: [Koha-devel] Something I learned about MySQL today Message-ID: I thought I'd share something I learned this morning about MySQL. The topic is using information in a table in the same query that is inserting that information into the table. Whenever I forget that MySQL doesn't like that it trips me up. I saw it happen recently in a Koha database update, so it was on my mind. Today I found out that it can be done if table aliases are used in the subquery. I was working on an entirely different software when it tripped me up again, but I decided to see if there was a way after all. Here's the query I ended up with, that works in recent versions of MySQL, as an example: insert into users (group_id,handle,name,email,user_notify,password,security_level,landing_page,ldap_username,restricted_leaderboard,search,ticketSelectLimit) (select 33,'user2',u2.name,u2.email,u2.user_notify,u2.password,u2.security_level,u2.landing_page,h2.ldap_username,h2.restricted_leaderboard,h2.search,h2.ticketSelectLimit from users as u2 where handle = 'user' ); -- Michael Hafen Washington County School District Technology Department Systems Analyst -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Wed Feb 22 01:53:31 2023 From: dcook at prosentient.com.au (David Cook) Date: Wed, 22 Feb 2023 11:53:31 +1100 Subject: [Koha-devel] ChatGPT and Koha Message-ID: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> Hi all, Like many around the world, I may have been bitten by the ChatGPT bug. Most of my ChatGPT questions have been more general in nature, but I figured I'd ask it about Koha, as there is a lot of public information, but it's still a niche topic. I asked it to generate me a Koha plugin, and it refused for a while, but eventually I was able to convince it to try. The result wouldn't even compile, but it got a lot of things right. In other conversations, it's made mistakes but always done a good job of fixing its mistakes. Has anyone else played with ChatGPT and Koha or ChatGPT in general (on IT topics)? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Wed Feb 22 06:14:32 2023 From: dcook at prosentient.com.au (David Cook) Date: Wed, 22 Feb 2023 16:14:32 +1100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: References: Message-ID: <034c01d9467c$8f3933c0$adab9b40$@prosentient.com.au> I think that the number of bug reports and commits is a bit intimidating. Unless there is a compelling reason to the contrary, I think squashing a lot of these commits would be a good idea. Also, I’m doing a diff on https://gitlab.com/joubu/Koha/-/commits/bug_32991 and the stats are: 76 files changed, 929 insertions(+), 1823 deletions(-). That’s a lot of changes to review. Looking through the changed files… I’d say targeting changes that affect non-ERM functionality should take highest priority – like Bug 32981 and Bug 32923 – since more people have the skills to work on them. Then maybe all the ERM changes can be tested at 1 time all together, although that’s a bit messy in terms of attaching signed off patches… Looking at the Vue components… I’m not sure what to be looking for from a QA perspective, since we don’t have any rules around Vue.js specifically. For Javascript related things, things look OK in the couple of *.vue files I’ve reviewed, but I’d need to double-check them to know for sure. Looking through Breadcrumb.vue and Main.vue, I’d probably do things a bit differently for readability and generalizability/reusability. I don’t know if that should be a blocker or not at this stage though… Personally, I don’t have any investment in the ERM work, but I’m very interested in the Vue.js work. I’d love to make sure we’re creating a design that maximizes reusability and eases maintenance. My koha-testing-docker is broken at the moment, so I’ll look at fixing that up, and then I’ll try to look at this more. I am willing to help, although my schedule is fairly full too. I’m trying to do more Vue.js on other projects, so hopefully I can bring that experience back to Koha and help more… David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel On Behalf Of Jonathan Druart Sent: Wednesday, 22 February 2023 1:57 AM To: koha-devel Subject: Re: [Koha-devel] Vue improvements/refactorings A quick update. There are several bug reports, and the tree is at https://gitlab.com/joubu/Koha/-/commits/bug_32991 It's ~40 commits on top of master, a lot of architecture changes in the erm/vue files. It would be great to have them pushed ASAP, they are blocking other works. Most important is that people will read, learn and copy the code that is in master, which will be obsolete (and generate conflicts) one this tree will be pushed. How can we coordinate to make it move forward? Who is willing to help here? Cheers, Jonathan Le mer. 15 févr. 2023 à 14:09, Jonathan Druart > a écrit : Hi, Pedro and I have been working on improving the way we request the Koha REST API from Vue components. We ended up with the implementation that is available on the following remote branch: https://gitlab.com/joubu/Koha/-/commits/bug_32925 It contains the patches from the following bug reports: Bug 32898 - Cypress tests are failing Bug 32923 - x-koha-embed must a header of collectionFormat csv Bug 32806 - Some Vue files need to be moved for better reusability Bug 32939 - Have generic fetch functions in vue modules Bug 32925 - Display loading info when a form is submitted First, make the tests pass (32898)! We forgot to include the cypress test in the jenkins pipeline and we missed regressions! There have been regressions on the REST API specs, that are fixed on 32923. We noticed that the code we provided for the ERM module was not flexible enough and too ERM oriented. Some directories have been moved and code split a bit to make it more reusable for other modules (32806). Finally there are 32939 that introduce generic fetch functions, to have all the error handling (catch exceptions and display the error on the UI) in a single place. On top of that we added a "loading" message when a form (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only a couple of lines of code! All this must be considered a base for future Vue enhancements, and I would like people interested in the Vue work to have a look at it. Cheers, Jonathan -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Wed Feb 22 06:57:00 2023 From: dcook at prosentient.com.au (David Cook) Date: Wed, 22 Feb 2023 16:57:00 +1100 Subject: [Koha-devel] koha-testing-docker startup gotcha... Message-ID: <035601d94682$7ddabbc0$79903340$@prosentient.com.au> Hi all, With the latest version of koha-testing-docker, you might have problems getting it to start up if your "koha" git directory is not owned by UID 1000. I use koha-testing-docker on Windows, so I use a named volume to mount my "koha" git directory. It also means that I cloned that git repo and do my checkouts with the "root" user in koha-testing-docker (not as my normal user on a Docker host like you would do if you were using Linux as your workstation). So "root" owns my "koha" git directory, which causes koha-testing-docker to fail to startup. I've worked around that by chowning my "koha" git repo to be owned by UID 1000, and that's got it starting up, but it could have future issues where permissions aren't quite right. Anyway, just something to be aware of. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: From dcook at prosentient.com.au Wed Feb 22 07:29:04 2023 From: dcook at prosentient.com.au (David Cook) Date: Wed, 22 Feb 2023 17:29:04 +1100 Subject: [Koha-devel] Testing ERM functionality Message-ID: <036301d94686$f5cdd690$e16983b0$@prosentient.com.au> Hi Jonathan and folks, Is there a general test plan that can be used for testing ERM functionality? Should/could koha-testing-docker come with some test data for ERM to ease testing? Here's my first look (in a very long time): 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=erm 2. Change "ERMModule" to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/erm/erm.pl I note the following warning in the console: runtime-core.esm-bundler.js:167 [Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals. at
-- In a separate email, I've asked what I should be looking for in terms of QA. Or are we still at a stage of looking for feedback? Personally, I think that we might still be a bit too ERM focused with the Vue.js. Instead of http://localhost:8081/cgi-bin/koha/erm/erm.pl perhaps we should be going to http://localhost:8081/cgi-bin/koha/spa/erm. Note that "spa" is a placeholder here (in this case standing for single page application). Off the top of my head, I don't have a great base URL in mind. That way "Koha" is the Vue.js app, and "ERM" is a component provided to "Koha". We could centralize a number of methods in the root "Koha" app. Actually, me emailing is probably pointless. Maybe one night I can do some work in the evening, so that I can link up with folk and we can chat more. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Wed Feb 22 07:43:04 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Wed, 22 Feb 2023 07:43:04 +0100 Subject: [Koha-devel] Vue improvements/refactorings In-Reply-To: <034c01d9467c$8f3933c0$adab9b40$@prosentient.com.au> References: <034c01d9467c$8f3933c0$adab9b40$@prosentient.com.au> Message-ID: It's a lot of changes, that's why they are split into several bug reports and patches. Is it always either too big or too small? > I’m not sure what to be looking for from a QA perspective Does it look better after the patches than before? Is it still working? If so they should get in. > I’d probably do things a bit differently There are always different ways. Here it's mine, feel free to propose alternatives. > creating a design that maximizes reusability and eases maintenance That's *exactly* the goal of these patches. And more work is in the pipe so it cannot wait too long. Le mer. 22 févr. 2023 à 06:14, David Cook a écrit : > I think that the number of bug reports and commits is a bit intimidating. > Unless there is a compelling reason to the contrary, I think squashing a > lot of these commits would be a good idea. > > > > Also, I’m doing a diff on > https://gitlab.com/joubu/Koha/-/commits/bug_32991 and the stats are: 76 > files changed, 929 insertions(+), 1823 deletions(-). That’s a lot of > changes to review. > > > > Looking through the changed files… I’d say targeting changes that affect > non-ERM functionality should take highest priority – like Bug 32981 and Bug > 32923 – since more people have the skills to work on them. Then maybe all > the ERM changes can be tested at 1 time all together, although that’s a bit > messy in terms of attaching signed off patches… > > > > Looking at the Vue components… I’m not sure what to be looking for from a > QA perspective, since we don’t have any rules around Vue.js specifically. > For Javascript related things, things look OK in the couple of *.vue files > I’ve reviewed, but I’d need to double-check them to know for sure. > > > > Looking through Breadcrumb.vue and Main.vue, I’d probably do things a bit > differently for readability and generalizability/reusability. I don’t know > if that should be a blocker or not at this stage though… > > > > Personally, I don’t have any investment in the ERM work, but I’m very > interested in the Vue.js work. I’d love to make sure we’re creating a > design that maximizes reusability and eases maintenance. > > > > My koha-testing-docker is broken at the moment, so I’ll look at fixing > that up, and then I’ll try to look at this more. > > > > I am willing to help, although my schedule is fairly full too. I’m trying > to do more Vue.js on other projects, so hopefully I can bring that > experience back to Koha and help more… > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Koha-devel *On > Behalf Of *Jonathan Druart > *Sent:* Wednesday, 22 February 2023 1:57 AM > *To:* koha-devel > *Subject:* Re: [Koha-devel] Vue improvements/refactorings > > > > A quick update. > > > > There are several bug reports, and the tree is at > https://gitlab.com/joubu/Koha/-/commits/bug_32991 > > It's ~40 commits on top of master, a lot of architecture changes in the > erm/vue files. > > It would be great to have them pushed ASAP, they are blocking other works. > > Most important is that people will read, learn and copy the code that is > in master, which will be obsolete (and generate conflicts) one this tree > will be pushed. > > > > How can we coordinate to make it move forward? Who is willing to help here? > > Cheers, > > Jonathan > > > > Le mer. 15 févr. 2023 à 14:09, Jonathan Druart < > jonathan.druart at bugs.koha-community.org> a écrit : > > Hi, > > > > Pedro and I have been working on improving the way we request the Koha > REST API from Vue components. > > We ended up with the implementation that is available on the following > remote branch: > > https://gitlab.com/joubu/Koha/-/commits/bug_32925 > > > > It contains the patches from the following bug reports: > > *Bug 32898* > - > Cypress tests are failing > > *Bug 32923* > - > x-koha-embed must a header of collectionFormat csv > > *Bug 32806* > - Some > Vue files need to be moved for better reusability > > *Bug 32939* > - Have > generic fetch functions in vue modules > > *Bug 32925* > - > Display loading info when a form is submitted > > > > First, make the tests pass (32898)! We forgot to include the cypress test > in the jenkins pipeline and we missed regressions! There have been > regressions on the REST API specs, that are fixed on 32923. > > We noticed that the code we provided for the ERM module was not flexible > enough and too ERM oriented. Some directories have been moved and code > split a bit to make it more reusable for other modules (32806). > > Finally there are 32939 that introduce generic fetch functions, to have > all the error handling (catch exceptions and display the error on the UI) > in a single place. On top of that we added a "loading" message when a form > (POST/PUT/DELETE) is submitted and, thanks to the previous moves, it's only > a couple of lines of code! > > > > All this must be considered a base for future Vue enhancements, and I > would like people interested in the Vue work to have a look at it. > > > > Cheers, > > Jonathan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From a.roussos at dataly.gr Wed Feb 22 07:45:47 2023 From: a.roussos at dataly.gr (Andreas Roussos) Date: Wed, 22 Feb 2023 08:45:47 +0200 Subject: [Koha-devel] ChatGPT and Koha In-Reply-To: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> References: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> Message-ID: <4f8809b7-6b79-ccea-0d01-a3d31a5cd127@dataly.gr> Hi David, FWIW, a couple of weeks ago I copied and pasted two snippets of Perl code from Koha because I couldn't understand what type of variable they were generating. ChatGPT came back with a pretty comprehensive answer about hash references. What impressed me (apart from the quality of its reply) was that I copied/pasted the code in a hurry including the line numbers preceding each line, however that did not seem to confuse ChatGPT at all! Kind regards, Andreas On 2023-02-22 02:53, David Cook wrote: > > Hi all, > > Like many around the world, I may have been bitten by the ChatGPT bug… > > Most of my ChatGPT questions have been more general in nature, but I > figured I’d ask it about Koha, as there is a lot of public > information, but it’s still a niche topic. > > I asked it to generate me a Koha plugin, and it refused for a while, > but eventually I was able to convince it to try. The result wouldn’t > even compile, but it got a lot of things right. In other > conversations, it’s made mistakes but always done a good job of fixing > its mistakes. > > Has anyone else played with ChatGPT and Koha or ChatGPT in general (on > IT topics)? > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website :https://www.koha-community.org/ > git :https://git.koha-community.org/ > bugs :https://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.druart at bugs.koha-community.org Wed Feb 22 07:53:04 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Wed, 22 Feb 2023 07:53:04 +0100 Subject: [Koha-devel] Testing ERM functionality In-Reply-To: <036301d94686$f5cdd690$e16983b0$@prosentient.com.au> References: <036301d94686$f5cdd690$e16983b0$@prosentient.com.au> Message-ID: About the warning I guess you are working on top of the "refactoring" branch, have a look at 32991 commit message and the discussion on the bug. Le mer. 22 févr. 2023 à 07:29, David Cook a écrit : > Hi Jonathan and folks, > > > > Is there a general test plan that can be used for testing ERM > functionality? Should/could koha-testing-docker come with some test data > for ERM to ease testing? > > > > Here’s my first look (in a very long time): > > 1. Go to > http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=erm > 2. Change “ERMModule” to “Enable” > 3. Go to http://localhost:8081/cgi-bin/koha/erm/erm.pl > > > > I note the following warning in the console: > > > > runtime-core.esm-bundler.js:167 [Vue warn]: setup() return property > "_is_loading" should not start with "$" or "_" which are reserved prefixes > for Vue internals. > > at
> > > > -- > > > > In a separate email, I’ve asked what I should be looking for in terms of > QA. Or are we still at a stage of looking for feedback? > > > > Personally, I think that we might still be a bit too ERM focused with the > Vue.js. > > > > Instead of http://localhost:8081/cgi-bin/koha/erm/erm.pl perhaps we > should be going to http://localhost:8081/cgi-bin/koha/spa/erm. Note that > “spa” is a placeholder here (in this case standing for single page > application). Off the top of my head, I don’t have a great base URL in > mind. > > > > That way “Koha” is the Vue.js app, and “ERM” is a component provided to > “Koha”. We could centralize a number of methods in the root “Koha” app. > > > > Actually, me emailing is probably pointless. Maybe one night I can do some > work in the evening, so that I can link up with folk and we can chat more… > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From uwe.dierolf at kit.edu Wed Feb 22 08:31:17 2023 From: uwe.dierolf at kit.edu (Uwe Dierolf) Date: Wed, 22 Feb 2023 08:31:17 +0100 Subject: [Koha-devel] ChatGPT and Koha In-Reply-To: <4f8809b7-6b79-ccea-0d01-a3d31a5cd127@dataly.gr> References: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> <4f8809b7-6b79-ccea-0d01-a3d31a5cd127@dataly.gr> Message-ID: Hi all, yes, ChatGPT is awesome. I asked ChatGPT to write a Koha plugin that places some javascript code into pages of the staff frontend. The code was as expected as far as I can say this, cause I never developed a Koha plugin but it was pretty similar to the code which you can find in the KitchenSink plugin. Then I asked the Bot to activate the javascript only on specific pages having a specific page id. Looked also very convincing. Last but not least I wanted to know how to create the kpz file and got an answer too. Perhaps ChatGPT can produce the code for the vue.js based frontend. Or perhaps copilot already can do this ;-) Best regards, Uwe -------------------------------------------------------------------------- Uwe Dierolf Karlsruher Institut für Technologie (KIT) KIT-Bibliothek -------------------------------------------------------------------------- Am Wed, Feb 22, 2023 at 08:45:47AM +0200 schrieb Andreas Roussos: > Hi David, > > FWIW, a couple of weeks ago I copied and pasted two snippets of Perl code from Koha because I couldn't understand what type of variable they were generating. ChatGPT came back with a pretty comprehensive answer about hash references. > > What impressed me (apart from the quality of its reply) was that I copied/pasted the code in a hurry including the line numbers preceding each line, however that did not seem to confuse ChatGPT at all! > > Kind regards, > > Andreas > > On 2023-02-22 02:53, David Cook wrote: > > > Hi all, > > > > Like many around the world, I may have been bitten by the ChatGPT bug… > > > > Most of my ChatGPT questions have been more general in nature, but I figured I’d ask it about Koha, as there is a lot of public information, but it’s still a niche topic. > > > > I asked it to generate me a Koha plugin, and it refused for a while, but eventually I was able to convince it to try. The result wouldn’t even compile, but it got a lot of things right. In other conversations, it’s made mistakes but always done a good job of fixing its mistakes. > > > > Has anyone else played with ChatGPT and Koha or ChatGPT in general (on IT topics)? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ From jonathan.druart at bugs.koha-community.org Wed Feb 22 09:25:14 2023 From: jonathan.druart at bugs.koha-community.org (Jonathan Druart) Date: Wed, 22 Feb 2023 09:25:14 +0100 Subject: [Koha-devel] ChatGPT and Koha In-Reply-To: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> References: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> Message-ID: For Koha core developers I am not sure it is relevant. Hasn't ChatGPT been fed with 2 years old data? With data we actually wrote ourselves. So basically if I ask it something I am requesting what my 2 year-ago self knew? I have certainly forgotten some stuff, but I also know that what was true 2 years ago is no longer 100% correct. By the way, what would be the license for such generated code? Certainly GPLv3 for Koha, but what about Vue.js code for instance? Le mer. 22 févr. 2023 à 01:53, David Cook a écrit : > Hi all, > > > > Like many around the world, I may have been bitten by the ChatGPT bug… > > > > Most of my ChatGPT questions have been more general in nature, but I > figured I’d ask it about Koha, as there is a lot of public information, but > it’s still a niche topic. > > > > I asked it to generate me a Koha plugin, and it refused for a while, but > eventually I was able to convince it to try. The result wouldn’t even > compile, but it got a lot of things right. In other conversations, it’s > made mistakes but always done a good job of fixing its mistakes. > > > > Has anyone else played with ChatGPT and Koha or ChatGPT in general (on IT > topics)? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mail at davidschmidt.at Wed Feb 22 10:51:01 2023 From: mail at davidschmidt.at (David Schmidt) Date: Wed, 22 Feb 2023 10:51:01 +0100 Subject: [Koha-devel] koha-testing-docker startup gotcha... In-Reply-To: <035601d94682$7ddabbc0$79903340$@prosentient.com.au> References: <035601d94682$7ddabbc0$79903340$@prosentient.com.au> Message-ID: <300ea59e-ba65-4434-82d7-6f2e5abc2483@app.fastmail.com> what I like to do to always have matching UIDs ########## ########## # Dockerfile ARG CONTAINER_UID=1000 RUN useradd --create-home --home-dir /home/hks3 \ --uid $CONTAINER_UID --user-group --shell /bin/bash hks3 # building container docker-compose build --build-arg CONTAINER_UID=`id -u` ########## ########## now the ids always match. cheers david (HKS3 / koha-support.eu) On Wed, 22 Feb 2023, at 6:57 AM, David Cook wrote: > Hi all, > > With the latest version of koha-testing-docker, you might have problems getting it to start up if your “koha” git directory is not owned by UID 1000. > > I use koha-testing-docker on Windows, so I use a named volume to mount my “koha” git directory. It also means that I cloned that git repo and do my checkouts with the “root” user in koha-testing-docker (not as my normal user on a Docker host like you would do if you were using Linux as your workstation). So “root” owns my “koha” git directory, which causes koha-testing-docker to fail to startup. > > I’ve worked around that by chowning my “koha” git repo to be owned by UID 1000, and that’s got it starting up, but it could have future issues where permissions aren’t quite right. > > Anyway, just something to be aware of… > > David Cook > Senior Software Engineer > Prosentient Systems > Suite 7.03 > 6a Glen St > Milsons Point NSW 2061 > Australia > > Office: 02 9212 0899 > Online: 02 8005 0595 > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From tomascohen at gmail.com Wed Feb 22 15:07:38 2023 From: tomascohen at gmail.com (Tomas Cohen Arazi) Date: Wed, 22 Feb 2023 11:07:38 -0300 Subject: [Koha-devel] Pull newer images today :-D Message-ID: Hi, we've just pushed a change to Koha, moving away from node-sass to dart-sass, and older docker images will fail as all assets are automatically built on startup and it will fail otherwise. Best regards -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F -------------- next part -------------- An HTML attachment was scrubbed... URL: From victor at tuxayo.net Wed Feb 22 23:25:07 2023 From: victor at tuxayo.net (tuxayo) Date: Wed, 22 Feb 2023 23:25:07 +0100 Subject: [Koha-devel] Volunteer needed to open the bidding for KohaCon24 & need confirmation of task list Message-ID: <8d2adb4d-b487-f887-46eb-98cfe8b374e5@tuxayo.net> Hi :) The things to do are: - making the wikipage using the template - make an announcement email using past ones - send reminders - @all: anything else? The aim is to start the bid in the next weeks so proposals that start early 2024 have time to plan. And let the bid run until the next general meeting in april I can help with proofreading and finding past resources. (wikipage template, emails) Cheers, -- tuxayo From dcook at prosentient.com.au Thu Feb 23 00:56:45 2023 From: dcook at prosentient.com.au (David Cook) Date: Thu, 23 Feb 2023 10:56:45 +1100 Subject: [Koha-devel] ChatGPT and Koha In-Reply-To: References: <032a01d94658$19686a40$4c393ec0$@prosentient.com.au> Message-ID: <046201d94719$5a023970$0e06ac50$@prosentient.com.au> I understand what you’re saying because it says its knowledge after 2021 is limited, but it also has a greater breadth of knowledge than your 2 year-ago self. It claimed that some of its Vue.js answers were due to the conventions used by the Vue.js community, which was fascinating. It differed from some examples I found online in Vue.js documentation, so it would be interesting to know if the AI was out of date or if the documentation was out of date. Considering the explanation it gave for its answer, I think the documentation was probably out of date, as it gave a better answer than the documentation. (I found ChatGPT was able to answer my Vue.js questions much better than the official Vue.js documentation and most of the examples I could find online.) I asked it to explain some general best practices for processing background tasks and distributed computing and it gave some excellent answers (and follow-up answers to follow-up questions). It certainly offers a better understanding of those topics than any Koha community developer has. I told it that its not particularly skilled at very specific tasks (like writing a Koha plugin), but it’s very good with fundamentals, and it mentioned that explaining fundamentals is one of its primary goals. It’s not there to write your code for you, but to offer advice/guidance to help you write code better. That said, it’s not always 100% correct either. You do have to consider its answers critically, and sometimes it’s just plain wrong, although usually its wrong in terms of minor details, and if you point out its mistake, it gets the correct answer. I was quizzing it on the use of some Perl POE modules from CPAN and there were times it tried to pass options that just didn’t exist (and have never existed). But its corrections were accurate and followed the concurrent programming designs I used myself years ago with those modules. On the other hand, I had it design a recursive algorithm in PHP for filtering data, and while its first attempts were close, the more I tried to get it to fix it, the worse it got until it was absolutely unusable. Perhaps the problem was the AI or perhaps the problem was with my instructions. I just asked it to do an algorithm for converting ISBN-13 to ISBN-10 in Javascript. I already wrote one myself a few days ago, and it’s interesting to compare. Its algorithm is probably 98% correct, and it wrote it more concisely than I did (although we know I love verbosity). Licensing is certainly a tough topic (consider the licensing problems with GitHub Copilot). According to a post online, it claims not to have a licence on its code, but advises checking with legal professionals to be on the safe side. However, I don’t think a person would really be using the code generated by ChatGPT. The code it generates tends to be example code. The kind of thing you’d find in documentation, tutorials, Stackoverflow, etc. It’s good for illustrating concepts, but you wouldn’t necessarily want to copy/paste it, and just use it. It probably wouldn’t help a person to write “Koha code”, but it could help a person to better understand a concept they need to know while writing “Koha code”. Another example… I just asked “could you generate a functional operating system from scratch?” It said that it could not, but outlined what a person would need to do in order to write one, and gives some good warnings about why it’s probably not a good idea to try to do it solo haha. I know this email is too long, but I suppose I’d just emphasize that it’s a very interesting “helper”. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Jonathan Druart Sent: Wednesday, 22 February 2023 7:24 PM To: David Cook Cc: koha-devel Subject: Re: [Koha-devel] ChatGPT and Koha For Koha core developers I am not sure it is relevant. Hasn't ChatGPT been fed with 2 years old data? With data we actually wrote ourselves. So basically if I ask it something I am requesting what my 2 year-ago self knew? I have certainly forgotten some stuff, but I also know that what was true 2 years ago is no longer 100% correct. By the way, what would be the license for such generated code? Certainly GPLv3 for Koha, but what about Vue.js code for instance? Le mer. 22 févr. 2023 à 01:53, David Cook > a écrit : Hi all, Like many around the world, I may have been bitten by the ChatGPT bug… Most of my ChatGPT questions have been more general in nature, but I figured I’d ask it about Koha, as there is a lot of public information, but it’s still a niche topic. I asked it to generate me a Koha plugin, and it refused for a while, but eventually I was able to convince it to try. The result wouldn’t even compile, but it got a lot of things right. In other conversations, it’s made mistakes but always done a good job of fixing its mistakes. Has anyone else played with ChatGPT and Koha or ChatGPT in general (on IT topics)? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 _______________________________________________ Koha-devel mailing list Koha-devel at lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From julian.maurice at biblibre.com Thu Feb 23 14:15:36 2023 From: julian.maurice at biblibre.com (Julian Maurice) Date: Thu, 23 Feb 2023 14:15:36 +0100 Subject: [Koha-devel] Random data in CGI Vars Message-ID: Hello, I've been encountering strange bugs on two different Koha instances (both 21.11). When cataloguing new records, instead of the record being saved, users are being redirected to an empty cataloguing form (like if they clicked on "New record"). They have to use "Back" and submit the form again until it works. I suspected something going wrong in how the form data was being sent to Koha so I added the following line in cataloguing/addbiblio.pl warn Data::Dumper->Dump([{ $input->Vars }], ['Vars']) . "\n"; right after CGI->new And indeed there is something going wrong. Some of the variables are replaced by random data. Here's an example: 'tag_041_subfield_a_452653_624274' => '', '' => "Ly[\x{1cf}^KJ{)Z\x{fffd}(-D<\x{fffd}\x{fffd}\x{fffd}BN", 'tag_856_code_x_883542_376496' => 'x', Sometimes the 'op' parameter is replaced by random data, and that's why we see this strange behaviour. Have you ever experienced something like this ? Do you know where it could come from ? -- Julian Maurice BibLibre From martin.renvoize at ptfs-europe.com Thu Feb 23 19:02:52 2023 From: martin.renvoize at ptfs-europe.com (Renvoize, Martin) Date: Thu, 23 Feb 2023 18:02:52 +0000 Subject: [Koha-devel] Koha 22.11.03 release Message-ID: Hello, Bonjour, Ola, Kia ora, 今日は, The Koha community is pleased to announce the release of version 22.11.03. This release is a bugfix/maintenance release with a small number of minor architectural enhancements to aid in the continued maintenance of this version. It includes 40 enhancements and 87 bugfixes. For full release notes, please visit https://koha-community.org/koha-22-11-03-released/ Thanks for anybody involved! 🚀 Martin Renvoize, MPhys (Hons) Head of Development and Community Engagement E: martin.renvoize at ptfs-europe.com P: +44 (0) 1483 378728 M: +44 (0) 7725 985636 www.ptfs-europe.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From trmurakami at gmail.com Fri Feb 24 02:39:16 2023 From: trmurakami at gmail.com (Tiago Murakami) Date: Thu, 23 Feb 2023 22:39:16 -0300 Subject: [Koha-devel] Permissions on Pootle In-Reply-To: <48d83df8-ff3d-7603-033d-425335994b9b@web.de> References: <48d83df8-ff3d-7603-033d-425335994b9b@web.de> Message-ID: Hi Katrin and Koha-Devel community, I've translated many strings in the last few days, but when I download the files, they don't have the newly translated strings. Please let me know how often Pootle export files are generated. Thank you in advance, Tiago Murakami On Mon, Feb 13, 2023 at 4:24 PM Katrin Fischer wrote: > Hi Tiago, > > we had a change/correction to the permission system a while ago. I have > made you part of the pt-BR translation team now. You should be able to > submit translations. > > Katrin > On 13.02.23 19:24, Tiago Murakami wrote: > > Hi, > > I´m a librarian in Brazil. I had Pootle permissions for translation, but, > I only have them for suggestions. What is the best way to ask for > permission to translate Pootle in pt-BR? > > Thanks in advance, > > -- > Tiago Murakami > > _______________________________________________ > Koha-devel mailing listKoha-devel at lists.koha-community.orghttps://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > > _______________________________________________ > Koha-devel mailing list > Koha-devel at lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ > -- Tiago Murakami -------------- next part -------------- An HTML attachment was scrubbed... URL: From kohanews at gmail.com Mon Feb 27 18:59:59 2023 From: kohanews at gmail.com (Koha Newsletter) Date: Mon, 27 Feb 2023 18:59:59 +0100 Subject: [Koha-devel] Koha Community Newsletter: February 2023 Message-ID: The Koha Community Newsletter for February 2023 is here: https://koha-community.org/koha-community-newsletter-february-2023/ Many thanks to everyone who submitted articles and news to this newsletter! Please feel free to email me with any corrections or suggestions. -- Michael Kuhn Editor, Koha Community Newsletter -------------- next part -------------- An HTML attachment was scrubbed... URL: