[Koha-devel] Rewrite of URLs, flushing all empty arguments

[Jonathan Druart]

Have a look at bug 25548 maybe?
It has been backported but maybe your apache config is not correct (see the
RewriteRule)?

Le jeu. 8 juin 2023 à 18:03, Philippe Blouin <philippe.blouin at inlibro.com>
a écrit :

> Hi David,
>
> Yes, connection being the login page.  Any call to it with &variable=&
> will get see its empty variable get flushed, as you summarized with
>
>
> http://localhost:8081/cgi-bin/koha/tools/letter.pl?op=delete_confirm&branchcode=&module=suggestions&code=ACCEPTED
>
> http://localhost:8081/cgi-bin/koha/tools/letter.pl?op=delete_confirm&module=suggestions&code=ACCEPTED
>
> The fact that it's not just branchcode, but any toto= or whatever= that
> gets flushed, seem to point to an apache setting.
>
> BUT my question was really: is Koha doing it ?  seems not, by your
> answers.  Is Apache doing it by default (new version...), my googling
> doesn't point to that, obviously.
>
> No redirect/rewrite in network.
>
> But again, you're telling me it's not Koha, so I'll dig.
>
> PS yes, the second link doesn't work.  We created a fix, but I didn't like
> it because I wanted to explore the root cause.
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blouin at inLibro.com
> inLibro | pour esprit libre | www.inLibro.com
> On 2023-06-07 19:38, David Cook wrote:
>
> First things first, Philippe, you haven’t given enough information about
> the problem.
>
>
>
> For instance:
>
>
> http://localhost:8081/cgi-bin/koha/tools/letter.pl?op=delete_confirm&branchcode=&module=suggestions&code=ACCEPTED
>
>
> http://localhost:8081/cgi-bin/koha/tools/letter.pl?op=delete_confirm&module=suggestions&code=ACCEPTED
>
>
>
> On koha-testing-docker, which admittedly is a later version, neither of
> these raise an error, although the second link won’t work as expected. So
> you should look at the actual error message in your log, and try to work it
> out from there. It might be that it’s a known issue that’s been fixed
> upstream already.
>
>
>
> Not sure what you mean by “the connection page”. Is that the login screen
> for letter.pl or something else?
>
>
>
> When you say “the branchcode= disappears on landing”, it’s not clear what
> you mean. Take a look at the Network tab on your browser and see if there
> are any redirects. You can also increase the logging on your Apache to see
> what exactly it’s doing:
> https://httpd.apache.org/docs/2.4/mod/core.html#loglevel.
>
>
>
> Maybe that problem instance has some Javascript running that is
> interfering with the location URL. You can add breakpoints in your browser
> so that it pauses at certain points in the process of loading.
>
>
>
> My suggestion would be doing some hands-on troubleshooting. Work the
> problem. The truth is out there.
>
>
>
> David Cook
>
> Senior Software Engineer
>
> Prosentient Systems
>
> Suite 7.03
>
> 6a Glen St
>
> Milsons Point NSW 2061
>
> Australia
>
>
>
> Office: 02 9212 0899
>
> Online: 02 8005 0595
>
>
>
> *From:* Koha-devel <koha-devel-bounces at lists.koha-community.org>
> <koha-devel-bounces at lists.koha-community.org> *On Behalf Of *Michael Hafen
> *Sent:* Thursday, 8 June 2023 7:17 AM
> *To:* Philippe Blouin <philippe.blouin at inlibro.com>
> <philippe.blouin at inlibro.com>
> *Cc:* koha-devel at lists.koha-community.org
> *Subject:* Re: [Koha-devel] Rewrite of URLs, flushing all empty arguments
>
>
>
> There are many layers interacting here.  First is apache recieving the
> request, where it passes through any apache modules that are loaded, then
> it's passed to cgi or fcgi (you haven't mentioned whether you have plack
> enabled, but you probably do), then it's passed to Koha's codebase.  There
> could be version differences between Debian and Ubuntu in either Apache
> modules or Perl CGI/FCGI modules that would cause an empty get variable to
> be dropped.  The perl module versions would be the first thing I'd check.
>
>
>
> On Wed, Jun 7, 2023 at 3:10 PM Philippe Blouin <
> philippe.blouin at inlibro.com> wrote:
>
> Hello all!
>
> New issue (in 22.05 here, but might be anywhere):
>
> https://somedomain.net/cgi-bin/koha/tools/letter.pl?op=delete_confirm
> <https://v22-test-intranet.hapax.inlibro.net/cgi-bin/koha/tools/letter.pl?op=delete_confirm>
> *&branchcode=&module=suggestions&code=ACCEPTED*
>
> When somedomain is onto one of our debian box (bullseye, 11), the
> branchcode= disappears on landing.  Be it on the connection page or
> letter.pl, we do not have the branchcode= anymore, and the code throws an
> error (branchcode being undefined)
>
> When running onto our laptops (Ubuntu) that doesn't happen.
>
> We have no custom RewriteRule, so I'm trying to figure out WHERE this
> rewrite comes from.
>
> All suggestions welcomed,
>
> Best regards,
>
> --
>
> Philippe Blouin,
> Directeur de la technologie
>
> Tél.  : (833) 465-4276, poste 230
> philippe.blouin at inLibro.com
>
> inLibro | pour esprit libre | www.inLibro.com
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
>
>
> --
>
> Michael Hafen
>
> Washington County School District Technology Department
>
> Systems Analyst
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel at lists.koha-community.org
> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
> website : https://www.koha-community.org/
> git : https://git.koha-community.org/
> bugs : https://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20230608/ca475d8f/attachment-0001.htm>